Magic Lantern Forum

Using Magic Lantern => Post-processing Workflow => HDR and Dual ISO Postprocessing => Topic started by: kichetof on March 18, 2014, 05:04:33 PM

Title: Lightroom plugin cr2hdr v3.0 DEV (WIP)
Post by: kichetof on March 18, 2014, 05:04:33 PM
Lightroom Dual ISO Plugin

This plugin allows you to convert Dual ISO picture from Lightroom directly to cr2hdr tools.

Lightroom v4 and more is needed.



(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs28.postimg.org%2Fgxrkj7n3h%2Fcr2hdr_3_0_170304_01_SLP_DEV.png&hash=c0443d8ab9402e6fd6367ccc56abf1fc)



How to use:



Default settings:

> Plugin settings:

> cr2hdr settings:
This plugin is translate in english, french, german, portuguese and swedish. (feel free to send me a translated file).



/!\ DEV /!\ Download the lastest version of Lightroom Dual ISO Converter (cr2hdr) plugin (dev version) (https://web.archive.org/web/20200805172717/https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-170316-02-MLV-DEV.zip).



How the plugin works:



How to install this plugin:

To install this plugin, extract zip and save folder cr2hdr.lrplugin where you want.
(Don't use hyphen mark "-" in path. This is an Adobe bug.)

On Lightroom, open the Plug-In Manager (shortcut Win: Ctrl + Alt + Shift + , (comma), Mac: Command + Option + Shift + , (comma)) and install it.

You can follow instructions from Adobe (http://help.adobe.com/en_US/lightroom/using/WSB8C2DF2B-2ED0-4b97-BA18-5DBEDC69E7D9.html).



Follow the projet on Magic Lantern Forum (http://www.magiclantern.fm/forum/index.php?topic=11056.msg107262#msg107262).

Contribute to the code on Bitbucket (https://bitbucket.org/kichetof/lr_cr2hdr).

This plugin is distributed under the GNU GPL v2.



Changelogs:

2014-09-30 v3.0 BETA 3
2014-09-22 v3.0 BETA 2
2014-09-13 v3.0 BETA
2014-04-21 - 2014-09-12 v2.2 BETA
2014-03-27 v2.1
2014-03-26 v2.0.2
2014-03-26 v2.0.1
2014-03-25 v2.0
2014-03-19 v1.0.3
2014-03-19 v1.0.2
2014-03-19 v1.0.1
2014-03-18 v1.0
Title: Re: Lightroom plugin cr2hdr
Post by: Marsu42 on March 18, 2014, 05:13:12 PM
I've the pleasure to share with you my first Lightroom plugin!

Thanks, that certainly improves usability for newbies and people who keep the cr2 and dng in the same place. Still, with acr the dual_iso auto wb is broken so this workflow isn't without problems atm.
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 18, 2014, 06:16:54 PM
Great! Will test later
Title: Re: Lightroom plugin cr2hdr
Post by: a1ex on March 18, 2014, 06:36:39 PM
Still, with acr the dual_iso auto wb is broken

IIRC you were the one researching this problem, along with engardeknave: http://www.magiclantern.fm/forum/index.php?topic=10265

Did you check if converting CR2's to Adobe DNG before running cr2hdr helps? Did you try to copy the exif info from an Adobe DNG file to cr2hdr output? I remember asking you this stuff, but I don't remember your answer (and my LR demo expired).
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 18, 2014, 08:11:26 PM
Wonderful little plugin. Don,t understand wb problem? Converted/exported my cr2 directly and it gave me superb result after processing my dng in lightroom. Perfect being able to work with dualiso straight within lightroom. Very convenient. Big thanks!

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs28.postimg.org%2Fc9cgex26l%2Fdualiso_5715.jpg&hash=955008ad81af8b1b1e25d746f3d51c88)
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 18, 2014, 08:28:53 PM
a big lol from my side when reading that post. why?

tonight i sat in front of the adobe SDK because i wanted to make dual iso files usable straight out of LR.
the intermediate step was just too inconvinient if you gave a graphical workflow.
then i decided, this is not a simple task if you never made a LR plugin. so i stopped since i didnt want to spend a week.
(i thought the right way is to generate a proxy file and using custom extensions)
i hoped that someone would come up with a proper solution.

and three hours after i stopped reading the SDK and example plugins you posted exactly what i was looking for.
wow, this was a perfect timing :)

thanks for this cool plugin, im gonna try it!
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 18, 2014, 08:33:13 PM
It is awesome.
My workflow
1 - importing the folder with dual iso cr2 files and I rate all of the 1 star(for being able to differ the originals from my resulting dngs)
2 - export to dng with the plugin
3 - back into the folder I choose to show "unrated" pictures and I end up with only my dng,s. Awesome indeed!
So nice.

*Of course one could simply point the dng,s to a specific folder to have the exported separately from the originals. Even better than above workflow
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 18, 2014, 09:01:48 PM
first feedback:

 - Lightroom 4.4
 - Windows 7 x64, German
 - installed cleanly
 - "C:\Program Files\Adobe\Adobe Photoshop Lightroom 4.4\cr2hdr.lrplugin"
 - .lrcat path contains spaces too
 - images are in path without spaces
 ! exporting fails with error message that that was no dual iso file
 -> problem was the binaries not being found - placed in a %PATH% directory and it works
 -> edit: i restarted LR and removed cr2hdr from the %PATH% directory and it suddenly works ... (?!?!)
 ! logfile per image "dualiso_xxxx.txt" is created, but empty
 -> didnt check yet where it comes from :)

conclusion:
aside from the mentioned install trouble a damn cool plugin which will push dual_iso a lot.

here the german translation:
http://upload.g3gg0.de/pub_files/cf7f49e55e19749234d19593907c5785/TranslatedStrings_de.txt
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 18, 2014, 09:26:20 PM
I put the plug in straight to the lightroom plugin folder.
Rightclick program "lightroom" go to show package contents to contents to plugIns folder and put the plugin in there. Works straight away on mac.
Title: Re: Lightroom plugin cr2hdr
Post by: Walter Schulz on March 18, 2014, 09:34:05 PM
here the german translation:
http://upload.g3gg0.de/pub_files/cf7f49e55e19749234d19593907c5785/TranslatedStrings_de.txt

Verbesserungsvorschlag:
"$$$/ML/Publish/noDualIso=Das Bild ^1 scheint kein dual ISO Bild zu sein"
->
"$$$/ML/Publish/noDualIso=Das Bild ^1 scheint kein Dual-ISO-Bild zu sein"

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 18, 2014, 09:36:06 PM
yep, good idea
Title: Re: Lightroom plugin cr2hdr
Post by: chris_overseas on March 18, 2014, 09:46:44 PM
- Lightroom 5.3
- Windows 7 x64, English
- Installed fine from a separate directory (F:\Lightroom\Plugins\cr2hdr.lrplugin)
- Images are in a path that contains spaces
- Selected several images, right-clicked and exported, everything worked fine!

Note that I copied over new versions of cr2hdr.exe (I used the 20 bit version), exiftool.exe (9.54) and dcraw.exe (9.20) since the included ones appear to be quite old?

Bugs/issues:
- I get an empty log file for each image (as pointed out by g3gg0)
- The cr2hdr command line window opens in the foreground (is it possible to open it minimised, hidden or behind Lightroom?)
- The DNGs were created fine and the corresponding CR2 says it is in a stack, but the DNGs don't appear in the filmstrip or library (grid) view. [OK, turns out that's because I had just imported the CR2s then exported directly, so my library selection was "Previous import" rather than the folder I'd imported. I don't think that can be considered a bug?]

Overall, this looks great and will definitely simplify my workflow. Thank you!
Title: Re: Lightroom plugin cr2hdr
Post by: garry23 on March 18, 2014, 10:11:50 PM
A simple report that this plugin works perfectly: well at least in my set up, ie LR5.3 and 64bit Win7.

I just right click on the image and select cr2hdr and magically the DNG returns to Lightroom, I don't even need to synchronize the folder in library view as I need to do with some plugins.

It means that we now have 1-click processing of dual-ISO.

Many thanks to the author of the plugin.

Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 18, 2014, 10:46:53 PM
All my logfiles (.txt files) contain all infomation about the conversion process. No one is empty.
I,m on a mac and lightroom 4.4

example from logfile:

"   1 image files updated
cr2hdr: a post processing tool for Dual ISO images

Last update: 310e39f on 2014-02-27 05:17:41 UTC by 1p:
Fix ISOs in dual ISO

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)

Input file      : /Users/itguser/Desktop/desktop/cr2hdr/ML/dualiso_5715.cr2
Camera          : Canon EOS 5D Mark III
Full size       : 5920 x 3950
Active area     : 5796 x 3870
White level     : 12500
Black borders   : 124 left, 80 top
Black level     : 1963
ISO pattern     : BddB RGGB
Noise levels    : 10.65 6.20 6.19 10.53 (14-bit)
ISO difference  : 3.98 EV (1580)
Black delta     : 3.96
Dynamic range   : 10.73 (+) 9.95 => 13.93 EV (in theory)
Looking for hot/cold pixels...
Hot pixels      : 1155
Cold pixels     : 487
AMaZE interpolation ...
Amaze took 6.27 s
Edge-directed interpolation...
Semi-overexposed: 23.77%
Deep shadows    : 66.49%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.8 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 2.45 (16-bit), ideally 2.45
Dynamic range   : 14.07 EV (cooked)
Black adjust    : 0
Output file     : /Users/itguser/Desktop/desktop/cr2hdr/ML/dualiso_5715.DNG"
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 18, 2014, 11:03:35 PM
Thank you all for your feedback! I appreciate :)

I'm glad that this plugin makes your workflow easier!!

So, my workflow is Mac and it's really more simple to write shell command on it!

I spent a lot of hours to find a way to launch the command on windows and I'll find a way to optimise it! (see my post on dev ml forum and Lightroom discussion)
To windows users:

Could you add before LrTasks.execute (where cr2hdr.exe is call): mlLog:debug(command)
And paste result from windbg or anything else debugger

Could you add /B and/or /MIN after /WAIT on windows command var and tell me if it's more user friendly

Normally all path are escaped so I don't understand why you don't have output file!

I'll update dcraw and exiftool (forget to commit new version)

Thank you for deutsch translation! :) I'll add it tomorrow

If you're a pro with lua and Lightroom sdk feel free to help me to make code more robust :)
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 18, 2014, 11:08:07 PM
a big lol from my side when reading that post. why?

tonight i sat in front of the adobe SDK because i wanted to make dual iso files usable straight out of LR.
the intermediate step was just too inconvinient if you gave a graphical workflow.
then i decided, this is not a simple task if you never made a LR plugin. so i stopped since i didnt want to spend a week.
(i thought the right way is to generate a proxy file and using custom extensions)
i hoped that someone would come up with a proper solution.

and three hours after i stopped reading the SDK and example plugins you posted exactly what i was looking for.
wow, this was a perfect timing :)

thanks for this cool plugin, im gonna try it!

I'm happy to help you! For one time it's me who can help you!
Title: Re: Lightroom plugin cr2hdr
Post by: chris_overseas on March 19, 2014, 12:35:04 AM
(For those wanting to play with the plugin code, make sure you go into LR's Plugin Manager and enable "reload plugin on each export" so your changes to the script are picked up and recompiled each time it runs)


Personally I prefer /B over /MIN. I also added /BELOWNORMAL to reduce the cr2hdr priority slightly and help keep the computer responsive.

Here is the updated code incorporating the above changes:
Code: [Select]
command = string.format('"start /D "%s\\bin" /B /WAIT /BELOWNORMAL cr2hdr.exe "%s" ^> "%s""', pluginPath, filePath, output)

I wonder if there is a way to run multiple cr2hdr conversions in parallel? Also since I'm not really interested in having the log files left behind, I've removed that feature from my copy. Maybe there's a way to make it optional. I know additional settings can be added to the Plugin Manager dialog though I haven't looked into how to do that yet.
Title: Re: Lightroom plugin cr2hdr
Post by: mad.eos on March 19, 2014, 12:40:14 AM
A huge thanks from my part kichetof! You're the man!

This has, in my opinion, turned a whole new leaf in the post processing workflow for whoever works with lightroom!

Very good work! ;)

By the way, have you already updated your zipfile with the new cr2hdr files?
Title: Re: Lightroom plugin cr2hdr
Post by: Luiz Roberto dos Santos on March 19, 2014, 04:17:48 AM
This will be very helpful, big thanks.
So, this is on Half-res blending mode? Any chance to apply blending full-res? 0k, that requires Octave, but it could be done. Moreover, as mentioned above, perhaps the new features of 20bit version and "film-curve" could help.
I will test soon and bring you the feedback. Also, try to do the translation into Portuguese - BR.
Title: Re: Lightroom plugin cr2hdr
Post by: painya on March 19, 2014, 04:29:18 AM
This is not to the ML Gurus.
To the beginners!
Here is a quick user friendly guide-
Open LR
File>Plugin manager
Click on the folder
Restart LR
Right click on your image
Export>ML>Cr2_hdr (or whatever it is)
Enjoy!
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 19, 2014, 08:12:14 AM
I wonder if there is a way to run multiple cr2hdr conversions in parallel?

I just ran exports in several export operations. Tried running 5 exports simultaneously of cr2 to dng and they work in parallell that way. Occassionally I get a pop up window telling me an internal error has occured but it exports anyway so I just ignored and synchronized the folder when finished.

The error code
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2F4m6myhng1%2FSka_rmavbild_2014_03_19_kl_08_44_16.png&hash=74539e43983879044d5bf77d63a183b2)

*It appears the error code does indeed affect some pictures only getting halfway through the process so Running several export operations simultaneously isn,t stable.
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 19, 2014, 09:05:45 AM
Note that I copied over new versions of cr2hdr.exe (I used the 20 bit version), exiftool.exe (9.54) and dcraw.exe (9.20) since the included ones appear to be quite old?

Updated !

here the german translation:
http://upload.g3gg0.de/pub_files/cf7f49e55e19749234d19593907c5785/TranslatedStrings_de.txt

Thanks for this translation!

Here is the updated code incorporating the above changes:
Code: [Select]
command = string.format('"start /D "%s\\bin" /B /WAIT /BELOWNORMAL cr2hdr.exe "%s" ^> "%s""', pluginPath, filePath, output)

Yeaaaah !! Big thanks for that !!! (I'm more comfortable with a shell terminal)

I wonder if there is a way to run multiple cr2hdr conversions in parallel? Also since I'm not really interested in having the log files left behind, I've removed that feature from my copy. Maybe there's a way to make it optional. I know additional settings can be added to the Plugin Manager dialog though I haven't looked into how to do that yet.

I don't know how to make it, but I'll read the lightroom SDK to find it :)

I just ran exports in several export operations. Tried running 5 exports simultaneously of cr2 to dng and they work in parallell that way. Occassionally I get a pop up window telling me an internal error has occured but it exports anyway so I just ignored and synchronized the folder when finished.

The error code
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2F4m6myhng1%2FSka_rmavbild_2014_03_19_kl_08_44_16.png&hash=74539e43983879044d5bf77d63a183b2)

*It appears the error code does indeed affect some pictures only getting halfway through the process so Running several export operations simultaneously isn,t stable.

Thanks for this try ! I'll investigate how to make it possible!

New version 1.0.1, I'll update first post soon !
Title: Re: Lightroom plugin cr2hdr
Post by: Marsu42 on March 19, 2014, 09:21:04 AM
IIRC you were the one researching this problem, along with engardeknave: http://www.magiclantern.fm/forum/index.php?topic=10265

Well, he was researching it a bit and quickly came to the conclusion I arrived at even w/o some days of trial & error - it's too complex for us to figure out the algorithm how acr arrives at its wb values from the tags embedded in the cr2 :-(

thanks for this cool plugin, im gonna try it!

Maybe you can figure out to get the correct "as shot" wb from acr? This is a real pita, if you didn't shoot a wb/color card or a non-dual_iso shot to compare it's complete guesswork what the correct wb/tint is.
Title: Re: Lightroom plugin cr2hdr - Error: 'Already treated
Post by: fotogemeinschaft_de on March 19, 2014, 09:35:57 AM
After the first export (which was ok) I always get the following error with every other Picture:

'Already treated' - 'The File xy has already converted to dual iso'
(LR 5.2)

In fact the file was NOT converted.

I have found the reason for this behaviour by myself: The plugin doesn't add numbers to the converted files; my filenames are rather long and the plugin therefore produces always the same filenames in the same directory.

After every single conversion I have to rename the converted file manually. A batch-job will therefore not be possible but nevertheless the integration in LR is great..

Ralf
Title: Re: Lightroom plugin cr2hdr
Post by: vertigopix on March 19, 2014, 09:57:28 AM
Thanks for this plugin !   :)
Checked you version 1.0.1 and working perfectly for me (LR 5.3 64bit, Win7 64)

Great job !
Title: Re: Lightroom plugin cr2hdr
Post by: Luiz Roberto dos Santos on March 19, 2014, 09:58:08 AM
Work's fine to me on LR 5.3 (Win8 64bit). Very fast, FYI.

I made a Portuguese (BR) translation: http://textuploader.com/1wvb/raw
Title: Re: Lightroom plugin cr2hdr - Error: 'Already treated
Post by: kichetof on March 19, 2014, 10:02:51 AM
After the first export (which was ok) I always get the following error with every other Picture:

'Already treated' - 'The File xy has already converted to dual iso'
(LR 5.2)

In fact the file was NOT converted.

I have found the reason for this behaviour by myself: The plugin doesn't add numbers to the converted files; my filenames are rather long and the plugin therefore produces always the same filenames in the same directory.

After every single conversion I have to rename the converted file manually. A batch-job will therefore not be possible but nevertheless the integration in LR is great..

Ralf

Ok I know what you're this problem. My export template rename the file with "dualiso_xxxx.cr2" but if your originale name doesn't has number, the export plugin can't add to the destination.
I'll try to resolve it !
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 19, 2014, 10:11:04 AM
Work's fine to me on LR 5.3 (Win8 64bit). Very fast, FYI.

I made a Portuguese (BR) translation: http://textuploader.com/1wvb/raw

Thanks for this translation!

I commit it and I'll update plugin when I find a way to solve fotogemeinschaft_de problem.
You can download Portuguese BR (https://bitbucket.org/kichetof/lr_cr2hdr/src/df27905cd855768cd60efe81c8de657710f7aa49/TranslatedStrings_br.txt?at=default) or Portuguese PT (https://bitbucket.org/kichetof/lr_cr2hdr/src/df27905cd855768cd60efe81c8de657710f7aa49/TranslatedStrings_pt.txt?at=default) and place it into cr2hdr.lrplugin for the moment ;)
Title: Re: Lightroom plugin cr2hdr - Error: 'Already treated
Post by: fotogemeinschaft_de on March 19, 2014, 10:44:19 AM
Ok I know what you're this problem. My export template rename the file with "dualiso_xxxx.cr2" but if your originale name doesn't has number, the export plugin can't add to the destination.
I'll try to resolve it !

My filenames HAVE unique numbers, but are rather long (;-) f.i.  140302-1584-320ASA-Max-Mustermann-00491739900599.CR2 '1584' is the unique number.

Your plugin seems to CUT the filename; if it won't cut the filename and only would add '-dual-iso-1[number consecutively
].dng' at the END of the filename everything would be ok...
Title: Re: Lightroom plugin cr2hdr - Error: 'Already treated
Post by: Audionut on March 19, 2014, 10:58:57 AM
140302-1584-320ASA-Max-Mustermann-00491739900599.CR2

Why only 48 characters?  :o  :P
Title: Re: Lightroom plugin cr2hdr - Error: 'Already treated
Post by: kichetof on March 19, 2014, 11:03:37 AM
My filenames HAVE unique numbers, but are rather long (;-) f.i.  140302-1584-320ASA-Max-Mustermann-00491739900599.CR2 '1584' is the unique number.

Your plugin seems to CUT the filename; if it won't cut the filename and only would add '-dual-iso-1[number consecutively
].dng' at the END of the filename everything would be ok...

Solved it ! :) Download v1.0.2 from first post
Title: Re: Lightroom plugin cr2hdr - Error: 'Already treated
Post by: fotogemeinschaft_de on March 19, 2014, 11:37:09 AM
Solved it ! :) Download v1.0.2 from first post

Great! Thanks a lot!

Ralf
Title: Re: Lightroom plugin cr2hdr - Error: 'Already treated
Post by: fotogemeinschaft_de on March 19, 2014, 01:29:02 PM
Why only 48 characters?  :o  :P

How much are possible?  ;)
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 19, 2014, 01:29:59 PM
I just ran exports in several export operations. Tried running 5 exports simultaneously of cr2 to dng and they work in parallell that way. Occassionally I get a pop up window telling me an internal error has occured but it exports anyway so I just ignored and synchronized the folder when finished.

The error code
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2F4m6myhng1%2FSka_rmavbild_2014_03_19_kl_08_44_16.png&hash=74539e43983879044d5bf77d63a183b2)

*It appears the error code does indeed affect some pictures only getting halfway through the process so Running several export operations simultaneously isn,t stable.

Fix it :)

Update to v1.0.3
Title: Re: Lightroom plugin cr2hdr
Post by: Stedda on March 19, 2014, 01:34:12 PM
Thanks for your time and sharing this is great!
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 19, 2014, 01:59:28 PM
Fix it :)

Update to v1.0.3

This is so great. I ran 4 operations simultaneously, exported to a specific folder. Fast and within lightroom, no problems at all. Very good work. Such a useful plugin and dualiso still amaze me every time. It even reimports the dngs automatically without having to sync the folder. Sweet! Thanks a million

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2Fsc2541w6f%2Fdualiso_6860.jpg&hash=7bfe16d3fae1a4c12a27327f66236e7f)
Title: Re: Lightroom plugin cr2hdr
Post by: mclein on March 20, 2014, 02:16:16 AM
Hi, great implementation!
However, the original cr2hdr can process the .dng file too.
I generally store all the photo in dng format and i wonder if the plugin will be able to process not only the .cr2 dual iso files but the one converted in .dng too.

thanks!
Title: Comparison
Post by: filmio on March 20, 2014, 07:25:25 AM
Excellent Plugin, I made my first attempt on Dual ISO. Here're the results against a .CR2 file
If anyone has a tutorial or Workflow for this, will be really appreciated it.
http://postimg.org/image/7f3zv0r85/

Thanks Magic Lantern and fellow cinematographers.  8)
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 20, 2014, 08:28:40 AM
However, the original cr2hdr can process the .dng file too.

Good point !
I'll add to the next release !

I rewrite the plugin, so I think it's for this weekend ;)

------------

Okay, if a dng is sended to cr2hdr, it'll write the output with same name. I need to see how to make it nicely :) (maybe disable check if dual iso already treated)

With dng support, I can't check if file doesn't have interlaced iso without read text file ... I think I'll not add support for dng file or find an elegant way to check if dng and if interlaced iso found. I add it to the todo list
Title: Re: Lightroom plugin cr2hdr
Post by: Audionut on March 20, 2014, 09:58:58 AM
Maybe the source for cr2hdr could provide some useful hints.
Title: Re: Lightroom plugin cr2hdr
Post by: a1ex on March 20, 2014, 10:25:19 AM
If the DNG was already processed, it will be tagged with Dual-ISO.

However, telling whether a CR2 or DNG is interlaced is not easy (it's a heuristic, and the one from cr2hdr is not perfect).
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 20, 2014, 10:50:15 AM
If the DNG was already processed, it will be tagged with Dual-ISO.

However, telling whether a CR2 or DNG is interlaced is not easy (it's a heuristic, and the one from cr2hdr is not perfect).

Yeah good point ! I can read the label of the file and reimport if not tagged ! Thanks a1ex !
Title: Re: Lightroom plugin cr2hdr
Post by: hdm on March 20, 2014, 08:57:37 PM
Hey kichetof,
i'm getting a error message: Error #256. And it says i should report it here.
I hope i can get it to work. Is it something i'm doing wrong?

I'm running osx 10.9.2, lightroom 5.2 on macbook pro 2011.

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fwww.hooiveld-media.nl%2FMLshare%2Fscreencr2hdrerror256.png&hash=eb77d2d1bd6796de5246d8b05dcda8d2)
Title: Re: Lightroom plugin cr2hdr
Post by: moocowe on March 20, 2014, 09:52:49 PM
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fwww.hooiveld-media.nl%2FMLshare%2Fscreencr2hdrerror256.png&hash=eb77d2d1bd6796de5246d8b05dcda8d2)

I'm getting this same error message running Lightroom 4.1 on OSX 10.9.2.
When I added the plug-in via the Plug-in Manager, it didn't show up in the export options.
It shows up after manually copying the plug-in to the Lightroom/Modules folder, but I get Error #256 when I run it.

Thanks for creating this, I look forward to getting it working.
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 20, 2014, 10:30:34 PM
Try to put it straight to pluginfolder. Program-lightroom-rightclick, show package contents-contents-plugins
Title: Re: Lightroom plugin cr2hdr
Post by: moocowe on March 20, 2014, 11:00:52 PM
I've tried it in the following locations, and all 3 give the same error #256:

lightroom 4.app/contents/plugins
library/application support/adobe/lightroom/modules
user folder/library/application support/adobe/lightroom/modules

I also just tried adding it via Plug-in Manager again, and it displayed this time, but gave error #256 as well.
Title: Re: Lightroom plugin cr2hdr
Post by: Danne on March 20, 2014, 11:24:48 PM
Strange. I, m on version 4.4, mavericks 10.9.2
Title: Re: Lightroom plugin cr2hdr
Post by: moocowe on March 21, 2014, 12:19:21 AM
If I change the export options to dng, I get a different message saying:

~ Already treated ~
The file _UAL1916.CR2 has already converted to dual iso

No converted file exists, and I have tried playing around with different naming options. All there is in the folder is the original CR2 and a txt file generated by cr2hdr when I try to export
Title: Re: Lightroom plugin cr2hdr
Post by: albert-e on March 21, 2014, 02:23:37 AM
If I change the export options to dng, I get a different message saying:

~ Already treated ~
The file _UAL1916.CR2 has already converted to dual iso

No converted file exists, and I have tried playing around with different naming options. All there is in the folder is the original CR2 and a txt file generated by cr2hdr when I try to export

I have LR 5.3 installed on a Mac OS X Mavericks 10.9.2. On Export window:
File Naming/Rename To[Custom Settings]/Extensions[Lowercase]
File Settings/Image Format[Original]

This is the default setting for the Export To: Magic Lantern/cr2hdr, nothing else to do except leave the imported filename as the original as in: IMG_nnnn-dualiso.cr2.

It should work.


Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 21, 2014, 07:26:24 AM
@hdm @moocowe

Do you buy lightroom from Mac App Store? Maybe this is the problem. Could you check your privacy rules (under Mac settings (I don't remember the exact name) and enable to run program from any developer (not recommended but only for testing) and let me known

Export a dng will display already treated!

I'm going to rewrite the plugin and change the check for already treated!

Stay tuned! I hope this weekend ;)
Title: Re: Lightroom plugin cr2hdr
Post by: hdm on March 21, 2014, 07:38:40 AM
@kichetof

My lightroom is stand alone, not via Mac app store. I will check your solution with developer settings. Will send an update soon.
Anyway, hope it works because it looks like a neat piece of software!

Edit: tested with different security options, including 'run any program'. The error, however, remains. Also tried moving the plugin and installing it from different folders. Nothing worked. The plugin does show up in the plugin-manager, says it's okay and i can select it to export. Hope this helps, looking forward to a solution.

Edit #2: (also @moocowe ) i've got it working. Just install this package that i found in the original post from a1ex. It probably needs this to preform: https://bitbucket.org/a_d_/magic-lantern/downloads/OSX_cr2hdr.zip Just run the cr2hdr package and than simply open lightroom to use the export cr2hdr from kichetof.
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 21, 2014, 09:40:39 AM
@kichetof
Edit #2: (also @moocowe ) i've got it working. Just install this package that i found in the original post from a1ex. It probably needs this to preform: https://bitbucket.org/a_d_/magic-lantern/downloads/OSX_cr2hdr.zip Just run the cr2hdr package and than simply open lightroom to use the export cr2hdr from kichetof.

Yeah great!!

I know the problem. You had not dcraw and/or exiftool installed on your mac ;)
I'll add a note for the next release !

Thanks for your investigation and the solution
Title: Re: Lightroom plugin cr2hdr
Post by: moocowe on March 21, 2014, 09:48:30 AM
Excellent! Working fine now.
Thanks very much guys, I knew it would be something I'd done wrong.
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 22, 2014, 01:26:48 AM
can you add some helpful feaure?

i usually group my shoots into collections.
now when i run your export plugin, the image gets added to the gallery, but not to the collection the source image was in.

-> can you check in which galleries the source image was and add the .dng there too?
Title: Re: Lightroom plugin cr2hdr
Post by: qqluqq on March 22, 2014, 03:40:44 PM
He seems to think half of my images aren't dual iso while they all are, is there a way to force him to do it anyway?
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 22, 2014, 05:28:22 PM
-> can you check in which galleries the source image was and add the .dng there too?

Good idea ! I add it to the todo list!

I read the sdk to optimize the actual code and add all the new features after :)

He seems to think half of my images aren't dual iso while they all are, is there a way to force him to do it anyway?

To force cr2hdr, you need to manually drag'n'drop to the exe cr2hdr and reimport to lightroom. If you obtain "The image does not appear to be dual iso" I can't do anything to solve it ;)
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 23, 2014, 01:29:04 AM
bug report:

i have dozens of cmd.exe processes in background according to my task manager.

command line: C:\Windows\system32\cmd.exe  /K del   "D:\Users\g3gg0\Pictures\Kamera\2013_07_17\NO8A5896-dualiso.cr2" "D:\Users\g3gg0\Pictures\Kamera\2013_07_17\NO8A5896-dualiso.xmp"
current directory: C:\Program Files\Adobe\Adobe Photoshop Lightroom 4.4\

Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 23, 2014, 12:45:15 PM
command line: C:\Windows\system32\cmd.exe  /K del   "D:\Users\g3gg0\Pictures\Kamera\2013_07_17\NO8A5896-dualiso.cr2" "D:\Users\g3gg0\Pictures\Kamera\2013_07_17\NO8A5896-dualiso.xmp"
current directory: C:\Program Files\Adobe\Adobe Photoshop Lightroom 4.4\

uh ‽ Why do you have /K on the command ‽

Could you try to change on line 28

Code: [Select]
local rm = MAC_ENV == true and 'exec rm ' or 'start /B del '
with

Code: [Select]
local rm = MAC_ENV == true and 'exec rm ' or 'start /B /WAIT del '
I don't have access on windows now to try to resolve it. I hope /WAIT solve that!

OR maybe... on windows I can't remove a lots a file with del (maybe one by one)
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 23, 2014, 04:25:19 PM
this causes to block even the first export.

trying "start /B cmd.exe /C del /F /Q" now - looks good ;)
Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on March 23, 2014, 04:31:44 PM
this causes to block even the first export.

trying "start /B cmd.exe /C del /F /Q" now - looks good ;)

Yeah so good ! Thanks

I found an other way to move ;)
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 24, 2014, 10:04:41 PM
here (http://upload.g3gg0.de/pub_files/7d36a685b662c14f49558809489ff170/MLExportServiceProvider.lua) my modification that adds .dng support from e.g. raw videos.

the modification is necessary as cr2hdr will overwrite the input file in case of .dng.

i tried raw video with dual iso, but with line skipping its having some horizontal lines (expected)
didnt try a zoomed recording yet.
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 25, 2014, 11:39:40 AM
cr2hdr v2 available now :)

@g3gg0 I've added a new way to export, no need to remove cr2&xmp files ;) thanks for your try
Title: Re: Lightroom plugin cr2hdr v2
Post by: Danne on March 25, 2014, 02:24:19 PM
Nice one! Good work on being able to rename files.
I have one problem. When trying to export to a subfolder all I get is a copy from the original file, no conversion i being made as when I export to the same folder? This worked in former versions.
Thanks again for all your work on this.

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fs3zwaq87l%2FSka_rmavbild_2014_03_25_kl_14_03_35.png&hash=098a725cee45ab5650a5ea4aafe52bea)
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 25, 2014, 02:49:45 PM
Nice one! Good work on being able to rename files.
I have one problem. When trying to export to a subfolder all I get is a copy from the original file, no conversion i being made as when I export to the same folder? This worked in former versions.
Thanks again for all your work on this.

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fs3zwaq87l%2FSka_rmavbild_2014_03_25_kl_14_03_35.png&hash=098a725cee45ab5650a5ea4aafe52bea)

It's really strange, why you don't have ML Logo + the explanation text on your export windows ?

With the v2, I export cr2+xmp files to a temporary folder (not needed after conversion) and move the result file from temp folder to original folder. After all conversion, the temp folder is deleted!
Title: Re: Lightroom plugin cr2hdr v2
Post by: fotogemeinschaft_de on March 25, 2014, 03:15:42 PM
On my System (Windows 8.1; LR 5.2) the new version (2.0) doesn't open a window and doesn't export a file anymore. Before this new version it was ok.
Title: Re: Lightroom plugin cr2hdr v2
Post by: Danne on March 25, 2014, 03:18:28 PM
Sorry.
I get the logo-window fine at the start. Really sweet. When I change from export to "Hard drive" instead of "Magic lantern" all the way up to export directly to a subfolder, that,s when the problem occurs. In the former version I could choose between keepin them in the same folder as the originals or converting directly to a subfolder for instance named "ML". Maybe I,m missing something.

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs16.postimg.org%2Fc82ansq79%2FSka_rmavbild_2014_03_25_kl_13_54_53.png&hash=71c60a2b457e7d8991b90fbe0af63516)
Title: Re: Lightroom plugin cr2hdr v2
Post by: tomuse on March 25, 2014, 03:31:01 PM
Yes this is correct, after the conversation the DNG file is under the TEMP Folder in Lightroom, but the dng File will not be move in the original Folder. Under the Version 1.03 the workflow is running
Title: Re: Lightroom plugin cr2hdr v2
Post by: fotogemeinschaft_de on March 25, 2014, 03:54:17 PM
I would like to re-install the older version 1.03. Where can I download it?
Title: Re: Lightroom plugin cr2hdr v2
Post by: tomuse on March 25, 2014, 03:59:51 PM
Under the following Link https://bitbucket.org/kichetof/lr_cr2hdr/downloads/
Title: Re: Lightroom plugin cr2hdr v2
Post by: fotogemeinschaft_de on March 25, 2014, 04:08:13 PM
Under the following Link https://bitbucket.org/kichetof/lr_cr2hdr/downloads/

Thanks!

Ralf
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 25, 2014, 04:59:41 PM
On my System (Windows 8.1; LR 5.2) the new version (2.0) doesn't open a window and doesn't export a file anymore. Before this new version it was ok.

If you right click on picture on click on cr2hdr, no windows open. To see the windows, you need to go to Export... and select cr2hdr ;) but it doesn't explain why you don't have the result file... maybe it's the same problem from tomuse.

converting directly to a subfolder for instance named "ML". Maybe I,m missing something.

With v2, you can't import into a subfolder. I can add a field to add a custom name to create a new subfolder on the top folder ;)

Yes this is correct, after the conversation the DNG file is under the TEMP Folder in Lightroom, but the dng File will not be move in the original Folder. Under the Version 1.03 the workflow is running

So, the conversion work, but the move doesn't works (strange!) Do you have a file with the exactly same name of the output file ?

All your problem appears on Windows or Mac ?

Unfortunately, I don't have a Windows desktop under my hand now to try it. But I use LR function to check file and move file, I was hoping it would work out of the box
Title: Re: Lightroom plugin cr2hdr v2
Post by: Danne on March 25, 2014, 05:06:59 PM
"With v2, you can't import into a subfolder. I can add a field to add a custom name to create a new subfolder on the top folder"

Hehe, I like the sound lf that
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 25, 2014, 05:20:24 PM
Could you try to replace MLExportServiceProvider.lua with this version : https://bitbucket.org/kichetof/lr_cr2hdr/raw/b92125f660783c6bfd4bd44b8debf9af15153e41/MLExportServiceProvider.lua

and tell me if you receive an error message after conversion.
I forgot to parse move function to check if success to move the file. That's not solve the problem, only for identifying the crash

After trying the modified version, could you try this one https://bitbucket.org/kichetof/lr_cr2hdr/raw/9cfa2803f006fd17af6cb6731415a61fa014fe2c/MLExportServiceProvider.lua
and let me know ! I replaced move by copy
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 25, 2014, 05:39:15 PM
"With v2, you can't import into a subfolder. I can add a field to add a custom name to create a new subfolder on the top folder"

Hehe, I like the sound lf that

Could you try this version on mac it'll works fine :) (not tested yet)

forget what I said. Not so simple
Title: Re: Lightroom plugin cr2hdr v2
Post by: camagna on March 25, 2014, 06:25:49 PM
There must be something wrong. in LR (5.3, Mac 10.9.2) I get this errors on plugin loading:

Plug-in error log for plug-in at: /Users/xxxx/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin

**** Error 1

An error occurred while attempting to run one of the plug-in’s scripts.
Could not load toolkit script: MLFunctions

**** Error 2

Could not load the post-processing filter from this plug-in.
Could not load toolkit script: MLFunctions

Title: Re: Lightroom plugin cr2hdr v2
Post by: poromaa on March 25, 2014, 08:50:52 PM
This is so neat! Thanks a lot!
Great work!
Title: Re: Lightroom plugin cr2hdr v2
Post by: tomuse on March 25, 2014, 09:04:18 PM
Could you try to replace MLExportServiceProvider.lua with this version : https://bitbucket.org/kichetof/lr_cr2hdr/raw/b92125f660783c6bfd4bd44b8debf9af15153e41/MLExportServiceProvider.lua

Yes after changing this lua a Lightroom error come "unable to move the file" because the import and the export folder are the same.

After trying the modified version, could you try this one https://bitbucket.org/kichetof/lr_cr2hdr/raw/9cfa2803f006fd17af6cb6731415a61fa014fe2c/MLExportServiceProvider.lua
and let me know ! I replaced move by copy


After copy this lua File i became a Error "unable to copy the file" the same like above same Import / Export folder

My Folder form the CR Files is on Volume G:\...\DUAL_ISO - DNG\ The Error come always on the Volume C:\
Title: Re: Lightroom plugin cr2hdr v2
Post by: Luiz Roberto dos Santos on March 25, 2014, 11:53:30 PM
@kichetof

Why export AdobeRGB? 0k, this is non-bayer, but why tag it?

Quote
s = {
   id = "996B34E8-83FC-4D31-AF92-A644E36B8D96",
   internalName = "cr2hdr",
   title = "cr2hdr",
   type = "Export",
   value = {
      collisionHandling = "overwrite",
      embeddedMetadataOption = "all",
      exportServiceProvider = "com.adobe.lightroom.export.ml.dualiso",
      exportServiceProviderTitle = "Magic Lantern",
           export_colorSpace = "AdobeRGB"
      export_destinationPathSuffix = "ML",
      export_destinationType = "sourceFolder",
      export_photoSectionsEnabled = true,
      [...]


Anyway, I had some free time so I took the liberty to translate correctly to pt-br:
Note: the blue is the correct translation.

TranslatedStrings_br.txt
Quote
"$$$/ML/ExportManager/Title=Magic Lantern Dual ISO" [Magic Lantern Dual ISO]
"$$$/ML/ExportManager/MLTopic=Magic Lantern fio Dual ISO" [Tópico para Magic Lantern Dual ISO]
"$$$/ML/ExportManager/MLDocTech=doc Técnico" [Documento Técnico]
"$$$/ML/ExportManager/Description=Este plugin permite converter uma imagem ISO com dupla cr2hdr (graças a1ex) de lanterna mágica.^n^nComo funciona :^n^n- Exportação imagem para pasta temporária^n- Add -dualiso sufixo imaginar^n- Converter foto com cr2hdr^n- Importação convertido imagem deste catálogo LR^n- Adicionar DualISO ao rótulo^n- Adicionar imagem convertida para as coleções da imagem original" [Este plugin permite converter uma imagem Dual ISO por meio do cr2hdr (obrigado ao a1ex) do Magic Lantern.^n^Como isso funciona :^n^n- Exporta a imagem para uma pasta temporária^n- Adiciona o sulfixo -dualiso a imagem^n- Converte a imagem com cr2hdr^n- Importa a imagem convertida dentro do mesmo catálogo do LR^n- Adiciona o rótulo DualISO^n- Adiciona a imagem convertida as mesmas coleções de sua imagem original]
"$$$/ML/ExportManager/ASTitle=configurações avançadas" [Configurações Avançadas]
"$$$/ML/ExportManager/ASSuffix=Sufixo para saída de arquivo iso dupla :" [Sulfixo dual iso ao arquivo de saída :]
"$$$/ML/ExportManager/ASLabel=Definir o rótulo para arquivo ISO dupla :" [Definindo o rótulo para o arquivo Dual ISO :]
"$$$/ML/ExportManager/ASCollection=Adicionar arquivo ISO dupla a coleção?" [Adicionar o arquivo Dual ISO a coleção ?]
"$$$/ML/ExportManager/ASCollectionInfo=Desmarque para não adicionar à coleção imagem original" [Desmarcar para não adicionar à coleção da imagem original]
"$$$/ML/ExportManager/ASLog=Manter arquivo de log após a conversão?" [Mantenha o arquivo de histórico de eventos depois da conversão?]
"$$$/ML/ExportManager/ASLogInfo=Desmarque para remover" [Desmarque para remover]
"$$$/ML/Dependencies/ErrorTitle=~ Dependências erro ~" [~ Erro com dependências ~]
"$$$/ML/Dpendencies/Error=Este plugin obras (cr2hdr) precisam dcraw e exiftool.^n^nFavor instalá-lo antes de executar este plugin" [Para esse plugin trabalhar (cr2hdr) é necessário ter dcraw e exiftool.^n^nPor favor, instale estes antes de executar esse plugin]

 :)
Title: Re: Lightroom plugin cr2hdr v2
Post by: mad.eos on March 26, 2014, 12:26:04 AM
What happened? I installed v2 now it creates to a temp folder but then it's not available! Creates the dng file but then when I try to develop "Folder could not be found" am I missing something? What am I doing wrong? My workflow is doomed! LOL

Switching back to 1.03! You're still the man Kich! With all this help, and your hard work, i'm sure this problem will be solved in no time!  ;D
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 26, 2014, 09:30:20 AM
Could you try to replace MLExportServiceProvider.lua with this version : https://bitbucket.org/kichetof/lr_cr2hdr/raw/b92125f660783c6bfd4bd44b8debf9af15153e41/MLExportServiceProvider.lua

Yes after changing this lua a Lightroom error come "unable to move the file" because the import and the export folder are the same.

After trying the modified version, could you try this one https://bitbucket.org/kichetof/lr_cr2hdr/raw/9cfa2803f006fd17af6cb6731415a61fa014fe2c/MLExportServiceProvider.lua
and let me know ! I replaced move by copy


After copy this lua File i became a Error "unable to copy the file" the same like above same Import / Export folder

My Folder form the CR Files is on Volume G:\...\DUAL_ISO - DNG\ The Error come always on the Volume C:\

Okay thanks for the report! It's the move/copy functions that is problematic on windows only... always windows, always...


Why export AdobeRGB? 0k, this is non-bayer, but why tag it?

Do you prefer sRGB or ProPhoto ? I think is the best profil for export to cr2hdr, but if you think it's not, tell me the best :)

Anyway, I had some free time so I took the liberty to translate correctly to pt-br:
Note: the blue is the correct translation.

TranslatedStrings_br.txt
 :)

Many thanks for your corrections! I'll add on the next stable version :)
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 26, 2014, 09:32:26 AM
There must be something wrong. in LR (5.3, Mac 10.9.2) I get this errors on plugin loading:

Plug-in error log for plug-in at: /Users/xxxx/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin

**** Error 1

An error occurred while attempting to run one of the plug-in’s scripts.
Could not load toolkit script: MLFunctions

**** Error 2

Could not load the post-processing filter from this plug-in.
Could not load toolkit script: MLFunctions

Very strange ! I've the same configuration, I'll investigate why you have this error.

What happened? I installed v2 now it creates to a temp folder but then it's not available! Creates the dng file but then when I try to develop "Folder could not be found" am I missing something? What am I doing wrong? My workflow is doomed! LOL

Switching back to 1.03! You're still the man Kich! With all this help, and your hard work, i'm sure this problem will be solved in no time!  ;D

The copy/move fail on windows, maybe you have this problem

------------------------------------------------------------------------------------------


Windows, windows, windows .......

I think I found why it's bug! my custom functions is not loaded... I need to found how to read it!


====================================================

Please try to replace MLExportServiceProvider.lua with this version (https://bitbucket.org/kichetof/lr_cr2hdr/raw/c58124667af3989f1811cf48e50f6c4b2f2bedbf/MLExportServiceProvider.lua). It works on my windows.. I really need a Windows VM at home ;)
Title: Re: Lightroom plugin cr2hdr v2 unstable
Post by: kichetof on March 26, 2014, 04:00:28 PM
V2.0.12 to download ;) Try and report me if it works (... or not :))

forget to update portuguese correction, 2.0.2 now up to date ;)
Title: Re: Lightroom plugin cr2hdr v2
Post by: Luiz Roberto dos Santos on March 26, 2014, 04:34:50 PM
Do you prefer sRGB or ProPhoto ? I think is the best profil for export to cr2hdr, but if you think it's not, tell me the best

Well, in my work process I try to keep as much detail in the process. ProPhotoRGB is known to be the larger of the known color spaces (not counting the tangential wide gammut, etc.).
But, I think the engine Lightroom has its own color space, called Melissa RGB (http://ptgmedia.pearsoncmg.com/imprint_downloads/peachpit/peachpit/lightroom4/pdf_files/LightroomRGB_Space.pdf), which does not restrict or limit the colors, keeping the information in full.

Many thanks for your corrections! I'll add on the next stable version :)

;D
Title: Re: Lightroom plugin cr2hdr v2 unstable
Post by: tomuse on March 26, 2014, 07:39:06 PM
Please try to replace MLExportServiceProvider.lua with this version. It works on my windows.. I really need a Windows VM at home ;)
« Last Edit: Today at 11:49:45 AM by kichetof »

Yes wonderfull with this new LUA File the workflow rock... Many thanks, fast and big JOB !!!
Title: Re: Lightroom plugin cr2hdr v2 unstable
Post by: tomuse on March 26, 2014, 07:47:35 PM
V2.0.2 to download ;) Try and report me if it works (... or not :))

forget to update portuguese correction, 2.0.2 now up to date ;)

Good, this Version 2.02 has no Problems, everything is as it should be :)
Title: Re: Lightroom plugin cr2hdr v2 unstable
Post by: shahed26 on March 26, 2014, 08:48:16 PM
Thanks for this. Going to try it out on windows 8.1
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 27, 2014, 12:21:42 AM
V2.1 :)

"With v2, you can't import into a subfolder. I can add a field to add a custom name to create a new subfolder on the top folder"

Hehe, I like the sound lf that

You can now!
Title: Re: Lightroom plugin cr2hdr v2
Post by: mad.eos on March 27, 2014, 03:00:41 AM
You sir... I take off my hat... Great job!! It now works!! Thank you!  ;)
Title: Error Code
Post by: LazR on March 27, 2014, 05:25:32 PM
I have reread the topic numerous times in hopes of finding an answer, but could not find one. I have installed OSX_cr2hdr as per the instruction, and I run cr2hdr, which is in my Applications folder, before starting Lightroom, but I continue to receive Error #11 when trying to export a single Dual ISO image. The plugin appears to be installing correctly through the plugin manager as well as manually (tried numerous times).

Any ideas what I might be doing wrong? Your help is greatly appreciated.

Running on:
Lightroom 5.3
Mac OS X 10.7.5
cr2hdr.2.1

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fwww.thelivingsea.com%2Fimages%2Fmisc%2Flr-error.jpg&hash=034759ed3dc8e3fd22da0fce62f4a52b)
Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 27, 2014, 07:01:47 PM
Hi LazR,

Could you try to run cr2hdr into a terminal a paste the output. Maybe I'll can determine what the problem is with that.
Title: Re: Lightroom plugin cr2hdr v2
Post by: LazR on March 27, 2014, 08:43:16 PM
Thank you your time and help, Kichetof. Sorry, as I am quite the newb when it comes to all of this, so perhaps I am not completely understanding your request.

I opened the GUI version of cr2hdr Beta 2.0 app in terminal (open -a /Applications/cr2hdr.app/ 140327-092716-0001.CR2) and it simply opens the app and processes the CR2 dual iso file perfectly. There was no output afterwards in Terminal. Only the saved text file for the image processed (info below) was included in the folder with the new DNG file.

I was able to process the dual iso files like this before. It is just in your plugin that I still get the Error #11. Could this be related to your Lightroom plugin not finding the cr2hdr app? Should I have another version of cr2hdr on my Mac instead? Perhaps the binary version in /usr/bin folder instead. I have tried both of the versions of your plugin listed on the beginning of this post and both are giving me the same #11 Error.

I appreciate your help.

Text file:
    1 image files updated
cr2hdr: a post processing tool for Dual ISO images

Last update: 2f4e2df on 2013-12-02 17:45:36 UTC by alex:
cr2hdr: fix DNG compression under Windows

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)

Input file      : 140327-092716-0001.CR2
Camera          : Canon EOS 7D
Full size       : 5360 x 3516
Active area     : 5202 x 3465
White level     : 12500
Black borders   : 158 left, 51 top
Black level     : 1957
ISO pattern     : dBBd GBRG
Noise levels    : 5.86 21.15 23.25 5.79 (14-bit)
ISO difference  : 4.08 EV (1691)
Black delta     : 8.20
Dynamic range   : 10.83 (+) 8.82 => 12.90 EV (in theory)
Looking for hot/cold pixels...
Hot pixels      : 23
Cold pixels     : 990
AMaZE interpolation ...
Amaze took 4.22 s
Edge-directed interpolation...
Semi-overexposed: 7.17%
Deep shadows    : 74.08%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.8 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 4.49 (16-bit), ideally 4.44
Dynamic range   : 13.20 EV (cooked)
Black adjust    : -1
Output file     : 140327-092716-0001.DNG

Title: Re: Lightroom plugin cr2hdr v2
Post by: kichetof on March 27, 2014, 09:32:56 PM
So strange!

The plugin work well, but the execute command for cr2hdr doesn't works...

Could you uninstall the plugin, install this version (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.1.0.3-log.zip) and paste the output log (normally MLDualISO.txt into your home folder or documents folder). You can replace your username/name if you want but keep space if present.

I hope I'll solve your problem quickly!
Title: Re: Lightroom plugin cr2hdr v2
Post by: Danne on March 28, 2014, 12:34:22 AM
V2.1 :)

You can now!

Will try this asap!

*Nice one! Creates a subfolder and puts them in there nice and with options keeping logs or not. Real nice. Truly grateful for your work on this! Big thanks
Title: Re: Lightroom plugin cr2hdr v2
Post by: LazR on March 28, 2014, 04:57:55 AM
So strange!

The plugin work well, but the execute command for cr2hdr doesn't works...

Could you uninstall the plugin, install this version (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.1.0.3-log.zip) and paste the output log (normally MLDualISO.txt into your home folder or documents folder). You can replace your username/name if you want but keep space if present.

I hope I'll solve your problem quickly!

Here is the information from the log file:
2014-03-28 03:52:02 +0000, DEBUG   Export cr2hdr file: /Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.DNG
2014-03-28 03:52:02 +0000, DEBUG   Export cr2hdr output: /Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.txt
2014-03-28 03:52:02 +0000, DEBUG   Export xmp file: /Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.xmp
2014-03-28 03:52:02 +0000, DEBUG   Plugin Path: /Lightroom Catalogs/Plugins/cr2hdr.lrplugin
2014-03-28 03:52:02 +0000, DEBUG   Command for cr2hdr: exec "/Lightroom Catalogs/Plugins/cr2hdr.lrplugin/bin/cr2hdr" "/Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.cr2" > "/Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.txt"
2014-03-28 03:52:02 +0000, DEBUG   Problem with export to cr2hdr
2014-03-28 03:52:02 +0000, DEBUG   Error: 11
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on March 28, 2014, 09:01:09 AM
uh?! I don't understand...

2014-03-28 03:52:02 +0000, DEBUG   Command for cr2hdr: exec "/Lightroom Catalogs/Plugins/cr2hdr.lrplugin/bin/cr2hdr" "/Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.cr2" > "/Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.txt"

Could you try to run into a Terminal this command and let me know:

Code: [Select]
"/Lightroom Catalogs/Plugins/cr2hdr.lrplugin/bin/cr2hdr" "/Volumes/Photo Vault 1/Underwater Photos/2014 Photos/2014-03-27/ML/140327-092716-0001-dualiso.cr2"
(If quote failed, remove it)

Maybe there are some restriction in 10.7.5 but it's too old and my head doesn't remember...

When you launched cr2hdr into a terminal in my last request, do you use cr2hdr exec from my plugin or from another one ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: LazR on March 28, 2014, 02:49:25 PM
Maybe there are some restriction in 10.7.5 but it's too old and my head doesn't remember...

When you launched cr2hdr into a terminal in my last request, do you use cr2hdr exec from my plugin or from another one ?

I think you might be on to something here, Kitchetof. I originally ran the cr2hdr APP that was included in the zip file in OSX_cr2hdr. As a standalone application, dropping the CR2 files into the window will convert them properly as DNG files. Now, when trying the cr2hdr exec in your application or any other version I could find in the Mac terminal, I keep getting an Illegal instruction: 4. From what I read online, this error has to do with code that is not compatible with an older OS X version. Strange that the cr2hdr APP works perfectly, though. Hmmmm...

I will upgrade my system to OS X Maverick and report back if the problem continues. Thank you so much for your time and assistance. It is greatly appreciated.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on March 28, 2014, 02:56:44 PM
The cr2hdr app on my plugin was build on my system (Mac 10.9.2) and maybe I'll have to enable something to be backward compatible.

I'll read how to build with backward compatibility. Thanks for your feedback
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: LazR on March 28, 2014, 03:18:49 PM
The cr2hdr app on my plugin was build on my system (Mac 10.9.2) and maybe I'll have to enable something to be backward compatible.

I'll read how to build with backward compatibility. Thanks for your feedback

FYI - I pulled the cr2hdr exec from the package content of the cr2hdr gui app that works with my system and even that one gives me the same error when executing it in the Mac terminal.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on March 28, 2014, 04:20:05 PM
FYI - I pulled the cr2hdr exec from the package content of the cr2hdr gui app that works with my system and even that one gives me the same error when executing it in the Mac terminal.

uh ?! When you run outside LR it works, but in my plugin no.

Which command do you use into the terminal ?

could you run "ls -l" on the folder where cr2hdr for the plugin is. It's really strange
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: LazR on March 28, 2014, 04:46:58 PM
uh ?! When you run outside LR it works, but in my plugin no.

Which command do you use into the terminal ?

could you run "ls -l" on the folder where cr2hdr for the plugin is. It's really strange

Good news is that upgrading the OS X to Maverick did the trick. Your wonderful plugin is working beautifully now.

Here is the listing from the bin folder inside your plugin:
-rwxr-xr-x  1 Laz  wheel   101256 Mar 16 19:37 cr2hdr
-rwxr-xr-x@ 1 Laz  wheel   164735 Mar 16 19:37 cr2hdr.exe
-rwxr-xr-x@ 1 Laz  wheel   631720 Mar 19 23:04 dcraw.exe
-rwxr-xr-x@ 1 Laz  wheel  5265644 Mar 19 23:04 exiftool.exe
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on March 28, 2014, 05:04:32 PM
Maybe some LR function doesn't works on 10.7 but I don't know!

Glad to know it works on 10.9 ! :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: nanomad on March 28, 2014, 06:39:20 PM
Sorry if it is an old question or if you already stated it.
Are planning on relasing the source code under a free software license?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on March 28, 2014, 06:46:38 PM
Are planning on relasing the source code under a free software license?

I don't have the time to check what I need to paste into the code to make it under free software. I need to found the part of GNU GPL to add it.

The code is on open source on bitbucket (https://bitbucket.org/kichetof/lr_cr2hdr/src).
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: nanomad on March 28, 2014, 06:51:29 PM
That is good enough for me

You may or may not hear from me soon (good news)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on March 28, 2014, 07:16:33 PM
Updated source with GNU GPL V2 license :) It was faster as I thought
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: mad.eos on March 28, 2014, 09:19:21 PM
This project is warping to lightspeed! :-D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: nanomad on March 29, 2014, 10:20:08 AM
We call it a killer application. Better not waste the opportunity ;D
Title: Re: Lightroom plugin cr2hdr
Post by: g3gg0 on March 29, 2014, 01:36:39 PM
can you add some helpful feaure?

i usually group my shoots into collections.
now when i run your export plugin, the image gets added to the gallery, but not to the collection the source image was in.

-> can you check in which galleries the source image was and add the .dng there too?

@kichetof:
ping :)


edit: just realized that it is being added, but not grouped as in the library view.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on March 29, 2014, 04:20:51 PM
Ouch! Effectively, the photo is stacked with the original in the library view, is added to the collection but not stacked with original.

I read the API Ref and the only function I found is LRCatalog:AddPhoto which I use to import and stack in library view.

But for the Collection view, I don't know how to group with original, I'll read again and again to see if there is a solution.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on April 01, 2014, 09:00:13 PM
Kichetof

Sorry to bother you, but I being thick!

I have loaded the latest version 2.1, which is clearly stated in the LR plug-in manager window. Also the plug-in runs as expected.

But...for the life of me I can not find a sub-menu to additional settings.

When I run the plugin it goes and does its stuff straight away and there is nothing about settings in the plug-in manager window.

I'm running Windows 7 64bit mode, with the latest LR.

Hope you can help.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 01, 2014, 10:56:02 PM
Hi garry,

I think I know your "problem". It seems that you did a confusion.

The settings are available in the export window and not in the plugin manager window.

The window shortcut is: Ctrl + Maj + E
The mac shortcut is: Commande + Maj + E

I hope it solved your problem ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on April 02, 2014, 12:06:30 AM
Kichetof

That was it!

Many thanks.

Cheers

Garry
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: lasfede on April 05, 2014, 09:52:28 AM
Awesome!!!! Thank you so much!!!!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: szDE on April 13, 2014, 08:13:24 PM
Super-useful plugin! Thank you, kichetof.

If I may, I'd like to suggest some additional settings:
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: a1ex on April 13, 2014, 08:36:41 PM
For a GUI, it might be interesting to parse the command-line options from the help text and create widgets from that.

For example:

- simple boolean options (except maybe for debug ones): create a checkbox, e.g. --compress => [X] Compress (and as a tooltip, print the help text from the command-line; here, "Lossless DNG compression")

- the --no- options can be negated like in gcc. For example, the --no-fullres option: in the default configuration fullres is enabled, and you disable it with --no-fullres. In the --fast configuration (which turns it off) you can re-enable it with --fast --fullres (but keep all the other fast processing). So, in this case, a checkbox named Fullres and enabled by default might make sense.

- options with numeric arguments: those are identified by %d or %f (they can have as many parameters as there are wildcards).
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 13, 2014, 11:49:52 PM
@szDE greats ideas!

  • Multithreading (ie. Barracuda GUI). For multithreading I don't know how to add it, but you can run multi export.
  • Delete original (convert and erase). Version 2.1 export to a temp folder and keep original after conversion, I don't want to make this decision but I can add an option

I add all this good ideas on my todo list :)
  • Define command-line parameters (ie. --soft-film=x).
  • Define custom cr2hdr.exe files (ie. 20-bit variant).
  • Define presets (ie. standard, --soft-film=2, --soft-film=4, etc.).
  • Ability to skip confirmation box when using plugin on bunch of different files (jpegs and cr2 together). Just silently skip jpegs.

For a GUI, it might be interesting to parse the command-line options from the help text and create widgets from that.

For example:

- simple boolean options (except maybe for debug ones): create a checkbox, e.g. --compress => [X] Compress (and as a tooltip, print the help text from the command-line; here, "Lossless DNG compression")

Excellent infos!
I'll add it for Easter or just after :)


Thanks for your feedback!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: szDE on April 14, 2014, 11:50:53 AM
kichetof,

Barracuda GUI achieves multithreading by running multiple instances of cr2hdr simultaneously, in background. Perhaps, there's a way to do it the same way in your plugin?


It would be great to have the ability to make it optional in export preset. This way it would be possible to define multiple cr2hdr presets.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 14, 2014, 10:21:53 PM
Barracuda GUI achieves multithreading by running multiple instances of cr2hdr simultaneously, in background. Perhaps, there's a way to do it the same way in your plugin?

Ok ! You can run multiple instances from LR ;) Select 1 photo, export to cr2hdr, select 3 photos on the same time and export to cr2hdr, select 10 photos and export to cr2hdr on the same time, and you have 14 photos on export to cr2hdr on "parallel" with LR ;) (3 tasks on parallels, 1 with 1, 1 with 3 and 1 with 10)

It would be great to have the ability to make it optional in export preset. This way it would be possible to define multiple cr2hdr presets.

I add it on the todo with cr2hdr options :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: batman on April 17, 2014, 10:04:47 PM
When converting dng files all metadata gets stripped, camera settings etc.  Everything works fine with cr2 files though!

I'm using:
Windows 8.1 x64
Lightroom 5.4
cr2hdr 2.1
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 20, 2014, 07:26:55 PM
When converting dng files all metadata gets stripped, camera settings etc.  Everything works fine with cr2 files though!

doh ‽ I don't know why. Maybe dcraw bug with dng ? A1ex do you have an idea?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: swinxx on April 20, 2014, 09:58:31 PM
Great plugin! Thx so much. That is absolutly useful!!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on April 21, 2014, 12:19:30 AM
Following the example of kichetof with his Dual-ISO Lightroom Plugin, I have created a (near) seamless plug-in-like workflow for CeroNoice. The only limitation is that it is Windows based: sorry Mac users.

What I have done is create a .exe file to run CeroNoice, which can be used as an external editor in LR.

To set up the workflow, simply put the required files in a processing folder, ie CeroNoice.exe etc, together with my .exe, called CeroNoice Bracketing.exe.
Set up an external editor preset in Lightroom, with the following attributes:
1.   Export original (can be .cr2 or .dng);
2.   No file naming;
3.   Post processing = open in other application (ie point to CeroNoice Bracketing)

Finally, set up a ‘watched folder’ in LR, where the 32-bit processed .tif will be returned. The returned file will have the image name of the lightest orginal, with _32-bit appended.

Once set up, all you do is select, from darkest to lightest, the input images, export via the CeroNoice Bracketing preset and carry on working. In a few seconds the output file will appear in the LR watch folder (which I call 32-bit Procesing, for easy identification).

All working files, ie LR exports are deleted. You can move the 32-bit Tif or simply leave in the 32-bit Processing folder.

I have found LR handles the CeroNoice created Tifs well.

I am not going to fill up this post with more details, as I often sense not all are interested in such ‘specific stuff’. However, if there is enough interest I will willingly pass on my LR set up and .exe to anyone who wishes to use it, ie PM me or indicate your interest in this post.

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 21, 2014, 09:28:15 AM
V2.2 BETA

I've added:

On Mac the optional args works very well. Windows users please test!

Download cr2hdr 2.2 BETA (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA.zip) and let me know if it works for you!


  • Delete original (convert and erase). Unfortunately, there is nothing on the SDK to do that
  • Define command-line parameters (ie. --soft-film=x). cr2hdr optional arguments done!
  • Define custom cr2hdr.exe files (ie. 20-bit variant). I'm waiting final version to add it
  • Ability to skip confirmation box when using plugin on bunch of different files (jpegs and cr2 together). Just silently skip jpegs. Done !

Happy Easter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on April 21, 2014, 09:54:41 AM
MLFunctions.lua missing? Failure to add module ...

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 21, 2014, 10:08:30 AM
@Walter remove all the files and download this (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA.zip)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on April 21, 2014, 10:14:17 AM
Nope. Same error. MLFunctions.lua (present in 2.1) is missing.
German Win7 x64, LR 5.4.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 21, 2014, 10:18:00 AM
It's really strange because I remove all functions from this file... I check

Do you remove the plugin from Plugin Manager on LR ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on April 21, 2014, 10:24:10 AM
Yes, removed 2.1 in module manager. Tried to install the beta 2.2 plugin several times. Retried to install 2.1 without any problems. Copied 2.2 beta files and dir to the same location where 2.1 is sitting, renamed old 2.1 folder, too. Doesn't work either.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 21, 2014, 10:43:27 AM
I don't know why it doesn't work on Windows... On my Mac everything works well

Did you try to remove plugin, close LR and reinstall plugin ? Maybe there some informations on cache...
Or last try, copy MLFunctions from 2.1 to 2.2-beta.

If I have some time tonight I'll check else tomorrow ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on April 21, 2014, 10:59:49 AM
No need to look. It's running now.
Renamed the folder containing 2.2 beta matching the old (2.1) folder name and loaded plugin. It showed 2.1 first. Then removed it (module manager) and restarted LR, installed module again. Now I'm on 2.2.

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on April 21, 2014, 11:27:18 AM
Quote
No need to look. It's running now.
Let me rephrase that ... ;-)
Left: 2.1. works as designed
Right: 2.2 beta seems to have a path/argument problem.
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs02.imageupper.com%2F1_t%2F5%2FP13980717362434865_1.jpg&hash=ac84d63b358a195294d01befa44daf82) (http://imageupper.com/g/?S020001005P13980717362434865)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: edmagiclantern on April 21, 2014, 11:57:20 AM
Hi all,

First thank YOU for this great ML integration in LR, makes the workflow much easier.

Quick one: when shooting I often alternate between Dual iso and standard settings.
When i get home i process all the images via the plug in so that i dont miss any Dual ISO. However everytime LR processes one image that is not Dual iso the procedure results in an error «image xxx appears not to be Dual ISO» and the conversion stops until i press enter. Making it not a batch conversion anymore and making me sit in front of computer while 2000 images are converted :s.
the question is: is it possible to turn the messages / errors off in the Image Conversion process?

Best regards to all
Eduardo
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on April 21, 2014, 12:28:42 PM
I hope I improved german menu a bit:
Code: [Select]
"$$$/ML/ExportDialog/ExportMenu/Title=Magic Lantern"
"$$$/ML/Publish/Progress=Exportiere ^1 Bilder mit cr2hdr"
"$$$/ML/Publish/Progress/One=Exportiere ein Bild mit cr2hdr"
"$$$/ML/Import/ErrorTitle=~ Fehler beim Import ~"
"$$$/ML/Import/Error=Kann die Dual-ISO-Datei nicht importieren!^n^nBitte Ordner händisch synchronisieren"
"$$$/ML/Publish/noDualIsoTitle=~ Keine Dual-ISO-Datei erkannt ~"
"$$$/ML/Publish/noDualIso=Das Bild ^1 scheint kein Dual-ISO-Bild zu sein"
"$$$/ML/Publish/Error/Title=~ Fehler beim Export ~"
"$$$/ML/Publish/Error=Fehler beim Exportieren von ^1 mit cr2hdr!^r^Fehler #^2^r^rBitte diese Fehlernummer im Magic Lantern Forum melden^n"
"$$$/ML/Publish/AlreadyConvertTitle=~ Fehler beim Konvertieren ~"
"$$$/ML/Publish/AlreadyConvert=Das Bild ^1 wurde bereits konvertiert"
"$$$/ML/Publish/Error/NotRawTitle=~ Fehler: Ungültiges Format ~"
"$$$/ML/Publish/Error/NotRaw=Es können nur RAW-Fotos (CR2 & DNG) mit cr2hdr exportiert werden"
"$$$/ML/ExportManager/Title=Magic Lantern Dual ISO"
"$$$/ML/ExportManager/MLTopic=Forums-Diskussion zu Dual-ISO (WWW, englisch)"
"$$$/ML/ExportManager/MLDocTech=Technische Dokumentation (WWW, englisch)"
"$$$/ML/ExportManager/Description=Dieses Plugin erlaubt es, eine Datei im Dual-ISO-Format mittels cr2hdr (Danke, a1ex) zu konvertieren.^n^nFunktionsweise:^n- Exportiert Bilddatei in temporären Ordner^n- Fügt Suffix -dualiso an den Dateinamen^n- Konvertiert Bild mittels cr2hdr^n- Importiert konvertiertes Bild in den LR-Katalog^n- Fügt DualISO der Beschriftung hinzu^n- Fügt das konvertierte Bild den Sammlungen hinzu, die das Original enthalten^n- Fügt Stichwort Dual-ISO der konvertierten Datei hinzu"
"$$$/ML/ExportManager/ASTitle=Erweiterte Einstellungen"
"$$$/ML/ExportManager/ASSuffix=Suffix für die konvertierte Dual-ISO-Datei:"
"$$$/ML/ExportManager/ASLabel=Definieren Sie die Beschriftung für die Dual-ISO-Datei:"
"$$$/ML/ExportManager/ASCollection=Dual-ISO-Datei den Sammlungen der Originaldatei hinzufügen?"
"$$$/ML/ExportManager/ASCollectionInfo=Haken entfernen, um die konvertierte Datei nicht den Sammlungen des Originals hinzuzufügen"
"$$$/ML/ExportManager/ASLog=Log-Datei nach der Konvertierung behalten?"
"$$$/ML/ExportManager/ASLogInfo=Haken entfernen, um Log-Datei zu löschen"
"$$$/ML/Dependencies/ErrorTitle=~ Abhängigkeitsfehler ~"
"$$$/ML/Dependencies/Error=Dieses Plugin benötigt cr2hdr, dcraw und exiftool.^n^nBitte installieren Sie diese Dateien, bevor dieses Plugin ausgeführt wird"
"$$$/ML/ExportManager/ASSubfolder=Speichern Sie die konvertierte Datei in diesen Unterordner:"
"$$$/ML/ExportManager/ASSubfolderPL=Aktueller Ordner"
"$$$/ML/ExportManager/ASSubfolderInfo=Leer lassen, um in denselben Ordner zu importieren"
"$$$/ML/ExportManager/CRTitle=Parameter für cr2hdr"
"$$$/ML/ExportManager/ASVerbose=Verbose-Modus abschalten?"
"$$$/ML/ExportManager/ASVerboseInfo=Für stillen Modus Haken setzen"
"$$$/ML/ExportManager/ASMoveToTrash=Original-Datei nach Konvertierung in Papierkorb verschieben?"
"$$$/ML/ExportManager/ASMoveToTrashInfo=Haken setzen, um Original-Datei zu löschen (Vorsicht!)"

Q:
Code: [Select]
"$$$/ML/ExportManager/ASCollection=Dual-ISO-Datei den Sammlungen der Originaldatei^n hinzufügen?"Works

Code: [Select]
"$$$/ML/ExportManager/ASCollectionInfo=Haken entfernen, um die konvertierte Datei nicht den Sammlungen^n des Originals hinzuzufügen"Won't do the trick. How to do get "Info" to use 2 lines instead of an unreadable single one?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on April 21, 2014, 01:14:18 PM
As I often have mixed non dual ISO and dual ISO pictures, it would be cool to show the error messages after converting.
Just as the original lr export does it with a dialog after exporting.

Now it pops up a modal dialog every second image as I select the whole bunch of images.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 21, 2014, 02:08:41 PM
@Walter
Yeah thanks for the translation! Ok now we have a problem with command line on windows... as usual...

@edmagiclantern @g3gg0
I've muted the message with a user option.

I thought there was a time, make a message summarizing what has worked or not. It can be a good idea!

I don't have any access to my Mac to make any change before tomorrow ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: softly.dk on April 23, 2014, 10:43:23 PM
@Walter
Yeah thanks for the translation! Ok now we have a problem with command line on windows... as usual...

There is an error in the args for cr2hdr.exe on the windows command line. Simply change line #172 in the file MLExportServiceProvider.lua
from          
local args = string.format('"%s%s%s%s%s%s%s%s%s"',  .....
to
local args = string.format('%s%s%s%s%s%s%s%s%s',  ......
to make it work on windows
//Claus
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 24, 2014, 02:45:47 PM
Thanks Claus to help me with Windows! I'll update the Beta this end of week ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 24, 2014, 08:53:27 PM
v2.2 BETA 2


You can Download 2.2 BETA 2 here (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA2.zip)

Let me know and take a beer! Cheers


I updated the code (but not the zip). I added an observer to the --fast option to disable all --no-x options when it selected ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 26, 2014, 03:04:54 PM
v2.2 BETA 3


Download 2.2 BETA 3 (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA3.zip)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: a1ex on April 26, 2014, 03:50:15 PM
--fast option disable all --no-xx on GUI

If you could let the user specify --fast --fullres (that is, turn the --no-xx into --xx on the GUI instead of disabling it), would be pretty nice (though not essential; I use these options mostly for troubleshooting). I'm not sure how you implemented it, but I'm curious - do you have some screenshots besides the one from the first post?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 27, 2014, 12:14:14 AM
Great job!

Idea: save source and processing data in image metadata. Something like
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FzSZGO5P.png&hash=e6cd1ec9c261db582071d2e2df27ab1c)

It could help batch post-processing.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on April 27, 2014, 04:08:43 AM
Idea: save source and processing data in image metadata. Something like

Love this idea.  It's something that should probably be added to cr2hdr itself.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: a1ex on April 27, 2014, 10:40:02 AM
If you explain me how to add custom name/value tags with exiftool, I can add it.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 27, 2014, 11:28:13 AM
I think it's much easier to add custom metadata to LR catalog at first, and it will suit the most one's needs.

I made a rough patch to cr2hdr plugin, just to test the concept. Added custom metadata tagset "Dual ISO", added a few tags and just parsed the output of cr2hdr.exe. And then used photo:setPropertyForPlugin (_PLUGIN, 'ISOdifference', iso_str_s).

It's possible to add user-defined tags as described here
http://perlmaven.com/adding-custom-tags-with-image-exiftool (http://perlmaven.com/adding-custom-tags-with-image-exiftool)
But I see no application for this in my LR workflow.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on April 27, 2014, 11:33:27 AM
More example code here (http://u88.n24.queensu.ca/exiftool/forum/index.php?topic=3885.0).
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 27, 2014, 01:01:30 PM
IMHO the main reason to add LR metadata is batch-processing. You choose all photos with all shadows deeper than say 90% and add one kind of NR settings. Then choose shadows from 70 to 89% and add another NR. Looking at my workflow it could be hundreds of dual ISO shots from one trip, and the metadata sorting could save hours of work.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 27, 2014, 01:47:57 PM
@a1ex I'll make some screenshot when I'll return at home.
I wrote to quickly to explain the --fast option. When you select it, all no-xx are disabled and user can enable one by one every --no-xx to reenable it and when you deselect it, all --no-xx are disabled. With the screenshots it will more simple to understand :)


@akry yeah!! Awesome! Could you please share your patch? It will be easier and faster for me!

I really like this idea and I'll add it quickly :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 27, 2014, 04:46:42 PM
@kichetof, just don't blame me for the rough code :)

https://www.dropbox.com/s/gwomgdiqzuwesqz/cr2hdr.lrplugin.akry-metadata-patches.zip (https://www.dropbox.com/s/gwomgdiqzuwesqz/cr2hdr.lrplugin.akry-metadata-patches.zip)
The patch starts with "akry metadata patch" comment in
1. Info.lua: added metadata provider and tagset
2. MLExportServiceProvider.lua: inserted metadata code in function exportServiceProvider.processRenderedPhotos

patchMetadataDefinitionFile.lua and patchMetadataTagset.lua should be copied to the plugin directory.

BTW, is it possible to add metadata in camera?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 27, 2014, 04:59:10 PM
Thanks akry! I'll reed this tonight and try to add it on the same time! Big thanks!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on April 27, 2014, 10:20:13 PM
BTW, is it possible to add metadata in camera?

https://bitbucket.org/hudson/magic-lantern/src/478b8fc3b314/modules/deflick/?at=unified

This one (https://bitbucket.org/hudson/magic-lantern/src/478b8fc3b314d0cb0d6503ddf9e8e411b2cce8fc/modules/dual_iso/exiftool-bridge.c?at=unified). if you want to add to cr2hdr.
Title: Re: Lightroom plugin cr2hdr v2.2 BETA 4
Post by: kichetof on April 28, 2014, 12:34:53 AM
v2.2 BETA 4

Download cr2hdr 2.2 BETA 4 (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA4.zip)

Thanks akry for your code, it's save to me a lot of a time!

And now the screenshots (sorry I forget to switch in english ;))


(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs18.postimg.org%2F6kb0pgg5l%2Fcr2hdr_opens_args_1.png&hash=c9d58f9102d4d63f2526ed9c8b12edf6)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fgt5dofukx%2Fcr2hdr_opens_args_2.png&hash=af3d283805b70d3cefbed744ed7d23d6)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs10.postimg.org%2Fqn6isrt8p%2Fcr2hdr_opens_args_3.png&hash=879df6d41df81fbff86afc2aa3f1c7e7)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs8.postimg.org%2Fqtmds0zw5%2Fcr2hdr_opens_args_4.png&hash=0880665f21d5526ba757b95bfb15714b)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs21.postimg.org%2Fy4w9l3dyf%2Fcr2hdr_opens_args_5.png&hash=fbb8ec4e2022ba8311f292c86b978084)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs28.postimg.org%2Fk4h4b0yel%2Fcr2hdr_opens_args_6.png&hash=9a90ba7e83652648ad6d25ddda271f9a)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs18.postimg.org%2Fvsvuj4l3d%2Fcr2hdr_finish.png&hash=c99eadedef52e27638a40a010b7a2138)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs10.postimg.org%2Fk0t1r2qbt%2Fcr2hdr_metadata.png&hash=3558fa704b9b251a0ed7e7ea9d7abc66)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on April 28, 2014, 12:36:23 AM
maybe you can put it on bitbucket so that others can contribute easier?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 28, 2014, 12:41:36 AM
it's here (https://bitbucket.org/kichetof/lr_cr2hdr/commits/203476168cbab484aec0e8e15331f5b8d480b5a6) for the last commit and the source (https://bitbucket.org/kichetof/lr_cr2hdr/src) is here :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on April 28, 2014, 12:45:37 AM
oh ok didnt notice, thanks :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 28, 2014, 12:51:10 AM
no problem ! Feel free to pull request :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: chmee on April 28, 2014, 01:32:57 AM
@kichetof [2.1 with 5DIII and LR 5.3]
marvelous work. i just did my first dualISOs, and i'm damn proud of you, makin this files so easy to handle. one click, done. where's the donate button?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 28, 2014, 11:35:13 AM
@kichetof Glad it helps!

I've made two more minor additions. First, the color label. 'DualIso' or any custom color name won't work — only standard 'red', 'yellow' etc. So no point in text field, I've changed it to popup.

Code: [Select]
f:edit_field {
  value = bind 'label',
  width = 100,
},

replaced with
Code: [Select]
f:popup_menu {
title = LOC "$$$/ML/ExportManager/ASLabel=Color label for Dual ISO file :",
items = {
  { title = "none", value = '' },
          { title = "Red", value = 'red' },
          { title = "Yellow", value = 'yellow' },
          { title = "Green", value = 'green' },
          { title = "Blue", value = 'blue' },
          { title = "Purple", value = 'purple' },
},
value = LrView.bind( "label" ),
size = 'small'
},
Of course we have to change { key = 'label', default = "DualISO" } to { key = 'label', default = "" } upstream.


Second thing, I got complains about the final summary dialog. Dunno why but I thought this problem is easy to solve: just added checkbox «Show summary after conversion» (with a proper bind value) and enclosed summary dialog in "if exportSettings.showSummary then LrDialogs.presentModalDialog…"
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 28, 2014, 12:48:04 PM
@chmee glad to help you! Drink a beer for me :)


Yes good point for final dialog!

But for the label I don't understand why it doesn't work for you! I set the label but not the label color. Is it the same? see my next post

Could you send pull request from bitbucket? It's more easy to add quickly! :)

Big thanks for your feedback and your great help!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on April 28, 2014, 12:56:49 PM
No LR at hand, damned!
Not sure who is confusing things here. Propably me, because I do not know how to do lua.

ASlabel in 2.2 Beta will be shown as a text field below pic's left corner in grid view mode (if enabled to be shown. Default is "not"). "DualISO" or other strings will work just fine here.
This "label" doesn't have to be confused with "Colour Label" ...

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 28, 2014, 02:06:33 PM
from LR API References

label: (string) The name of assigned color label.

don't blame me! 8)

I'll change "my label: DualISO" from label to caption or headline or maybe another when I go home and have LR on my hand ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 28, 2014, 05:57:07 PM
@kichetof I don't! LR API is kinda esoteric. :)
BTW I can't find a way to save previous settings so Magic Lantern:cr2hdr is always using defaults. However «Export with Previous» works.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 28, 2014, 06:46:52 PM
I updated the code and replaced label with caption and you can mute the summary alert.

Effectively, if you don't open the Export Manager Windows (cmd + maj + e) default settings are applied.

exportServiceProvider.sectionsForTopOfDialog( f, propertyTable )
(optional) This plug-in defined callback function is called when the user chooses this export service provider in the Export or Publish dialog.

To update with right click : Export to cr2hdr; maybe this function should be used:

exportServiceProvider.updateExportSettings( exportSettings )
(optional) This plug-in defined callback function is called at the beginning of each export and publish session before the rendition objects are generated. It provides an opportunity for your plug-in to modify the export settings.

Yes this function is called when you bypass export windows ;) so we can add some useful info!
This function is added to the source! You can play with it :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 29, 2014, 12:33:06 AM
Big cleanup !

I've split the plugin on 3 files : Primary file (MLExportServiceProvider.lua) and 2 secondary files (MLDialogs.lua, MLProcess.lua)

And I started to customizing the plugin manager ! A lot of work in perspective :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 29, 2014, 09:50:43 PM
@kichetof, refactoring in progress :)

Three issues so far.
1. I think it is a good idea to leave a color label, not caption (or maybe keep both) — I like visual when working with grid. I suggest a) assign color label; b) add keyword (not caption, coz it bad for shots management workflow).
2. MLProcess[55]: local gt = WIN_ENV and " ^> " or " > " — not working unless I change " ^>" to " >" (I use Windows 7).
3. Still can't save new settings in Export dialog, no "Update with new settings" menu item.

Title: Re: Lightroom plugin cr2hdr
Post by: kichetof on April 29, 2014, 10:49:27 PM
Okay I'll add the label color ;)

What do you suggest to replace caption?

I've no idea for windows command, I'm running on Mac and I hate cmd.exe! ;)

Code: [Select]
command = string.format('"start /D "%s\\bin" /B /WAIT /BELOWNORMAL cr2hdr.exe "%s" ^> "%s""', pluginPath, filePath, output)

I haven't add the keep setting but found a way for maybe keep. We need to try but  I always use export manager windows ;)

I'll check tomorrow to add color label and I need some feedback for the windows command ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on April 30, 2014, 01:57:22 PM
@kichetof, I've made few patches.

1. MLDialog.lua. Added code for keywords and color labels in MLDialogs.settings()
2. MLExportServiceProvider.lua. Added "keywords" to exportServiceProvider.exportPresetFields
3. MLProcess.lua. New function MLProcess.split() and new code in MLProcess.process()
4. MLProcess.lua. I think local gt = WIN_ENV and " > " or " > " is unneeded — local gt = " > " is enough. It works on my PC.

https://www.dropbox.com/s/wuxu5hziifzcnq7/20140430-2-cr2hdr.lrplugin-akry-patches.zip (https://www.dropbox.com/s/wuxu5hziifzcnq7/20140430-2-cr2hdr.lrplugin-akry-patches.zip)

Seemed, cr2hdr already adds "Dual-ISO" keyword by itself.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 30, 2014, 04:11:08 PM
@akry ! Yeah good patches!

I'll add it tonight!

I don't know for local gt because I never add problem with > or ^> but I never really used this plugin on windows
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on April 30, 2014, 10:04:55 PM
The color label is user dependent.

In my case, I set red color to "Reject" and in the MLDialog is set to "red" so, no color! But if I set Red to "Reject" it works fine!

I added your patches and custom label color with user defines. Unless that, it doesn't work if it not the same name ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 01, 2014, 09:11:05 PM
Known issue with color label.. If you change from menu the title of the label and you run the plugin, the name inside the plugin is the old name. You need to close and re open the plugin to get it the new.

I made some test and I can't found a way to bind title.

Actually this is the code to fill popup_menu items

but I think we have no problem if you can make something like that but it doesn't works

If you have some useful information, please help me :)

I think that the problem come with the async task to get the color name.

Ok I know, it comes from the async function, I've tested some things and I found that the async function return the value after exportServiceProvider.sectionsForTopOfDialog, so it's normal that the value is the old. We need to find an "update" method to refresh values


Solved! Thanks Rob from adobe!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: nikasio14 on May 02, 2014, 08:38:33 PM
Hey There!

First of all, big Hand to kiteof producing this marvelous piece of plugin-code :D
I am new to ML anyway and was unsure to use it in daily photography; since most of these interesting features required me a lot of learning-how-to and post-processing; whereas i allways want to get best results out of my camera straight away.
I tumbled over the Dual-Iso-Function, since this is a great Idea never the less allows me to take an HDR even in High-Speed-movements with an incredible quality.
Since i found this Lightroom-Plugin (v.2.1 installed) i am going to use Dual-ISO more often! It works like a charm, just by x-ing out original Cr2's, then export to DNG and afterwards erasing Cr2s. It has made dealing with Dual-Iso even more simple then producing multiple image-hdr (where you have alignment probs and so on.)

Long story short, i am deeply impressed! Therefor i want to contribute your plugin and bring the german language-files to a grammatically correct version. (me<=native) Will i need to upload the german strings-file?

Yours, Niklas
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 02, 2014, 08:52:29 PM
Download latest beta from https://bitbucket.org/kichetof/lr_cr2hdr/downloads and extract TranslatedStrings_de.txt and try your best. I expect Beta 5 to arrive this weekend.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 12:16:49 AM
Hi nikasio14! Thanks for your feedback and for your help.

As Walter said, a new beta will come soon :)

When it will available, you can play with the source code and change value into TranslatedStrings_de.txt and you can directly send a pull request (clone the project, navigate into your fork source, directly edit from your browser or use TortoiseHG to synchronize to your computer, and send a pull request into mine)

helpful informations: Submitting a pull request all via web browser (http://www.magiclantern.fm/forum/index.php?topic=7940.0), Creating Pull Request (http://www.magiclantern.fm/forum/index.php?topic=10774.msg104838#msg104838)

Stay tuned!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 01:02:44 AM
V2.2 BETA 5 and I hope the last beta :)

What's new:

Windows users please test, test & test again! I removed an escaped character but I've no windows on the hand to test ;)

People who speak: german or portuguese please send me the correct translation for the plugin! I will be very grateful!

Download cr2hdr 2.2 BETA 5 (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA5.zip)

Please feedbacks!

Enjoy!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 01:25:02 AM
I suppose color labeling is responsible for this warning:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs21.postimg.org%2Fyd0awnnub%2FBild_5.jpg&hash=af200f25fcab165654b7839913366e49) (http://postimg.org/image/yd0awnnub/)
(Rough Translation:
Confirm
Your catalog must be updated before it can be used with the following plug-in:
Dual ISO converter
Update Catalog; Disable This Plug-In)

I'm not happy about this.
Is it really necessary to change LR's database schema? Is there a way to make this one optional? What happens if Adobe changes the schema? Will there be data loss?

Will test it after I created a new catalog to play with.

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on May 03, 2014, 10:09:26 AM
this is quite normal when installing a plugin.
i guess you have enough backups :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 10:44:24 AM
Du kennst den Spruch "Im Haus des Fischers wird kein Fisch gegessen"?

Ciao
Walter (Sysadmin)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on May 03, 2014, 11:00:09 AM
@Walter Schulz, it's absolutely normal. Any plugin using custom metadata will issue this warning, it's a part of legal LR behavior. All changes are made via LR API and no harm to catalog is possible. The warning actually means than you will need this plugin to view the Dual ISO metadata.

If Adobe will change schema (which it probably already did few times) all custom metadata will be preserved. There are many plugins using custom metadata. My «Camera Temperature», lots of Jeffrey Friedl's great plugins such as «jf Facebook», «jf Megapixel Sort», John's «Big Note».
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 11:02:58 AM
Thanks akry for you reply! :)



Walter it's normal :)

Akry has added a metadata preset on beta 4 and LR need to be updated to add it on the metadata choice ;)

Unfortunately I can't disable it, it's write on the plugin and I can't tell LR: by pass it ;)

Make a backup of your catalog :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 11:16:21 AM
Okay, paranoia mode is idle now.
Made a test bed catalog just for fun ... <g>
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on May 03, 2014, 11:38:52 AM
Du kennst den Spruch "Im Haus des Fischers wird kein Fisch gegessen"?

Ciao
Walter (Sysadmin)

<ot>
its the same as i know it about car mechanics and the overall condition of their cars... ;)
after realizing that i have 35k (>1TiB) of images (and some videos) i tend to backup those even though having raid 1.
</ot>
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 11:51:33 AM
Paranoia too!
I made a backup every time I run LR :) I've a lot a Gb of my LR catalog backup :D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 11:56:38 AM
Here is an old dog trying to learn a new trick: Dived into Bitbucket and created my first pull request.
Did I have followed the procedure correctly or messed up?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 12:20:01 PM
@Walter yeah it's right! :) it's already merged!

I was in the same situation as you when I started there a few months ago
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 03, 2014, 02:54:29 PM
Hi kitchehof! Awesome progress.
Tried to incorporate a swedish translation string but It seems I only get halfway right. Some  strings aren,t following to swedish. Tried finding the answer looking in the german and french translations but It seems I did practically the same but in swedish?
Any hints on this one?
I,m on lightroom 4.4 on mac osX mavericks
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs13.postimg.org%2Fakqum9chf%2FSka_rmavbild_2014_05_03_kl_14_47_00.png&hash=af376be69e55709018c3c0f37fcb96b4) (http://postimg.org/image/akqum9chf/)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs13.postimg.org%2Fue2yeypv7%2FSka_rmavbild_2014_05_03_kl_14_47_43.png&hash=d424d299e70a8cd73cfaf83a3845d8b6) (http://postimg.org/image/ue2yeypv7/)

"$$$/ML/ExportDialog/ExportMenu/Title=Magic Lantern"


"$$$/ML/Dependencies/ErrorTitle=~ Dependencies error ~"
"$$$/ML/Dpendencies/Error=Denna plugin (cr2hdr) kräver dcraw och exiftool.^n^nVänligen installera dessa innan installation av denna plugin"


"$$$/ML/Import/Error=Import av dual iso fil ej möjlig!^n^nVänligen synkronisera din mapp manuellt"


"$$$/ML/ExportManager/Title=Magic Lantern Dual ISO"
"$$$/ML/ExportManager/MLTopic=Magic Lantern Dual ISO forumdiskussion”
"$$$/ML/ExportManager/MLDocTech=Teknisk dokumentation”
"$$$/ML/ExportManager/Description=Denna plugin konverterar en DUAL ISO bild med cr2hdr (tack A1ex) från Magic Lantern.^n^nFunktionsbeskrivning :^n^n- Export av bild till temporär mapp^n- Adderar -dualiso suffix till bild^n- Konverterar bild med cr2hdr^n- Importerar konverterad bild till denna LR Katalog^n- Adderar DualISO till beskrivningen^n- Adderar konverterad bild till mappen med din originalbild”
"$$$/ML/ExportManager/ASTitle=Avancerade inställningar”
"$$$/ML/ExportManager/ASSuffix=Suffix för konverterad dual iso fil :"
"$$$/ML/ExportManager/ASLabel=Definiera färgetikett till Dual ISO fil :"
"$$$/ML/ExportManager/ASCollection=Addera Dual ISO fil till bildsamling ?"
"$$$/ML/ExportManager/ASCollectionInfo=Avmarkera för att ej addera till originalbilderna"
"$$$/ML/ExportManager/ASLog=Behåll loggfil efter konvertering?"
"$$$/ML/ExportManager/ASLogInfo=Avmarkera för att radera loggfil”
"$$$/ML/ExportManager/ASSubfolder=Addera konverterad fil till följande undermapp:"
"$$$/ML/ExportManager/ASSubfolderPL=Aktuell mapp”
"$$$/ML/ExportManager/ASSubfolderInfo=lämna blankt för återimport till samma mapp”
"$$$/ML/ExportManager/Keywords=Addera nyckelord :"
"$$$/ML/ExportManager/KeywordsInfo=comma-separated"
"$$$/ML/ExportManager/ASLabelInfo=Lämna tomt utan färgetikett”
"$$$/ML/ExportManager/ASSummary=Visa summering efter konvertering ?"
"$$$/ML/ExportManager/ASSummaryInfo=Avmarkera för att ta bort”
"$$$/ML/ExportManager/CRTitle=cr2hdr optional arguments"


"$$$/ML/Publish/Progress=Exporting ^1 foto till cr2hdr"
"$$$/ML/Publish/Progress/One=Exporterar ett foto till cr2hdr"
"$$$/ML/Publish/Error=Export ej möjlig ^1 till cr2hdr! Error #^2"
"$$$/ML/Publish/AlreadyConvertTitle=Redan behandlad”
"$$$/ML/Publish/Error/NotRaw=Endast RAW (CR2 & DNG) foto är tillåten att export till cr2hdr"
"$$$/ML/Publish/Finish=cr2hdr export färdig”
"$$$/ML/Publish/NoPhotoExported=Inget foto har exporterats”
"$$$/ML/Publish/NbPhotoExported=^1 foto har exporterats korrekt”
"$$$/ML/Publish/NbPhotosExported=^1 photo har exporterats korrekt”
"$$$/ML/Publish/Finish/NoImage=Ingen bild”
"$$$/ML/Publish/Finish/AlreadyConvertTitle=Redan behandlad^1"
"$$$/ML/Publish/Finish/NotRawTitle=Fel format^1"
"$$$/ML/Publish/Finish/NoError=Inget fel"
"$$$/ML/Publish/Finish/Success=Konverterad^1"
"$$$/ML/Publish/Finish/noDual=Ej DualISO^1"
"$$$/ML/Publish/Finish/Error=Fel^1"
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 03:30:01 PM
Well, kichehof gave his best but german and english doesn't look that well right now (he will be the first to agree with this, I suppose).
I'm working over german text right now but I think we will need some iterations to find a proper GUI style. My command of french language is non existent. Not that easy to solve this puzzle.
Bit of stuck with the "cr2hdr export finished" box translation. Will work it over soon.

Code: [Select]
"$$$/ML/Dependencies/ErrorTitle=~ Abhängigkeitsfehler ~"
"$$$/ML/Dependencies/Error=Dieses Zusatzmodul benötigt cr2hdr, dcraw und exiftool.^n^nBitte installieren Sie diese Dateien, bevor dieses Zusatzmodul ausgeführt wird"

"$$$/ML/ExportDialog/ExportMenu/Title=Magic Lantern"


"$$$/ML/ExportManager/Title=Magic Lantern Dual ISO"
"$$$/ML/ExportManager/MLTopic=Forums-Diskussion zu Dual-ISO (WWW, englisch)"
"$$$/ML/ExportManager/MLDocTech=Technische Dokumentation zu Dual-ISO(WWW, englisch)"
"$$$/ML/ExportManager/Description=Dieses Plugin erlaubt es, eine Datei im Dual-ISO-Format mittels cr2hdr (Danke, a1ex) zu konvertieren.^n^nFunktionsweise:^n- Exportiert Bilddatei in temporären Ordner^n- Fügt Suffix -dualiso an den Dateinamen^n- Konvertiert Bild mittels cr2hdr^n- Importiert konvertiertes Bild in den LR-Katalog^n- Fügt DualISO der Beschriftung hinzu^n- Fügt das konvertierte Bild den Sammlungen hinzu, die das Original enthalten^n- Fügt Stichwort Dual-ISO der konvertierten Datei hinzu"
"$$$/ML/ExportManager/ASTitle=Erweiterte Einstellungen"
"$$$/ML/ExportManager/ASSuffix=Suffix für die konvertierte Dual-ISO-Datei:"
"$$$/ML/ExportManager/ASLabel=Definieren Sie die Beschriftung für die Dual-ISO-Datei:"
"$$$/ML/ExportManager/ASCollection=Dual-ISO-Datei den Sammlungen der Originaldatei hinzufügen?"
"$$$/ML/ExportManager/ASCollectionInfo=Haken entfernen, um die konvertierte Datei nicht den Sammlungen des Originals hinzuzufügen"
"$$$/ML/ExportManager/ASLog=Log-Datei nach der Konvertierung behalten?"
"$$$/ML/ExportManager/ASLogInfo=Haken entfernen, um Log-Datei zu löschen"
"$$$/ML/ExportManager/ASSubfolder=Speichern Sie die konvertierte Datei in diesen Unterordner:"
"$$$/ML/ExportManager/ASSubfolderPL=Aktueller Ordner"
"$$$/ML/ExportManager/ASSubfolderInfo=Leer lassen, um in Quellordner zu importieren"
"$$$/ML/ExportManager/Keywords=Add keywords:"
"$$$/ML/ExportManager/KeywordsInfo=comma-separated"
"$$$/ML/ExportManager/ASLabelInfo=Leave blank to not add color label"
"$$$/ML/ExportManager/ASSummary=Show summary message after conversion?"
"$$$/ML/ExportManager/ASSummaryInfo=Uncheck to hide"
"$$$/ML/ExportManager/CRTitle=Parameter für cr2hdr"


"$$$/ML/Import/Error=Kann die Dual-ISO-Datei nicht importieren!^n^nBitte Ordner händisch synchronisieren"

"$$$/ML/InfoProvider/Bitbucket=Bitbucket-Projektseite zum Zusatzmodul (WWW, englisch)"


"$$$/ML/Publish/Progress=Exportiere ^1 Bilder mit cr2hdr"
"$$$/ML/Publish/Progress/One=Exportiere ein Bild mit cr2hdr"
"$$$/ML/Publish/Error=Fehler beim Exportieren von ^1 mit cr2hdr! Fehler #^2"
"$$$/ML/Publish/AlreadyConvertTitle=Fehler beim Konvertieren"
"$$$/ML/Publish/Error/NotRaw=Es können nur RAW-Fotos (CR2 & DNG) mit cr2hdr exportiert werden"
"$$$/ML/Publish/Finish=cr2hdr-Export beendet"
"$$$/ML/Publish/NoPhotoExported=Kein Foto wurde exportiert"
"$$$/ML/Publish/NbPhotoExported=^1 Foto wurde erfolgreich exportiert"
"$$$/ML/Publish/NbPhotosExported=^1 Fotos wurden erfolgreich exportiert"
"$$$/ML/Publish/Finish/NoImage=Keine Bilddatei"
"$$$/ML/Publish/Finish/AlreadyConvertTitle=Bereits bearbeitet^1"
"$$$/ML/Publish/Finish/NotRawTitle=Falsches Format^1"
"$$$/ML/Publish/Finish/NoError=Fehlerfrei"
"$$$/ML/Publish/Finish/Success=Konvertiert^1"
"$$$/ML/Publish/Finish/noDual=Kein DualISO^1"
"$$$/ML/Publish/Finish/Error=Fehler^1"
Again: Most strings in $$$/ML/Publish/Finish above are just placeholders right now.

Ciao
Walter

PS: Please no more blanks between last letter and colons, periods etc. ;-)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 04:14:49 PM
Hi Danne thanks for your works!

I think I found the problem, sometimes you have at the end of the line ” instead of " (check your text editor)

I added your translation to the source, try with this file swedish translation (https://bitbucket.org/kichetof/lr_cr2hdr/src/1bc84f5e97ef3fba7e7e49adf05d7a0c69cf954f/TranslatedStrings_sv.txt?at=default)

@Walter yes I make a rough translation (french include). I'm better in programation than in language  8)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 05:25:31 PM
@All

What do you think if I remove that ?
And add a new section at the bottom with some help/info?
Quote
This plugin allows to convert a Dual ISO picture with cr2hdr (thanks a1ex) from Magic Lantern.

How it works :

- Export picture to temp folder
- Add -dualiso suffix to picture
- Convert picture with cr2hdr
- Import converted picture into this LR Catalog
- Add DualISO to the label
- Add converted picture to the collections of the original picture

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs27.postimg.org%2Fj8b9c24ir%2Fcr2hdr_without_description.png&hash=3c013fcc7d0d36b2d578dadd31ce0e76)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 06:08:52 PM
Less work for translators traded in for a small loss for users (less info).
Let's keep it as simple as possible. You have my vote.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 03, 2014, 08:10:18 PM
You have my vote for a help section replacing what you brought up. Thanks a lot for the swedish translation correction.

Of course I saw two things from my translation that could be changed. Maybe you put it in your provided link? Thanks

line 29 is        "$$$/ML/ExportManager/KeywordsInfo=comma-separated"
should be       "$$$/ML/ExportManager/KeywordsInfo=kommaseparerad"

line 44 is        "$$$/ML/Publish/NbPhotosExported=^1 photo har exporterats korrekt"
should be       "$$$/ML/Publish/NbPhotosExported=^1 foto har exporterats korrekt"


Thanks again for this plugin, really good
/D

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 10:08:53 PM
@Walter & Danne

Ok I note your votes, IMO we could write a text file (more flexible, no sequence like ^r^n) with basic informations in english and read this file into the bottom section.

What do you think ?


No I've a best idea! We can make an illustration with pictures :)

Swedish (https://bitbucket.org/kichetof/lr_cr2hdr/src/299ddc936e095d75e821431709809b3c0e8ca76b/TranslatedStrings_sv.txt?at=default) updated! ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 03, 2014, 10:26:11 PM
Swedish, thanks!
Yea, pictures, what are you thinking?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 10:32:16 PM
Something likes that

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fwww.mindtools.com%2Fmedia%2FDiagrams%2FCommunicationsProcess.jpg&hash=57aec6d9120b85f13ea70bd3da57906f)

But with illustration like cr2 banding (dual iso preview), cr2hdr terminal icon, LR metadata etc
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 03, 2014, 10:46:21 PM
looks nice, although I don,t see the deeper picture yet. I,m sure you,re on to something though :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 11:10:39 PM
Q about GUI consistency
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs27.postimg.org%2Ftbqgvyr1b%2FBild_4.jpg&hash=3651dbb2b641ac571f34d505a2d218eb) (http://postimg.org/image/tbqgvyr1b/)
1. Most plug-ins don't have a dedicated header section (upper frame to the right) in Plug-In Manager interface. Seems like Jeffrey Friedl is using this a lot: feedback options, log transfer, info buttons (frankly: GUI design not always convincing). Potential there, I think.
2. Title (left window) and section headers doesn't match. Is the license info about cr2hdr, plug-in or both?

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 11:17:25 PM
I prefer have a header for the plugin, when you selected it, you know directly what is it.

Effectively it's not the same name, I'll change it to match :) and yes it's the license info about the plugin not cr2hdr (it's my mistake)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 03, 2014, 11:26:28 PM
I,m sure you,re on to something though :)

If killing the export finish message box is his agenda I will cover his back.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 03, 2014, 11:50:44 PM
If it looks not good and/or not nice, I'll not add it in the release ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 04, 2014, 12:55:55 AM
Problem with keywords?
Entry in Plug-In Manager:
Code: [Select]
Dual ISO, cr2hdrEntry for converted DNG:
Code: [Select]
cr2hdr, Dual ISO, Dual-ISO
Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 01:33:22 AM
No problem :)

Try to convert without added a keyword and check after conversion. Dual ISO or Dual-ISO I don't remember is added with cr2hdr.

I only added some useful placeholder, but maybe I doesn't wrote the bests
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 02:08:47 AM
What do you think ?

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs28.postimg.org%2F3zl216i7h%2Fcr2hdr_illustration.gif&hash=4eca64689dee2dcbccc081ba77c8c752)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: newsky13 on May 04, 2014, 07:26:09 AM
The plugin is just perfect! Thank you so much! But can do so that would be custom keywords exported to the DNG? Thank you.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 04, 2014, 08:10:06 AM
True. Custom keywords will be added if a second export takes place. Dual-ISO will show up, though. Is there a parameter for cr2hdr?
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs14.postimg.org%2Fiqza152bx%2FBild_9.jpg&hash=7150c89324c351fd614ac65975e0cb7e) (http://postimg.org/image/iqza152bx/)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on May 04, 2014, 08:23:56 AM
Is there a parameter for cr2hdr?

To add keywords to the output of cr2hdr?

Only in the source (https://bitbucket.org/hudson/magic-lantern/src/e5939c727eb4fb759df433244bb4e675503a98ba/modules/dual_iso/exiftool-bridge.c?at=unified).
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 04, 2014, 08:44:27 AM
Thanks!
Because this is hardcoded I suggest to change GUI a little bit:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs28.postimg.org%2Fyhutfixvt%2FBild_11.jpg&hash=7d4dce720acc94f2c7944dca858d9c39) (http://postimg.org/image/yhutfixvt/)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 11:00:19 AM
I like it! I'll add it ;)

@Walter
I'll merge your pull request (thanks!) but you don't have to clone for every pull request. Clone my project like Walter/lr_cr2hdr_edit or what you want and simply push commit from my repo to keep yours up to day. I'll found a capture when I've my Mac on my hand ;)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2Frvtfc3zp3%2Fbitbucket_sync.png&hash=b3dde494b628fe99f5bba888de6ece4c)
Directly from Overview page

What do you think about illustration?
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2F3u7u2liu9%2Fcr2hdr_illustr_2.png&hash=3634e6c699176e7f90069859cd1f7826)

or without background

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs16.postimg.org%2Fv13kbhbxx%2Fcr2hdr_illustr_2_clear.png&hash=4f43005f094fa03b2049340047fe3d80)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on May 04, 2014, 01:02:30 PM
is it really IMG-0069-dualiso.CR2 ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 01:48:53 PM
Good observation g3gg0!

I edited my previous post and added without background ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 04, 2014, 01:51:46 PM
Hi All,

I've just tried out the lightroom plugin for mac, it's got some serious speed compared to the old GUI. I'm wondering whether it is running the latest 20 bit version of cr2hdr.

The reason I ask is because compared to the v2 GUI which was released on 2013-12-02 there have been some staggering images posted up by A1ex regarding improvements in aliasing and moire. this post in particular caught my eye http://www.magiclantern.fm/forum/index.php?topic=7139.1925.

I have conducted a test of my own using an old mac version of cr2hdr and your latest lightroom plugin. Both images seem pretty much identical as far as aliasing and overall usability in the real world is concerned.

Here are both images with a 400% crop on the most offending areas.
https://www.dropbox.com/s/2gt40u0k80nx459/crop1.jpg (https://www.dropbox.com/s/2gt40u0k80nx459/crop1.jpg)
https://www.dropbox.com/s/1ffm3oakgrfwwbv/crop2.jpg (https://www.dropbox.com/s/1ffm3oakgrfwwbv/crop2.jpg)

So just a bit of clarification really on whether the lightroom plugin is running the latest version of cr2hdr and if it isn't is there a way to update the plugin? Just in case you think this has been covered I have been keeping a close eye on these forums for the past few months and it was A1ex's quite remarkable images that prompted me to engage. But so far I have not managed to find a way to re-create his results on my video stills.

Any suggestions or help would be greatly appreciated.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 02:47:07 PM
I focused on the module with stable version and add arguments.

Once this version will lose its beta status, I'll plan to add an experimental cr2hdr-20bit but it's always in development so I don't want to spend a lot of time if there are a lot of changes when it will be available.

Feel free to clone the plugin, add a new branch and pull request and I'll add it :)

(I encountered some difficult to compile cr2hdr since Xcode 5.1 has been released: -Wno-error=unused-command-line-argument-hard-error-in-future)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 04, 2014, 03:12:36 PM
Thank you for getting back to me so quickly. That seems like a very sensible way to work, otherwise you'd be fighting an uphill battle.
Also i'm quite relieved that it is the stable build and my eyes haven't packed in yet ;)

Thank you that's very generous, something that incorporates some of the current breakthroughs would be very beneficial to filmmakers. We'll certainly start seeing a lot more video clips that sell the great work you guys are doing.

Do cloning and pull requesting happen on bitbucket? I'm very new so pardon my ignorance but if you have a link then i'll follow it and do some learning



Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 04:36:25 PM
@joshuamk see links in this post (http://www.magiclantern.fm/forum/index.php?topic=11056.msg113780#msg113780)

Okay I confirm I've some trouble to compile cr2hdr-20bit!

Code: [Select]
$ make cr2hdr
REBUILDING
[ README   ]   module_strings.h
[ gcc      ]   cr2hdr
clang: error: unknown argument: '-mno-ms-bitfields' [-Wunused-command-line-argument-hard-error-in-future]
clang: note: this will be a hard error (cannot be downgraded to a warning) in the future
make: *** [cr2hdr] Error 1

And after removing -mno-ms-bitfields from Makefile.cr2hdr:

Code: [Select]
$ make cr2hdr
[ gcc      ]   cr2hdr
cr2hdr.c:1218:46: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist rggb.m"));
                                             ^
cr2hdr.c:1218:46: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:1351:46: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist bddb.m"));
                                             ^
cr2hdr.c:1351:46: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:1468:5: error: function definition is not allowed here
    {
    ^
cr2hdr.c:1510:24: error: use of undeclared identifier 'gain'; did you mean
      'main'?
    double a = 100.0 / gain;
                       ^~~~
                       main
cr2hdr.c:555:5: note: 'main' declared here
int main(int argc, char** argv)
    ^
cr2hdr.c:1510:22: error: invalid operands to binary expression ('double' and
      'int (*)(int, char **)')
    double a = 100.0 / gain;
               ~~~~~ ^ ~~~~
cr2hdr.c:1531:39: error: use of undeclared identifier 'gain'; did you mean
      'main'?
                int delta = b * 100 / gain - d;
                                      ^~~~
                                      main
cr2hdr.c:555:5: note: 'main' declared here
int main(int argc, char** argv)
    ^
cr2hdr.c:1531:37: error: invalid operands to binary expression ('int' and
      'int (*)(int, char **)')
                int delta = b * 100 / gain - d;
                            ~~~~~~~ ^ ~~~~
cr2hdr.c:1542:51: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist iso-curve.m"));
                                                  ^
cr2hdr.c:1542:51: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:1964:55: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist fullres-curve.m"));
                                                      ^
cr2hdr.c:1964:55: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:2295:56: warning: if statement has empty body [-Wempty-body]
            if(system("dcraw -d -r 1 1 1 1 edges.dng"));
                                                       ^
cr2hdr.c:2295:56: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:2308:59: warning: if statement has empty body [-Wempty-body]
            if(system("dcraw -d -r 1 1 1 1 edge-map.dng"));
                                                          ^
cr2hdr.c:2308:59: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:2334:21: error: function definition is not allowed here
                    {
                    ^
cr2hdr.c:2352:53: error: use of undeclared identifier 'pi0'
                    interp[x   + y * w] = ev2raw[(2*pi0+pip+pim)/4];
                                                    ^
cr2hdr.c:2594:51: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist mix-curve.m"));
                                                  ^
cr2hdr.c:2594:51: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:3070:55: warning: if statement has empty body [-Wempty-body]
            if(system("octave --persist soft-film.m"));
                                                      ^
cr2hdr.c:3070:55: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:3370:34: warning: if statement has empty body [-Wempty-body]
        if(system("octave wb.m"));
                                 ^
cr2hdr.c:3370:34: note: put the semicolon on a separate line to silence this
      warning
9 warnings and 7 errors generated.
make: *** [cr2hdr] Error 1
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on May 04, 2014, 05:33:33 PM
your compiler seems a bit picky.
okay local function definitions are evil, but still its valid C :)

try to install gcc.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 06:25:07 PM
It's gcc from Xcode and since version 5.1 it's soooo restrictive!

Code: [Select]
gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
Target: x86_64-apple-darwin13.1.0
Thread model: posix

I'll search if I can use an another version

I'll remove Xcode 5.1.1 and reinstall Xcode 5.0.2 I hope its solve this problem
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 07:19:59 PM
the error is still present with xcode 5.0.2 :(

Code: [Select]
gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
Target: x86_64-apple-darwin13.1.0
Thread model: posix

Code: [Select]
make cr2hdr
REBUILDING
[ README   ]   module_strings.h
[ gcc      ]   cr2hdr
cr2hdr.c:1218:46: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist rggb.m"));
                                             ^
cr2hdr.c:1218:46: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:1351:46: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist bddb.m"));
                                             ^
cr2hdr.c:1351:46: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:1467:29: error: expected ';' at end of declaration
    int match_test(int gain)
                            ^
                            ;
cr2hdr.c:1510:24: error: use of undeclared identifier 'gain'; did you mean
      'main'?
    double a = 100.0 / gain;
                       ^~~~
                       main
cr2hdr.c:555:5: note: 'main' declared here
int main(int argc, char** argv)
    ^
cr2hdr.c:1510:22: error: invalid operands to binary expression ('double' and
      'int (*)(int, char **)')
    double a = 100.0 / gain;
               ~~~~~ ^ ~~~~
cr2hdr.c:1531:39: error: use of undeclared identifier 'gain'; did you mean
      'main'?
                int delta = b * 100 / gain - d;
                                      ^~~~
                                      main
cr2hdr.c:555:5: note: 'main' declared here
int main(int argc, char** argv)
    ^
cr2hdr.c:1531:37: error: invalid operands to binary expression ('int' and
      'int (*)(int, char **)')
                int delta = b * 100 / gain - d;
                            ~~~~~~~ ^ ~~~~
cr2hdr.c:1542:51: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist iso-curve.m"));
                                                  ^
cr2hdr.c:1542:51: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:1964:55: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist fullres-curve.m"));
                                                      ^
cr2hdr.c:1964:55: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:2295:56: warning: if statement has empty body [-Wempty-body]
            if(system("dcraw -d -r 1 1 1 1 edges.dng"));
                                                       ^
cr2hdr.c:2295:56: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:2308:59: warning: if statement has empty body [-Wempty-body]
            if(system("dcraw -d -r 1 1 1 1 edge-map.dng"));
                                                          ^
cr2hdr.c:2308:59: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:2333:45: error: expected ';' at end of declaration
                    int edge_interp(int dir)
                                            ^
                                            ;
cr2hdr.c:2352:53: error: use of undeclared identifier 'pi0'
                    interp[x   + y * w] = ev2raw[(2*pi0+pip+pim)/4];
                                                    ^
cr2hdr.c:2594:51: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist mix-curve.m"));
                                                  ^
cr2hdr.c:2594:51: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:3070:55: warning: if statement has empty body [-Wempty-body]
            if(system("octave --persist soft-film.m"));
                                                      ^
cr2hdr.c:3070:55: note: put the semicolon on a separate line to silence this
      warning
cr2hdr.c:3370:34: warning: if statement has empty body [-Wempty-body]
        if(system("octave wb.m"));
                                 ^
cr2hdr.c:3370:34: note: put the semicolon on a separate line to silence this
      warning
9 warnings and 7 errors generated.
make: *** [cr2hdr] Error 1
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: a1ex on May 04, 2014, 09:57:34 PM
clang does not support nested functions, so the only option is to refactor the code with a regular function (shouldn't be very hard).
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 11:04:56 PM
oh thanks a1ex for your reply! I do not understand why it did not worked! Thanks for explanation!

But .. I don't know how to make changes  :o I hope you can make something


New visual!
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs21.postimg.org%2Frdrrdyix3%2Fcr2hdr_new_visual.png&hash=6ee178a5bc2d4e6312c72462460c4612)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on May 04, 2014, 11:38:58 PM
"Apple LLVM version 5.0 (clang-500.2.79)" != gcc :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 04, 2014, 11:53:45 PM
Okay I learned something! I believed with gcc -v that I had gcc ... apple apple apple.... :)

Code: [Select]
$ brew install gcc49
I'll try tomorrow!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 05, 2014, 12:27:18 AM
oh thanks a1ex for your reply! I do not understand why it did not worked! Thanks for explanation!

But .. I don't know how to make changes  :o I hope you can make something


New visual!
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs21.postimg.org%2Frdrrdyix3%2Fcr2hdr_new_visual.png&hash=6ee178a5bc2d4e6312c72462460c4612)

I like it...
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: a1ex on May 05, 2014, 09:09:32 AM
I just tried to refactor the nested function, and got this:

Code: [Select]
diff -r 8b19cff1db59 modules/dual_iso/cr2hdr.c
--- a/modules/dual_iso/cr2hdr.c Mon May 05 09:53:19 2014 +0300
+++ b/modules/dual_iso/cr2hdr.c Mon May 05 10:06:45 2014 +0300
@@ -1828,6 +1828,30 @@
     return round(raw_adjusted + fast_randn05());
 }
 
+struct xy { int x; int y; };
+
+struct edge_dir
+{
+    struct xy ack;      /* verification pixel near a */
+    struct xy a;        /* interpolation pixel from the nearby line: normally (0,s) but also (1,s) or (-1,s) */
+    struct xy b;        /* interpolation pixel from the other line: normally (0,-2s) but also (1,-2s), (-1,-2s), (2,-2s) or (-2,-2s) */
+    struct xy bck;      /* verification pixel near b */
+    /* note: all y coords should be multiplied by s */
+};
+
+static int edge_interp(int dir, int x, int y, float** plane, int* squeezed, const struct edge_dir edge_directions[], int s, int* raw2ev)
+{
+    int dxa = edge_directions[dir].a.x;
+    int dya = edge_directions[dir].a.y * s;
+    int pa = COERCE((int)plane[squeezed[y+dya]][x+dxa], 0, 0xFFFFF);
+    int dxb = edge_directions[dir].b.x;
+    int dyb = edge_directions[dir].b.y * s;
+    int pb = COERCE((int)plane[squeezed[y+dyb]][x+dxb], 0, 0xFFFFF);
+    int pi = (raw2ev[pa] * 2 + raw2ev[pb]) / 3;
+   
+    return pi;
+}
+
 static int hdr_interpolate()
 {
     int w = raw_info.width;
@@ -2174,15 +2198,7 @@
         #endif
 
         /* define edge directions for interpolation */
-        struct xy { int x; int y; };
-        const struct
-        {
-            struct xy ack;      /* verification pixel near a */
-            struct xy a;        /* interpolation pixel from the nearby line: normally (0,s) but also (1,s) or (-1,s) */
-            struct xy b;        /* interpolation pixel from the other line: normally (0,-2s) but also (1,-2s), (-1,-2s), (2,-2s) or (-2,-2s) */
-            struct xy bck;      /* verification pixel near b */
-        }
-        edge_directions[] = {       /* note: all y coords should be multiplied by s */
+        const struct edge_dir edge_directions[] = {
             //~ { {-6,2}, {-3,1}, { 6,-2}, { 9,-3} },     /* almost horizontal (little or no improvement) */
             { {-4,2}, {-2,1}, { 4,-2}, { 6,-3} },
             { {-3,2}, {-1,1}, { 3,-2}, { 4,-3} },
@@ -2374,24 +2390,12 @@
 
                     int dir = edge_direction[x + y*w];
                     
-                    int edge_interp(int dir)
-                    {
-                       
-                        int dxa = edge_directions[dir].a.x;
-                        int dya = edge_directions[dir].a.y * s;
-                        int pa = COERCE((int)plane[squeezed[y+dya]][x+dxa], 0, 0xFFFFF);
-                        int dxb = edge_directions[dir].b.x;
-                        int dyb = edge_directions[dir].b.y * s;
-                        int pb = COERCE((int)plane[squeezed[y+dyb]][x+dxb], 0, 0xFFFFF);
-                        int pi = (raw2ev[pa] * 2 + raw2ev[pb]) / 3;
-                       
-                        return pi;
-                    }
-                   
                     /* vary the interpolation direction and average the result (reduces aliasing) */
-                    int pi0 = edge_interp(dir);
-                    int pip = edge_interp(MIN(dir+1, COUNT(edge_directions)-1));
-                    int pim = edge_interp(MAX(dir-1,0));
+                    #define EDGE_INTERP(dir) edge_interp(dir, x, y, plane, squeezed, edge_directions, s, raw2ev)
+                    int pi0 = EDGE_INTERP(dir);
+                    int pip = EDGE_INTERP(MIN(dir+1, COUNT(edge_directions)-1));
+                    int pim = EDGE_INTERP(MAX(dir-1,0));
+                    #undef EDGE_INTERP
                     
                     interp[x   + y * w] = ev2raw[(2*pi0+pip+pim)/4];
                     native[x   + y * w] = raw_get_pixel32(x, y);

Quite ugly if you ask me, so if you can use gcc on mac, I would prefer to keep the nested function.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 05, 2014, 09:26:43 AM
Thanks a1ex for your works!
I don't have my mac on the hands, I'll try this evening. I'll try everything to compile with gcc so keep nested function!
Title: Native speaker needed for quality control!
Post by: Walter Schulz on May 05, 2014, 05:55:25 PM
Do you have half an hour and language skills beyond mine? First one may be tough, second one a no-brainer.
Please locate TranslatedStrings_en.txt inside your plug-in folder or here (https://bitbucket.org/kichetof/lr_cr2hdr/src) and give it a makeover. Get rid of those blanks at the end of sentences, change odd translation into proper english. In short: Create the text you want to read!

If you don't want to dive into Bitbucket you may post your results here.
If you got stuck with LR terminology: Take a look into "Export to harddisk" and feel free to follow your guts.
Or contact me by PM.

Ciao
Walter

PS: Native editors for other languages may just jump in.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on May 05, 2014, 07:06:36 PM
If I'm being picky.

Quote
"$$$/ML/Dpendencies/Error=This plugin (cr2hdr) needs dcraw and exiftool.^n^nPlease install it before running this plugin"

Otherwise, it looks fine here.


edit:  This is better:  https://bitbucket.org/kichetof/lr_cr2hdr/pull-request/3/small-tweaks-to-english-translation/diff
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 05, 2014, 10:59:25 PM
Thanks Audionut for your translation! I already merged :)

@a1ex & g3gg0 big thanks !

Code: [Select]
gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/Cellar/gcc/4.8.2/libexec/gcc/x86_64-apple-darwin13.1.0/4.8.2/lto-wrapper
Target: x86_64-apple-darwin13.1.0
Configured with: ../configure --build=x86_64-apple-darwin13.1.0 --prefix=/usr/local/Cellar/gcc/4.8.2 --enable-languages=c,c++,objc,obj-c++ --program-suffix=-4.8 --with-gmp=/usr/local/opt/gmp --with-mpfr=/usr/local/opt/mpfr --with-mpc=/usr/local/opt/libmpc --with-cloog=/usr/local/opt/cloog --with-isl=/usr/local/opt/isl --with-system-zlib --enable-version-specific-runtime-libs --enable-libstdcxx-time=yes --enable-stage1-checking --enable-checking=release --enable-lto --disable-werror --enable-plugin --disable-nls --enable-multilib
Thread model: posix
gcc version 4.8.2 (GCC)

Code: [Select]
make cr2hdr
REBUILDING
[ README   ]   module_strings.h
[ gcc      ]   cr2hdr
kelvin.c: In function 'adobe_coeff':
kelvin.c:314:25: warning: iteration 3u invokes undefined behavior [-Waggressive-loop-optimizations]
           cam_xyz[0][j] = table[i].trans[j] / 10000.0;
                         ^
kelvin.c:313:9: note: containing loop
         for (j=0; j < 12; j++)
         ^

I've cr2hdr fully fonctionnal! Classic and 20bit versions!

@a1ex could you add a release status (or what you want) when you run cr2hdr for identified which is running (classic or 20bit) ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 05, 2014, 11:13:21 PM
@kichetof: Do you have some kind of time table/milestones in mind about 2.2RC/2.2 final? Having some ideas to discuss and not sure if it's a good idea to press them into 2.2 or scheduling them to a release after that.

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 05, 2014, 11:45:49 PM
@Walter
With all the changes, I even thought of a version 3 :)

So feel free to propose your ideas and I'll examine if I add now or in near future!

To release this version, I need a double check in translation, especially in swedish and portuguese ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 06, 2014, 12:32:26 AM
I've added a dynamically method to update synopsis when you change default settings.

(You can see the synopsis when you minimize section)

Could you please send me the correct translation for DE, SV, PT (https://bitbucket.org/kichetof/lr_cr2hdr/commits/3a43baf99edba7101bd6887cfb9dbf8bac7672a4) ? :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on May 06, 2014, 12:44:19 AM
I guess like many I am waiting with bated breath to use the 20-bit version.

You seem well passed the Pareto point :-)

Hope I can try out tonight. 
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 06, 2014, 01:00:15 AM
I think it's for the end of this week :) too late to write it now

Stay tuned!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 06, 2014, 01:01:51 AM
(You can see the synopsis when you minimize section)

Well, I see them ...
The synopsis strings doesn't match with their sections. Makes no sense to me to translate them.

The whole concept is a little bit beyond my understanding: Each section has a header telling what will be found in it. Good so far. And if a section is closed there will be a second text but why? Cannot see the benefit.
KISS = Keep it simple ...

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 06, 2014, 08:14:40 AM
When I run dozens of times the plugin, it's more simple for me to see if I have changed something.
And I think its can be useful for beginer users :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 06, 2014, 08:26:09 AM
Then there is no need to translate a string which will add up to user confusion: Just copy section header strings to synopsis.

Still not seeing the benefit, though. Might be more convincing if you have an example showing a synopsis actually helping.

"Lightbulb (http://abbieisaninjaa.files.wordpress.com/2011/06/gru_lightbulb.png)!" moment missing.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 06, 2014, 09:06:26 AM
I wanted to add a summary of changes (for cr2hdr exemple like: --fast or --cs5x5 etc) but I think it will charge a lot the GUI for nothing.

When the section is open, you don't see the synopsis. I run a lot of tests and believe me, it's really more simple with that  :) and there are only 2 strings to translate

With these 2 strings, you know directly if there are a modification or not and you don't need to verify all fields manually (especially for cr2hdr args)

Sometimes I add some useful functions for users and sometime I add some useful functions for me  8)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on May 06, 2014, 09:40:43 AM
Code: [Select]
make cr2hdr
REBUILDING
[ README   ]   module_strings.h
[ gcc      ]   cr2hdr
kelvin.c: In function 'adobe_coeff':
kelvin.c:314:25: warning: iteration 3u invokes undefined behavior [-Waggressive-loop-optimizations]
           cam_xyz[0][j] = table[i].trans[j] / 10000.0;
                         ^
kelvin.c:313:9: note: containing loop
         for (j=0; j < 12; j++)
         ^

yeah the line should be:
Code: [Select]
cam_xyz[j/3][j%3] = table[i].trans[j] / 10000.0;

due to the way how compilers organize it in memory, it wont make a functional difference.
but compilers may be free to place it in a different way or do optimizations - then it would hurt.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 06, 2014, 09:41:28 AM
Lightbulb!

String "a" if defaults are used. String "b" if not!
Boy, that *does* make sense!

Will there be a button (or more, one for each tab?) to restore factory defaults?

Ciao
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 06, 2014, 09:53:05 AM
yeah the line should be:
cam_xyz[j/3][j%3] = table.trans[j] / 10000.0;

if thou say :) I believe you!

Will there be a button (or more, one for each tab?) to restore factory defaults?

You read in my mind  8)
I think I'll add one by section (one for cr2hdr args and one for plugin settings)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: g3gg0 on May 06, 2014, 09:58:58 AM
(updated my post and added markup to treat it as code)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 06, 2014, 05:34:10 PM
About synopsis again. My suggestions for english and german strings.
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs10.postimg.org%2Flez8vs851%2FBild_21.jpg&hash=14151ad6f6d9f708e2607bd41b4ceb9b) (http://postimg.org/image/lez8vs851/)

Code: [Select]
"$$$/ML/ExportManager/SynopsisModuleDefault=This section is using default settings"
"$$$/ML/ExportManager/SynopsisModuleCustom=This section is using customized settings"

Code: [Select]
"$$$/ML/ExportManager/SynopsisModuleDefault=Diese Sektion verwendet die Standardeinstellungen"
"$$$/ML/ExportManager/SynopsisModuleCustom=Diese Sektion verwendet geänderte Einstellungen"

Tried to find a translation guide about LR terminology without success. Will be grateful for a link or some help here:
section -> Sektion
or
section -> Abschnitt

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on May 06, 2014, 10:55:34 PM
Just tried Alex's latest cr2HDR-20bit in the LR plugin and I must say it looks very good.

Thanks to all those working behind the scenes on this post-processing side of ML.

Cheers!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 07, 2014, 11:25:46 AM
Thanks Walter for your suggestions! I'll add it tonight ;)

What about marking as rejected? Is there an API call for "Delete rejected photos"?

It's exactly what I'll add into advanced settings (marking as rejected for cr2hdr and cr2hdr-20bit instead delete).
Unfortunately, I don't found anything to remove the photo from the catalog and I think it's a LR protection.

Regarding the integration of cr2hdr-20bit into the plugin, I need your opinion

What I do ? Add 4 tabs ? Add 1 tab for cr2hdr-20bit with all these settings ? [/i](in my MacBookPro 15", I think if I add 4 tabs, I can't read the whole text)[/i]
I need to add theses arguments:

Code: [Select]
{
        "Highlight/shadow handling", (struct cmd_option[]) {
            { (int*)&soft_film_ev,    1, "--soft-film=%f",  "bake a soft-film curve to compress highlights and raise shadows by X EV\n"
                                          "                  (if you use this option, you should also specify the white balance)"},
            OPTION_EOL
        },
    },

Code: [Select]
{
        "White balance", (struct cmd_option[]) {
            { &gray_wb,     WB_GRAY_MAX, "--wb=graymax",    "set AsShotNeutral by maximizing the number of gray pixels (default)" },
            { &gray_wb,     WB_GRAY_MED, "--wb=graymed",    "set AsShotNeutral from the median of R-G and B-G" },
            { &exif_wb,               1, "--wb=exif",       "set AsShotNeutral from EXIF WB (not exactly working)" },
            { (int*)&custom_wb[0],    3, "--wb=%f,%f,%f",   "use custom RGB multipliers (default 2,1,2)" },
            OPTION_EOL
        },
    },

Code: [Select]
{
        "Flicker handling", (struct cmd_option[]) {
            { (int*)&same_levels,    1, "--same-levels",       "Adjust output white levels to keep the same overall exposure\n"
                                            "                  for all frames passed in a single command line\n"
                                            "                  (useful to avoid flicker - for video or panoramas)" },
            /* todo: deflicker, percentiles... */
            OPTION_EOL
        },
    },

Code: [Select]
{
        "Misc settings", (struct cmd_option[]) {
            /* Would it be better to use this as default behavior, and have an --overwrite switch? */
            { &skip_existing,  1, "--skip-existing",  "Skip the conversion if the output file already exists" },

            { &embed_original, 1, "--embed-original", "Embed the original CR2 file in the output DNG, and delete the CR2\n"
                                    "                  You will be able to re-process the DNG with a different version or different conversion settings.\n"
                                    "                  To recover the original RAW: exiftool IMG_1234.DNG -OriginalRawFileData -b > IMG_1234.CR2" },
            OPTION_EOL
        },
    },
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 07, 2014, 11:55:00 AM
Unfortunately, I don't found anything to remove the photo from the catalog and I think it's a LR protection.

I think users can do with this limitation. I don't know your workflow but I found it most convinient to set the rejected flag on those pics I want to get rid off and delete this whole creepy bunch later.

Something to add to an upcoming tutorial ...


Regarding the integration of cr2hdr-20bit into the plugin, I need your opinion

Not sure right now. Let me sleep on this. Do you have some kind of GUI layout sketches?

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 07, 2014, 12:34:50 PM
My workflow:

Import photo, set the flag and add specific label color for rejected photos and move all rejected pictures with color label to an other catalog ;)

No I don't have some mockup but I'll find or draw this or code an exemple!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on May 07, 2014, 02:53:24 PM
For what's worth, I simply replaced the normal version of cr2hdr with the 20bit one in the LR plugin folder, after renaming it.

All works fine.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 08, 2014, 04:59:32 PM
@kichetof: Any news from the drawing board department?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 08, 2014, 05:10:53 PM
@Walter he is overloaded :)

I wrote the restore default settings yesterday but not fully functionnal. I hope for this evening!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 08, 2014, 05:24:56 PM
Amazed to hear that there's a 20bit plugin working in lightroom. What files do I need to place in the plugin's 'bin' file? Is there a unix executable for it?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on May 08, 2014, 05:54:41 PM
All I did was download Alex's latest 20 bit cr2hdr exe, rename it and replaced yen existing cr2hdr.exe in the LR plugin folder.

As I say, it worked seamlessly.

BTW I have not kept track with plugin enhancements as they 'only' seem to be addressing the LR user interface.

I will upgrade soon!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 08, 2014, 06:15:51 PM
I didn't think that worked... I mean when I use the plugin it works with or without the windows cr2hdr.exe, dcraw.exe and exiftool.exe.
So from what I gather the only essential file to run the plugin is the unix executable file.

Correct me if I'm wrong but I see no difference whether the windows .exe files are part of the file structure.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 08, 2014, 06:19:21 PM
Joshua, what are you taking about?
Do you have LR running in Unix (Mac OS excluded)? And which "Unix executable file" do you have?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: garry23 on May 08, 2014, 06:27:33 PM
So I don't confuse people. I am running the latest LR in a 64bit win environment.

As I said, 'all' I did was replace the cr2hdr.exe in the LR plugin folder.

Cheers
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 08, 2014, 06:33:23 PM
Ah pardon me I'm running the plugin for mac.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 08, 2014, 06:44:14 PM
Any OS X environment will give windows executables some peaceful resting place as long as WINE stays out of the house ...
See first page.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 08, 2014, 07:11:16 PM
To run cr2hdr-20bit on Mac you need draw v9.21 (download available here (https://bitbucket.org/kichetof/lr_cr2hdr/downloads))
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 08, 2014, 11:37:18 PM
With one tab
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs27.postimg.org%2Fqgnl09sz7%2Flr_cr2hdr_20bit.png&hash=4fdf3e3161d7450e1132ab6f7d2e8d4e)

With 4 tabs
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2F8fvi08h9j%2Flr_cr2hdr_20bit_4tab.png&hash=096f06369233e80ba457c1186eadf231)

This is for the tab, I didn't have the time to code items into tab ;)
Personally I prefer one tab
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 09, 2014, 11:56:57 AM
Ah thanks for the link to dcraw9.21.

My mac is currently running dcraw v9.19 how do you update it to the new version?

So far I have tried the obvious 'sudo port install dcraw' but terminal returns 'sudo: port: command not found'

I'm sure its simple to you guys. Any suggestions?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 09, 2014, 12:56:09 PM
So far I have tried the obvious 'sudo port install dcraw' but terminal returns 'sudo: port: command not found'

You don't have MacPort installed ;)

You can simply do that
/usr/bin is a private folder, you need to copy with root privileges.

Before copy, make a backup of your actual version
Code: [Select]
sudo mv /usr/bin/dcraw /usr/bin/dcraw.9.20  #<-- I like to put the version of the file I backup, to know your version simply run dcraw into terminal
Code: [Select]
cd /folder/where/you/downloaded/dcraw
sudo cp dcraw /usr/bin/
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 09, 2014, 02:47:29 PM
Thanks for the reply. I have installed Mac Port, xcode and installed dcraw via terminal but the lightroom plugin says...

~ Dependencies error ~ This plugin (cr2hdr) need dcraw and exiftool.
Please install it before run this plugin

I'm very puzzled. Now if I type into terminal 'sudo port install dcraw'. then my password It returns...

--->  Computing dependencies for dcraw
--->  Cleaning dcraw
--->  Scanning binaries for linking errors: 100.0%
--->  No broken files found.



Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 09, 2014, 04:06:30 PM
you need exiftool too ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 09, 2014, 04:21:57 PM
Already seem to have exiftool 9.59 installed. I grabbed it from here http://www.sno.phy.queensu.ca/~phil/exiftool/index.html

Is that right?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 09, 2014, 04:31:18 PM
Could you try to run
Code: [Select]
which dcraw exiftool
This command is use to define if these 2 soft are present.
I've planned to modify cr2hdr exec to add my path for the exec ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 09, 2014, 04:41:01 PM
Ah. Right so using that command confirms they are both present somewhere but not sure where. Could the path be the problem?

'which dcraw exiftool'

/opt/local/bin/dcraw
/usr/bin/exiftool


Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 09, 2014, 05:13:09 PM
Nop the path is not the problem, which command return the right value.
Have you try to restart LR and restart computer ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 09, 2014, 05:26:49 PM
Yes both the computer and LR have been restarted. Here are a couple of images.

The terminal when dcraw is typed
https://www.dropbox.com/s/tx7wajnh5usi5dk/Screen%20Shot%202014-05-09%20at%2016.19.06.png

The terminal when exiftool is typed
https://www.dropbox.com/s/d7oh1c2n8mfjg1o/Screen%20Shot%202014-05-09%20at%2016.19.29.png

The current files in the plugin bin
https://www.dropbox.com/s/ht73mt4huju3ovh/Screen%20Shot%202014-05-09%20at%2016.20.21.png

The alert inside lightroom
https://www.dropbox.com/s/zl8eo9xrvmo1obe/Screen%20Shot%202014-05-09%20at%2016.23.43.png

I really appreciate the help, apologies if this is all just a bit basic. I'm happy to supply any screenshots you need.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 09, 2014, 06:41:55 PM
uh ‽

from Terminal, could you try this

Code: [Select]
cd /Applications/Adobe Photoshop Lightroom/Contents/PlugIns/cr2hdr.lrplugin/bin
./cr2hdr /path/to/a/dualiso/image

And if its work, edit MLProcess.lua into cr2hdr.lrplugin like this (start at line 217)
Code: [Select]
if MAC_ENV then

local cmd = MLProcess.checkDependencies()
isDependOk = LrTasks.execute(cmd)

if isDependOk ~= 0 then

--LrDialogs.message(LOC "$$$/ML/Dependencies/ErrorTitle=~ Dependencies error ~", LOC "$$$/ML/Dpendencies/Error=This plugin (cr2hdr) need dcraw and exiftool.^n^nPlease install it before run this plugin")
--do return end

end
end

Add two hyphen (--)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 10, 2014, 09:30:06 AM
Hmm okay so I can't seem to get the terminal command to do anything. I tried inputting it a couple and this is what I get:
https://www.dropbox.com/s/4he449gg2t5715g/terminal1.png

Now I assuming I did this part wrong I decided to try your code in MLProcess.lua anyway. I placed it in here:
https://www.dropbox.com/s/qrcxnzcgykz1821/MLscript.png

I'm still getting the dependencies error in lightroom. What i'm thinking of doing is completely reinstalling the plugin and seeing what happens.
I hope the images are useful. If you see what I'm doing wrong please let me know :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 10, 2014, 10:10:13 AM
@joshuamk
 in your terminal, your are not in the LR plugin folder ;) use TAB to add \ before space or Drag&Drop from Finder to Terminal
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 10, 2014, 10:36:50 AM
Cool dragged and dropped and yes that works in terminal! Here is the screenshot. https://www.dropbox.com/s/1cvpofxyl5glkyy/Screen%20Shot%202014-05-10%20at%2009.33.18.png

How can we get LR to recognise dcraw and exiftool? I tried adding your code to MLProcess.lua but not much luck there i'm afraid.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 10, 2014, 10:51:20 AM
Cool! On LR go to plugin manager (CMD + Alt + MAJ + ,), disable and reenable the plugin with your mlprocess edited and normally it will works fine!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 10, 2014, 01:02:47 PM
Hmm that hasn't worked. Still getting the error in LR
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 10, 2014, 02:43:27 PM
Remove plugin from LR, edit the MLProcess.lua with added 2 hyphens and reinstall it into LR
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: joshuamk on May 10, 2014, 03:15:39 PM
Sorry still nothing. Just the dependencies error.  :-\

I have highlighted the inserted script. Is this how the code should look?
https://www.dropbox.com/s/qrcxnzcgykz1821/MLscript.png
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 10, 2014, 03:23:12 PM
very strange! Delete the selected text and try again, with -- before LrDialogs, you should not have any message.. strange
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Teletobi on May 11, 2014, 02:01:52 PM
Hey folks,

thank you so much for implementing this great feature!

I took a lot of photos during my holiday using dual iso.

I got two questions regarding post processing:

1) Is it possible to just keep the .dng and automatically delete the original .cr2 using the lightroom plugin or any other method?
2) How can I convert a lot of pictures (>3k) quickly? Should I use 4 threats or just one? The CPU is an  i5 quad-core.

Thanks in advance!

ML rocks!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 11, 2014, 02:13:19 PM
Export dng to designated folder. Before exporting you could filter the originals as rejected to filter them from the dngs. You can start four exports or more in parallell to speed up things.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Teletobi on May 11, 2014, 02:30:56 PM
Thank you for the quick answer.

My problem is that I took about half of the shots with dual iso and the other half without.
The only way for me to distinguish the cr2s with dual iso from the cr2s without dual iso is to do it all by myself. Or is there any possible way for lightroom to filter the dual-iso-cr2s?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 11, 2014, 02:46:40 PM
I think you can export them all at once. Cr2hdr will probably skip the ones who aren,t dual iso. Try
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Teletobi on May 11, 2014, 02:53:08 PM
Yeah, exporting works fine. The problem is, that after the export I have the following files: .dng , .cr2 without dual iso AND unfortunately .cr2 WITH dual iso. I was hoping to automatically delete the .cr2 with dual iso and keep the other files after export.

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 11, 2014, 03:32:04 PM
Don, t know the answer to that. Though. There is a setting (unreliable) which names the dual-iso files to dualiso. It, s in the dual iso magic lantern menu in camera. Think it, s still there
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 11, 2014, 06:48:47 PM
@Teletobi you can filter by keywords ;) "Dual-ISO"

In the next release, I'll add a possibility to reject dual iso cr2 pictures to keep only the dng (I can't delete a picture from plugin, LR restriction)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Teletobi on May 11, 2014, 07:45:07 PM
Actually this wont solve my problem. Now I wrote a little tool to do the following job:
This tool will delete all CR2s, which have a corresponding DNG in the same folder. All other CR2s will remain untouched.

Instructions
1) Open Lightroom
2) Import files from the SD-/CF-Card
3) Use Lightroom plugin cr2hdr v2.1 to convert CR2 dual iso images to DNG
Note: Don't use subfolders for the output! Just place the DNGs in the same folder as the CR2s. At best leave "-dualiso" as suffix.
4) Close Lightroom.
5) Use filedelete_v01.exe to delete all unnecessary CR2s. All non-dualiso-CR2s will stay, just the dualiso-images will be deleted.
6) Open Lightroom, go to Library -> search for missing photos.
7) Remove all missing photos from the library.
8) Finished.

Downloadlinks
Tool
http://www.animal-shots.com/downloads/ml/filedelete_v01.exe
Sourcecode VB.net
http://www.animal-shots.com/downloads/ml/filedelete_v01_sourcecode.rar

Note: Use at your own risk! Dont make me responsible for loss of data!

HF!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 11, 2014, 09:07:15 PM
Okay I know what you mean!

I added in the future release the flag to rejected on the original file, then you will be able to filter by flag and keyword and remove not needed pictures.

And with cr2hdr-20bit there are an argument to remove the original picture after conversion
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Teletobi on May 11, 2014, 09:15:30 PM
I added in the future release the flag to rejected on the original file, then you will be able to filter by flag and keyword and remove not needed pictures.

And with cr2hdr-20bit there are an argument to remove the original picture after conversion

Perfect! Meanwhile I will use the tool :)

Thank you for your great work!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 12, 2014, 07:08:44 PM
First try for cr2hdr-20bit GUI
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs16.postimg.org%2Fjpi48pcd1%2Fcr2hdr_20bit_gui1.png&hash=436bf82254e80fdbd2f76d36ced15ad4)

@a1ex
For soft-film, what's the min and max values acceptable ? Actually I set from 0.0 to 20.0 is it right ?
Could you confirm this default settings ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: a1ex on May 12, 2014, 07:12:21 PM
Default is 0, the unit is in stops, so I'd say reasonable values are from 0 to 10.

BTW, the WB checkboxes should be in the same radio group.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 12, 2014, 07:43:09 PM
So quick! Thanks!
I set from 0 to 10 and use integral value (displayed in float...)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs18.postimg.org%2Flhc6y4jjd%2Fcr2hdr_20bit_gui2.png&hash=f0773b2fc924b5a4c3a93f90ea833fd7)

Disabled status when cr2hdr-20bit is not selected (I can't find a way to hide the tab... if you know :)))
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs4.postimg.org%2Fqfqguhagt%2Fcr2hdr_20bit_gui3.png&hash=8538ac676ba165040c04985a8d332941)
Title: Re: Lightroom plugin cr2hdr v2.2 BETA 6
Post by: kichetof on May 12, 2014, 10:04:46 PM
cr2hdr 2.2 BETA 6

What's news:

Download cr2hdr 2.2 BETA 6 (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA6.zip)

Please test, test and test and send me the right translation :)

* for future release of cr2hdr-20bit with local executables (see pull request on bitbucket MagicLantern) !
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 12, 2014, 10:17:18 PM
No native speaker therefore some doubts about
"Restore to defaults".
If I ask my guts I would go with "Restore factory settings" or "Restore default settings".
But my guts won't have any chance to pass TOEFL ...
Native speakers, please jump in!

@kichetof: You're spreading space decease again! Stop it, please!
Code: [Select]
This is wrong !
This is correct!

Code: [Select]
"$$$/ML/ExportManager/ExecRestore=Einstellungen zurücksetzen"
"$$$/ML/ExportManager/ASFlag=Originaldatei als 'Abgelehnt' markieren?"
"$$$/ML/ExportManager/ASFlagInfo=Haken entfernen, um nicht zu markieren"
"$$$/ML/ExportManager/AScr2hdr=cr2hdr-Version auswählen"
"$$$/ML/ExportManager/AScr2hdrInfo=cr2hdr 'klassisch' oder cr2hdr-20bit 'experimentell'"

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 12, 2014, 10:55:04 PM
@kichetof: You're spreading space decease again! Stop it, please!

This is wrong ! This is correct in french
This is correct! This is wrong in french

I wrote too quickly the translation file to take care about punctuation ;)

Thanks for your translation. Already committed.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 12, 2014, 11:12:11 PM
Thanks!

Open to discussion:
- Change radio button/slider font style to black. 

Not happy with popup control "AScr2hdr=Choose which version of cr2hdr:" location in "Advanced Settings". What about a radio button inside section "cr2hdr optional arguments"? If selected 'classic' (=cr2hdr) tab/options for cr2hdr-20bit will be greyed out (not selectable) and other way round for 'experimental' (=cr2hdr-20bit)?

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 12, 2014, 11:30:44 PM
About continuity:

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs18.postimg.org%2F7mzhq8t7p%2FBild_23.jpg&hash=ac40e22ac49f721d00a6ba7deb27c05b) (http://postimg.org/image/7mzhq8t7p/)
Suggestion: Change caption left 'cr2hdr' to 'Dual ISO' or 'Dual ISO Converter'.
Okay with you, a1ex?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 12, 2014, 11:31:27 PM
Thanks!

Open to discussion:
- Change radio button/slider font style to black. 

Approved!

like that ?
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2Fy3xkmketz%2Fcr2hdr_20bit_gui4.png&hash=ff761c590d3940554ebfbfe8f6993bb9)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 12, 2014, 11:44:10 PM
I like it. A lot! Second/third/fourth opinion welcome!

Cream on top:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs7.postimg.org%2Fdtv1696av%2Fcr2hdr_20bit_gui4.jpg&hash=c48ab7edea1fa5e421dfcd28eeac4b23) (http://postimg.org/image/dtv1696av/)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 12, 2014, 11:58:34 PM
good idea!

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs1.postimg.org%2F7132rg6cv%2Fcr2hdr_20bit_gui5.png&hash=a04a03774299ce04504c372ce3b2c425)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 12, 2014, 11:59:30 PM
20bit = classic? ;-)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 13, 2014, 12:03:45 AM
too late for my brain!  8)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 13, 2014, 09:00:55 PM
kichetof, new build, please!
Having some ideas ...
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 13, 2014, 11:25:37 PM
If it's some useful and quickly added ideas I can add before the release! Else I'll add after a "long" break ;) v3 on starting block!

I need some help for translation!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 14, 2014, 06:57:10 AM
Short term: New design in parameter section. Same for log view.

v3: Choose between several customized settings.
"Ring around the rosie": 1 pic in -> x rendered pics out with different cr2hdr parameters. Will do a user poll for this one. Not sure if it suits user needs.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 14, 2014, 07:24:42 AM
I thought to rewrite it but I didn't think to use tab items. How do you imagine it? How many tab items? Which terms to use for each item? (Short text < ~15 char)

Regarding the possibility to ask user to change parameters when rendering I have some doubts... Many users ask me to mute the alerts when rendering.
I think it's more relevant to launch a second exportation in the same time or after with the news settings.

To solve some problems with dependencies, I'll wait for new features in cr2hdr to use local exec (dcraw & exiftool) before release the next final version! :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 14, 2014, 07:48:47 AM
I thought to rewrite it but I didn't think to use tab items.

Same here. Want to get rid of tabs for good.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 14, 2014, 08:29:50 AM
I like it but it need to be useful and don't surcharge the GUI.

I'll make a test to watch the final visual!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: russellsnr on May 15, 2014, 08:52:56 AM
Hi, OK plonker question!!
I do not understand any of the tech stuff about change this string or that letter what I need to no in simple terms is how once I have finished with the image in Lightroom how do I get it to show in my external editor (OnOne suite 8.5) without the lines all across the image. It looks great in Lightroom but when exported direct or even to a folder and opened from the OnOne suite I get the lines?
Many Thanks for the Lightroom plug-in works great.
Russ
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 15, 2014, 02:07:49 PM
Hi russellsnr, are you sure do you open the converted image in OnOne ? (you need to open img_1234-dualiso.dng and the image isn't striped)

@Walter stay tuned! you were right...  8)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: russellsnr on May 15, 2014, 04:37:31 PM
Hi, Firstly thank you the reply.
I exported the DNG to OnOne direct from Lightroom and also from a saved version on computer.
These are the results I have, in Lightroom great.
  (https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi1110.photobucket.com%2Falbums%2Fh443%2Frussellsnr%2FLightroomVersion_zps9ce81eb2.png&hash=7533a796dcfa70e472634bfadfe5a4fc) (http://s1110.photobucket.com/user/russellsnr/media/LightroomVersion_zps9ce81eb2.png.html)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi1110.photobucket.com%2Falbums%2Fh443%2Frussellsnr%2FOnOneVersion_zps02a0c056.png&hash=73f7e1dc6d8eb01527a8682a59080d7b) (http://s1110.photobucket.com/user/russellsnr/media/OnOneVersion_zps02a0c056.png.html)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 15, 2014, 09:29:22 PM
You took a picture of your screen ‽ :) joke!

Try to run in a terminal cr2hdr your_picture.cr2 and try to open it into OnOne, and then we will know if the problem comes from cr2hdr in LR plugin or from cr2hdr only ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 15, 2014, 11:09:34 PM
New GUI

As Walter suggested, I refactored the GUI, and... I like it a lot! (Thanks guy!)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fotd56wvcx%2Fcr2hdr_new_gui_1.png&hash=52a33d37a20395d612bc5d9ec2b7bd0b)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fwyq57yda9%2Fcr2hdr_new_gui_2.png&hash=8c63ae7a42a76b7e07322fd117abab4b)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fwxg7ejbgh%2Fcr2hdr_new_gui_3.png&hash=8d667a448028f05664766348cc9cf850)

(Sorry for french translation in printscreen, when I switch in english, my export manager windows are too small and I can't resize it...)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: akry on May 16, 2014, 08:17:27 PM
A GUI thing: the settings are not fitting into the export dialog window. It is not horizontal resizable in LR on Windows.
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi.imgur.com%2F5H71sLB.png&hash=02ee5855d127c71a85691878a5b5490a)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 16, 2014, 08:42:49 PM
Thanks akry for the feedback!
I just committed a new logo (in png to try to fix the transparency...) and let me know if the width is ok and after that, I'll find a way to match all in this width :)

What do you think if I put the gray text which is in on the right into a tooltip for each items ? Except for cr2hdr arguments, I need to find an other way

First try with args: (changed label size and removed --)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs9.postimg.org%2Fan0pwek33%2Fgui_width_args_fix.png&hash=a80484c497fadd54ee46a79dc695d0ac)

And now with plugin option
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2Fp3oqx9t47%2Fgui_width_module_fix.png&hash=3649d7376385cb8c7e4683f93029c08d)

Source updated, could you please try ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: swinxx on May 16, 2014, 11:14:46 PM
Can you please offer a compiled version for testing. I have no idea how to compile the plugin. Thx
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 16, 2014, 11:25:48 PM
no compile needed, only download from source and replace old files ;)

Replace MLDialogs.lua with this version (https://bitbucket.org/kichetof/lr_cr2hdr/raw/251622db7ddfc7050528fb3a801e353d26274519/MLDialogs.lua)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Stedda on May 16, 2014, 11:40:02 PM
Width works fine for me on Windows 7 LR5.4.... plugin gets better every time. Thanks for all your work. This plugin is a real winner!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 17, 2014, 03:03:30 PM
Thanks, kichetof!

But! I wanted to get rid of tabs, but now we have *two* sections with tabs in it. Instead of going tabs I would prefer file handling following LR's "Hard Drive" export dialog design.
In LR there are two sections covering file manipulation: One "Export Location", one "File Naming".

====
EDIT:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs4.postimg.org%2Fh7vfm5bd5%2FBild_3.jpg&hash=3ae89ca9c691b856d3d699653cfe7053) (http://postimg.org/image/h7vfm5bd5/)
Changed item order in cr2hdr argument tab, too.
====

Another option to prevent users losing orientation inside plug-ins: Separators. In my opinion they will do fine in "arguments" tab section. No reservations about tabs in this section ... now.

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: russellsnr on May 17, 2014, 03:38:22 PM
You took a picture of your screen ‽ :) joke!

Try to run in a terminal cr2hdr your_picture.cr2 and try to open it into OnOne, and then we will know if the problem comes from cr2hdr in LR plugin or from cr2hdr only ;)
Hi, Sorry not sure what you are asking but I have tried exporting from Lightroom to Photoshop CS 6 and a single image to Machinery HDR pro with excellent results in both. Not being savvy in all this software programing talk it makes it sound complected to change things.
Thanks again
Russ
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 17, 2014, 05:28:49 PM
Hi, Sorry not sure what you are asking

He asked you to run cr2hdr from commandline/terminal like you did before in
http://www.magiclantern.fm/forum/index.php?topic=7342.msg94426#msg94426
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: russellsnr on May 17, 2014, 10:59:32 PM
He asked you to run cr2hdr from commandline/terminal like you did before in
http://www.magiclantern.fm/forum/index.php?topic=7342.msg94426#msg94426
Hi, Thank you for all the help/advice.
I have UN-installed then re-installed the L/R plug-in, restarted computer  and now it is working fine I have no idea why or how but it's working.
Again
Thank You
Russ
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: lureb74 on May 19, 2014, 09:00:16 PM
Hello,

First, great plugin kichetof! I post my experiment with the intention to help developing (because I'm not a coder :)).

I just tried to use the latest 2.2 beta6 to convert a 60fps Dual-ISO mlv_raw video at 1920x448. The video was shooted in manual mode, 1/120 speed, with a samyang 85mm at f/2, ISO 100-800. Converted in LR with theese settings:

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs9.postimg.org%2Fo4k8ft127%2Fsettings.gif&hash=1350c310f5773fec492e5e9a2bfe3e0a)


Upscaled to 1920x734 and conformed to 30fps in post. Here's the result:



As you can see, it have flickering (see the white paper) and seems that exposition changes when passing from light to dark areas (the wooden door) and vice versa... what do you think about it?

Have a question: what is "Octave"? I find this program: http://octave.sourceforge.net/ (http://octave.sourceforge.net/), is that right? How to use it and what kind of improvements can make to this kind of workflow?

Many thanks,

Lorenzo
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: a1ex on May 19, 2014, 10:30:16 PM
The --same-levels option requires all the files to be passed in the same command line.

If they are passed one by one, it will have no effect.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 20, 2014, 10:03:45 AM
====
EDIT:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs4.postimg.org%2Fh7vfm5bd5%2FBild_3.jpg&hash=3ae89ca9c691b856d3d699653cfe7053) (http://postimg.org/image/h7vfm5bd5/)
Changed item order in cr2hdr argument tab, too.
====

Another option to prevent users losing orientation inside plug-ins: Separators. In my opinion they will do fine in "arguments" tab section. No reservations about tabs in this section ... now.

Ciao
Walter

@Walter I like this concept! Could you send me a pull request with your changes?
Do you have an exemple with separators ?

@lureb74 thanks! But for your problem, I need to check a1ex answer :)
if I didn't say stupidity, Octave is like Matlab

The --same-levels option requires all the files to be passed in the same command line.

If they are passed one by one, it will have no effect.

Ouch...! LR export one by one... so to apply this setting, I need to export all and run after cr2hdr on all files... Maybe I'll disable this setting until I found the best way to do that properly!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 20, 2014, 06:48:11 PM
@Walter I like this concept! Could you send me a pull request with your changes?

Not that sure if that's a good idea. I intended to make a mock-up, not actual code *doing* something. So I had some fun with CTRL-C/CTRL-V and never tried generating DNGs.

Do you have an exemple with separators ?

Tried that option and ended up not liking it anymore.

More suggestions for GUI layout:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs14.postimg.org%2Fe4kk0dwvh%2FBild_6.jpg&hash=f8033d83a15c3ead65d469bb2543c08c) (http://postimg.org/image/e4kk0dwvh/)
Could you insert some "blank" (= grey) below slider?

Ciao
Walter
Title: Thanks for your great Work
Post by: jackyjack on May 20, 2014, 07:08:12 PM
It works like a charm and redefines the possibilities of my little eos m :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 20, 2014, 10:48:59 PM
No problem to add a spacer it looks good!
Don't worry about copy paste! If you doesn't change any bind or values all will works like a charm! Send me your version and I'll lookup if everything seems okay :)
I'll in holydays in some days (welcome BHPV) so I don't have enough time!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 21, 2014, 12:17:40 AM
Without spacer (http://fbe.am/sYs)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 21, 2014, 07:42:14 AM
Thanks Walter! I'll try to add it tomorrow :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 23, 2014, 08:25:26 AM
Meanwhile, across the border:
http://www.dpreview.com/news/2014/05/22/dxo-optics-pro-9-5-now-integrates-with-adobe-lightroom?utm_campaign=internal-link&utm_source=news-list&utm_medium=text&ref=title_0_2
They make much fuss about beeing the first application transfering RAW from LR and putting a DNG back there.
Quote:
"Up until now, exporting a RAW image from Lightroom to another software application required first converting it to JPEG or TIFF format, which can reduce image quality. DxO Optics Pro v9.5 offers the first non- destructive workflow that is completely integrated with Lightroom."

Cheers, kichetof and enjoy this and your holidays!

Ciao
Walter

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 23, 2014, 11:39:48 AM
Yeah good news for DxO users!

@Walter I doesn't have yet the time to edit the plugin with your modification! I hope that I will write before my holidays!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 23, 2014, 11:59:54 AM
Maybe you missed the fun: They are second (or third, didn't investigate) because a1ex (cr2hdr) and you (lr plug-in)  implemented a complete workflow with "RAW (from LR) -> App -> DNG (into LR)" prior to DxO Optics Pro 9.5. Yes, DxO Optics Pro is a lot more powerful but their statement is just wrong. So ... lawsuit, anyone?





Just kidding ...

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: chris_overseas on May 23, 2014, 12:49:19 PM
My understanding is that the DNG files output by DxO are linear DNGs, i.e. they have been demosaiced. See section 4 here for details: http://www.dxo.com/intl/photography/tutorials/optimize-your-workflow-dxo-optics-pro-9-and-adobe-lightroom (http://www.dxo.com/intl/photography/tutorials/optimize-your-workflow-dxo-optics-pro-9-and-adobe-lightroom)

Linear DNG is still something of an improvement over TIFF (Adobe's Eric Chan discusses this here: http://www.dpreview.com/forums/post/30148341 (http://www.dpreview.com/forums/post/30148341)) but I'm not sure that DxO's claims of a fully non-destructive workflow are legitimate. If you're going to sue over anything, that might be a good place to start ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 23, 2014, 01:27:58 PM
We're the future!  8)

This is a good point for us to be in advance!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 25, 2014, 12:48:45 AM
New GUI

Thanks Walter it's nice! (I wasn't able to unzip your file)

Download Source branch default (https://bitbucket.org/kichetof/lr_cr2hdr/get/default.zip) and rename the folder like cr2hdr.lrplugin or what you want.

If everything seems good, I'll release the v3 in second week of june.

I disabled --same-levels option until I find a way to export all pictures before run cr2hdr

Enjoy!

With a preview, it's better :)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2F5tsj11jgh%2Fdic_new_gui.png&hash=b7ca7a716e9f0c239aef057c3ee7da1a)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 25, 2014, 02:42:11 PM
Just tried this one. Really nice work with the gui. wb settings in 20-bit and, shadow/highlight, soft film. Nice feature.
Thanks again
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 25, 2014, 04:58:48 PM
Thoughts that enters my mind on "arguments" and "additional arguments for 20-bit version".
Where can I get info on chromasmoothing(what the alternatives does), aliasmap and what it does and so on? Also about wb "additional arguments for 20-bit version"?.
I am thinking when placing cursor on top of each argument, a small explanationwindow appears with a very short information of the functionality? Maybe hard to implement? Maybe not wanted? Only a suggestion.
Love this tool
/D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 25, 2014, 08:53:47 PM
New Metadata

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2Famru7hkon%2Fdic_metadata_new.png&hash=a5ab743b5a19b182070ffe40b5675a6f)

Download Source branch default (https://bitbucket.org/kichetof/lr_cr2hdr/get/default.zip) and rename the folder like cr2hdr.lrplugin or what you want.

An update of your LR Catalog is needed, don't worry :)

@Danne, there are some tooltip to explain all theses options. You run the plugin on windows ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Stedda on May 25, 2014, 09:01:48 PM
Metadata FTW! Nice work guys!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 25, 2014, 09:04:08 PM
Hi Kitchehof, I run it under mac os X mavericks. Searched but couldn,t find any tooltip. I could maybe help gathering a tooltip collection. Need to find all the information first though  :P

*didn,t notice the metadata-option. Nice one!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 25, 2014, 09:36:18 PM
Oh, I forgot something, if there are no Dual ISO, the log file go directly to the trash!

@Danne place the cursor on any radio button or check box and you'll have a tooltip :) works well on mac!

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 30a5132 on 2014-05-07 10:34:25 UTC by a1ex:
cr2hdr: print a message when overwriting the output file

No input files.

GUI usage: drag some CR2 or DNG files over cr2hdr.exe.

Command-line usage: bin/cr2hdr20bit [OPTIONS] [FILES]

Shortcuts:
--fast          : disable most postprocessing steps (fast, but low quality)
                  (--mean23, --no-cs, --no-fullres, --no-alias-map, --no-stripe-fix, --no-bad-pix)

Interpolation methods:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--mean23        : average the nearest 2 or 3 pixels of the same color from the Bayer grid (faster)

Chroma smoothing:
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--cs3x3         : apply 3x3 chroma smoothing in noisy and aliased areas
--cs5x5         : apply 5x5 chroma smoothing in noisy and aliased areas
--no-cs         : disable chroma smoothing

Bad pixel handling:
--really-bad-pix: aggressive bad pixel fix, at the expense of detail and aliasing
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)
--black-bad-pix : mark all bad pixels as black (for troubleshooting)

Highlight/shadow handling:
--soft-film=%f  : bake a soft-film curve to compress highlights and raise shadows by X EV
                  (if you use this option, you should also specify the white balance)

White balance:
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)
--wb=graymed    : set AsShotNeutral from the median of R-G and B-G
--wb=exif       : set AsShotNeutral from EXIF WB (not exactly working)
--wb=%f,%f,%f   : use custom RGB multipliers (default 2,1,2)

Other postprocessing steps:
--no-fullres    : disable full-resolution blending
--no-alias-map  : disable alias map, used to fix aliasing in deep shadows
--no-stripe-fix : disable horizontal stripe fix

Flicker handling:
--same-levels   : Adjust output white levels to keep the same overall exposure
                  for all frames passed in a single command line
                  (useful to avoid flicker - for video or panoramas)

DNG compression (requires Adobe DNG Converter):
--compress      : Lossless DNG compression
--compress-lossy: Lossy DNG compression (be careful, may destroy shadow detail)

Misc settings:
--skip-existing : Skip the conversion if the output file already exists
--embed-original: Embed (move) the original CR2 file in the output DNG. The original will be deleted.
                  You will be able to re-process the DNG with a different version or different conversion settings.
                  To recover the original: exiftool IMG_1234.DNG -OriginalRawFileData -b > IMG_1234.CR2
--embed-original-copy:
                  Similar to --embed-original, but without deleting the original.


Troubleshooting options:
--debug-blend   : save intermediate images used for blending:
    dark.dng        the low-ISO exposure, interpolated
    bright.dng      the high-ISO exposure, interpolated and darkened
    halfres.dng     half-resolution blending (low noise, high aliasing)
    fullres.dng     full-resolution blending (minimal aliasing, high noise)
    *_smooth.dng    images after chroma smoothing
--debug-black   : save intermediate images used for black level subtraction
--debug-amaze   : save AMaZE input and output
--debug-edge    : save debug info from edge-directed interpolation
--debug-alias   : save debug info about the alias map
--debug-rggb    : plot debug info for RGGB/BGGR autodetection (requires octave)
--debug-bddb    : plot debug info for bright/dark autodetection (requires octave)
--debug-wb      : show the vectorscope used for white balance (requires octave)
--iso-curve     : plot the curve fitting results for ISO and black offset (requires octave)
--mix-curve     : plot the curve used for half-res blending (requires octave)
--fullres-curve : plot the curve used for full-res blending (requires octave)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 25, 2014, 10:10:09 PM
Oh man, you,re so right. Tooltip,s already there. This is so professionally made. Beautiful
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 26, 2014, 05:55:36 PM
LR bug or is it just me? Or Windows?

Mark picture -> open context menu -> Export -> Export ...
If LR plug-in "Dual ISO converter (cr2hdr)" was selected before it will come up and tooltips will be available. If not and I have to change to this one there will be no tooltips available. Same for Lightroom Presets "Export to DNG". Tooltips are available (Metadata -> Write Keywords as Lightroom Hierarchy) if opened by default. After opening another plug-in and turning back to "Export to DNG" tooltips are gone.

Windows 7 Ultimate, 64-bit german. LR 5.4 german/english.

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 26, 2014, 06:38:17 PM
New Metatada

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs22.postimg.org%2Fawwozstup%2Fdic_metadata_isorange.png&hash=230e5a4e36f28ac76ea244559577fc5e)

I added ISO Range (like 100 - 800) :)

@a1ex do you have a trick to round ISO like Canon menu ? (especially for intermediate ISO like 320 or 640)

@Walter no "problem" for me (LR5.4 Mac 10.9.3) but sometimes I need to wait 1-2sec before that the tooltip displayed
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 26, 2014, 08:58:05 PM
Error in MLMetadataDefinitionFile.lua
   Line 114:          title = LOC "$$$/ML/Metadata/cr2hdrArgs=Executable",
   Line 132:          title = LOC "$$$/ML/Metadata/cr2hdrArgs=Active options",

Error in MLMetadataTagset.lua
   Line 52:             label = "Command line"
Missing LOC definition.

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 26, 2014, 09:05:18 PM
Eye of tiger! Fixed!

@a1ex: German language support, please!
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs4.postimg.org%2Fcywod7cwp%2FBild_2.jpg&hash=4b3fc56ae404e045be3489e13784f11b) (http://postimg.org/image/cywod7cwp/)
Semi-overexposed = "Halb-überbelichtet"? Urks! "Scheinbare Überbelichtung"?
Deep shadow = "Tiefer Schatten"? ... naja ...
Dynamikbereich (src1), Dynamikbereich (src2) = "Quelle 1", "Quelle 2". No clue what's meant by that.

Other finetuning needed? Open to suggestions!

Ciao
Walter

Feel free to send a pull request, all translated files are updated with these LOC string ;)


Error in MLMetadataDefinitionFile.lua
   Line 114:          title = LOC "$$$/ML/Metadata/cr2hdrArgs=Executable", Fixed
   Line 132:          title = LOC "$$$/ML/Metadata/cr2hdrArgs=Active options", Fixed

Error in MLMetadataTagset.lua
   Line 52:             label = "Command line" Fixed
Missing LOC definition.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 26, 2014, 09:53:02 PM
Eye of tiger!

Not so much. Notepad++ helps a lot.

Fixed!

Thanks! If you have too much time at hand:
Computer's decimal mark setting not used in LR's GUI.
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs24.postimg.org%2Fej5d1usdd%2FBild_7.jpg&hash=51741085de2b4686f566aa367a0ce163) (http://postimg.org/image/ej5d1usdd/)
Not sure about side effects here.
- Store metadata with dot all the time but use computer settings for GUI?
- Store metadata with computer settings for decimal mark? ... and opening a can of worms in post?

Ciao
Walter

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 26, 2014, 10:08:08 PM
Could you try with these changes: https://bitbucket.org/kichetof/lr_cr2hdr/branch/localizableNumber
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 26, 2014, 10:26:10 PM
Will test it.

Next item: Lots of unlocalized strings in MLdialogs.lua. Tooltips and tabs captions and others. But keep strings like "--mean23" unlocalized, please!

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 26, 2014, 10:33:02 PM
a lot of works yes !
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 26, 2014, 11:08:51 PM
Have tested it. Looks like it reads setting for decimal mark during export but only for "ISO difference". Doesn't affect pics converted before or pics handled on computers with different settings.
I'm not absolutely sure but I have reservations about this. Don't like the idea branding different decimal marks into metadata. "Mars Climate Orbiter" may not be our mission name but ...
If it is not possible to keep a unique data format in metadata I would like to ditch the idea.
If it is possible to use unique data formats and manipulate their appearance at LR runtime depending on system settings: Fine.

Ciao
Walter

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 26, 2014, 11:38:37 PM
For ISO Difference do you obtain the right result? I set only for this setting just for the try ;)

I don't know how to display with system settings... Localization is always a mistake!
I've an idea but I need to know for each LR supported language who have dot or comma and replace depending of the language. It's not perfect but I think it can be done the job for 90% of users!

Read the last paragraph http://www.lua.org/pil/22.2.html ‽  :-X
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 27, 2014, 11:57:42 AM
Tooltip localizable committed!

@Walter what's your settings in windows for your numbers? Because I found a lot a thing about thousand separator with comma, but alway a point for decimal. It's a german rules ?

I can set : DE (or maybe another)? replace dot by comma
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 27, 2014, 12:48:07 PM
Decimal marks worldwide:
http://en.wikipedia.org/wiki/Decimal_mark#Hindu.E2.80.93Arabic_numeral_system
LR within W7 will read actual system setting for decimal mark at startup. Change the setting, startup LR -> Exposure numbers will show either dot comma (or any letter you tell Windows to use).
I suppose they are reading LOCALE_SDECIMAL via API.

And yes, it is working for ISO Difference. Works as intended, I'm afraid.

Will work on tooltips later.

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 27, 2014, 01:50:34 PM
Thanks for the informations! I hate commas for numbers, I always use dot. (Swiss french)

Great news if my trick works! I'll write a function to convert all number depending the system locale!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 27, 2014, 02:00:45 PM
kichetof, before you do this may I ask *what* the results will be?
If you're changing metadata contents depending on system locale: Just don't!
If you're changing strings appearing in LR's UI depending on system locale and keeping metadata content consistent and independent from system settings: That's what we need!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 27, 2014, 02:27:12 PM
I read the log file from cr2hdr with point decimal marker and set the metadata to the photo with this value. I can't change the displayed values because it show you the values from the metadata.

If I store into metadata a number with comma, you're a comma in your metadata.
If I store into metadata a number with point, you're a point in your metadata.

This is the data type that I allowed for metadata:

string — The field value must have a string value.
enum — The field value must have one of the allowed values specified in
the values entry. In the Metadata panel, allowed values are shown as a
pop-up menu for the field.
url — The field value must have a string value. In the Metadata panel, the
text field is acccompanied by a button that treats the text value as a URL,
opening it in the user’s preferred web browser.


So I can't store a number. The unique possibility is to rewrite the number depending the system locale like I made on the try.

What do you think ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 27, 2014, 02:52:35 PM
Skip it, then. I can see only troubles ahead if we have language dependend decimal markers in our metadata. Go with dots!
Sorry for keeping you running in circles!

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on May 27, 2014, 03:27:05 PM
Finally a workflow in lightroom that can be used and queued with enfusegrouping and other things. Biggest thumbs up for automatic rejection of originals after conversion. Also, graymax setting in whitebalance totally works. Alex cr2hdr geniality and this app nails the best in my camera atm.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 27, 2014, 03:59:33 PM
Metadata update

I've setup a way to update all already converted files to add ISO Range in metadata. (I don't want to spend a lot of time to try to search information about command line informations)

LR Catalog update needed ;)
(If you know how to reset schemaVersion from the catalog, you're welcome! I made some tests and I need to increase this number on my catalog ...)

GUI update

I've moved the info text to tooltips, what do you think ?

Download Source branch default (https://bitbucket.org/kichetof/lr_cr2hdr/get/default.zip) and rename the folder like cr2hdr.lrplugin or what you want.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: rpt on May 27, 2014, 05:38:35 PM
I read the log file from cr2hdr with point decimal marker and set the metadata to the photo with this value. I can't change the displayed values because it show you the values from the metadata.

If I store into metadata a number with comma, you're a comma in your metadata.
If I store into metadata a number with point, you're a point in your metadata.

This is the data type that I allowed for metadata:

string — The field value must have a string value.
enum — The field value must have one of the allowed values specified in
the values entry. In the Metadata panel, allowed values are shown as a
pop-up menu for the field.
url — The field value must have a string value. In the Metadata panel, the
text field is acccompanied by a button that treats the text value as a URL,
opening it in the user’s preferred web browser.


So I can't store a number. The unique possibility is to rewrite the number depending the system locale like I made on the try.

What do you think ?
One could do it with printf and sprintf in c++. Take a look at http://stackoverflow.com/questions/14753505/c-c-printf-use-commas-instead-of-dots-as-decimal-separator.

Hope this helps.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 27, 2014, 06:59:53 PM
I've moved the info text to tooltips, what do you think ?

Good decision! But this may call for redesign: Button aligned left to text as in other export options. See Export to Hard Drive.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 27, 2014, 08:37:14 PM
- Text field for "Active Options" in LR's Metadata section can be edited/changed. Why?
- Change string "Active Options" to "Arguments" like it's named in Module Manager.
- Capital leading letters in Metadata section
ISO overlap -> ISO Overlap
Noise level -> Noise Level
...

German strings (tbc):
Code: [Select]
"$$$/ML/Metadata/ISOdifference=ISO-Differenz"
"$$$/ML/Metadata/DynamicRange=Dynamikumfang"
"$$$/ML/Metadata/DynamicRangeOrig1=Dynamikumfang (src1)"
"$$$/ML/Metadata/DynamicRangeOrig2=Dynamikumfang (src2)"
"$$$/ML/Metadata/SemiOverexposed=Semi-overexposed"
"$$$/ML/Metadata/DeepShadows=Deep shadows"
"$$$/ML/Metadata/ISOoverlap=ISO-Überlappung"
"$$$/ML/Metadata/NoiseLevel=Rauschpegel"
"$$$/ML/Metadata/NoiseLevelIdeal=Rauschpegel (ideal)"
"$$$/ML/Metadata/cr2hdrExec=Ausführbare Datei"
"$$$/ML/Metadata/cr2hdrVersion=Version"
"$$$/ML/Metadata/cr2hdrArgs=Parameter"
"$$$/ML/Metadata/cr2hdrISORange=ISO-Bereich"


"$$$/ML/Metadata/TagsetTitle=Dual-ISO"
"$$$/ML/Metadata/TagsetDICTitle=Dual ISO Converter"
"$$$/ML/Metadata/TagsetCLTitle=Kommandozeile"
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 27, 2014, 10:47:48 PM
- Text field for "Active Options" in LR's Metadata section can be edited/changed. Why?
- Change string "Active Options" to "Arguments" like it's named in Module Manager.
- Capital leading letters in Metadata section
ISO overlap -> ISO Overlap
Noise level -> Noise Level

1. If I set uneditable it displayed on one line and you can't read all info until tooltip are displayed (try to replace readOnly = false, with readOnly = true,)
2. I set like cr2hdr log and it's more relevant than arguments (arguments is before running, active options is what is used)
3. I'll fix typo

Good decision! But this may call for redesign: Button aligned left to text as in other export options. See Export to Hard Drive.

I don't have LR on the hand. What do you mean with Button aligned left to text ? It's already done no?

One could do it with printf and sprintf in c++. Take a look at http://stackoverflow.com/questions/14753505/c-c-printf-use-commas-instead-of-dots-as-decimal-separator.
Hope this helps.

I don't know if I can use setlocale but it can be useful! Thanks
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Luiz Roberto dos Santos on May 28, 2014, 03:34:12 AM
@kichetof

Update translation to Portuguese - BR

http://pastebin.com/raw.php?i=YE8gQgYz (http://pastebin.com/raw.php?i=YE8gQgYz)



Code: [Select]
"$$$/ML/ExportDialog/ExportMenu/Title=Magic Lantern"


"$$$/ML/InfoProvider/Bitbucket=Projeto Bitbucket"


"$$$/ML/Dependencies/ErrorTitle=~ Erro com dependências ~"
"$$$/ML/Dependencies/Error=Para esse plugin trabalhar (cr2hdr) é necessário ter dcraw e exiftool.^n^nPor favor, instale estes antes de executar esse plugin"


"$$$/ML/Import/Error=Não foi possível importar o arquivo Dual ISO!^n^nFavor sincronizar manualmente sua pasta"


"$$$/ML/ExportManager/Title=Magic Lantern Dual ISO"
"$$$/ML/ExportManager/MLTopic=Tópico para Magic Lantern Dual ISO"
"$$$/ML/ExportManager/MLDocTech=Documento Técnico"
"$$$/ML/ExportManager/Description=Este plugin permite converter uma imagem Dual ISO por meio do cr2hdr (obrigado ao a1ex) do Magic Lantern.^n^Como isso funciona :^n^n- Exporta a imagem para uma pasta temporária^n- Adiciona o sulfixo -dualiso a imagem^n- Converte a imagem com cr2hdr^n- Importa a imagem convertida dentro do mesmo catálogo do LR^n- Adiciona o rótulo DualISO^n- Adiciona a imagem convertida as mesmas coleções de sua imagem original"
"$$$/ML/ExportManager/ASTitle=Configurações Avançadas"
"$$$/ML/ExportManager/ASSuffix=Sulfixo Dual ISO ao arquivo de saída :"
"$$$/ML/ExportManager/ASLabel=Definindo o rótulo para o arquivo Dual ISO :"
"$$$/ML/ExportManager/ASCollection=Adicionar o arquivo Dual ISO a coleção ?"
"$$$/ML/ExportManager/ASCollectionInfo=Desmarcar para não adicionar à coleção da imagem original"
"$$$/ML/ExportManager/ASLog=Mantenha o arquivo de histórico de eventos depois da conversão ?"
"$$$/ML/ExportManager/ASLogInfo=Desmarque para remover"
"$$$/ML/ExportManager/ASSubfolder=Adicione o arquivo convertido para esta subpasta :"
"$$$/ML/ExportManager/ASSubfolderPL=Pasta atual"
"$$$/ML/ExportManager/ASSubfolderInfo=Deixe em branco para a reimportação na mesma pasta"
"$$$/ML/ExportManager/Keywords=Adicionar palavras-chave :"
"$$$/ML/ExportManager/KeywordsInfo=Separação por vírgula"
"$$$/ML/ExportManager/ASLabelInfo=Deixe em branco para não adicionar indicador colorido"
"$$$/ML/ExportManager/ASSummary=Mostrar mensagem após conversão ?"
"$$$/ML/ExportManager/ASSummaryInfo=Desmarque para ocultar"
"$$$/ML/ExportManager/CRTitle=cr2hdr argumentos opcionais"
"$$$/ML/ExportManager/SynopsisModuleDefault=Configurações Padrão^1"
"$$$/ML/ExportManager/SynopsisModuleCustom=Configurações Customizadas^1"
"$$$/ML/ExportManager/ExecRestore=Restaurar para padrões"
"$$$/ML/ExportManager/ASFlag=Marcar um indicador na foto original para descartá-la posteriormente ?"
"$$$/ML/ExportManager/ASFlagInfo=Deselecionar para não marcar o indicador "
"$$$/ML/ExportManager/ASTabModuleOther=Configurações gerais de módulos"
"$$$/ML/ExportManager/FETitle=Exportar Arquivo"
"$$$/ML/ExportManager/MDTitle=Metadados"
"$$$/ML/ExportManager/CRTab1=Argumentos"
"$$$/ML/ExportManager/CRTab2=Argumentos adicionais para versão 20bit"
"$$$/ML/ExportManager/CRTab3=Solucionar Problemas"
"$$$/ML/ExportManager/TTExecClassicVersion=Versão clássica"
"$$$/ML/ExportManager/TTExecExpVersion=Versão experimental"
"$$$/ML/ExportManager/TTFast=Desabilitar todas as etapas de pós-processamento (rápido, mas de baixa qualidade)^n(--mean23, --no-cs, --no-fullres, --no-alias-map, --no-stripe-fix, --no-bad-pix)"
"$$$/ML/ExportManager/TTAmaze=usar uma etapa temporária para demosaico (AMaZE) seguido de uma interpolação 'edge-directed' (padrão)"
"$$$/ML/ExportManager/TTMean=média mais próxima a 2 ou 3 pixels da mesma color da grade Bayer (rápido)"
"$$$/ML/ExportManager/TTNoCs=desabilitar esfumaçamento de chroma"
"$$$/ML/ExportManager/TTCs2=aplicar esfumaçamento de chroma 2x2 nas áreas com ruído e com serrilhado (padrão)"
"$$$/ML/ExportManager/TTCs3=aplicar esfumaçamento de chroma 3x3 nas áreas com ruído e com serrilhado (padrão)"
"$$$/ML/ExportManager/TTCs5=aplicar esfumaçamento de chroma 5x5 nas áreas com ruído e com serrilhado (padrão)"
"$$$/ML/ExportManager/TTNoBadPix=Não arrumar bad pixel (aconselhável para fotografias com estrelas)"
"$$$/ML/ExportManager/TTRBadPix=Arrumar agressivamente bad pixel, sacrificando detalhes e adquirindo mais serrilhado"
"$$$/ML/ExportManager/TTBBadPix=marcar todos os 'bad pixels' como preto (para solução de problemas)"
"$$$/ML/ExportManager/TTNoFRes=desabilitar mesclagem de alta resolução"
"$$$/ML/ExportManager/TTNoAlias=desabilitar mapa de serrilhado, usado para arrumar serrilhados em sombras profundas"
"$$$/ML/ExportManager/TTNoStrip=desabilitar conserto de faixas horizontais"
"$$$/ML/ExportManager/TTNoCompress=Sem compressão:"
"$$$/ML/ExportManager/TTCompress=DNG sem compressão:"
"$$$/ML/ExportManager/TTCompressLossy=DNG com compressão (tome cuidado, isso irá destruír os detalhes de sombra)"
"$$$/ML/ExportManager/TTSoftFilm=utilizar uma curva suave de filme para comprimir as luzes altas e aumentar as sombras, métrica por número EV^n(se você usar esta opção, você deverá  especificar o balanço de brancos)"
"$$$/ML/ExportManager/TTNoWb=Não marcar como 'AsShotNeutral'"
"$$$/ML/ExportManager/TTWbGrayMax=marcar como 'AsShotNeutral' para maximizar o número de pixels cinza (padrão)"
"$$$/ML/ExportManager/TTWbGrayMed=marcar como 'AsShotNeutral' pela mediana de R-G e B-G"
"$$$/ML/ExportManager/TTWbExif=marcar como 'AsShotNeutral' pelo EXIF WB (impreciso)"
"$$$/ML/ExportManager/TTSameLevels=Ajustar a saída do nível de brancos para manter a mesma exposição geral^npara todos os frames passados por uma única linha de comando^n(útil para previnir iluminação ocilante - para vídeos ou panoramas)"
"$$$/ML/ExportManager/TTSkipExisting=Pular a conversão se o arquivo de saída já existe"
"$$$/ML/ExportManager/TTEmbedOriginal=Copiar o arquivo original CR2 junto com o DNG de saída, e deletar o CR2 primário^nVocê será capaz de re-processar o DNG com uma versão diferente ou diferente configurações de conversão.^nPara recuperar o RAW original: exiftool IMG_1234.DNG -OriginalRawFileData -b > IMG_1234.CR2"
"$$$/ML/ExportManager/TTDebugBlend=salvar imagens intermediárias usadas para mesclagem:^n    dark.dng        the low-ISO exposure, interpolated^n    bright.dng      the high-ISO exposure, interpolated and darkened^n    halfres.dng     half-resolution blending (low noise, high aliasing)^n    fullres.dng     full-resolution blending (minimal aliasing, high noise)^n    *_smooth.dng    images after chroma smoothing"
"$$$/ML/ExportManager/TTDebugBlack=salvar imagens intermediárias usadas para substração de níveis do preto"
"$$$/ML/ExportManager/TTDebugAmaze=salvar entrada e saída AMaZE"
"$$$/ML/ExportManager/TTDebugEdge=salvar informações de debug para a interpolação 'edge-directed'"
"$$$/ML/ExportManager/TTDebugAlias=salvar informações sobre o mapa de serrilhamento"
"$$$/ML/ExportManager/TTDebugRggb=Debug para detecção automática RGGB/BGGR (requer octave)"
"$$$/ML/ExportManager/TTDebugBddb=Debug para detecção automática claro/escuro (requer octave)"
"$$$/ML/ExportManager/TTDebugWb=Mostrar o vectorscope, usado para balanço de brancos (requer octave)"
"$$$/ML/ExportManager/TTDebugIsoCurve=Curva para resultados apropriados de ISO e equilírio de pretos (requer octave)"
"$$$/ML/ExportManager/TTDebugMixCurve=Curva usada para resolução média de mesclagem (requer octave)"
"$$$/ML/ExportManager/TTDebugFullresCurve=Curva usada para resolução inteira de mesclagem (requer octave)"


"$$$/ML/Publish/Progress=Exportando ^1 fotos para cr2hdr"
"$$$/ML/Publish/Progress/One=Exportando uma foto para cr2hdr"
"$$$/ML/Publish/Error=Não foi possível exportar ^1 para cr2hdr! Erro #^2^"
"$$$/ML/Publish/AlreadyConvertTitle=Corretamente tratado"
"$$$/ML/Publish/Error/NotRaw=Somente é permitido exportar para cr2hdr fotos em RAW"
"$$$/ML/Publish/Finish=cr2hdr exportação terminada"
"$$$/ML/Publish/NoPhotoExported=Nenhuma foto pôde ser exportada"
"$$$/ML/Publish/NbPhotoExported=^1 foto pôde ser exportada com sucesso"
"$$$/ML/Publish/NbPhotosExported=^1 foto pôde ser exportada com sucesso"
"$$$/ML/Publish/Finish/NoImage=Sem imagem"
"$$$/ML/Publish/Finish/AlreadyConvertTitle=Corretamente tratado^1"
"$$$/ML/Publish/Finish/NotRawTitle=Formato errado^1"
"$$$/ML/Publish/Finish/NoError=Sem erros"
"$$$/ML/Publish/Finish/Success=Convertido^1"
"$$$/ML/Publish/Finish/noDual=Sem DualISO^1"
"$$$/ML/Publish/Finish/Error=Erro^1"


"$$$/ML/Metadata/ISOdifference=Diferença de ISO"
"$$$/ML/Metadata/DynamicRange=Alcânce Dinâmico"
"$$$/ML/Metadata/DynamicRangeOrig1=Alcânce Dinâmico (src1)"
"$$$/ML/Metadata/DynamicRangeOrig2=Alcânce Dinâmico (src2)"
"$$$/ML/Metadata/SemiOverexposed=Semi-superexposto"
"$$$/ML/Metadata/DeepShadows=Sombras profundas"
"$$$/ML/Metadata/ISOoverlap=Sobreposição de ISO"
"$$$/ML/Metadata/NoiseLevel=Nível de Noise"
"$$$/ML/Metadata/NoiseLevelIdeal=Nível de Noise (ideal)"
"$$$/ML/Metadata/cr2hdrExec=Executável"
"$$$/ML/Metadata/cr2hdrVersion=Versão"
"$$$/ML/Metadata/cr2hdrArgs=Opções ativas"
"$$$/ML/Metadata/cr2hdrISORange=Alcânce de ISO"


"$$$/ML/Metadata/TagsetTitle=Dual ISO"
"$$$/ML/Metadata/TagsetDICTitle=Dual ISO Converção"
"$$$/ML/Metadata/TagsetCLTitle=Linha de Comando"


"$$$/ML/Metadata/PresetDICTitle=Dual ISO Converter (cr2hdr)"
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 28, 2014, 07:28:17 AM
I can use setlocale http://lua-users.org/wiki/LuaLocales I'll try!

Thanks Luiz for your great works! I removed _br.txt because there are only PT translation in LR. it's work for you? Or only _br.txt works?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: rpt on May 28, 2014, 03:43:01 PM
I can use setlocale http://lua-users.org/wiki/LuaLocales I'll try!
U da man!  :)

Again, thank you for the plugin. :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Walter Schulz on May 29, 2014, 02:23:29 AM
1. If I set uneditable it displayed on one line and you can't read all info until tooltip are displayed (try to replace readOnly = false, with readOnly = true,)
2. I set like cr2hdr log and it's more relevant than arguments (arguments is before running, active options is what is used)
Points taken.

I don't have LR on the hand. What do you mean with Button aligned left to text ? It's already done no?
A little mock-up:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2Ftbqno4eir%2FBild_13.jpg&hash=c63f5be80493632761ba47519d35568c) (http://postimg.org/image/tbqno4eir/)

Ciao
Walter
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on May 29, 2014, 09:02:01 AM
It looks good!

I've committed all theses changes! Upon my return, I'll investigate for locale number and cr2hdr options to use local exec of dcraw and exiftool (if you know how to made all theses changes, you're welcome! (https://bitbucket.org/hudson/magic-lantern/pull-request/489/cr2hdr-try-to-use-local-dcraw-exiftool))

No more changes until I get back from my holidays!  8)

Manhattanhenge & BH powered!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: rpt on May 29, 2014, 03:27:35 PM
No more changes until I get back from my holidays!  8)

Manhattanhenge & BH powered!
Enjoy! Expect to see dual ISO pictures posted on your return!
 :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Luiz Roberto dos Santos on May 31, 2014, 02:04:50 AM
Thanks Luiz for your great works! I removed _br.txt because there are only PT translation in LR. it's work for you? Or only _br.txt works?

Hi,
Yes, It works (I clone your hg, and replace with this file)... some bugs and errors, but I will fix it.
Here is the file, with minor changes:

http://pastebin.com/raw.php?i=yQQwJju6 (http://pastebin.com/raw.php?i=yQQwJju6)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on June 02, 2014, 05:26:02 PM
Off-topic discussion moved here: http://www.magiclantern.fm/forum/index.php?topic=12165.0
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on June 24, 2014, 11:36:06 AM
When I enable DNG compression, looks like the DNG is not being copied back to the original folder, and instead is being deleted.

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 30a5132 on 2014-05-07 10:34:25 UTC by a1ex:
cr2hdr: print a message when overwriting the output file

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)
--compress      : Lossless DNG compression

Input file      : C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.cr2
Camera          : Canon EOS 5D Mark III
Camera model    : Canon EOS 5D Mark III
Full size       : 5920 x 3950
Active area     : 5796 x 3870
Black borders   : 124 left, 80 top
Black level     : 2045
ISO pattern     : BddB RGGB
White levels    : 13273 13787
Noise levels    : 7.15 4.31 4.30 7.06 (14-bit)
ISO difference  : 3.00 EV (800)
Black delta     : 1.47
Dynamic range   : 11.35 (+) 10.68 => 13.68 EV (in theory)
AMaZE interpolation ...
Amaze took 2.57 s
Edge-directed interpolation...
Semi-overexposed: 28.92%
Deep shadows    : 37.36%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 5.4 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 46.37 (20-bit), ideally 46.38
Dynamic range   : 13.92 EV (cooked)
Black adjust    : -13
AsShotNeutral   : 0.38 1 0.84, 9850K/g=0.98 (gray max)
Output file     : C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.DNG
C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.DNG: copying EXIF from C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.cr2
Found C:\Program Files (x86)\Adobe\Adobe DNG Converter.exe
Compressing C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.DNG...
start "" /wait "C:\Program Files (x86)\Adobe\Adobe DNG Converter.exe" -dng1.4  -o "C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.DNG" "C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.DNG.DNG"


The summary message says the CR2 hasn't been processed.  If I don't use DNG compression, everything works fine.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: camagna on June 24, 2014, 11:47:27 AM
Yes, I can confirm. DNG compression option doesn't work.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on June 25, 2014, 12:06:56 AM
Hum ‽
I think that DNG Converted compress a temp picture that doesn't exist

Code: [Select]
start "" /wait "C:\Program Files (x86)\Adobe\Adobe DNG Converter.exe" -dng1.4  -o "C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.DNG" "C:\Users\Audionut\AppData\Local\Temp\090B874C-CC57-43F6-85B3-51ACAD3745DB\_46A6164-dualiso.DNG.DNG"

Called after cr2hdr conversion and I think LR remove this temp file before DNG Converter (because it's not called by LR but by cr2hdr like --same-levels).

It seems to be the right folder and so the right file (not deleted‽) maybe I need to copy the .DNG.DNG file into LR if you use --compress ?

Maybe I need to rethink how I export picture for cr2hdr and maybe not use temp file. Any ideas?

Unfortunately I don't have too much time at the moment.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: philmoz on June 25, 2014, 01:09:20 AM
I did a quick test on OS/X and the compressed DNG does get created; but with the wrong output filename.

For example if I issue a command like:
  "Adobe DNG Converter" -dng1.4 -o "/somepath/fileneme.DNG" "/somepath/filename.DNG.DNG"

I end up with an output file called:
  /somepath/"/somepath/filename.DNG"

In other words the file is in the correct directory; but the filename includes the directory path in the name (OS X allows forward slash characters in filenames).

Perhaps the Adobe DNG Converter is expecting only a filename for the -o parameter; not a full path.

Will test on Windows when I get a chance.

Phil.

Edit:
Checked the Adobe documentation for the converter - the '-o' parameter only accepts a filename, not a full path. It defaults to saving the output into the same directory as the input file. The '-d' parameter can override the output directory.

On OS/X it creates a badly named file as I outlined above, on Windows the converter silently fails and produces no output.

Still figuring out the whole mercurial pull/branch mechanism so in the meantime here's a diff patch that fixes the problem for me (only tested on OS/X so far).
Code: [Select]
diff -r 30a513223c01 modules/dual_iso/adobedng-bridge.c
--- a/modules/dual_iso/adobedng-bridge.c        Wed May 07 13:34:25 2014 +0300
+++ b/modules/dual_iso/adobedng-bridge.c        Wed Jun 25 18:46:37 2014 +1000
@@ -92,6 +92,15 @@
     snprintf(tmp, sizeof(tmp), "%s.DNG", source);
     rename(source, tmp);
     
+    // Find filename part only, '-o' parameter to DNG converter does not accept path
+    const char *src_filename = strrchr(source, '/');
+    if (!src_filename)
+        src_filename =  strrchr(source, '\\');
+    if (!src_filename)
+        src_filename = source;
+    else
+        src_filename++;
+
     char compress_cmd[1000];
     char* start =
 #if defined(WIN32) || defined(_WIN32)
@@ -99,7 +108,7 @@
 #else
     "";
 #endif
-    snprintf(compress_cmd, sizeof(compress_cmd), "%s\"%s\" -dng1.4 %s -o \"%s\" \"%s\"", start, adobe_dng, lossy ? "-lossy" : "", source, tmp);
+    snprintf(compress_cmd, sizeof(compress_cmd), "%s\"%s\" -dng1.4 %s -o \"%s\" \"%s\"", start, adobe_dng, lossy ? "-lossy" : "", src_filename, tmp);
     printf("%s\n", compress_cmd);
     int r = system(compress_cmd);
     if(r!=0)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on July 01, 2014, 01:43:57 PM
Only just noticed your edit phil.  Confirmed working on windows.

For pull requests, check this (http://www.magiclantern.fm/forum/index.php?topic=7940.0) and this (http://www.magiclantern.fm/forum/index.php?topic=10774.0).

Suggest you put comments in this tag.
Code: [Select]
/* Comment */
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on July 18, 2014, 09:01:48 PM
Hi Kitchehof and @Alex.
So, I was getting some really good results with dual iso film in 3x crop mode and started converting in lightroom. dualiso dng - regular dng;s. Macbook pro 13 inch , mavericks.
Problem occured with a white stripe at the bottom at every third dng or so(see included picture). I think this has been going on for a while in the binary. I tried MLV mystic and an earlier version of OSX_cr2hdr and those hasn,t got this problem. The stripe causes flicker. Is there a fix?

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs8.postimg.org%2F3wcm37l2d%2Fimage.png&hash=a571f3a4a5e0608dfc0d5e22b88e4993)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs8.postimg.org%2F49926i9np%2Fimage.png&hash=3dae1f9fe9677de34b44c7c58ef7c9c3)


Thanks
//Daniel

Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 15, 2014, 08:49:51 AM
Hi Kitchehof! Question. There was some talk of having the option of "same levels" in the app for when converting dual iso movie sequences. What about it? Is there a slight possibility for you to look into it? It would take care of the flickering which randomly occur in the processed files now.
Thanks man.
//D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 15, 2014, 06:42:25 PM
Hi Danne,
I need to see how to integrate it into LR... Actually I use the processing step from LR, so one picture at once. To use same-levels, I need to know all picture names with folder to launch the command like this : cr2hdr --same-levels /path/img1.cr2 /path/img2.cr2 /path/img3.cr2 and not cr2hdr --same-levels /path/img1.cr2 && cr2hdr --same-levels /path/img2.cr2.

Unfortunately, I didn't had much time the last few months. I hope I'll have more free time in september for found a way to use same-levels :)

Maybe there're a way to loop into exportContext to retrieve path and filename (<-- this is a note for my brain :)))
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 15, 2014, 06:55:59 PM
Nice to hear from you Kitchehof :)
I made my computer sweat for few days runing a lot of dual iso dng:s. It so so easy with the lightroom app.
Have you also noticed the pixelated border? (White stripe at the bottom). It only shows in dual iso movie files, not in stills.
Have no idea if that can be fixed or not.
Thanks for answers.
/D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 15, 2014, 07:00:09 PM
uh ‽ I don't know what the problem ! Maybe try to convert your dual-iso with cr2hdr in the Terminal and compare both :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 15, 2014, 07:28:22 PM
Yea I tried another converter and the problem is in the cr2hdr binary I think. I showed this in my reply #371 here :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 15, 2014, 08:49:21 PM
Could you run cr2hdr without any parameters and no pictures. Tell us the 2 version of the binary :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 16, 2014, 12:36:28 AM
Hi Kitchehof!

Here is the original file 2560x1090 3x zoom mode

https://drive.google.com/file/d/0B4tCJMlOYfirOWtiSWstNWUteVk/edit?usp=sharing

With both lightroom binary (310e39f on 2014-02-27) and other tools like cr2hdr 2.0 (2f4e2df 20113-12-02) for mac put together from A.D I get a thin white line at the bottom. Earlier versions than 2f4e2df 20113-12-02 seems not to have the problem.
https://bitbucket.org/a_d_/magic-lantern/downloads/

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fvsny34yy9%2FSka_rmavbild_2014_08_16_kl_00_25_05.png&hash=0076f5a50f32180828eee41cf5e93d31)

Here,s some text from the mac app 2.0. It says cr2hdr version 2f4e2df 20113-12-02 (gives a white line at the bottom)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs7.postimg.org%2F5832lm1rv%2Fcr2hdr_2_0.png&hash=d34d463ce2f27445e557ecf34868e4c8)

With an older mac app, 1.4 I don,t get any white lines. Couldn,t find out what cr2hdr version. No white line with MLVmystic either which are giving the best fullres results at the moment.

No white line

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Flwmv3ht69%2FSka_rmavbild_2014_08_16_kl_00_25_26.png&hash=fae36b1fcf07a2bcc9eb0ba2684c7bab)

text from 1.4 version(no white line)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs16.postimg.org%2Fytjmvspl1%2Fcr2hdr_1_4.png&hash=143b5847a87f946df5be08431a5881a5)

Conclusion. Something happened with the later binary versions, probably starting from this version 2f4e2df 20113-12-02 and it shows when converting dual iso movie files in 3x zoom mode every now and then. Could this be fixed you think?


/D



Title: Re: Lightroom plugin cr2hdr v2.1
Post by: ayshih on August 16, 2014, 02:30:07 AM
First, don't use a cr2hdr built in 2013(!)

Second, don't refer to "2.0" and 1.4" when referring to the version of cr2hdr, because it's not versioned like that.  I presume you are referring to the version of the Lightroom plugin, but that doesn't immediately reveal what version of cr2hdr is actually being used.

Third, please do what kichetof suggested: in your two cases with different behavior, run the respective cr2hdr executables from Terminal, without giving it any input files.  The first few lines should look like:
Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: f381b87 on 2014-07-06 09:46:41 UTC by phil:
Fix output (-o) filename value passed to Adobe DNG Converter wh...

No input files.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 16, 2014, 07:42:54 AM
I don, t know how to execute from terminal. This is my way of trying to explain.
I provided the original dng. My point is that after the 2013 date that I found ALL cr2hdr versions I used are giving a strange white bottom line when converting dual iso movie files filmed in 3x mode. Not in every picture. It comes and goes about avery third or fourth picture. Both in the lightroom plugin and in the mac converter. Maybe something to do with the interpolation method, I don, t know.
If you like Ayshih or Kitchehof please run the provided original in the plugin and see for yourself.
I modified some of my text according to Ayshis response above.
Thanks Kitchehof.
//D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 16, 2014, 01:51:41 PM
@Danne
Try to use this cr2hdr binary https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.30a5132.zip (replace the binary into the LR Plugin bin folder, make a copy of the old binary, or rename it).
Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 30a5132 on 2014-05-07 10:34:25 UTC by a1ex:

Maybe it will solve your problem !
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 16, 2014, 02:34:34 PM
Thanks for sharing but no success though. Still the white bottom line.
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs27.postimg.org%2Fsj1uph9nn%2FSka_rmavbild_2014_08_16_kl_14_33_31.png&hash=f79c8038e920eb96b5d9fcd633220540)

Did you try converting the provided original to see if it gives the same result? Maybe  Have to post an issue report. Do you perhaps know where to find cr2hdr on bitbucket? Been searching.
Thanks for helping.
/D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 16, 2014, 02:42:28 PM
Here is two more. One with purple colored line. These are zoomed in crops. Any idea what is causing this?

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs22.postimg.org%2F6qrh0ztap%2FSka_rmavbild_2014_08_16_kl_14_42_13.png&hash=99ef6de0c6e8069d79e8a12e189d1f7c)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs22.postimg.org%2Fxd3xpyxht%2FSka_rmavbild_2014_08_16_kl_14_42_23.png&hash=5ec97179cf3ef3ce138227daf81a8333)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 16, 2014, 04:52:46 PM
I've converted your image with cr2hdr 310e39f 140227 and cr2hdr-20bit 30a5132 140507 and indeed there are on both the white line at the bottom. Strange. Maybe A1ex has a solution !
Do you try to convert a classic picture took from Dual ISO and not from a Dual ISO Movie ?

You can't found cr2hdr from bitbucket outside MagicLantern Project. You need to compile yourself from the source if you want the latest changes. Or use one of the binary compiled by A_D_ or myself.

I won't be at home for 2 weeks and without access to internet, so I hope a1ex solve this problem :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 16, 2014, 07:56:27 PM
Thanks man for listening. I, ll do some more searching on this and see what comes up.
//D
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 17, 2014, 09:22:52 AM
If someone have some times and knowledges to help me to resolve this pull request (https://bitbucket.org/hudson/magic-lantern/pull-request/489/cr2hdr-try-to-use-local-dcraw-exiftool/diff), Version 3 will come out :)

Target:

Big thanks for your great help !
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: lureb74 on August 18, 2014, 04:20:00 AM
New GUI
...
Download Source branch default (https://bitbucket.org/kichetof/lr_cr2hdr/get/default.zip) and rename the folder like cr2hdr.lrplugin or what you want.
If everything seems good, I'll release the v3 in second week of june.
...

Hi,

I just installed this version, and report this error that appear when I try to process a dual-iso image:

[string "MLProcess.lua"]:157: attempt to perform arithmetic on local 'isoFirst' (a nil value)

However, the image is created anyway, but LR stops elaborating (when select multiple files).

Hope it whould be useful, CHEERS!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on August 22, 2014, 09:06:23 AM
Hi Kitchehof. Would be possible to solve the same levels problem by using a manual setting somehow? In Alex code you can change the numbers in whitelevel. Would be sweet to have it set on "standard 50000" and then try different settings if needed.
 
Right, using --same-levels with parallel processing is a little harder (because all the files are analyzed at the end, and then it decides a white level that hopefully matches all of them). But it can be done after a regular conversion, like this:

Code: [Select]
exiftool *.DNG "-WhiteLevel<BlackLevel"
exiftool *.DNG "-WhiteLevel+=50000"

You may need to fiddle with the values though; lower the value if you get pink highlights, increase it if you think you can squeeze some more highlight detail.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 26, 2014, 11:37:19 AM
[string "MLProcess.lua"]:157: attempt to perform arithmetic on local 'isoFirst' (a nil value)

Hi Lureb74, could you post a screenshot of Dual ISO Metadata from the picture that is problematic (only if not empty) ? Could you post exif ISO ? Thanks !

@Danne
Yes this is a workaround to "fix" it ;)

To add --same-levels I need to know the list of pictures that have been selected for rendering. I need to investigate into exportContext:renditions.

I'm back from vacation and I'll have some time to try to implement this function.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: cfmcmillan on August 26, 2014, 06:00:12 PM
It seems that something is broken in the export of DNG files.  I always get the "Wrong Format" message when I try to export a DNG - while there's a dualiso file when I get done, it hasn't been converted.

OS = Win 7
LR = 5.6

Love it when it worked.  I took a look at MLExportServiceProvider.lua but I can't quite follow the logic to see what's going wrong. 
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 26, 2014, 07:48:36 PM
@cfmcmillan
Which version of plugin do you use ?
Could you check into Metadata with EXIF & IPTC selected, the row File Format ? And tell me exactly what's wrote (case sensitive!) because I don't understand why it doesn't work...
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 26, 2014, 08:18:54 PM
@Danne & all --same-levels user :)

It's sound good !

Code: [Select]
for photo in exportSession:photosToExport() do mlLog:debugf("%s", photo:getRawMetadata("path")) end
I've found the way to list pictures path before export :) now I need some time to rewrite the plugin to add --same-levels and maybe, I'll remove the export (speed enhancement) but I need some try and I don't know if I can ;)

Stay tuned!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: chris_overseas on August 27, 2014, 01:44:22 PM
Currently the amount of temp space required is about 2.5x the total size of all the dual ISO photos being converted because copies of the CR2 and DNG files are kept until the entire export is complete. Would it be possible to delete the temp CR2 and DNG files after each file is processed? I'm currently only able to process a fraction of my dual ISO photos at a time, otherwise I run out of disk space.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 27, 2014, 02:52:41 PM
@chris I'll rewrite the plugin and there were no export to temp folder. I'll use original cr2 or dng file :)

So, I need some help.

How do you think the rendering to cr2hdr:

- export all pictures to cr2hdr with args (same-levels or not) in one time, like:
cr2hdr [args...] picture1 picture2 pictureN
And after reimport one by one picture and add metadata

Or

- export one picture to cr2hdr with args (no same-levels) for each picture, like:
cr2hdr [args...] picture1

The first idea is the only possibility to use same-levels, so I'll use this for it but for pictures without this arg, I don't know if it's a good idea.

I explain: if cr2hdr crash all processed files will not be reimported into LR, because the return of the execution will fail.

So, this is my idea:

Process by batch if same-levels are selected and process individually if not selected.

What do you think?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: chris_overseas on August 27, 2014, 03:20:36 PM
I don't have any use for same-levels personally so can't really comment on that side of things, but without same-levels I'd prefer to see the files processed individually if that means less temp space is used along with more robust recovery in the event of an error.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Levas on August 27, 2014, 08:58:57 PM
Found out about the Lightroom plugin cr2hdr v2.2 BETA 6.
I am amazed by the dual iso output results by 20 bit export  :D

Is there a newer plug in version available for download and if so, where can i find the newest version ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 27, 2014, 10:18:13 PM
Actually the beta 6 is the latest :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Levas on August 27, 2014, 10:32:59 PM
Ah, so I have the latest version, in that case I'm cool  8)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 29, 2014, 07:57:41 PM
hum, I've a little problem with --same-levels for reading the log file to apply metadata...

Coding skill are welcome :)

I've a table with all path of each pictures, and I've a log file like that:

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 0eabcb0 on 2014-08-29 12:42:54 UTC by a1ex:
cr2hdr exposure matching: when all else fails, brute force prevails...

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)
--same-levels   : Adjust output white levels to keep the same overall exposure
                  for all frames passed in a single command line
                  (useful to avoid flicker - for video or panoramas)

Input file      : /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8353.CR2
Camera          : Canon EOS 5D Mark III
Camera model    : Canon EOS 5D Mark III
Full size       : 5920 x 3950
Active area     : 5796 x 3870
Black borders   : 124 left, 80 top
Black level     : 2046
ISO pattern     : BddB RGGB
White levels    : 15180 13787
Noise levels    : 8.43 6.73 6.70 8.42 (14-bit)
ISO difference  : 2.98 EV (789)
Black delta     : 3.55
Dynamic range   : 10.94 (+) 10.44 => 13.42 EV (in theory)
Looking for hot/cold pixels...
Hot pixels      : 310
Cold pixels     : 308
AMaZE interpolation ...
Amaze took 2.84 s
Edge-directed interpolation...
Semi-overexposed: 1.17%
Deep shadows    : 54.64%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 5.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 55.98 (20-bit), ideally 55.97
Dynamic range   : 13.87 EV (cooked)
Black adjust    : -25
AsShotNeutral   : 0.47 1 0.68, 5867K/g=1.05 (gray max)
Output file     : /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8353.DNG
/Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8353.DNG: copying EXIF from /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8353.CR2

Input file      : /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8354.CR2
Camera          : Canon EOS 5D Mark III
Camera model    : Canon EOS 5D Mark III
Full size       : 5920 x 3950
Active area     : 5796 x 3870
Black borders   : 124 left, 80 top
Black level     : 2046
ISO pattern     : BddB RGGB
White levels    : 10086 13785
Noise levels    : 7.30 6.70 6.70 7.28 (14-bit)
ISO difference  : 1.98 EV (394)
Black delta     : 5.47
Dynamic range   : 10.23 (+) 10.65 => 12.63 EV (in theory)
Looking for hot/cold pixels...
Hot pixels      : 23
Cold pixels     : 340
AMaZE interpolation ...
Amaze took 2.80 s
Edge-directed interpolation...
Semi-overexposed: 1.33%
Deep shadows    : 23.53%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 5.3 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 99.76 (20-bit), ideally 97.64
Dynamic range   : 12.33 EV (cooked)
Black adjust    : -97
AsShotNeutral   : 0.52 1 0.64, 5145K/g=1.13 (gray max)
Output file     : /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8354.DNG
/Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8354.DNG: copying EXIF from /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8354.CR2

Equalizing levels...
/Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8353.DNG: 8185 ... 40345
/Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8354.DNG: 8190 ... 40350

How can I read this log file to apply metadata to each picture ? Each log "block" are delimited by a return before "Input file".

This is the actual parse log file function (thanks akry!):
Code: [Select]
-- parse logfile to read info
function MLProcess.parseLogFileToArray(filename)

local logFileOpen = assert(io.open(filename, 'r'))

local logfile = logFileOpen:read("*all")
logFileOpen:close()

info = {}
info_index = {}

-- parse cr2hdr output for "xxx : yyy" and store keys/values in temp_t
for k, v in string.gmatch(logfile, '%s*([%w%s-]+)%s*:%s*([%S ]+)%s*') do

k = MLProcess.trim(k)

-- there are duplicating keys in output (for instance, "Dynamic range")
if info[k] ~= nil then

local t = k
info_index[t] = info_index[t] + 1
k = k .. info_index[t]

else

info_index[k] = 1

end

info[k] = MLProcess.trim(v)

end

return info

end

Maybe return an array with log info ?
Feel free to pull request into the main repo !

Thanks a lot for your help!
Tof
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Levas on August 29, 2014, 08:04:31 PM
Don't know if I'm correct, but the way I read it, there is no log for "same levels" with the settings to apply to another picture.
Description says  "for all frames passed in a single command line".
It just needs all filenames of a serie in one single command line.




Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 29, 2014, 09:43:01 PM
The only way to obtain log file from cr2hdr is to redirect stdout to a file. Or another way, add an option into cr2hdr to log like : --logfile

If you observe my log file, they are 2 dual iso files, this is my command:

Code: [Select]
cr2hdr --same-levels /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8353.CR2 /Users/tof/Documents/MagicLantern/Dual ISO try/_MG_8354.CR2 > /Users/tof/Documents/MagicLantern/Dual ISO try/log.txt
I'll see to add a function log file to cr2hdr exec (if my knowledges are enough!), it's more simple to treated after
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 29, 2014, 11:29:38 PM
Maybe I've a solution, parse the log file and extract the filename like _MG_1234.CR2 from Input file and use it as a key like:

Code: [Select]
info[_MG_1234.CR2][k]
So, in the loop, if I read "Input file" change the key with this value (functional for one or more file)

What do you think ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on August 30, 2014, 12:32:19 AM
Would it be easier to process all of the files multithreaded through cr2hdr, and then run your own exiftool processing (with it's log file) afterwards?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on August 30, 2014, 12:49:49 AM
Would it be easier to process all of the files multithreaded through cr2hdr, and then run your own exiftool processing (with it's log file) afterwards?

That's exactly what I think now. Use cr2hdr --same-levels photoN and after that, loop into log file to add exif.

I'm currently writing the new processus to add --same-levels, and I resolve some interrogation progressively (and add a lot of interrogations too!)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Levas on September 01, 2014, 07:23:50 PM
I'm wondering what is the best approach for developing the exposure for dual iso files:

I usually take a good look at the histogram and then adjust the following:
Lift exposure by 2 to 4 stops
Compress the highlights using the highlight slider (putting it to -50 to -100)
Raise the shadows with the shadow slider (putting it to +50 to +100)
Normally I never use the black and white sliders (I mean the two sliders below the highlights and shadows sliders  ;) , don't know if they are called like this in the english version...)

Recently I saw on youtube a whole different approach.
This guy used the curves tab and raised the darks and shadows with the sliders available there.
I tried this too, but I didn't like the result, pushing the shadow slider in curves tab, creates some really flat looking shadows, too less tones for my tastes.

Now I'm curious how other ML users develop their dual iso files, how do you develop you're exposure in lightroom ?
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Audionut on September 02, 2014, 12:32:38 AM
The sliders and the curves are basically the same thing, just the curves will give you more control.

I tend to rely on the histogram, placing everything in the correct zones (http://dpanswers.com/content/tech_zonesystem.php).  Which usually means having the highlight slider close to -100, and the shadow slider at + some value.
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: lureb74 on September 08, 2014, 01:31:44 PM
Hi!
I don't know if anyone already reported it, but I have a couple of weird aspects to report about the LRplugin (in order of relevance):

- In my pc I have the temp and applications cache folders setted on a RamDisk (for drastic speed improvement and to avoid tons of read-write cycles to SSD, and I suggest people considering this!), so this plugin is setted to use the default user temp folder, right? Is it possible to put an option for choosing a custom temp path? I'm shooting Dual-ISO clips (even 2.5k), so the problem is the RamDisk is getting full too soon (I can maintain only a 4GB RamDisk, due to the total amount of ram I have installed)! Also, I'm wondering why the plugin makes a temp copy, it couldn't make the job leaving the files in the original path?

- The "Compress" option doesn't work well: it makes the job in the temp folder, but after that it deletes the temp folder without copying the results in the original path, so there's no final file!

- If I try to enbed the original CR2 (in case of video, changing the extension from DNG to CR2 before conversion), the original CR2 file is not deleted.

- the "skip-existing" option doesn't produce any difference. I think without flagging it, the plugin should overwright existing files (or at least ask to do so).

Thank you,
Lorenzo
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on September 08, 2014, 05:51:05 PM
Hi Lureb! I'm working on the new version and nothing are exported, only converted into cr2hdr (more speed, less ram used)!!

Regarding the options for the 20bit version, I'll check it!

Work in progress! Check the commits! Lot of changes!
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on September 11, 2014, 06:33:12 AM
Hi Kitchehof! Question. Will there be a possibilty to export to a specific folder again opposed to the current one within the same folder? In early versions this was possible. Reason I ask is that Dmilligan created a "mlvfs" app simply mounting mlv files working in realtime with raw dng files.
http://www.magiclantern.fm/forum/index.php?topic=13152.0
Specifying a folder could mean being able to convert dual iso dng mounted with mlvfs directly through your lightroom app. This doesn,t work now since the fuse mount only has read permission.
I tried using an early build of yours 1.0.3 though it says It will only export raw files not dng:s but I get the feeling an updated version allowing dng conversion would work :)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: kichetof on September 11, 2014, 11:26:21 PM
Hi Danne,
Unfortunately, I can't do it.
The future release, could use --same-levels  8), use an other way for converting.

Before future release: Export CR2/DNG to temp folder with suffix, convert with cr2hdr into temp folder, reimport into LR with or without subfolder, apply metadata and all.

Future release: Convert with cr2hdr original file, reimport into LR with or without subfolder, apply metadata and all.

My problem is, I can't specify to cr2hdr an output file where I want, so, for the moment I can't use MLVFS but I'll think for a way ;)

Looks at the commits for testing the new plugin, future beta when I fix a bug with DNG files ;)
Title: Re: Lightroom plugin cr2hdr v2.1
Post by: Danne on September 11, 2014, 11:49:37 PM
Cool stuff Kitchehof :)!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 13, 2014, 11:59:45 AM
New BETA v3 available !

Check first post for download link and change logs!

Don't forget, this is a BETA, please use at your own risk!

(I made a lots, a lots and a lots of tests, but we are never too careful)



Information about DNG file. If you convert a DNG, this file is overwritten by cr2hdr and moved with suffix by the plugin and original file kept in Lightroom (but file is missing).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Stedda on September 13, 2014, 01:59:36 PM
Thanks a ton for all your efforts!  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kontrakatze on September 13, 2014, 04:00:42 PM
Hello,
to test the new version, do I need a current version of the cr2hdr package for osx and does anybody maintain this package? Mine is still from 4th of October 2013 and I can't find any newer anywhere.


Regards,
kontrakatze
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 13, 2014, 04:14:27 PM
Hi kontrakatze,
The only thing do you need on Mac, is exiftool and dcraw. You can install it with a_d_ package or manually.

cr2hdr and cr2hdr-20bit are included with the plugin ;)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kontrakatze on September 13, 2014, 04:22:49 PM
Oh, thank you! I took a look into the package and found them  :)

By the way, why do I get a message stating: "catalog has to be updated to use this new plugin"
I'm not quite sure if this was exactly what it said, as it appeared only once.

Regards,
kontrakatze
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 13, 2014, 04:45:28 PM
You received this message because you haven't updated your catalog when you have installed the plugin.

Try to disable and re enable the plugin in the Plugin manager or if it doesn't works, uninstall and reinstall it. Let me know!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 13, 2014, 05:18:44 PM
Nice work Kitchehof! I imagine you,ve been working a lot on this. Same levels working! That is goood news :)
I gave it a first try.
So, all worked fine with same levels and all dng files are converted and exiftool is doing its thing. So when I reach the end two dialogues pops up. There is also two pics missing. I think it is exiftool related.

[img=http://s21.postimg.org/h368f1d03/Screen_Shot_2014_09_13_at_16_58_58.png] (http://postimg.org/image/h368f1d03/)

[img=http://s21.postimg.org/bqhe0wp3n/Screen_Shot_2014_09_13_at_16_59_07.png] (http://postimg.org/image/bqhe0wp3n/)

[img=http://s21.postimg.org/w0epg1q8j/Screen_Shot_2014_09_13_at_17_07_40.png] (http://postimg.org/image/w0epg1q8j/)

I also tried the export trick to get several conversions going in parallell and the I got the dialogues from each export and this time with more photos missing.
I had some issues with photos gone missing when using the -overwrite_original before with exiftool but I have no idea if this is related to this.

Once again. Big thanks.

Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 13, 2014, 05:47:37 PM
Hi Danne,

Effectively, I worked hard to make it possible :)

Could you send me some informations:
- the number of pictures exported (approximatively)
- the settings of the plugin (included cr2hdr)
- the name of your picture
- the name of the log file text on your folder (generated by cr2hdr)
- where do your dualiso come from ?

I think that the problem come with the way I store the name of the log file. (rename and move)

Does the file : M22-1411_000000-M22-1411_000190-dualiso.TXT exists on the folder ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 13, 2014, 07:46:00 PM
Hi Kitchehof! With these settings I got it to work successfully, both on my desktop and from my external hard disc drive.

 - I use Mlrawviewer 1.2.3 for exporting
 - New test used 44 pictures dual iso from 5d mark 3

I use default settings and then as below.

Settings
[img=http://s14.postimg.org/acjsbw09p/Screen_Shot_2014_09_13_at_18_34_28.png] (http://postimg.org/image/acjsbw09p/)

Name of the picture
[img=http://s14.postimg.org/cwff5zntp/Screen_Shot_2014_09_13_at_18_38_35.png] (http://postimg.org/image/cwff5zntp/)

Succes
[img=http://s14.postimg.org/pmjnj2vrx/Screen_Shot_2014_09_13_at_18_36_48.png] (http://postimg.org/image/pmjnj2vrx/)

text file
[img=http://s18.postimg.org/hdj7xatud/Screen_Shot_2014_09_13_at_19_39_25.jpg] (http://postimg.org/image/hdj7xatud/)

I managed to reproduce some problems when I erased the suffix of dual iso output file. Plugin wasn,t to happy about that.

Erasing suffix gave me most of my pics but also some random stops. Not sure but it happens in the end and probably exif tool related.
Will try this tool some more and report back.
Massive thanks on great efforts made here!!

[img=http://s24.postimg.org/kuzp4p5kh/Screen_Shot_2014_09_13_at_19_04_05.png] (http://postimg.org/image/kuzp4p5kh/)

[img=http://s24.postimg.org/xvbg14s4x/Screen_Shot_2014_09_13_at_19_06_07.png] (http://postimg.org/image/xvbg14s4x/)

[img=http://s24.postimg.org/3rwx96ovl/Screen_Shot_2014_09_13_at_19_06_16.png] (http://postimg.org/image/3rwx96ovl/)

[img=http://s24.postimg.org/ip5ea7241/Screen_Shot_2014_09_13_at_19_06_43.png] (http://postimg.org/image/ip5ea7241/)

[img=http://s24.postimg.org/ugt9kzwq9/Screen_Shot_2014_09_13_at_19_06_54.png] (http://postimg.org/image/ugt9kzwq9/)




Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 13, 2014, 08:26:50 PM
The minimum to get successful with the same level dual iso conversion is to "Keep the log file after conversion" ticked.
[img=http://s10.postimg.org/rtgl2akxx/Screen_Shot_2014_09_13_at_20_22_08.png] (http://postimg.org/image/rtgl2akxx/)

If not ticked this pops up
[img=http://s10.postimg.org/g1sprhqbp/Screen_Shot_2014_09_13_at_20_22_49.png] (http://postimg.org/image/g1sprhqbp/)

Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 14, 2014, 01:45:18 AM
I managed to reproduce some problems when I erased the suffix of dual iso output file. Plugin wasn,t to happy about that.

Erasing suffix gave me most of my pics but also some random stops. Not sure but it happens in the end and probably exif tool related.

Many thanks for your tests!
I need to check how I added suffix to enforce this!

The minimum to get successful with the same level dual iso conversion is to "Keep the log file after conversion" ticked.

For sure !! If I delete the log file.... I know what I need to change! Tomorrow after a good night of sleep!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 14, 2014, 12:03:10 PM
Hi Danne,

Could you replace MLProcess.lua (inside cr2hdr.lrplugin, right click, show contents package) with this corrected file (https://bitbucket.org/kichetof/lr_cr2hdr/raw/823a94de3a142af46f1db5bf08a4b265931c7933/MLProcess.lua). In my case everything works fine! (but my workflow is mainly with CR2 files. I converted to DNG from LR).

Let me know !
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 14, 2014, 12:32:41 PM
You nailed it Kitchehof! The updated  MLProcess.lua totally worked! So nice to see this. If suffix is not filled it creates a name itself. Nice. Also did not need to tick keep the log file. Will test with some freshly filmed dualiso movie files from today to see how this flow will work when converting a lot of files. I,ll report back.

Question. Is it a good idea to grey out the"add the converted file to this subfolder" when dual iso dng same levels is selected? As for now the originals are all converted and of course will not move to a subfolder for that reason. Instead creates a message "no such file or directory" if you specify a folder.

The folder containing the converted dng files needs to be synchronised after conversion since it creates a ghost duplicate of every file. It is very fast doing since they,re virtual duplicates but would be nice to have this automated if not to much trouble. Small things really. This app will be number one for dual iso movie files.

If it,s any help I uploaded 50mb of dualiso dng:s here.
https://drive.google.com/file/d/0B4tCJMlOYfirMUpoRXdjWTkyY1U/edit?usp=sharing

Thanks again.



Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 14, 2014, 12:58:13 PM
You nailed it Kitchehof! The updated  MLProcess.lua totally worked! So nice to see this.

Yeah so nice !

Question. Is it a good idea to grey out the"add the converted file to this subfolder" when dual iso dng same levels is selected? As for now the originals are all converted and of course will not move to a subfolder for that reason. Instead creates a message "no such file or directory" if you specify a folder.

Please update your MLProcess.lua file with this one (https://bitbucket.org/kichetof/lr_cr2hdr/raw/7756a687e5bfb0304ba52602461f3bc908b19de9/MLProcess.lua). I fixed the problem... :)
Mistake of my brain!

Let me know!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 14, 2014, 01:04:31 PM
So fast :). I, ll place the new lua after conversion of 30gb of dual iso movie files which is running my mac to the max in 4 parallell conversions at the moment :). Running nicely though.
Will be home again in a few hours. Coolest stuff.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kontrakatze on September 14, 2014, 01:31:49 PM
I still have a problem, which I think is not directly related to your script, but maybe you know a solution.

After importing a dualiso raw file into lightroom and conversion using your script (either way using 20-bit or classic) the dng's open fine in lightroom, but not in other programs. I very often use Photomatix for example which opens the dng's with a terrible magenta cast. To work with it I have to export the files after conversion using the dng profile from Lightroom, making a dng from a dng. I already contacted the developers of Photomatix and send them an example file. The problem seem to be some missing tags in the dngs created by cr2hdr, I guess. I don't know what to with it, but this is what they told me:

If you are going to pass on the needed tags to the Magic Lantern people, these are the missing tags:

CFAPlaneColor tag 50710
CFALayout tag 50711


The magenta cast is also visible in the finders preview. Maybe it is of some help anyhow.
By the way, your new version of the script is a huge improvement, chapeau!

Regards,
kontrakatze
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 14, 2014, 04:07:46 PM
Unfortunately, I can't do anything with this plugin to solve the "problem".

I remember a discussion about these tags (http://www.magiclantern.fm/forum/index.php?topic=7139.msg116922#msg116922) with a1ex and he said that it's optional but needed by photomatix.

I don't use photomatix but it's seem to be "easy" to add it! Looks at DNG specs and add it to chdk-dng.c

Maybe something like that (not tested, and I don't know how to to it)

Code: [Select]
CFAPlaneColor
Tag 50710 (C616.H)
Type BYTE
Count ColorPlanes
Value See below
Default 0, 1, 2 (red, green, blue) Usage Raw IFD
Description
CFAPlaneColor provides a mapping between the values in the CFAPattern tag and the plane numbers in LinearRaw space. This is a required tag for non-RGB CFA images.


CFALayout
Tag 50711 (C617.H) Type SHORT
Count 1
Value See below Default 1
Usage Raw IFD
Description
CFALayout describes the spatial layout of the CFA. The currently defined values are: 1 = Rectangular (or square) layout
2 = Staggered layout A: even columns are offset down by 1/2 row 3 = Staggered layout B: even columns are offset up by 1/2 row
4 = Staggered layout C: even rows are offset right by 1/2 column 5 = Staggered layout D: even rows are offset left by 1/2 column
6 = Staggered layout E: even rows are offset up by 1/2 row, even columns are offset left by 1/2 column
7 = Staggered layout F: even rows are offset up by 1/2 row, even columns are offset right by 1/2 column
8 = Staggered layout G: even rows are offset down by 1/2 row, even columns are offset left by 1/2 column
9 = Staggered layout H: even rows are offset down by 1/2 row, even columns are offset right by 1/2 column
Note that for the purposes of this tag, rows and columns are numbered starting with one. Layout values 6 through 9 were added with DNG version 1.3.0.0.

Code: [Select]
struct dir_entry raw_ifd[]={
    {0xC616,  T_BYTE,       4,  0x???},              // CFAPlaneColor tag 50710
    {0xC617,  T_SHORT,     1,  1},                    // CFAPlaneColor tag 50710; value: 1 to 9
}

and change

Code: [Select]
struct
    {
        struct dir_entry* entry;
        int count;                  // Number of entries to be saved
        int entry_count;            // Total number of entries
    } ifd_list[] =
    {
        {ifd0,      DIR_SIZE(ifd0),     DIR_SIZE(ifd0)},
        {ifd1,      DIR_SIZE(ifd1),     DIR_SIZE(ifd1)},
        {exif_ifd,  DIR_SIZE(exif_ifd), DIR_SIZE(exif_ifd)},
    };

with

Code: [Select]
struct
    {
        struct dir_entry* entry;
        int count;                  // Number of entries to be saved
        int entry_count;            // Total number of entries
    } ifd_list[] =
    {
        {ifd0,      DIR_SIZE(ifd0),     DIR_SIZE(ifd0)},
        {ifd1,      DIR_SIZE(ifd1),     DIR_SIZE(ifd1)},
        {exif_ifd,  DIR_SIZE(exif_ifd), DIR_SIZE(exif_ifd)},
        {raw_ifd,  DIR_SIZE(raw_ifd), DIR_SIZE(raw_ifd)},
    };

Something like that I think. It's out of my knowledges!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 14, 2014, 04:40:31 PM
Hi Kitchehof. Copy to folder works! Tried going deep in my hard drive but the "no such path" dialogoue appeared going this way. ML(hard drive)-3xdualiso-Vasteras-2014-09-14, Gideonsberg, Anna-(to folders). I think it is just to much folders.

Well, what worked was going straight to my hard drive and put the folders there.
Observations. Exiftool is not too happy about parallell conversions. In almost every txt file I get a message that white balance is not changed. But it does seem that it actually change it anyway so it could be a none issue. I observed this exiftool issue before when I ran terminal in four parallells. I checked metadata and all seemed ok though this time. Gotta to some more testing.

When queuing up and running the conversion in one big row exiftool will set the whitelevel the same on all the folders and without any white level errors.


So gotta do the 30gb test once more since I got the folder issues before. I,ll be back.

some pics
[img=http://s29.postimg.org/yulzny8nn/Screen_Shot_2014_09_14_at_16_06_52.png] (http://postimg.org/image/yulzny8nn/)

[img=http://s29.postimg.org/yvvxhdahf/Screen_Shot_2014_09_14_at_16_17_23.png] (http://postimg.org/image/yvvxhdahf/)

[img=http://s29.postimg.org/x5cwfvsyb/Screen_Shot_2014_09_14_at_16_23_26.png] (http://postimg.org/image/x5cwfvsyb/)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 14, 2014, 05:01:12 PM
Hi Danne,

If I understand right, you have specified a subfolder and you had a problem with this folder: ML(hard drive)-3xdualiso-Vasteras-2014-09-14, Gideonsberg, Anna-(to folders) ?

Could you paste the entire path ? Maybe there are some illegal char or it's too long or ... I don't know!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 14, 2014, 05:13:58 PM
Yes, thats right. I, ll get the path in a while, not at home :).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 14, 2014, 07:23:44 PM
Hi again! Had another go and directly to hard drive disc.

Didn,t get the multiple conversions to work fully and tried exporting a converted dng sequence with mlrawviewer but it was flickery so the exiftool command was random in multiple conversions. Will try in one long go as well.

What I did now, I select three folders and run the plugin, then three new folders, etc, etc and let them run in parallell. In total around 5000 dng:s lined up in 4 queues.
[img=http://s15.postimg.org/ftxyoyz07/Screen_Shot_2014_09_14_at_19_12_45.png] (http://postimg.org/image/ftxyoyz07/)

This is the path but I don,t think that is the problem here. The multiple conversion method works when same levels is not selected so it has to be exiftool related.
Last login: Sun Sep 14 19:16:56 on ttys000
Daniels-MacBook-Pro:~ Daniel$ /Volumes/ML/cr2hdr /Volumes/ML/cr2hdr/M14-1012_DNG_000001 /Volumes/ML/cr2hdr/M14-1014_DNG_000001 /Volumes/ML/cr2hdr/M14-1015_DNG_000001 etc, etc.
 
I didn,t try running this as one long row but one killer feature with this plugin is being able to run multiple folders through lightroom.
A solution could be to be able to run the dng:s with cr2hdr without the same level command in the first run and in second step apply the exiftool same level command in one long row wich seems to suit exiftool better?

Thanks for listening Kitchehof, and for all hard work.

error codes:

[img=http://s15.postimg.org/mbgv8h9dj/Screen_Shot_2014_09_14_at_19_01_29.png] (http://postimg.org/image/mbgv8h9dj/)

[img=http://s15.postimg.org/43k17l67r/Screen_Shot_2014_09_14_at_19_04_03.png] (http://postimg.org/image/43k17l67r/)

Something interrups
[img=http://s15.postimg.org/t8b1l05o7/Screen_Shot_2014_09_14_at_19_04_17.png] (http://postimg.org/image/t8b1l05o7/)

[img=http://s15.postimg.org/4vmp6saev/Screen_Shot_2014_09_14_at_19_04_36.png] (http://postimg.org/image/4vmp6saev/)

Something interrups
[img=http://s15.postimg.org/uidgdsotz/Screen_Shot_2014_09_14_at_19_06_05.png] (http://postimg.org/image/uidgdsotz/)

[img=http://s15.postimg.org/83r6jtwon/Screen_Shot_2014_09_14_at_19_11_40.png] (http://postimg.org/image/83r6jtwon/)



Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kontrakatze on September 14, 2014, 07:57:49 PM
@kichetof: Thank you very much for your help! I can't do this as I simply don't have the knowledge, but I read the passage you were talking about. Having in mind that this happened about 6 month ago, I don't think they are going to change anything. A workaround is to export the dng from lightroom as new dng. Then the missing "optional" tags are in the new dng. Not smooth, but working.
(in the end, it is quite funny that most applications that create dng's add these "optional" flags, which makes it quite a standard?).

Regards,
kontrakatze

Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 14, 2014, 08:33:06 PM
What I did now, I select three folders and run the plugin

Okay !! Now I understand well what you're doing!
I never tried this! I'll try in the week! When I've a solution, I tell you!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 14, 2014, 08:38:59 PM
haha, ok, cool.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 15, 2014, 12:52:19 PM
Hi Kitchehof.
I,m trying to narrow down when and why my exiftool stops working. What I notice is I get errors from my external harddrive which don,t happen when files are directly on internal hd. This makes me wonder if the plugin could work as is.
What is said about exiftool overwrite command is that if something else is occupied with the file somehow these errors might occur.
So, I will try to run your plugin later today from the internal disc and let you know...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 15, 2014, 10:08:46 PM
Hi Kitchehof! Tried some multiple conversions today as suggested before. This time from internal harddrive. This worked without flaws.  Will try all 5000 dng;s later but this already makes me thinks that exiftool is not the problem here but my hard drive. Either it has some permission flaws or something else giving this random problems. Have been doing som repairs and so on and will test both internal and external drive.
Sorry for being unspecific but it is hard to test all possibilities.
Conclusion so far. The app is fully working!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 15, 2014, 10:54:03 PM
 8) 8) 8)

I like that! :)

Enjoy!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 16, 2014, 07:10:03 AM
Sucess  8) You,re app finished converting 5148 dng:s with same leves commands in multiple of four conversions without a single problem :):)
Fantastic!
I,m using Mlrawviewer to export to dng:s and your lighroom app for the smoothest conversion worflow ever.
Amazing!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 16, 2014, 07:24:16 AM
Hi Danne,

Glad to help you and make you happy  8)
I'll update the beta with corrected MLProcess.lua when I'm at home!

No more feedback?

75 downloads and one feedback, so it's stable  :D

Some translation file needs a review!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 16, 2014, 07:40:35 AM
Yeah, and I tried runnning the same level option on my external hard drive again just now and the random problems with exiftool started again. This time I,m almost certain this is a bug from apple that has to do with permission handling. Found a lot of info on this.  I,m also getting error code -50 when deleting. This flaw will make exiftool confused and actually erase files randomly.
On internal drive all is working good though.

I could try to export copy to a specific folder though. This migh work better since it doesn,t overwrite the original. I,ll get back on this.

Were are the translation files? I could check for Swedish language.

Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 16, 2014, 08:09:17 AM
The new folder didn,t take care of the problem.
Conclusion. There could be a problem with exiftool on external hard drives when --same-level is selected. Apple bug. Internal drives are ok :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 16, 2014, 06:28:34 PM
Which version of exiftool do you use?

You can find source code here (https://bitbucket.org/kichetof/lr_cr2hdr/src/7756a687e5bfb0304ba52602461f3bc908b19de9/?at=same-levels).

Feel free to pull a request on bitbucket (see explanations post from Audionut) or post here!

Thanks for your feedback!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 01:39:01 PM
Hi all! dual iso movie file conversion now works in conjunction with MLVFS workflow from here http://www.magiclantern.fm/forum/index.php?topic=13152.0

And of course with the lightroom app as well :)

This means there is no need to export mlv since they,re read straight through fuse app :). Huge timesaver
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 22, 2014, 03:13:33 PM
Hi Danne,
I read that it's huge !! :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 03:51:31 PM
Yes, and with the lightroom app as well which is terrific :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: senzazn12 on September 22, 2014, 04:27:10 PM

Yes, and with the lightroom app as well which is terrific :)

Danne is it possible for you to make a video tutorial on using MLVFS with Lightroom  on Windows? Willing to donate for the tutorial since it will be time and energy on your part.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 04:37:32 PM
Sorry, I work in mac but if you get a setup done with fuse in window it should work the same. Simply select the mlvfs folder mount. Could make a tutorial for mac.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: senzazn12 on September 22, 2014, 05:04:29 PM

Sorry, I work in mac but if you get a setup done with fuse in window it should work the same. Simply select the mlvfs folder mount. Could make a tutorial for mac.

If you could that would be great since I could get the general idea.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 07:55:24 PM
Here is a little workflow demonstration of using the mlvfs fuse app together with Kitchehofs app converting dual iso movie files. Fusion!

Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: senzazn12 on September 22, 2014, 07:59:32 PM
Here is a little workflow demonstration of using the mlvfs fuse app together with Kitchehofs app converting dual iso movie files. Fusion!


Awesome! Thanks Danne!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: swinxx on September 22, 2014, 08:33:51 PM
hi,

thank you for that great plugin, although i have a problem because my dual iso video is flickering.
plugin 3.0 alpha 1, same level option applied, used fuse on mac to import into lightroom 5 and then exported the same way as the youtube video in the previous post, imported into after effects and made no changes in acr. (applied visionlog curve)
then exported to 422prores, but video is flickering

thanks, here are some of the not converted and converted files:
https://copy.com/H6fd6AwZxy0G
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 09:27:37 PM
I looked at your files and the whitelevel same level did not apply. If you choose "keep log file after conversion" you will be able to see what happens or not with exiftool.
I also noticed some whitelevel stop in the log file with my dng:s but somehow I think exif tool worked anyway. Need some more testing though I believe.

You can drag and drop your dng on one of these droplets to be able to see the exiftool information, whitelevel and so on.
http://owl.phy.queensu.ca/~phil/exiftool/List_Exif_Metadata.zip

Meanwhile you can change white and blacklevel like this and get same level to your dng:s. Just see to it that you get rid of the old exif temp files in the folder.

Exiftool -r *.DNG "-WhiteLevel<BlackLevel" -overwrite_original
Exiftool -r *.DNG "-WhiteLevel+=50000" -overwrite_original

1 - open terminal and write Exiftool -r *.DNG "-WhiteLevel<BlackLevel" -overwrite_original then hit space once.
2 - drag your folders or a single folder containing more folders on top of the terminal command (command -r will search all folders). Hit enter. Command line will run through the DNG;s. Wait until all files are finished.
3 - run the same again but now with the other command line Exiftool -r *.DNG "-WhiteLevel+=50000" -overwrite_original hit space once.
4 - drag your same folders or a single folder containing more folders on top of the terminal command (commando -r will search all folders). Hit enter.

Terminal might be giving some warnings about not finding dng,s but the command seems to run anyway.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 09:38:46 PM
Yes, I can confirm something fishy going on with exiftool. According to txt file whitelevel can,t update dng tag data through mlv files using the fuse workflow.

Conversion works fine, exiftool has some problems and it also seems it goes into a loop.

[img=http://s29.postimg.org/3rja8n0wj/Screen_Shot_2014_09_22_at_21_33_31.png] (http://postimg.org/image/3rja8n0wj/)

[img=http://s29.postimg.org/kum245hlf/Screen_Shot_2014_09_22_at_21_34_35.png] (http://postimg.org/image/kum245hlf/)

[img=http://s29.postimg.org/vg5xg5nwz/Screen_Shot_2014_09_22_at_21_35_53.png] (http://postimg.org/image/vg5xg5nwz/)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: swinxx on September 22, 2014, 10:13:01 PM
hi,

i have tried with mlvmystic_05,
no flickering.

you can find images in the shared directory from my previous post..
greets. 
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 10:27:30 PM
Mlvmystic gives flickery files. My 2,5k video shows this. Maybe not on your specific file.
Due to gpl issues and the total lack of maintenace on the app Mlvmystic is not supported by me anymore. The latest 20bit cr2hdr binary is the better one anyway.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: swinxx on September 22, 2014, 10:34:50 PM
so one interesting finding:

i downloaded the newest exiftool from here:
http://www.sno.phy.queensu.ca/~phil/exiftool/

i showed the content of the lr plugin and changed exiftool and the lib files.

then i converted the same file agains and voila, everthing looks great now, although i get an error that a file could not be imported, but i must check again, cause the converted files are here.. i have rendered the sequence and no more flickering :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 10:43:17 PM
Are you on mac or windows? Soounds great. How do you extract exiftool binary and lib folder?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: swinxx on September 22, 2014, 10:46:48 PM
hi,
i am on a mac,
just download it,
show the content of the plugin file of the kichetof plugin, find the exiftool and libs and replace them with the downloaded files from the link provided in the previous post.

greets. for the next 5 minutes i will be in the chat if you have problems, my nick is swinxx :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 10:57:27 PM
There is a chat :)? Tried writing in the livechat but no success.
Got the files replaced as you suggested, found the through your link but still the same hickup. Did you see the textfile? WHat does it say?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 22, 2014, 11:30:52 PM
hum, I'm really surprised that change exiftool into cr2hdr.lrplugin changes anything.
cr2hdr on Mac use exiftool from $PATH and not from plugin path. I tried to pull request but I don't have the knowledges to do that properly.

Try to update exiftool from ~phil with the newest version (9.71) and try again and let me know !
I think that the problem come from exiftool, the same with your external hard drive, maybe a permission error. Could you run into a terminal ls -l on your MLVFuse folder to compare permissions and groups.

I need to try with MLVFuse but not enough time to make all try :(

@Danne, which Mac do you have ‽ soooooo fast!!!
@swinxx do you have updated MLProcess.lua from source on Beta 1 ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: swinxx on September 22, 2014, 11:38:52 PM
@kichetof:

thank you for your reply,
no i used the download link from the first post,
then i changed the exiftool to 9.71

you can have a look at all files in the shared folder,

thank you
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: swinxx on September 22, 2014, 11:40:05 PM
sadly, i have not the skills to compile for myself :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 22, 2014, 11:49:18 PM
use this one (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA2.zip) :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 22, 2014, 11:51:44 PM
Hi Kitchehof! I ran the ls -l  command on the fuse folder. Goes like this:
[img=http://s24.postimg.org/bo0cxawch/image.jpg] (http://postimg.org/image/bo0cxawch/)

Tried updating and also running the exact same plugin version as swinxx but I always get the couldn,t update the whitelevel error.

My mac is faster than the wind ;). Na, I cut out the wait in premiere pro, makes the computer look like a beast mac pro :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 23, 2014, 12:06:35 AM
Thanks Danne! Could you run the same command where dualiso files are present with exiftool temp file?

Oh shit! It looks so real! I'm waiting the new MacBook Pro generation to changes my old but lovely
MacBook Pro 2008 :D
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 23, 2014, 12:14:11 AM
New macbook pros is what we need :)

So here are  three different folders:

Original folder with mlv files
[img=http://s9.postimg.org/jr9xk30jv/image.png] (http://postimg.org/image/jr9xk30jv/)

MLD folder created in the mlv orginal folder. Also containing converted dng files
[img=http://s9.postimg.org/o1olfo5mz/image.png] (http://postimg.org/image/o1olfo5mz/)

Inside the fuse app there is also dng:s being created in the folder
[img=http://s9.postimg.org/8u8lvbdsb/image.png] (http://postimg.org/image/8u8lvbdsb/)


Might be hitting the bed now. More investigating tomorrow. Thanks again.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 23, 2014, 07:29:34 AM
Hi Danne! Thanks for your printscreens! After a little but good night I see something :)

On the second picture, inside MLD folder, your rights are rwrr (644) but... I've a doubt with cr2hdr or exiftool with permission to run into user or by system/service.
Maybe the permissions could be rwrwr (664) or rwrwrw (666). I think this is a issue with MLVFS service that allow write permission only for user but not for groups or others.

I'll read MLVFS source and fuse permission to help to solve this issue!

After reflection, cr2hdr is launched by Lightroom with user confirmation, so I think it's the command line to exiftool inside plugin that run by other than user and have no permission for write into the folder.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 23, 2014, 07:34:28 AM
Yes, I think you, re right about permission handling. Hope it could work somehow :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 23, 2014, 07:46:59 AM
MLVFS Source: main.c

ALLOW_WRITEABLE_DNGS on line 292 aren't set to true but, a comment on lines 41-43 explain a problem with write permission. Maybe try to set to TRUE and compile MLVFS! I'm not at home with no Mac under the hands! Not easy on iPhone or iPad 8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 23, 2014, 07:50:16 AM
hehe, well, I,m off to work and my compiling skills a bit weak  :P, but there is no hurry at all for me :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: dmilligan on September 23, 2014, 01:23:10 PM
#define ALLOW_WRITEABLE_DNGS
at the top of the file is enough to make it "true" because we don't do:
#if ALLOW_WRITEABLE_DNGS
instead, we do:
#ifdef ALLOW_WRITEABLE_DNGS

Though, this is not really a permissions issue.  It's impossible to actually allow writing to the "virtual" DNGs, they are generated on the fly from the MLV file, but we mark them as writeable so that AE doesn't throw an error. (I'm sort of against this, which is why there is a macro that disables it). It seems that AE doesn't actually try to write to the DNGs and falls back to using an XMP, it just wants them to not be readonly.

Danne is sort of using MLVFS in a way I never intended, that is to be writing DNGs into the MLVFS. I was pretty much intending that the only DNGs would be the virtual ones created by the MLVFS, so it's interesting to me that his method works at all.

The correct thing to do would be to have cr2hdr read from the MLVFS DNGs and then write the converted DNG somewhere else outside of the MLVFS mount directory.

I will investigate this type of workflow and see what I can come up with.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: senzazn12 on September 23, 2014, 03:57:06 PM

#define ALLOW_WRITEABLE_DNGS
at the top of the file is enough to make it "true" because we don't do:
#if ALLOW_WRITEABLE_DNGS
instead, we do:
#ifdef ALLOW_WRITEABLE_DNGS

Though, this is not really a permissions issue.  It's impossible to actually allow writing to the "virtual" DNGs, they are generated on the fly from the MLV file, but we mark them as writeable so that AE doesn't throw an error. (I'm sort of against this, which is why there is a macro that disables it). It seems that AE doesn't actually try to write to the DNGs and falls back to using an XMP, it just wants them to not be readonly.

Danne is sort of using MLVFS in a way I never intended, that is to be writing DNGs into the MLVFS. I was pretty much intending that the only DNGs would be the virtual ones created by the MLVFS, so it's interesting to me that his method works at all.

The correct thing to do would be to have cr2hdr read from the MLVFS DNGs and then write the converted DNG somewhere else outside of the MLVFS mount directory.

I will investigate this type of workflow and see what I can come up with.

I see. Aren't we basically just making physical copies of the virtual DNG's using Danne's method when we export through LR? This would reduce storage space but is great for people who like to use LR for grading their shots.

There is a save metadata function in LR. Wondering if we could use that to save the metadata of the virtual DNG's so all the settings and editing we do in LR will be the same when opening the same DNG's in After Effects.

I have used this workflow before in LR with physical DNG's and all the settings I would apply there would be the same when opening in After Effects for export. This method saves time and space instead of re-exporting the edited DNG's in LR to use in After Effects.

The reason I grade in Lightroom is because I can go through the many DNG's in an MLV clip to see which scene I want to base my color grading on. In After Effects, when you open ACR, they only give you the first DNG to do your color grading on which is not practical if it was a panning shot and you wanted to do your color grading on a scene midway through the clip. I heard there is a workaround for this by using Adobe Bridge but couldn't get it to work.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: dmilligan on September 23, 2014, 04:46:28 PM
Everything works as it should if you would like to grade through Lr and then import into AE. Lr will create XMP sidecar files (it doesn't try to write to the DNGs unless you force it to), that contain all the ACR settings you selected. When you open the sequence in AE it sees the sidecars and these settings are applied.

MLVFS allows Lr to create XMP sidecars in the virtual directory structure by passing them through and storing the actual data for them in the real filesystem (in the xxx.MLD directories). This is how I designed it and expected it to work. The data for the virtual filesystem comes from two places: real files that appear in the .MLD directory are "passthrough", and "virtual" .dng (and .wav) files that are created on the fly by MLVFS.

What throws a monkey wrench in is trying to convert dual-ISO via the Lr plugin, within the virtual file system. I did not design it to allow you to write real/converted .dng files into the virtual filesystem. The only DNGs in the virtual filesystem should be the virtual .dngs, not ones that are "real" and passed through to the xxx.MLD directory. It's actually sort of "bug" that Danne's method works at all. That is what's causing the issues with exiftool. There is a better solution, I just need to figure out what that is, and what changes need to be made to MLVFS.



OT: please don't put in full quotes of posts, the text is right above, we can read it there, it makes these threads unnecessarily long; making specific quotes to respond to specific questions is fine
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 23, 2014, 04:56:07 PM
Monkey wrench  :D :D
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 23, 2014, 05:17:38 PM
#define ALLOW_WRITEABLE_DNGS
at the top of the file is enough to make it "true" because we don't do:
#if ALLOW_WRITEABLE_DNGS
instead, we do:
#ifdef ALLOW_WRITEABLE_DNGS

Eyes stacked in the early morning  ;) no attention to def...

Okay, now I understand well what do you do with fuse!
DNG files aren't writeable.

Exiftool write into the file, so with no write access, exiftool can't do the job! I hope you will find an issue to this "bug" ;)

Thanks for your great work!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: dmilligan on September 23, 2014, 05:30:31 PM
What exactly are you trying to use exiftool to write into the file? Since I generate the DNG tags, I can make them whatever they need to be, so just let me know what that is. It is impossible to make the virtual DNGs truly writable.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: dmilligan on September 23, 2014, 10:46:46 PM
So looking at the cr2hdr code, all the --same-levels option does is set all the white levels to the same value. So, this is not needed, b/c all the virtual DNGs from MLVFS will already have the same white levels (the white level for the entire DNG sequence comes from the RAWI block, of which there is only one per MLV file).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Danne on September 23, 2014, 11:02:54 PM
The conversion from cr2hdr changes levels so they differ from one dng to the next. Not linear. Exiftool can fix this quite fast in post but since the folders contain a exif temp file for each file one have to delete all of those after conversion which is tedious with many folders.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 24, 2014, 09:37:59 AM
Hi dmilligan,

cr2hdr loop into all converted files to apply a new white level (cr2hdr source for --same-levels (https://bitbucket.org/hudson/magic-lantern/src/c01318d86416e4abf7f02360d7e5af192d339f60/modules/dual_iso/cr2hdr.c?at=cr2hdr-20bit#cl-856))

Exiftool function to change white level (https://bitbucket.org/hudson/magic-lantern/src/c01318d86416e4abf7f02360d7e5af192d339f60/modules/dual_iso/exiftool-bridge.c?at=cr2hdr-20bit#cl-121) set_white_level.

This value is applied after cr2hdr conversion, maybe you can set a tags editable for this setting ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: dmilligan on September 24, 2014, 01:15:31 PM
Ah, I see, it changes the converted files, well that seems kind of strange to me, why doesn't it just write the same white level when it writes the DNGs in the first place, rather than using exiftool afterwards?

The problem must be something strange that exiftool is trying to do when writing the file, some file operation that I haven't implemented in MLVFS perhaps. It looks like it tries to make some sort of temp file copy to write the changes into and then overwrites the original with that, instead of writing directly into the original file (this also will cause a large performance penalty too, since the whole file has to be copied). I'll try to investigate to see what exactly exiftool is trying to do.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: a1ex on September 24, 2014, 01:34:28 PM
The white level is decided after processing all frames (if the first frame has no clipped stuff in it, the white level can't be detected in advance). For video, there are several optimizations that can be made, like relying on metadata, or scanning a few key frames in advance to detect exposure and white level, and use those for the entire video file, or even implementing the deflicker algorithm in cr2hdr.

Exiftool creates a temporary file, then renames it; not sure how to avoid this behavior. If this is too slow, exiv2 is much faster (but the syntax is different).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: jpaana on September 25, 2014, 11:23:47 PM
Exiftool creates a temporary file, then renames it; not sure how to avoid this behavior. If this is too slow, exiv2 is much faster (but the syntax is different).

Also with -overwrite_original_in_place option?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: a1ex on September 25, 2014, 11:30:24 PM
Yes (see the exiftool documentation or try the time command).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: senzazn12 on September 27, 2014, 08:31:37 PM
I'm getting an error when exporting my Dual ISO DNG sequence in LR 5.6 when using the plugin Beta 3.0 V2. It says no files converted but not errors. However, when just exporting a single Dual ISO DNG in LR it converts. I'm using Win 7.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: Kapuhy on September 27, 2014, 09:14:34 PM
I started to have an issue with v3.0 BETA2 - it says task completed but no export is being done. Removing /adding back the plugin does not work. However the version 2.1 continues to work when I install it. I also noticed that removing the plugin does not clear it completely - the data is still in the Lightroom 5 Preferences.agprefs file (I suspect this is where the problem is otherwise the re-install should fix it)...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA1
Post by: kichetof on September 27, 2014, 10:58:33 PM
@Kapuhy & senzazn12
It seems that you have the same bug.
I need more informations because all works fine with me.

Could you post your settings for the plugin and an exemple of your path with filename ?
Where does come your DNG files ?

Could you check the log from Console (mac) or a log viewer (win) and post the line that start with command:
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: DeafEyeJedi on September 28, 2014, 08:20:38 AM
I believe that I am also getting the same bug and here are the post of the settings in LR5 with the latest cr2hdr 20-bit Beta 3

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm4.staticflickr.com%2F3848%2F15189189839_be532862c1_b.jpg&hash=45ed57a85a715af0cbf5ceb54a1b98ed) (https://flic.kr/p/p9dyXr)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm4.staticflickr.com%2F3919%2F15375632922_ef04ddc07b_z.jpg&hash=17ddc9b64c3d9f37beafe2b847594cf6) (https://flic.kr/p/pqG8Zm)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: kichetof on September 28, 2014, 09:37:02 AM
Ok guys,

I don't understand your problem, it works well with same settings from DeafEyeJedi.

@DeafEyeJedi could you try to launch export from folder M20-1628.MLV and not from Previous import ?

Could you post screenshot from summary dialog?
Please, tell me how do you obtain your DNG files ?
Could you check keywords? (if you have no Dual-ISO, plugin skip)
If file isn't available, plugin skip too

Could you share 2-3 dng files from your sequence ?
or
Could you share a MLV that have problem (I think you use MLVFS)

I'm not a filmmaker, so I didn't test the plugin with it, I need to test it!

For Mac Users, could you paste me the log from Console.app (located into /Applications/Utilities, search Lightroom) and I need for the moment only line start with command. Windows users are welcome too :)

like this:
Code: [Select]
28.09.14 09:28:32.236 Adobe Photoshop Lightroom 5[44598]: MLDualISO DEBUG command : exec "/Users/tof/Documents/MagicLantern/LR plugin/cr2hdr.lrdevplugin/bin/cr2hdr20bit" --amaze-edge --cs2x2 --really-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/tof/Pictures/Photographies/ML Dev/Dual ISO/_MG_12826.dng" "/Users/tof/Pictures/Photographies/ML Dev/Dual ISO/_MG_12827.dng" > "/Users/tof/Pictures/Photographies/ML Dev/Dual ISO/_MG_12826-_MG_12827.TXT"
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: Kapuhy on September 28, 2014, 06:54:09 PM
I noticed that my issue is gone when I use a different catalog - re-import the same photos and then use the v3.0 BETA2 conversion and it works. So this is most likely related to the catalog and not the plugin itself. Does the plugin modify the catalog?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: Walter Schulz on September 28, 2014, 07:14:28 PM
Sure it does!
Don't know if you have the same error: I had strange issues with directory name where the plug-in is located. It won't work properly when renamed or copied to another location. Reinstallation didn't help. I did not investigate further and never had issues after using the directory name used for the first installation.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: kichetof on September 28, 2014, 08:55:26 PM
@Kapuhy yes this plugin modify the catalog by adding a custom metadata preset!

@Walter I change a lot of time the directory and no problem appear. Do you have some special char on your path ?

My workflow is only on Mac, maybe there are some issues on Windows ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: senzazn12 on September 29, 2014, 01:41:55 AM

I noticed that my issue is gone when I use a different catalog - re-import the same photos and then use the v3.0 BETA2 conversion and it works.

Just wondering how do I change the catalog?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: Walter Schulz on September 29, 2014, 01:48:15 AM
LR basics:
File -> New catalog
and
File -> Open catalog ...
And consult help files, please.
Title: Lightroom plugin cr2hdr v3.0 BETA2
Post by: senzazn12 on September 29, 2014, 01:56:43 AM
Conversion works good for me to now after changing catalog.

Thanks Kapuhy for mentioning the fix.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: chris_overseas on September 29, 2014, 02:58:44 AM
I'm seeing the same problem. This is with an existing catalog that I've successfully processed dual ISO images in before, but using an older version of the plugin. I'm running Windows 8.1, Lightroom 5.6, and the latest version of the same-levels branch from BitBucket.

If I select a bunch of photos then Right-click on them and choose Export -> Dual ISO Converter, a "Preparing for Export" dialog and progress bar appears. Once that's finished (a few seconds with ~800 images selected), the dialog disappears and a background task/progress bar appears in the top left saying "Exporting 800 photos to cr2hdr". So far so good... but after just a second or so the progress bar hits 100% and "Task complete" is shown. A "cr2hdr export finished" dialog then appears, saying no images were converted, no errors, and all the images are listed under the "No Dual ISO" tab. Roughly 200 or so of the images are dual ISO.

My path to the plugin is "F:\Lightroom\Plugins\lr_cr2hdr.lrplugin"
My path to the images is "F:\Photos\RAW\2014\2014-09 London" (note the space). They're definitely all present in that folder and Lightroom has imported them all fine. They are all individual photos - CR2 files copied straight from the camera. No MLV/DNGs.

It doesn't seem to matter how I launch the export, though if I launch it via the File menu instead of right-click, I don't get the final "cr2hdr export finished" dialog. Other than that, the behaviour is always the same.

I haven't added any new keywords anywhere, just left it with the default "Dual-ISO".

Is there anything else you'd like me to do to help diagnose the problem? Where can I find any log files? (enabling "Keep log file after conversion" doesn't generate any log files in my photo directory).

(I haven't yet tried a fresh catalog though presumably that will work OK given it seems to work for everyone else too)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: kichetof on September 29, 2014, 08:10:56 PM
@ chris_overseas Many thanks for all these informations!

I've some troubles to identify the problem.
Maybe the problem come from the location of the pictures ‽ Not in the same drive that lightroom  ‽

If you select only one, does it work ?

@all with the problem, could you run this version (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA2-log.zip) and share the log file located in your Documents folder ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: chris_overseas on September 29, 2014, 09:31:05 PM
Sorry I forgot to mention that even selecting a single photo doesn't work for me.

Thanks for the logging version - after playing around with it briefly I think I've found the problem. It's due to the space in the directory path. Seems the filename is being wrapped in quotes twice, so the "" ends up cancelling itself out and the space becomes an issue. If I try to convert photos where there's no space in the path they convert fine.

Code: [Select]
09/29/2014 20:18:04 DEBUG I'm called before exportServiceProvider.processRenderedPhotos
09/29/2014 20:18:04 DEBUG Path: C:\Temp Folder\LOND4158.CR2
09/29/2014 20:18:04 DEBUG Path DNG: C:\Temp Folder\LOND4158.DNG
09/29/2014 20:18:04 DEBUG Path TXT: C:\Temp Folder\LOND4158.TXT
09/29/2014 20:18:04 DEBUG first: C:\Temp Folder\LOND4158
09/29/2014 20:18:04 DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --compress --wb=graymax
09/29/2014 20:18:04 DEBUG command : "start /D "F:\Lightroom\Plugins\lr_cr2hdr.lrplugin\bin" /B /WAIT /BELOWNORMAL cr2hdr20bit.exe --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --compress --wb=graymax ""C:\Temp Folder\LOND4158.CR2"" > "C:\Temp Folder\LOND4158.TXT""

It looks like there's an additional quote right at the end of the command too that should probably be removed (though I don't think it really matters).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: kichetof on September 29, 2014, 11:09:57 PM
It looks like there's an additional quote right at the end of the command too that should probably be removed (though I don't think it really matters).

Sure!!! Thanks guy!!

Could you try this version (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.2.2-BETA2-fix.zip) ?

I forget to remove escaped args for windows... shame on me :) Mac user  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: chris_overseas on September 30, 2014, 01:00:19 AM
No shame on you at all! Your efforts are greatly appreciated and I can't thank you enough for providing Windows support even though you're developing on Mac.

Your fix works, thank you. There was another problem however which meant that I kept seeing the same behaviour even with your fix in place. I ended up adding some additional logging to figure out what was going on. It turned out it was because the previous failed conversion attempts added a "no Dual-ISO" keyword to ALL the photos including the dual ISO ones, so they'd get skipped straight away :) To fix this I just deleted that keyword from one photo then synced the change across all the others; once that was done the conversion started working correctly again. Presumably everyone else who was affected by this bug will need to do the same thing.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA2
Post by: kichetof on September 30, 2014, 07:43:39 AM
Many thanks chris_overseas!

Download latest BETA3 (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.zip) with fix for windows users.

Workaround to fix unconverted pictures:

On Lightroom, select the folders where dual iso are located, search all picture by keywords = no Dual ISO and remove this keyword!

Enjoy!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: limey on October 06, 2014, 03:56:45 PM
For whatever reason, I can't this plugin to work anymore with LR 5.3. I've tried all the version from 2.2.1 to beta 3. It used to be on my export right click menu, but no longer. It is also not under the export settings window either like in some of these screenshots.

I created a new catalog and still didn't work.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on October 06, 2014, 04:13:24 PM
Hi limey, could you check into plugin manager if you have some trouble with the plugin
Open plug-in manager:
Win: Ctrl + Alt + Shift + , (comma)
Mac: Command + Option + Shift + , (comma)


If it works, you have a green circle near the plugin name.
If not, could you send me the error message from the right panel ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: limey on October 06, 2014, 07:52:44 PM
No it says enabled. On all versions I installed, it said it was enabled with no errors.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Walter Schulz on October 06, 2014, 07:59:48 PM
Are you running Windows or OS X?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: limey on October 06, 2014, 09:09:42 PM
Windows 7
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Walter Schulz on October 06, 2014, 09:16:53 PM
Maybe you have the same error I had: After renaming/changing the plug-in's folder the app won't work at all.
You had a running configuration once, right?
If so: Try using the same foldername you used there.
 
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: limey on October 07, 2014, 03:36:19 AM
Got it working:
Initially, I tried renaming the extracted plugin folder. It still didn't work.

My plugin lived in the downloads folder and that is where I am adding it to LR from as well.

I left the plugin in the downloads folder, but moved the cr2hdr.lrplugin to the Downloads folder and when I added the plugin to LR it worked.

I now see the export window when I right click as well as the extra window after the export.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on October 08, 2014, 10:00:35 AM
It's a really strange problem with Windows !
Unfortunately, I don't have Windows to try it, so I can't investigate the problem, sorry guys !
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: philmoz on October 08, 2014, 10:38:37 AM
@Walter - I have both OS X and (shudder) Windows 8.1; but can't reproduce the problem.

Tried renaming the plugin folder in windows explorer; which removed the plugin from LR - when I re-added the plugin to LR it continued to work correctly in the new directory.

Did you do something different?

Phil.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Jeff Lombardo on October 08, 2014, 08:16:13 PM
Does anyone know what ERROR #11 means in the Lightroom Plugin for OSX?

I've successfully used Dual ISO on my iMac at home but now that I'm using it on my laptop it's not working.

Please advise....
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on October 11, 2014, 11:12:13 PM
@Jeff could you share a print screen and with what settings the error come ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: 50D on October 13, 2014, 10:50:23 AM
I use Mac. I try it.

Thanks from Spain
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on October 16, 2014, 01:44:57 AM
@kichetof -- my apologies I didn't realized you responded to one of my post from weeks ago. Somehow it got buried along... anyway I still have the original MLV file as well as the DNG's (pre and post MLVFS) and I've been also noticing that your plug-in beta 3 works for most part except for when sometimes LR processing bar on top left corner freezes or does not show percentage BUT when I go into my folder and can see the cr2hdr 20-bit doing its job as usual.

Perhaps its because I'm running mavricks on a 2006 Macbook Pro.  :o

I'm still on the fence between MLVFS (works with cr2hdr-r through Automator) and your plug-in on LR5 although it can be buggy at times when using it together with MLVFS.

Thanks again for your dedication and correspondents on keeping your plug-in's useful in the long run.

Let me know if you still want the samples of my original MLV and DNG's for your own experiments!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: lureb74 on October 16, 2014, 10:33:20 PM
Hi,

The "compress" and "compress lossy" options doesn't work: no conversion at all.



I report a bug using the "same levels" option (I don't know if it is already known):

when I try to export lots of dngs (over 600) windows gives me this error message:
Win32 API error 206 ("Nome del file o estensione troppo lunga.") when calling ShellExecuteExW from AgWorkspace.shellExecute

Exporting not-so-many dngs (e.g. 90 to 400) it will be no conversion at all. It works only with less than 90 dngs!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: dwalk51 on October 20, 2014, 11:57:18 PM
I feel like I'm going crazy but maybe I'm using the program incorrectly. Whenever I run the latest BETA3, it works flawlessly but overwrites my original file, which causes lightroom to show the original as a missing file in my catalog. I'm running off a Retina Macbook OSX 10.9.5 and Lightroom 5. Any help fixing this problem? When I uninstall the BETA3 plugin and install the latest stable version, it runs just fine.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on October 21, 2014, 11:09:21 AM
I'm still on the fence between MLVFS (works with cr2hdr-r through Automator) and your plug-in on LR5 although it can be buggy at times when using it together with MLVFS.

There are some problems with MLVFS, but I don't use it. I'll try to use it to make some tests.

Thanks again for your dedication and correspondents on keeping your plug-in's useful in the long run.

:)



The "compress" and "compress lossy" options doesn't work: no conversion at all.

Which version do you use ?

I report a bug using the "same levels" option (I don't know if it is already known):

when I try to export lots of dngs (over 600) windows gives me this error message:
Win32 API error 206 ("Nome del file o estensione troppo lunga.") when calling ShellExecuteExW from AgWorkspace.shellExecute

Exporting not-so-many dngs (e.g. 90 to 400) it will be no conversion at all. It works only with less than 90 dngs!

I don't speek italian, but your problem come from Windows, because the syntax of the command line are to long. You need to split your conversion and apply same-levels after with exiftool command.

Code: [Select]
Exiftool -r *.DNG "-WhiteLevel<BlackLevel" -overwrite_original
Exiftool -r *.DNG "-WhiteLevel+=50000" -overwrite_original



I feel like I'm going crazy but maybe I'm using the program incorrectly. Whenever I run the latest BETA3, it works flawlessly but overwrites my original file, which causes lightroom to show the original as a missing file in my catalog. I'm running off a Retina Macbook OSX 10.9.5 and Lightroom 5. Any help fixing this problem? When I uninstall the BETA3 plugin and install the latest stable version, it runs just fine.

Your files are DNG or CR2 ?

Information about DNG file. If you convert a DNG, this file is overwritten by cr2hdr and moved with suffix by the plugin and original file kept in Lightroom (but file is missing).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: dwalk51 on October 22, 2014, 05:26:43 PM


Your files are DNG or CR2 ?


Ah, that's my problem. Yes, I'm using DNG files. I suppose if I'm using DualISO I'll import as CR2's and later convert to DNG if need be. Thanks.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: camagna on January 04, 2015, 09:42:28 AM
hi everybody, and most of all hi kichetof. Anyone know why development of this astonishing and extremely useful plugin has stopped? I'd be willing to pay to get some updates… Please let us know what's going on!!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on January 04, 2015, 09:12:16 PM
I second that as well @camgna & @kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on January 17, 2015, 09:06:23 AM
or not?

**assuming all is well with the current plug-in?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: camagna on January 17, 2015, 11:16:18 AM
Please kichetof, give us some news. Any news. Please.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nonax on January 24, 2015, 08:57:52 AM
Ok, so strange problem here.

When I shoot dual ISO images in portrait orientation, camera knows its portrait and rotates image accordingly.

When I import into LR, whether as a cr2 or dng file, LR knows its portrait and rotates accordingly

When I use the cr2hdr plugin to convert the dual ISO image, if its a dng, it wont rotate the image upon import. I then tested the same image but the cr2 version and the created image was rotated upon upload.

So dng does not auto-rotate after I've run it through the cr2hdr plugin (both v2.1 and 3.0BETA) for some reason.

Any ideas?

PS I want LR to import my images as DNG and not CR2 from now on (this is the first time I've tried it), because I've been told that my LR edits are stored within the DNG file, as opposed to the catalog file for cr2 (by default) or a xmp file (I would have to check the box in settings for every catalog I make - I make a new catalog every shoot)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: russellsnr on February 23, 2015, 05:56:16 PM
Hi, I put this question in the Gen Help section and was directed here so!!
I installed a new hard drive and some software including Lightroom 5
before I did anything the Dual ISO plug-in worked fine with the image below
 
showing with options but now after installing the V3.0 when I send an image to the plug-in it just converts and sends back to Lightroom!
Is this now how it should work please as I get no options to use the 20 bit that I had before.
Please before/if someone answers I have read a lot of this original posting here and it is well over my head as far as change this here and change that number there.
I use Win 7 64 bit same as I did on the old drive.
Many Thanks
Russ
SORTED
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on March 15, 2015, 06:32:44 AM
@kichetof:

Any chance for an upcoming update with @a1ex's latest 20-bit cr2hdr (http://www.magiclantern.fm/forum/index.php?topic=7139.msg141778#msg141778) to be implemented for your plugin?

Thanks.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: garry23 on March 15, 2015, 02:10:23 PM
Just to say, I updated with Alex's latest 20-bit version, by jpsimply replacing the original .exe file.

Works fine.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on March 19, 2015, 04:52:03 PM
Can this be done with Mac as well?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Danne on March 19, 2015, 06:01:25 PM
Just enter the plugin and search the folders. Binary is in there.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Mehmet Kozal on March 19, 2015, 11:22:43 PM
Quote
Can this be done with Mac as well?

I right clicked > show package contents, then replaced the files from there.

Can't confirm now if it worked though :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on March 20, 2015, 12:36:17 AM
Thanks to @garry23, @Danne, @Mehmet Kozal for their inputs.

I can confirm that by replacing the actual file (cr2hdr-20bit) with the latest update from @a1ex works just fine.

Special thanks to @N/A for the mac compile. (otherwise this attempt wouldn't have been possible)

https://vimeo.com/122699159 (https://vimeo.com/122699159)

*cheers*
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: pettermannen on March 22, 2015, 11:16:13 PM
Hi! Thanks a lot developers and others for your help and contribution here!
I have a question. When you record MLV files and want to make a HDR video via the cr2hdr lightroom plugin, do you only enable HDR video in ML or do you also enable dual iso in expo menu?
i ask this because i have self recorded mlv files with only HDR video enabled and one frame is brighter and next darker and so on. When i convert in lightroom with cr2HDR plugin i get the message that the dng´s inside the mlv´s is not dual iso files and maybe they are not. Any Idea what i do wrong? I want to make a HDR video. Best regards Petter
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on March 23, 2015, 06:07:26 AM
HDR Video works well with @Danne's cr2hdr-r (http://www.magiclantern.fm/forum/index.php?PHPSESSID=62qfnorhvir540ikr508kequb5&topic=13512.msg130562#msg130562cr2hdr) (if you are on Mac) otherwise I can't speak for Windows...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Jared on March 30, 2015, 06:28:22 AM
Hello to all...
Wondering if this plugin can work DUALISO Video , with version 3.0BETA3 ( cr3hdr - 20bit ) can not export large quantity of frames, I tried to export +300 frames, only works 1 to 1 ( maximum exported 50 frames)
is there some other way to convert amounts of frames, or am I wrong?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Walter Schulz on March 30, 2015, 06:52:16 AM
http://www.magiclantern.fm/forum/index.php?action=search
Dual-ISO batch
cr2hdr batch
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kutu on March 30, 2015, 12:16:24 PM
full-res silent pics produce dng file, and after convertion, plugin for some reason delete original dng file (but create xxx-dualiso.dng)

with cr2 files it never happens

anyone have the same issue, or how i can turn off this behaviour?
Title: LR CC
Post by: Walter Schulz on April 22, 2015, 12:02:18 AM
First test: Plug-in working in LR CC. Handling stacks easier now.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 22, 2015, 09:19:23 AM
Hello guys,

Thank you for your kind messages, it's great :)
Sorry for my absence, I had a lot of change in recent months (residential change, laptop that died, BBQ at home, GTA Online heist update ... :)).

I watched the new advances and congratulations dmilligan for porting LUA !!

I have good news, the plugin will work without modification on Lightroom 6/CC ! whew

I'll do my best to implement news for 20bit cr2hdr that a1ex has added in March.
I will also get back to level to correct various bugs, feel free to revive me, I have tendency to enjoy the sun with some beers :)

I'll try to be here a lot, like before, now that my flat is ready :)
All the bests for you!
Tof
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: vertigopix on April 22, 2015, 09:28:37 AM
Quote
BBQ at home
Vu la météo prévue pour le week-end ça va pas être possible...   :(
Donc, au boulot !  :P

Non, je rigole, content de te revoir parmi nous et bonjour depuis les hauts de Lausanne ! (où je bosse)  ;)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 22, 2015, 09:32:29 AM
Vu la météo prévue pour le week-end ça va pas être possible...   :(

Qu'importe la météo, j'ai 50cm de couvert sur la terrasse pour rester à l'abri et griller tranquille :)
Toi t'es vers chez moi quand j'y suis pas (j'ai déménagé vers le CHUV) mais je bosse à Genève.
A bientôt avec une bière :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: vertigopix on April 22, 2015, 09:42:11 AM
Excellent !   :)
Ben je suis tout près du CHUV, je bosse à la radio...
Avec plaisir pour une bière une fois !
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 22, 2015, 09:56:18 AM
je bosse à la radio...
Avec plaisir pour une bière une fois !

Excellent, je suis à 2min en voiture de la radio et je bosse a 2min à pied de la radio... (à genève), le monde est petit!
Yes on va s'organiser une petite bière un de ces 4 :)



Confirmed after more conversion, LR 6/CC no bugs :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: vertigopix on April 22, 2015, 10:14:05 AM
Hé bien moi j'habite à Mathod, je bossais à la tv à Genève et je me suis rapproché de la maison en venant bosser à la radio à Lausanne (fusion RTS aidant...)
Oui, le monde est petit...  :)
Avec plaisir et à la prochaine !

Sorry ML team for spamming in french, but kichetof and i discovered that i work near where kichetof is living ! Small word...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Danne on April 22, 2015, 06:10:24 PM
Nice to have you back Kitchehof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Walter Schulz on April 22, 2015, 06:16:48 PM
Are you able to test "Same-Levels" option? cr2hdr20 expects a single line argument containing all captures to be processed. Cannot be done sequentially.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on April 22, 2015, 06:21:21 PM
Welcome back @kichetof and we'll definitely be here to help revive you back on track!

[emoji108]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: rpt on April 23, 2015, 05:28:42 AM
+1

Kichetof, if you are looking for sun, come to my city, Pune, India. Lots of sun and lots of beer.   :P

Look forward to your next update. Very happy to do testing too.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 23, 2015, 07:58:34 AM
@Walter could you share some same-level pictures, I don't know if I've a batch of them! :)
When LR will finish to recognize all the faces, I'll try!

@danne @deafeye @rpt :) happy world!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nicsut on April 24, 2015, 06:14:10 PM
I have a similar problem to limey on post 502.  Installed on Windows 7 64bit, running Lightroom 5.7, installed into plugins folder, plugin shows enabled and running (green dot showing), but no rightclick menu option nor export menu option showing.

I had initially installed the plugin from another folder, I was in a rush and put it in the wrong folder, and now for the life of me cannot remember which folder I had put it in, so limey's solution does not work for me.  Any suggestions ...?!

Thanks in advance for you help.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Audionut on April 25, 2015, 04:49:14 AM
@Walter could you share some same-level pictures, I don't know if I've a batch of them! :)

This should be the 2 images I shared with a1ex way back when.

https://dl.dropboxusercontent.com/u/34113196/ML/dual_iso/_46A0189.CR2
https://dl.dropboxusercontent.com/u/34113196/ML/dual_iso/_46A0190.CR2

These are from a quick fire pano with the same settings.  Before --same-levels they were rendered with different brightness.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: lintoni on April 25, 2015, 11:31:51 AM
I have a similar problem to limey on post 502.  Installed on Windows 7 64bit, running Lightroom 5.7, installed into plugins folder, plugin shows enabled and running (green dot showing), but no rightclick menu option nor export menu option showing.

I had initially installed the plugin from another folder, I was in a rush and put it in the wrong folder, and now for the life of me cannot remember which folder I had put it in, so limey's solution does not work for me.  Any suggestions ...?!

Thanks in advance for you help.

Windows Explorer does have a useful search function that should help you find the folder.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nicsut on April 25, 2015, 05:21:19 PM
Windows Explorer does have a useful search function that should help you find the folder.

Indeed it does.  And it would have helped me had I not deleted the plugin from this folder, and cleared the recycle bin.... :-o 

Really looking for a solution to the problem (other than my stupidity) on windows, of being able to change the plugin folder.  Also note that I have tried deleting the "Lightroom Preferences.agprefs" file and retrying the install, but clearly to problem lies outside of changes made on plugin install to this config file ...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: Walter Schulz on April 26, 2015, 01:05:14 AM
Had a related problem with folder naming/location. I had to use the directory name and location I used for installation or LR denied working with this module. Didn't investigate further, though.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 28, 2015, 01:45:03 PM
Unfortunately, I've never had this problem on Mac but I tested now on my windows 7 @work and I've the same problem.
Plugin is loaded without bug, but they are nothing in export context menu... I need to load plugin from the first path that I've installed it...
I'll investigate for Windows users ! :)

https://dl.dropboxusercontent.com/u/34113196/ML/dual_iso/_46A0189.CR2
https://dl.dropboxusercontent.com/u/34113196/ML/dual_iso/_46A0190.CR2

These are from a quick fire pano with the same settings.  Before --same-levels they were rendered with different brightness.

Okay, for me and my collegue, they aren't a different brightness from the 2 pictures after cr2hdr 20bit with same-level. Tried with cr2hdr 20bit 0eabcb0 and cc4340b (latest)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fv5rj660hp%2Faudionut_samelevel_compare_cr2hdr20bit_0eabcb0.jpg&hash=b6339430416fb4c1377651f3f73dfe95) (http://postimg.org/image/v5rj660hp/) (https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs29.postimg.org%2Fcgm588pc3%2Faudionut_samelevel_compare_cr2hdr20bit_cc4340b.jpg&hash=d2e0a5568225e6b3157fea0cc4ec41a8) (http://postimg.org/image/cgm588pc3/)

Metadata from 0eabcb0 (https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs28.postimg.org%2Fffio3ygnd%2Faudionut_samelevel_compare_brightness_metadata.jpg&hash=18e161bcf9d178551d5467f72aa6c413) (http://postimg.org/image/ffio3ygnd/)

Final result after cr2hdr 20bit same-level, LR panorama merge and auto tone:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs9.postimg.org%2Fh5giwjn97%2Faudionut_samelevel_LR_pano_auto_tone.jpg&hash=87bdafe8492aa799146635e6860520d1) (http://postimg.org/image/h5giwjn97/)


Are you able to test "Same-Levels" option? cr2hdr20 expects a single line argument containing all captures to be processed. Cannot be done sequentially.
This is the command when you enable same-level option:
Code: [Select]
[9936] MLDualISO DEBUG command : "start /D "C:\Users\tof\Scripts\cr2hdr.lrdevplugin\bin" /B /WAIT /BELOWNORMAL cr2hdr20bit.exe --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "E:\Mes images\Photographies\dualiso\Audionut files\_46A0189.CR2" "E:\Mes images\Photographies\dualiso\Audionut files\_46A0190.CR2" > "E:\Mes images\Photographies\dualiso\Audionut files\_46A0189-_46A0190.TXT""
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 28, 2015, 04:07:19 PM
@Windows users,

Maybe I found something... :)

Could you try it for me (on mine, it works, but I made a lot of tests...)

Edit file Info.lua under cr2hdr.lrplugin and add this after builtInPresetsDir = "presets", (line 42):

Code: [Select]
id = "",

If it doesn't works anyway, keep in place and add this on line 45 (after },):

Code: [Select]
LrForceInitPlugin = true,
final result:

Code: [Select]
LrExportServiceProvider = {
        title = LOC "$$$/ML/ExportDialog/ExportMenu/Title=Magic Lantern",
        file = 'MLExportServiceProvider.lua',
        builtInPresetsDir = "presets",
        id = "",
},
LrForceInitPlugin = true,

After some tests, it works without LrForceInitPlugin, but...

Let me know!! :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nicsut on April 28, 2015, 09:14:31 PM
@Windows users,

Maybe I found something... :)

...

After some tests, it works without LrForceInitPlugin, but...

Let me know!! :)

Firstly, a thousand thanks, for the plugin and all the effort you have put into this, and for trying to troubleshoot this issue.

I have manage tod get the menu options to show but unfortunately not with the edits to info.lua (I managed to work out where I had originally installed the plugin from...).

Neither of the additional lines affected allowed the right-click access to work.  Nor did they allow the plugin to show in the File/Export menu option, the plugin is not listed in the left hand column list.  However without either of these edits the plugin is accessible from the "Export To" dropdown list at the too of the "Export x File(s)" dialogue.

Nonetheless, your help is much appreciated.  Fantastic work!!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 28, 2015, 10:41:05 PM
Okay...
Crazy mode: another thing you can try... Try to enable/disable the plugin many times (5-10 times) and very fast! Try to reload the plugin a lot too!

Let me know!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nicsut on April 28, 2015, 11:27:00 PM
Okay...
Crazy mode: another thing you can try... Try to enable/disable the plugin many times (5-10 times) and very fast! Try to reload the plugin a lot too!

Let me know!

Tried both options several times, still no joy ...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 29, 2015, 07:01:28 AM
Tried both options several times, still no joy ...

:(
Have you try to edit Info.lua and after modifications, crazy mode?
I'll create a topic on Adobe forum, I hope somebody will help me and you! :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nicsut on April 29, 2015, 08:34:25 AM
:(
Have you try to edit Info.lua and after modifications, crazy mode?
I'll create a topic on Adobe forum, I hope somebody will help me and you! :)

Thanks once again for your super reactivity on this  :)

I believe I had let the info.lua changes in place when I tried the crazy stuff, but will check when I get back home tonight. (Will ensure that I try with and without each of the changes).

In the meantime, I have a functioning version of the plugin (albeit installed in the "wrong" folder), so I am sure you have more important things to worry about  ;D

Might just be worth a comment in the install instructions in the first post just to give a heads up that this problem exists?  And if I may be so bold, also worth a comment in the first post regarding the  DNG limitation in v3.0 BETA3?

Quote
Information about DNG file. If you convert a DNG, this file is overwritten by cr2hdr and moved with suffix by the plugin and original file kept in Lightroom (but file is missing).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 29, 2015, 09:47:12 AM
I'll solve this bug, believe me  8)

Maybe I'll remove the original DNG file... so no comment about it! :)

I've some trouble at work to login to adobe forums...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nicsut on April 29, 2015, 10:38:13 AM
I'll solve this bug, believe me  8)

I admire your tenacity - thanks  ;)

Quote
Maybe I'll remove the original DNG file... so no comment about it! :)

Personally my preference would be to retain the original file (for reprocessing by cr2hdr in the future with different options, or based on new releases of the utility).  If this is problematic to achieve with DNGs as the source, then I would modify my current workflow to not convert to DNG on import to LR, and then do the conversion to DNG (excluding any CR2s that I keyword as "Dual ISO Source") as a separate step.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: DeafEyeJedi on April 29, 2015, 10:47:37 AM
You're definitely on a roll, @kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 29, 2015, 11:04:29 AM
I admire your tenacity - thanks  ;)

:)

I retested to reproduce the bug and maybe that I found something interesting... Edit Info.lua with both modification (id and ForceInit), copy the .lrplugin to your destination path, add it to LR plugin manager and reload the plugin, close LR and voila it works well... if you could watching my head...  :o :o

Personally my preference would be to retain the original file (for reprocessing by cr2hdr in the future with different options, or based on new releases of the utility).  If this is problematic to achieve with DNGs as the source, then I would modify my current workflow to not convert to DNG on import to LR, and then do the conversion to DNG (excluding any CR2s that I keyword as "Dual ISO Source") as a separate step.

Okay, maybe it's not very easy to see what happen.
When you pass a DNG file to cr2hdr (and 20bit), the final file result to a unique DNG.

An exemple is more comprehensible :

I've in my folder 2 files: _46A0189.CR2 and _46A0189.DNG
When I pass _46A0189.CR2 with cr2hdr, this is what happen:

Code: [Select]
Input file      : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189.CR2
Output file     : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189.DNG (already exists, overwriting)



When I pass the DNG file _46A0189.DNG, this is what happen:

Code: [Select]
Input file      : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189.DNG
Output file     : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189.DNG

The original DNG dual ISO file (with banding) is overwrited by the exec.
My plugin add a suffix to the filename by moving it, so the original DNG file doesn't exist anyway, but LR keep in the catalog but there is no original file.

So, this is the final result after LR cr2hdr plugin finished:

Code: [Select]
E:\Mes images\Photographies\dualiso\Audionut files\_46A0189-dualiso.DNG

_46A0189.DNG doesn't exist, but LR keep this reference into the catalog ;) maybe I'll remove this reference, no ?

I don't know if my explainations are understandable :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: nicsut on April 29, 2015, 01:09:38 PM
I retested to reproduce the bug and maybe that I found something interesting... Edit Info.lua with both modification (id and ForceInit), copy the .lrplugin to your destination path, add it to LR plugin manager and reload the plugin, close LR and voila it works well... if you could watching my head...  :o :o

OK thanks - will try this this evening when I get home...  :)  Just for clarification, when you say "destination path" this is any new folder from which I wish to install the plugin that is not the original folder that plugin was installed from?

Quote
I don't know if my explainations are understandable :)

Very clear and understandable in terms of what happens file wise.

In terms of the catalogue however while indeed I could still see the original DNGs referenced in the (for instance) Last Import view in the Library (as you describe, they are not removed, but the file is missing), the newly created files with the "dualiso" file suffix are not visible in this view, but they are visible if I navigate through the folder structure ...   perhaps I am missing something, but not ideal from my perspective  :-\

The CR2 handling IMHO is perfect, ideally for me the DNG handling would mimic this.  As follows:

Code: [Select]
Input file                        : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189.DNG
Copy Input File to Output filename: E:\Mes images\Photographies\dualiso\Audionut files\_46A0189-dualiso.DNG
Output file                       : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189-dualiso.DNG

The target DNG dual ISO file (with banding) is overwriten by the exec, and this new file is added to the catalogue along side the original file.

Now that is just my perspective, not sure if this is achievable or is in sync with the majority of your user base  :-\
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3
Post by: kichetof on April 29, 2015, 01:46:50 PM
OK thanks - will try this this evening when I get home...  :)  Just for clarification, when you say "destination path" this is any new folder from which I wish to install the plugin that is not the original folder that plugin was installed from?

yes, the path where you want to "install" the plugin ;)

Very clear and understandable in terms of what happens file wise.

In terms of the catalogue however while indeed I could still see the original DNGs referenced in the (for instance) Last Import view in the Library (as you describe, they are not removed, but the file is missing), the newly created files with the "dualiso" file suffix are not visible in this view, but they are visible if I navigate through the folder structure ...   perhaps I am missing something, but not ideal from my perspective  :-\

Personnaly, I doesn't use the Last Imported view, I always naviguate (in LR) into the folder where I imported my raw.

The CR2 handling IMHO is perfect, ideally for me the DNG handling would mimic this.  As follows:

Code: [Select]
Input file                        : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189.DNG
Copy Input File to Output filename: E:\Mes images\Photographies\dualiso\Audionut files\_46A0189-dualiso.DNG
Output file                       : E:\Mes images\Photographies\dualiso\Audionut files\_46A0189-dualiso.DNG

The target DNG dual ISO file (with banding) is overwriten by the exec, and this new file is added to the catalogue along side the original file.

Now that is just my perspective, not sure if this is achievable or is in sync with the majority of your user base  :-\


Okay, I know what you want.
I can copy the DNG file to the destination file and use the copied files instead of the original file and process it.
That you have .DNG (original with banding) and -dualiso.DNG (cr2hdr pass) in result.

--> TODO : check!

download this alpha beta plugin (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.1.zip), don't forget, this is a BETA ! I've made a lot of tests but be careful!!

I already hear that somebody doesn't want to keep the original DNG  8) Don't worry, make some try and if everything works, I'll add an option to enable/disable the copy :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 29, 2015, 04:06:59 PM

--> TODO : check!

download this alpha beta plugin (https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels.zip), don't forget, this is a BETA ! I've made a lot of tests but be careful!!

I already hear that somebody doesn't want to keep the original DNG  8) Don't worry, make some try and if everything works, I'll add an option to enable/disable the copy :)

errm, just wow  :o :)

Didn't expect that kind of turn arround speed!!  Can't wait to get home to try 8)

Totally understand that others have other expectations - great that you can accomodate us all via an option  :)

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 29, 2015, 04:48:24 PM
UI added !
Just could not wait  8)

New link (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.1.zip) to try it!

TODO NOT POSSIBLE: remove DNG file from LR when user want it!
hum... there are no reference to remove picture from LR catalog in the SDK...

 ::) ::) 1 year after...
Unfortunately, I don't found anything to remove the photo from the catalog and I think it's a LR protection.
https://forums.adobe.com/message/3388099#3388099
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on April 29, 2015, 05:35:27 PM
Does this apply towards for Mac's as well?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 29, 2015, 06:50:18 PM
Every time for both platform!
Don't forget that I'm a Mac user :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 29, 2015, 07:52:09 PM
I retested to reproduce the bug and maybe that I found something interesting... Edit Info.lua with both modification (id and ForceInit), copy the .lrplugin to your destination path, add it to LR plugin manager and reload the plugin, close LR and voila it works well... if you could watching my head...  :o :o

Sorry, more head scratching in order... this did not work for me. :-[

Tried in the default plugin folder, and in another folder.  Still no right-click option, and does not show in export presets list, but can access via "export x files" dropdown list...  Tried with my own edits on info.lua, and with your alpha version on the dng treatment ... no joy with either  :'(

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 29, 2015, 07:57:56 PM
Try to remove the plugin. Close LR. restart LR. Close LR. Install plugin with plugin manager. Close LR and try to export :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 29, 2015, 08:00:26 PM
UI added !
Just could not wait  8)

Same link (https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels.zip) to try it!

TODO NOT POSSIBLE: remove DNG file from LR when user want it!
hum... there are no reference to remove picture from LR catalog in the SDK...

 ::) ::) 1 year after...https://forums.adobe.com/message/3388099#3388099

unfortunately I had errors on this as follows "keep original DNG after conversion" was selected:
Code: [Select]
There has been an error
Please report the problem to Magic Lantern forum
AgImportSession.addOnePhotoToLibrary: failed to import photo

followed by

Code: [Select]
Unable to Export:
An internal error has occured:
AgImportSession.addOnePhotoToLibrary: failed to import photo

sorry  ::)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 29, 2015, 08:41:39 PM
:) I like it!

Could you post the name of the dual ISO and all settings do you set to export please :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 29, 2015, 08:45:02 PM
Try to remove the plugin. Close LR. restart LR. Close LR. Install plugin with plugin manager. Close LR and try to export :)

Still no joy  :(
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 29, 2015, 09:00:12 PM
:) I like it!

Could you post the name of the dual ISO and all settings do you set to export please :)

filename = _MG_5621 2015-04-26.dng

settings: (need help, sorry - how do I post my screen capture here...? did a quick search on the [img] tag use not found the necessary syntax...)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 29, 2015, 09:21:13 PM
upload your print screen to http://postimage.org :) when upload is finished, copy the link for forum :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 29, 2015, 10:46:17 PM
upload your print screen to http://postimage.org :) when upload is finished, copy the link for forum :)

Thanks - done

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs7.postimg.org%2Foamqbo9sb%2Fcapture.png&hash=cec45bda2f6ea3ca7c81c9f2d30f6e40) (http://postimage.org/)
hébergeur d image gratuit (http://postimage.org/index.php?lang=french)

On 20bit version tab:
- soft-file set to 4
- wb=graymax
- flicker handline: same-levels selected

On troubleshooting:  nothing selected

Hope this helps!

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 29, 2015, 10:59:06 PM
Have you this file on your windows folder : _MG_5621 2015-04-26-dualiso.dng ?
Could you try with same-level unchecked please :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 29, 2015, 11:32:23 PM
Have you this file on your windows folder : _MG_5621 2015-04-26-dualiso.dng ?
Could you try with same-level unchecked please :)

OK in fact this is a file that I had previously converted the other day, so the -dualiso.dng already existed.  Folder contents as follows:

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs28.postimg.org%2F6tbtjdwz1%2Ffiles.png&hash=dcf4f0e92ba358d4da5738dcbc74cac5) (http://postimage.org/)
photo libre (http://postimage.org/index.php?lang=french)

So a -dualiso-2 was created.  Perhaps ideally there would be an option to allow either overwrite of existing -dualiso.dng(s), or creation of new variant ...

But guess what - success with same-level unchecked -dualiso-3.dng created, no error messages, and dualiso-3 acessable in the catalogue ;D   Excellent!!  Folder contents as follows:

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fmckp9bryp%2Ffiles2.png&hash=fbe3016e84def393dbd0ac7a2b12c807) (http://postimage.org/)
téléchargement de photos (http://postimage.org/index.php?lang=french)


Contents of _MG_5621 2015-04-26-dualiso-3.TXT as follows:
Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 0eabcb0 on 2014-08-29 12:42:54 UTC by a1ex:
cr2hdr exposure matching: when all else fails, brute force prevails...

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)
--soft-film=4   : bake a soft-film curve to compress highlights and raise shadows by X EV
                  (if you use this option, you should also specify the white balance)
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)

Input file      : D:\Audio Video\Photos\RAW for Lightroom\2015\April\26\_MG_5621 2015-04-26-dualiso-3.dng
Camera          : Canon EOS 5D Mark III
Camera model    : Canon EOS 5D Mark III
Full size       : 5920 x 3950
Active area     : 5796 x 3870
Black borders   : 124 left, 80 top
Black level     : 2044
ISO pattern     : dBBd RGGB
White levels    : 15193 13901
Noise levels    : 15.20 70.91 67.88 15.17 (14-bit)
ISO difference  : 2.90 EV (747)
Black delta     : 1.58
Dynamic range   : 9.76 (+) 7.39 => 10.29 EV (in theory)
AMaZE interpolation ...
Amaze took 3.48 s
Edge-directed interpolation...
Semi-overexposed: 3.35%
Deep shadows    : 66.43%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.9 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 536.50 (20-bit), ideally 468.64
Dynamic range   : 10.62 EV (cooked)
Black adjust    : -84
AsShotNeutral   : 0.50 1 0.54, 4707K/g=0.89 (gray max)
Soft-film curve : +4.00 EV baked at WB 2.00 1.00 1.84
Output file     : D:\Audio Video\Photos\RAW for Lightroom\2015\April\26\_MG_5621 2015-04-26-dualiso-3.DNG (already exists, overwriting)
D:\Audio Video\Photos\RAW for Lightroom\2015\April\26\_MG_5621 2015-04-26-dualiso-3.DNG: copying EXIF from D:\Audio Video\Photos\RAW for Lightroom\2015\April\26\_MG_5621 2015-04-26-dualiso-3.dng

Thanks once again for all you support  :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 12:01:09 AM
My mistake... sorry!

new link (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.1.zip) to download newest

I forget to change the name when same-level is checked for reimported into LR (cr2hdr works fine) ;)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 30, 2015, 06:57:43 AM
same link (https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels.zip) to download newest

Sorry - no joy - same errors  :(
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on April 30, 2015, 08:15:58 AM
Every time for both platform!
Don't forget that I'm a Mac user :)

Figured. Should have known better, myself! [emoji3] Will definitely test out the new updated beta however though I got a question -- do you know if it will be able to read Dual-ISO files from 70D yet?

Much appreciated, @kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 10:47:40 AM
Sorry - no joy - same errors  :(

Everything works well on both platform for me (don't forget to reload the plugin when you update some files (in plugin management) ;))

do you know if it will be able to read Dual-ISO files from 70D yet?

The plugin doesn't check from which model the Dual ISO come, so don't worry about that. Maybe it needs the last update of cr2hdr (I'll update this evening)



@ALL

It's time to release the final Lightroom Dual ISO Converter v3, so I need your help!
Please, try the same-levels option for cr2hdr 20bit.
Please translater, I need some translation for the latest update, if not, it will be google translated  :o
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 30, 2015, 11:00:18 AM
Everything works well on both platform for me (don't forget to reload the plugin when you update some files (in plugin management) ;))

OK, will check again this evening to make sure it is not a stupid user error  ;D (was a little bit early this morning when I retried, but I had hit the reload button, and when that did not work, removed the plugin, deleted the folder with the plugin and created it direct from the new download again ...).

Any thoughts on:
OK in fact this is a file that I had previously converted the other day, so the -dualiso.dng already existed....

... So a -dualiso-2 was created.  Perhaps ideally there would be an option to allow either overwrite of existing -dualiso.dng(s), or creation of new variant ...


Thanks once again for all you support  :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 11:21:18 AM
OK, will check again this evening to make sure it is not a stupid user error  ;D (was a little bit early this morning when I retried, but I had hit the reload button, and when that did not work, removed the plugin, deleted the folder with the plugin and created it direct from the new download again ...).

Try again and let me know !

So a -dualiso-2 was created.  Perhaps ideally there would be an option to allow either overwrite of existing -dualiso.dng(s), or creation of new variant ...

I added the function to check if file exist to choose an unique name if you forget to change the suffix, but I can remove it
Code: [Select]
if LrFileUtils.exists(finalPath) then
       finalPath = LrFileUtils.chooseUniqueFileName(finalPath)
       finalPathLog = LrFileUtils.chooseUniqueFileName(finalPathLog)
end
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on April 30, 2015, 11:53:50 AM
Installed LR CC on new laptop with Win 8.1.
Tried to install plug-in from source https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels.zip
but no avail. Error loading plug-in.
Tried link from first page and no problem at all.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 01:34:22 PM
@Walter
could you see in Plugin manager if there are an error explanation ?
There are no big changes between 3-BETA3 and this rush
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on April 30, 2015, 01:45:22 PM
Window showing up "An error occurred while attempting to load this plug-in."
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 02:12:52 PM
Have you renamed the folder kichetof-lr_cr2hdr-5c11d3cebe09 to cr2hdr.lrplugin ? (after unzipped, folder root before bin/ and presets/)

Don't forget, it's a rush :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on April 30, 2015, 02:14:34 PM
Yes, been there.
Tried to rename build from first page to cr2hdrx.lrplugin and it worked.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 02:16:14 PM
wtf?!

It works fine on my windows....
It's not the first time that you had a similar problem no ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on April 30, 2015, 02:17:05 PM
Different computer, different OS, different LR version.
Problem was on other comp with renaming plugin folder. No problem on new computer so far with "old" build. New build will not work at all. Started with new build, then switched to "classic" plugin. And that one works.

EDIT: We can do a remote session via Teamviewer. Let me just clean my browser cache ...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 02:36:25 PM
Could you try this plugin (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.1.zip)

If have some times, I'll do the Teamviewer session :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on April 30, 2015, 02:40:19 PM
Looks good! Works. More tests have to be postponed until evening.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 02:41:49 PM
...
I only zipped my cloned repo from bitbucket... I don't know why it don't work when you change the name...

but great :)



My adobe account has some trouble, so I can't connect to the forums, I'm waiting for Adobe technician resolve this issue (24-72 business hours)
Windows users be patient for a fix for the bug with plugin loading from another folder :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on April 30, 2015, 07:23:09 PM
OK feedback time  :)

1.  Thanks!!
2.  Used cr2hdr.3.0-BETA3.1
      - same-levels problem fixed  :D
      - install to other folders still have the problem
3.  On existing -dualiso file behaviour

I added the function to check if file exist to choose an unique name if you forget to change the suffix, but I can remove it
Code: [Select]
if LrFileUtils.exists(finalPath) then
       finalPath = LrFileUtils.chooseUniqueFileName(finalPath)
       finalPathLog = LrFileUtils.chooseUniqueFileName(finalPathLog)
end

What would be great is if a file with the same suffix already exists then if a (new) checkbox "overwrite existing dualiso DNG" is selected the existing file is overwritten, else choose unique name.  For safety purposes if run with this potion selected a confirmation dialogue should be displayed.  Thoughts, desirable, feasible?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on April 30, 2015, 09:26:05 PM
I like your idea for 3. :)
I'll add an UI option to let the choice to the user to overwrite or not an existing dual ISO final file :)
Maybe this Sunday or next week ;)

When my account are able to login to the Adobe forums, I'll ask for a solution to fix windows folder problem :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on April 30, 2015, 09:37:33 PM
Maybe you can find out where plug-in folder location is stored. I tried to follow the paths of LR by using Process Monitor and took a short dive into the catalog database schema but haven't found out yet.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 01, 2015, 12:47:02 AM
*feedbacks*

Ran the new cr2hdr v3.0 BETA3.1 in LR 5.6 and it failed to export because it says I didn't choose destination for export (when I know I did).

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7715%2F16703642894_19e22f5055_n.jpg&hash=ef64a32699d211dee7964027794fcbf3) (https://flic.kr/p/rs3x61)

https://vimeo.com/126553760 (https://vimeo.com/126553760)

https://vimeo.com/126557667 (https://vimeo.com/126557667)

Hopefully this is an human error on my part otherwise I have no idea... Thoughts?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 01, 2015, 06:47:07 AM
Maybe you can find out where plug-in folder location is stored. I tried to follow the paths of LR by using Process Monitor and took a short dive into the catalog database schema but haven't found out yet.

I'll investigate next week (no windows at home)

@DeafEyeJedi
Could you retry to export your dual ISO from the path where it's storage but not from previous import window?

Unable to reproduce the bug on my mac (try with original path folder and from last imported view) with DNG dual iso with same options like you.
I'll add a check if folder is writable before copying the DNG, maybe it's the problem.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 01, 2015, 09:18:15 AM
Actually I think the problem lies within the files being from 70D. Guess you were right that it may indeed need to wait for an update in the binary from @a1ex or no?

Because I just tried running your latest beta again with Dual-ISO files from 5D3 and it worked as expected.

Hmmm?

Let me know if you would like to try out few Dual-ISO CR2's (https://mega.co.nz/#F!yoNQWBTa!3ohyAu9UggiyreAiFjo8nACR2's) from 70D.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 02, 2015, 11:07:11 AM
Let me know if you would like to try out few Dual-ISO CR2's (https://mega.co.nz/#F!yoNQWBTa!3ohyAu9UggiyreAiFjo8nACR2's) from 70D.

Yes please, so I can handle the error and display a proper error message :)
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 02, 2015, 06:00:48 PM
@kichetof:

Here's the link to 70D movie files including Dual-ISO MLV/RAW from 70D111B (April 23)...

https://mega.co.nz/#F!6hchkCbD!zScVqL68khdbY6MylpzhNg

Here's the link to 70D CR2 files (As well as other varieties of files from 70D to choose from)...

https://mega.co.nz/#F!yoNQWBTa!3ohyAu9UggiyreAiFjo8nA
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 02, 2015, 08:46:48 PM
@kichetof:

Here's the link to 70D movie files including Dual-ISO MLV/RAW from 70D111B (April 23)...

https://mega.co.nz/#F!6hchkCbD!zScVqL68khdbY6MylpzhNg

Here's the link to 70D CR2 files (As well as other varieties of files from 70D to choose from)...

https://mega.co.nz/#F!yoNQWBTa!3ohyAu9UggiyreAiFjo8nA

Thank you! Electricity shutdown at home from this morning, so when it will comes back, I'll play with your files :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 03, 2015, 01:29:19 PM
Ok the problem comes from files from 70D.

When you try to convert file with cr2hdr (from terminal or LR), the result file isn't a valid DNG file.

@a1ex this is a file converted with cr2hdr that has a problem: https://mega.co.nz/#F!WIQgCJ6L!gjA5NcT3hV8UsqIDbn3u1Q

I'll try to catch the error, but now I don't know how..
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 03, 2015, 01:55:50 PM
Cr2hdr converts but doesn, t add color matrix. I think it doesn, t recognize the 70D camera id tag.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nikfreak on May 03, 2015, 02:52:37 PM
dcraw-bridge.c and raw.c from this pull request should contain the neccessary data or does anything miss?

https://bitbucket.org/hudson/magic-lantern/pull-request/620/add-support-for-eos-70d-111-both-revisions
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 03, 2015, 02:57:16 PM
I can't try because I don't know how to apply your PR on my local repo, I'll read how to do this!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 03, 2015, 03:11:30 PM
@nikfreak. Last I tried 70D cr2hdr there was the old flickery bottom pixel issue with dual iso movies. Also lacked some commands. Greymax I think. Could be wrong. Maybe someone could confirm.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nikfreak on May 03, 2015, 03:23:36 PM
I must admit I only seen that DeafEyeJeydi got it working with your help for movies but I guess he used the compiled cr2hdr provided by N/A (not sure about that).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 03, 2015, 03:27:45 PM
Yeah, though about that. Could be something with compilation. It is the one used. I will investigate.

*Downloaded the N/A build from 70D thread and all seems to be in order. Tried a mlv 1920x1080(5D mark 3) and it was interpolating that file as good as any late version. Also seems to have all the commands from former build. All seems good.

*worked fine with CR2 files both 5d mark 3 and a 70D file. With lossles dng compression with adobe dng converter a 70D DNG ends up with being 16mb. Nice.

Maybe @Deafeyejedi could do some more testing regarding interpolation issue cause, see if it can be reproduced.
I see the N/A compilation says Last update: "f381b87 on 2014-07-06 09:46:41 UTC by phil:"
and A1ex latest says "Last update: cc4340b on 2015-03-01 23:16:03 UTC by a1ex:"
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 03, 2015, 04:36:19 PM
@Kichetof: Is repository in https://bitbucket.org/kichetof/lr_cr2hdr/src synced with 3.1beta?
Have some GUI changes in mind + updates for german translation.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 03, 2015, 05:15:30 PM
Nice to see some major activity going on in here guys... [emoji1]

That's what I figured that it could actually come down to either one of the cr2hdr binaries but also I remember seeing @dmilligan just updated his app MLVFS yesterday with proper color matrix for 70D (it was same as 6D) so not sure if this info would help pick up pace on this progress of yours @kichetof?

I also believe we may have to fix the in camera issues regarding 70D dual ISO movie files (RAW/MLV) first before we blame the binaries becAuse Dual-ISO cr2's from 70D works fine with updated cr2hdr binary that N/A recently build (I think?) which was implemented into @Danne's latest app cr2hdr-r beta which works well.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 03, 2015, 06:26:12 PM
@Kichetof: Is repository in https://bitbucket.org/kichetof/lr_cr2hdr/src synced with 3.1beta?
Have some GUI changes in mind + updates for german translation.

Not now. I'll merge same-levels branch to unify in few hours. Apero time :)

Merged! You can go on!! :)
Pull request welcome!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 03, 2015, 10:39:29 PM
Thanks for syncing!
Fighting with Bitbucket now.
EDIT: Pull request created.

 
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 04, 2015, 10:31:55 AM
Merged ! :)



Flash info !

This is the latest BETA for v3 before final version !

Please, make a lot of test to try everything :)

Download v3.0-BETA3.2 (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.2.zip)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 04, 2015, 11:02:15 AM
kichetof: Final? I don't think so. Just about cornering a bug.
As far as I can tell, there is in fact a small incompatibility problem with LR CC. Magic Lantern will not show up in Plug-In Manager's left column when starting from scratch = Not updating LR 5.x with existing catalog and cr2hdr plug-in to 6/CC.
Making a clean Win7 installation right now (lots of computers here). Will install LR CC after that + plug-in.

There are lots of strings to be added in MLDialogs + translation files. Can be added later.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 04, 2015, 11:17:05 AM
I'll release the final version only when I'll resolve the bug with windows: when you update the plugin or change the path and it not working. (Waiting for adobe support)

Could you send some printscreen for your bug. No problem with LR CC on Mac (10.10.3) and Windows 7 (FR 64bit)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs15.postimg.org%2Flxunobh6v%2FLR_plugin_manager.jpg&hash=58a01631b2bf3b72da4d11f69927c9f6) (http://postimg.org/image/lxunobh6v/)

For translations... all files are available to make update, if there are some mistake, feel free to update (not only you :) ), I'll not stopping the final release because nobody translate in a specific language ;)
I can remove languages that are not translated and added only when it's done  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 04, 2015, 02:36:47 PM
Tried a little in lightroom 4 on a macbook pro mavericks
 
- DNG compression works both for movie files and CR2 files(adobe dng converter must be installed).
- Tried some variations and all seems fine. Adding flag, not adding flag and so on.
- Same levels on, dual iso movie files. Seemed to work, havn,t checked with exiftool
- Exporting to folder worked good.

- Had one strange bug with lots of messages. Couldn,t even make a printscreen(Freeze). After restarting computer all fine. Couldn,t reproduce

- Speed. I miss some multithreading. In bash it is simple writing, below, and it starts 4 processes in parallell. Is it impossible to do this in lightroom :)? Of course, I can always start 4 processes manually, no big deal, only curious.

Code: [Select]
find . -maxdepth 1 -mindepth 1 -name '*.CR2' -print0 | xargs -0 -P 4 -n 1 /usr/bin/cr2hdr20bit
Again, thanks for this fine tool/plugin inside a favourite editor.

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 04, 2015, 02:42:26 PM
Confirmed for Win 7 and Win 8 (german) and LR CC (german):
After installation (both fresh from scratch) a new catalog was created. I imported one pic and installed plug-in. Everything looks fine in Module Manager (wrong info in previous post, sorry) but export dialog is another thing.
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fpicload.org%2Fimage%2Fiaggwir%2Fscreen1.jpg&hash=808325401b67f059f9f1a51b0c118016)
No Magic Lantern in context menu

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fpicload.org%2Fimage%2Fiaggwii%2Fscreen2.jpg&hash=b12c2b8260499a6529186e4d208e7c9d)
Left column (Presets) in export dialog: No Magic Lantern, no Dual ISO Converter entry.

Can provide english menu, too.

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 04, 2015, 03:18:57 PM
- Speed. I miss some multithreading. In bash it is simple writing, below, and it starts 4 processes in parallell. Is it impossible to do this in lightroom :)? Of course, I can always start 4 processes manually, no big deal, only curious.

Code: [Select]
find . -maxdepth 1 -mindepth 1 -name '*.CR2' -print0 | xargs -0 -P 4 -n 1 /usr/bin/cr2hdr20bit

Thanks a lot for your great feedback!!
I'll try to use your command for mac user! :)

@Walter it's the same bug for windows users, I don't know how to fix it (I try to replace lua code with LR SDK function) and I'm waiting for Adobe support to unlock my account to access to the adobe forums to ask guy :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 04, 2015, 04:42:59 PM
@brave and beta tester Mac users
If you want to try multiprocess, you can follow this instruction (not tested, and I can't test before wednesday)

Edit MLProcess.lua
find line 121
Replace this

Code: [Select]
local cmd = WIN_ENV and 'start /D "%s\\bin" /B /WAIT /BELOWNORMAL %s.exe%s %s' or 'exec "%s/bin/%s"%s %s'by
Code: [Select]
local cmd = WIN_ENV and 'start /D "%s\\bin" /B /WAIT /BELOWNORMAL %s.exe%s %s' or 'xargs -0 -P 4 "%s/bin/%s"%s %s'
Please let me know if it works fine ! :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 04, 2015, 04:58:01 PM
Just tried :). Just ends process without converting.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 04, 2015, 05:10:14 PM
Could you open the Console.app and filter by "lightroom" and copy paste here :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 04, 2015, 05:11:47 PM
Yes, will test some more. Seems CR2 won,t convert but dng dual iso files will. Gonna test the script line again. Let me get back to you.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 04, 2015, 05:14:37 PM
Try to combine exec with xargs
like
Code: [Select]
exec 'xargs %s%s....'
If I find some extra times this evening, I'll try to find the best way!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 04, 2015, 05:22:56 PM
Awesomeness!
It worked with dng dual iso files! Fast running spitting out files.
Gonna test some CR2 files. It won,t convert at the moment.

It worked with original command without exec suggestion above.

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs7.postimg.org%2Fx4zx87tqv%2FScreen_Shot_2015_05_04_at_17_36_22.jpg&hash=0a67fac4ae676f7521a008df846102f9) (http://postimg.org/image/x4zx87tqv/)

*Wait a minute. Seems its only copying stuff. Still the lines showing. Needs some more investigating.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 04, 2015, 05:45:35 PM
Actually. Started fresh and got it all working as in the beginning. Then added the xarg command and they now convert. Will do a rerun to see if it,s really multithreading.
I renamed the plugin taking aways spaces cr2hdr 3.lrplugin to cr2hdr3.lrplugin
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 04, 2015, 05:49:20 PM
I like what you said  8)
Could you paste your final edit when all works fine! Or better, send a PR on bitbucket! I have limited access on my Mac at home (very busy :()
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 04, 2015, 05:55:20 PM
Sure :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: glubber on May 05, 2015, 09:01:12 AM

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fpicload.org%2Fimage%2Fiaggwii%2Fscreen2.jpg&hash=b12c2b8260499a6529186e4d208e7c9d)
Left column (Presets) in export dialog: No Magic Lantern, no Dual ISO Converter entry.

Can provide english menu, too.



The same happened to me too (LR 5.6 german, Win7) after installing V3.Beta3.
BUT after hitting "Export" in Export-dialog (window above) a preset for DualIso-Export was created, including an entry in context menu.
So all works fine now. But i guess there shouls be a preset right after installing a plugin in LR.
I have no LR at hands right now, so i can't show a screenshot.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 09:19:25 AM
Thanks for the tip but it isn't working for my environment.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 05, 2015, 09:37:29 AM
It's a bug very very strange!
I've read a lot of other LR plugin and everything looks similar in the conception.
Still waiting for adobe support... I've some trouble to connect to forums.adobe.com ERR_TOO_MANY_REDIRECTS

Maybe it's come from the presets lrtemplate or maybe from the LrToolkitIdentifier, I don't know :(

If you want to try, try in a new LR Catalog:
 be patient

I identified the problem ... if you disable builtnPresetsDir (Info.lua), the plugin doesn't appear in the list of exports available, so you have to investigate this side!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 05, 2015, 11:15:33 AM
@Windows users

I need you!

Please try this plugin and let me know!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 11:25:02 AM
If it is supposed to fix menu problem: No success.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 05, 2015, 11:37:23 AM
... arrg ! It fixes on my Windows when I've the bug... sh*t !
Could you try to enable / disable / enable and reload the plugin in plugin management ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 12:38:00 PM
Tested with Win 7 and 8: Error still there.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nicsut on May 05, 2015, 01:25:46 PM
Tested with Win 7 and 8: Error still there.

I will try this evening on my setup and see f it works there in an attempt to try and narrow this down.

Meanwhile enjoying the plugin - its doing the job  ;D

@kichetof, if you are interested if have some catalogue insertion/metadata suggestions - lmk
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 05, 2015, 02:13:08 PM
Windows bug not fixed yet!
I'm waiting my adobe account to ask somebody...

I tried to remove everything, to keep only essential code and nothing... Windows bullsh*t!

I'll not trying anymore until I ask adobe forums..
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 05, 2015, 07:03:21 PM
Not sure about windows but, I noticed when editing in lua script on mac (multithread testing) I had to remove the imported picture folder I tested with in lightroom and reimport it to start fresh. I think also I restarted lightroom.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Marius on May 05, 2015, 09:54:48 PM
Hello i'm new to all DualISO thing and this software, please don't bash me to much for silly question.

I have LR6 Mac
Installed: cr2hdr 3 Beta
Also installed: OSX_cr2hdr
 
And have this file that i've downloaded from internet: https://mega.co.nz/#F!yoNQWBTa!3ohyAu9UggiyreAiFjo8nA (thanks for this to this file owner for sharing samples) IMG_6186.CR2

But getting these error messages:
https://www.dropbox.com/s/6tn448a4eedyd5q/Screen%20Shot%202015-05-05%20at%2020.45.39.jpg?dl=0

But when i chose this option:
https://www.dropbox.com/s/ltfsdkrz7n40ai3/Screen%20Shot%202015-05-05%20at%2020.45.48.jpg?dl=0
i get these errors:
https://www.dropbox.com/s/aviw1iufdnat1mc/Screen%20Shot%202015-05-05%20at%2020.46.17.jpg?dl=0
and
https://www.dropbox.com/s/aaa9ocr9irvj3sv/Screen%20Shot%202015-05-05%20at%2020.46.21.jpg?dl=0
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 10:05:12 PM
Do you have a 70D?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Marius on May 05, 2015, 10:12:12 PM
Nope i have 6D, i've just tried other samples from different site, seems to work. But why does it mater what camera i have?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 10:14:27 PM
Because ML for 70D is in alpha state and a lot of things just doesn't work. And the file you have been using comes from 70D.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Marius on May 05, 2015, 10:16:09 PM
All right makes sense thanks

Now i have DNG file, and it might be the silliest question i will ask, but trying to open DNG in LR it shows preview unable, do i need to convert DNG to something?

Update: opened in Photoshop, but still cant open in LR6
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 05, 2015, 10:19:24 PM
The 70D isn,t updated with cr2hdr builds and will fail to be recognized and stop halfway through.
You can probably replace the cr2hdr20bit inside this lightroom plugin to the one Nikfreak created in first post in 70D thread and it will work with 70D as well, but you own a 6D so maybe just wait for Kitchehof when he,s ready to change binaries.
 
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 10:21:40 PM
Update: opened in Photoshop, but still cant open in LR6
Link to file available?

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Marius on May 05, 2015, 10:25:55 PM
I've used sample from here: http://neumannfilms.mediafire.com/download/6tvihparmfwfbch/0R0A0640.CR2 (again thanks for owner for this sample)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 10:27:05 PM
You asked about a DNG unable to open in LR and linked a CR2.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Marius on May 05, 2015, 10:30:40 PM
Sorry :)

i did convert this to DNG in LR6, but when i try to open that DNG in LR6 it's not working, but in photoshop it does, here is that DNG file: https://www.dropbox.com/s/5wj8atim365wxor/0R0A0640-DualISO-2.DNG?dl=0
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 05, 2015, 10:36:26 PM
Thanks. No trouble importing that file into LR CC.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Marius on May 05, 2015, 10:39:16 PM
All right my bad :) well not sure how worked, but basically if when converting CR to DNG it creates DualISO folder i just need to use that and working fine, but when i just try to drag DNG to lightroom then it stops working :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 05, 2015, 11:30:08 PM
@kichetof:

Finally back online after spending the weekend helping the wife with the move out from an apt into a house. Fun Stuff!

Downloaded v3.0-BETA3.2 and will test it out on MBP running Yosemite.

Thanks for the quick update, btw!

Stand by!

*EDIT*

Sorry I'm still somehow encountering this error on LR during exporting (it pops up and says could not find a destination to export) just like how I did last week. Have a feeling that this is due to my POS MBP not being set up properly even tho Ive ran this plugin with no problems (this was done with just 70D files) for testing purpose.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7795%2F17358452186_0ce5679b69_n.jpg&hash=c7628c17584fe2d49d4c8c22a4dda76c) (https://flic.kr/p/srUB5o)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7789%2F17196840850_926f367e8e_n.jpg&hash=cecad726109a18c2555d015edf288f7e) (https://flic.kr/p/scCiE3)

The one that's most strange is the fact that even though LR is giving me 'Export Errors' I still managed to find one DNG that got spitted out along with an Exiftool info text file (but Adobe PS won't recognize the file) so not sure if this is worth noting as well?
https://vimeo.com/126981410 (https://vimeo.com/126981410)

Should I stick with 5.6 or proceed with the update? Not sure if this would make a difference?

Thanks, again!

*EDIT Part II*

Decided to make another run with 5D3 files and it exported normally as expected... not sure what could be the culprit in here regarding 70D files on my end?

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm9.staticflickr.com%2F8738%2F17358513716_4cc4976791_n.jpg&hash=91544e4ea4d9c25d110d8bf17506ef2b) (https://flic.kr/p/srUVnf)

(I just ran @Danne's latest beta cr2hdr-r and it spitted out 70D Dual-ISO CR2's just fine. Strange?)

Do you know if you are using the same binary that he is using in his app?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 06, 2015, 05:24:36 PM
@ DeafEyeJedi
Thanks a lot for your feedback!
70D converted file failed when LR import it! Because DNG file isn't really converted (cr2hdr problem or dual iso file problem).
I use cr2hdr20bit compiled on my mac with latest a1ex changes (not 70D specific)

You can try to replace my bin with an other :)
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 06, 2015, 06:10:56 PM
Sounds good. Do you need a copy of Binary that either N/A or g3gg0 recenty built to be able to read 70D files or are you gonna wait for a1ex to release one?

Thanks!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 06, 2015, 06:36:44 PM
Until 70D still in alpha, I don't want to add the feature, feel free to replace in your folder :)

I want to resolve windows bug and multiprocess on mac before to add alpha :)
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 06, 2015, 06:41:12 PM
No problem -- that makes more sense!

Multithread is a MUST have - hehe [emoji12]

Keep up the hard work, @kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 06, 2015, 09:11:31 PM
@Danne
I found the way to run xargs (find "files" -print0|xargs ...) but for the moment, it's not faster (maybe launch in async) and it works faster with same-levels but LR crash because xargs finished the first image and the plugin import image but the other aren't totally converted...

I need to rethink the process but need to do two process (windows and Mac). So I don't know if I'll continue on this way!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 06, 2015, 09:24:59 PM
cool Kitchehof! Noticed you run both windows and mac in the same lua. Let me know if I could help.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 07, 2015, 07:49:42 AM
For those who are curious or in need of files (Dual-ISO RAW, MLV, CR2, MLV/RAW, FRSP DNG/MLV) from certain models such as 70D, 5D3 & the M... Perhaps to help speed up the process on getting the binaries up to date.

https://mega.co.nz/#F!DokxSIhC!q5iOd_rIQTRbCXA51Kyz5Q

Happy Updates!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 08, 2015, 10:10:08 AM
Adobe account now available :)

https://forums.adobe.com/thread/1839693
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 09, 2015, 01:50:29 AM
Thanks for letting us know... Hopefully they'll get back to you sooner rather than later.

[emoji108]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 09, 2015, 10:01:18 PM
Added my point of view in Adobe's forum.
And there is work to be done. a1ex changened cr2hdr content: http://magiclantern.fm/forum/index.php?topic=7139.msg147170#msg147170
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dubzeebass on May 11, 2015, 03:56:58 AM
I have a new Retina 5K iMac 27" and when I import version 3 beta, I get an error regarding the plugin schema. Using latest LR with the Behance-ified splash screen. Any ideas?

Log file:

Plug-in error log for plug-in at: /Users/bja/Documents/cr2hdr.lrplugin

**** Error 1

An error occurred while attempting to run one of the plug-in’s scripts.
No script by the name MLMetadataDefinitionFile.lua

**** Error 2

The plug-in’s metadata provider description could not be read.
No script by the name MLMetadataDefinitionFile.lua

**** Error 3

Could not read the metadata spec from this plug-in.
No script by the name MLMetadataDefinitionFile.lua

**** Error 4

An error occurred while attempting to run one of the plug-in’s scripts.
No script by the name MLInfoProvider.lua

**** Error 5

An error occurred while attempting to run one of the plug-in’s scripts.
No script by the name MLInfoProvider.lua

**** Error 6

An error occurred while attempting to run one of the plug-in’s scripts.
No script by the name MLInfoProvider.lua

**** Error 7

An error occurred while attempting to run one of the plug-in’s scripts.
No script by the name MLMetadataDefinitionFile.lua

**** Error 8

The plug-in’s metadata provider description could not be read.
No script by the name MLMetadataDefinitionFile.lua

**** Error 9

An error occurred while attempting to run one of the plug-in’s scripts.
No script by the name MLInfoProvider.lua

**** Error 10

Could not read the metadata spec from this plug-in.
No script by the name MLMetadataDefinitionFile.lua

**** Error 11

An error occurred while attempting to run one of the plug-in’s scripts.
No script by the name MLInfoProvider.lua

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 11, 2015, 10:18:32 AM
latest cr2hdr here (http://magiclantern.fm/forum/index.php?topic=7139.msg147286#msg147286)

@dubzeebass it's very strange. Do you have some files into cr2hdr.lrplugin ? (right click -> show package content)

@all I'll remove cr2hdr and replace everything with cr2hdr (ex 20bit), some GUI changes :)

But I'll be in holiday for 2 weeks, be patient or pull request! :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on May 11, 2015, 10:25:07 AM
Cr2hdr compile. Thank you Kichetof.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 11, 2015, 02:25:59 PM
from scratch: unzip, rename kichetof-lr_cr2hdr-42be6b9232cd to cr2hdr.lrplugin (https://bitbucket.org/kichetof/lr_cr2hdr/get/cr2hdr_unify.zip)
Changes: https://bitbucket.org/kichetof/lr_cr2hdr/commits/all
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on May 11, 2015, 06:31:27 PM
Great stuff & Thanks again @kichetof for your time on this.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 11, 2015, 07:53:22 PM
Oh that's a good thing to remove 2 versions of cr2hdr, there are a problem with fast checkbox... :)

wtf ?! no problem on LR CC Windows... I need to cleanup a little my Mac :)
Somebody could make some tests?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on May 12, 2015, 11:01:29 AM
Maybe I've a way for Windows users... :)

Please replace cr2hdr.lrtemplate into cr2hdr.lrplugin/presets with this version (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.lrtemplate) and let me know!
When you replace this file, reload the plugin from Plugin manager and restart LR (plugin translated in english until LR is restarted)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dubzeebass on May 12, 2015, 01:57:43 PM
It's working with the version you posted yesterday that needed renaming. Many thanks!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 18, 2015, 05:30:53 AM
Adobe account now available :)

https://forums.adobe.com/thread/1839693

More than a week without a developer jumping in to the rescue. Any more options available to hunt down this bug?
And still not convinced this bug doesn't occur on OS X if starting from scratch.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 22, 2015, 02:51:09 PM
Hello, again!

I think we have an Adobe Lightroom 6 problem here, kichetof.
- Downloaded SDK for LR5 (no LR6 SDK there, yet)
- Copied extracted FTP Upload plug-in directory to local disk
- Used Plug-in Manager to install plug-in
- Several times restarting LR.
-> Not showing up in "Presets". Same behauviour as your plug-in.
- Created an item "FTP Upload" in "User Presets" and this one is showing up.

Someone able to test this (or any other export plug-in *not previously installed*) in LR5 and telling if plug-in is there in "Presets"? The Windows machine I'm using right now has LR6 only and no LR5 installation file around here.
LR5 SDK is just 8 MByte and plug-ins can be used without programming skills.
http://www.adobe.com/devnet/photoshoplightroom/sdk/eula_lr5.html
Title: Re: Newbie Here - Sorry. I need help.
Post by: aworkofmarc on May 27, 2015, 07:04:14 PM
So I took my first ML dual-iso picture. I got the plugin installed into LR6, I import the photo... I right click, go to Export and select cr2hdr


And nothing happens. I still got all those lines in my image. I do the same process and I get the "Already Treated" message.


Please help. What am I doing wrong?  :-[
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 27, 2015, 07:11:35 PM
Processed DNG is stacked with CR2. Unstack or learn to handle stacks. 
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: aworkofmarc on May 27, 2015, 08:26:59 PM
So some crabby member told me to "Learn the LR Basics" -- Which, was what I was trying to do. But to save him and any other "PROS" around here who are to fussy and important to help  -- WHERE DO I LEARN "THE BASICS"????????????
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on May 27, 2015, 08:46:23 PM
I'm that crabby member and you learn LR basics using LR online help, tutorials, forums (all provided by Adobe on Adobe's web site) and 3rd party tutorials via youtube and other channels including your preferred supplier for printed media (aka books). This is ML area ...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on June 17, 2015, 10:39:47 PM
- DELETE -
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 12, 2015, 08:28:51 AM
Hi kichetof -- I'm just getting into dual_iso and found your Lightroom plugin. Wow, this makes it so easy. On my last photo outing I shot several bracket sets in order to use the fairly new Lightroom HDR feature and those turned out fine but the dual_iso shots looked just as good. Of course dual_iso works much better with moving subjects and your plugin made the dual iso workflow even easier and quicker than HDR. Thanks so much.

I do have a question and Walter Schulz, if you see this post first I searched for an answer--really I did.

My usual Lightroom workflow is to convert to DNG on import. However, using the v3.0 BETA3 plugin all of the metadata doesn't copy over to the new *-dualiso.DNG file. Most importantly, the Exposure, Focal Length, ISO Speed Rating, Model and Lens fields. The Exposure is changed to 1.0 sec at f/1.0 and the Model changed to Canikon. What makes this a problem is that I can't copy and paste these fields from the "original" dng file into the *-dualiso.DNG file. In addition, the Capture Time and Capture Date are gone on the *-dualiso.DNG file.

I thought that maybe I had a problem with exiftools on my MacBook Pro (OS-X Yosemite 10.10.4) but when I tried it on a CR2 file those problem metadata fields copied over to the DNG file created by the plugin just fine. Then I thought that it was probably a problem with cr2hdr but when I tried one of the dng files that was converted from a CR2 original in Lightroom using just cr2hdr, the metadata translated over to the new DNG file just fine. So there is probably something strange going on with the plugin when converting from a dng file.

By the way, I like to sort by Capture Time in Lightroom and with my preferred workflow of Copy to DNG on import, both the "original" Lightroom dng and the *-dualiso.DNG pop to the top of the sort. I guess that means that Lightroom sees it as having an earlier creation date even though the only thing that should have changed on the "original" Lightroom dng is to flag it as Rejected.

I guess that for now it is best to copy the CR2 files on import instead of copying to DNG on import even though I really want to end up with everything in DNG format.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 12, 2015, 11:27:59 AM
Confirmed and error exists on Win 8.1, too.
Converting DNG from commandline will preserve EXIF. Converting DNG with plug-in will fill fields with default settings.

EDIT: Played a bit with Process Monitor and don't understand what is happening here. This is the commandline for DNG:
Code: [Select]
"C:\Windows\System32\cmd.exe" /c "start /D "C:\Program Files\Adobe\Adobe Lightroom\Modules\cr2hdr.lrplugin\bin" /B /WAIT /BELOWNORMAL cr2hdr.exe --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax "C:\Users\Asus\Pictures\2015\2015-07-12\IMG_1906-dualiso.dng" > "C:\Users\Asus\Pictures\2015\2015-07-12\IMG_1906-dualiso.TXT""
? Soure file is "IMG_1906-dualiso.dng" which does not exist before export? Who the hell generates this file and why?
EDITEDIT: Ok, I think I understand now why this file has to be generated. Cr2hdr doesn't seem to have an output argument but will generate DNG and therefore overwriting source file if it is DNG.
I replaced cr2hdr.exe to see what is happening before cr2hdr.exe is executed and generated file is just fine, EXIF and all.
Then enabled original cr2hdr.exe again and dropped code above in commandline interface.
Code: [Select]
Undefined subroutine Image::ExifTool::ValidTagName called at C:\Program Files\Adobe\Adobe Lightroom\Modules\cr2hdr.lrplugin\bin/lib/Image/ExifTool.pm line 3648And this shows up in TXT:
Code: [Select]
C:\Users\Asus\Pictures\2015\2015-07-12\IMG_1906-dualiso.DNG: copying EXIF from C:\Users\Asus\Pictures\2015\2015-07-12\IMG_1906-dualiso.dn6
**WARNING** exiftool couldn't update DNG tag data
.dn6?
And EXIF is messed up.

Minor bug: If option "Keep original DNG file after conversion" is not used file will be deleted in file system only. Pic is visible inside LR still and has to be removed manually.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: david az on July 12, 2015, 12:42:16 PM
for Anyone who has a problem with a plug-in
 Of the Lightroom cr2hdr v3.0 beta not working
the Solution is

 1)  on the pc delete the folder lightroom Previews.lrdata

2) in lightroom
After this When you start the  plug-in cr2hdr In save  it Will  ask to select a folder to save files
select folder Location
3) save

And everything works perfectly  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 12, 2015, 03:11:57 PM
@dfort (et al):
Error and solution found.

Error:
Kichetof integrated Exiftool libraries v9.93 but 9.98 is needed.

Solution:
Download exiftool library 9.98 and replace contents.
Source is found here https://fossies.org/linux/misc/Image-ExifTool-9.98.tar.gz/
Rename bin\lib in plug-in folder and copy extracted lib folder from source above.

Only tested with DNG. Please test it through and report back.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 12, 2015, 09:11:51 PM
@Walter Schulz and @david az

I followed your instructions but am still having the same problems when converting Lightroom dng files to dualiso.DNG with the plugin.

It looks like you're on Windows and I'm on Mac so just to make sure we're seeing the same issue, here is what is happening with the files:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F437%2F19450465848_17e73b0e42_z.jpg&hash=76a0862b19874d2efda2cf15d4f2f4e1)

On the left is a file that was processed with the plugin in Lightroom and on the right is a dng file before processing. Something that got me curious was what happens to the "original" dng file? Ah ha--so it seems that the dng file is actually modified and the information from the original file is now inside of the new dualiso.DNG. Sort of like a "virtual copy" ? I don't know, I'm new to all this so I might be making some false assumptions. It is also interesting to see that an unprocessed dng is 19.9 MB and the processed file is 37.5 MB.

The important thing to note is that the metadata from the original file no longer available in the dualiso.DNG in Lightroom including (I'm guessing) the Capture Time because after processing with the plugin the shots sort to the top of the list in the Lightroom Library window. However, the metadata is buried in there somewhere:

Below - the converted image (note that the metadata is gone):
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F333%2F19017005354_d157d68e2a_z.jpg&hash=eea87c761ed828a728ca0d540e141510)

Below - the "original" dng that is now marked as Rejected but is still living inside of the converted dng (original metadata is still there):
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F446%2F19452986539_e7ec576927_z.jpg&hash=1e02b57dc700d02bff5344f6d934a6a9)

This issue is only present when the original cr2 files are imported into Lightroom using the "Copy to DNG" option. If the files from the card are not converted everything works fine. Here's the proof:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F375%2F19017553303_38915a1c65_z.jpg&hash=baa25cfeec0b1c31b2b3a228604b9b0f)

The cr2 file is retained and the dng that was created with the plugin has all of the metadata and is about the same size as the file that was converted from a dng "original".

I decided a while ago to standardize on DNG files because of several reasons including a significantly smaller file size. In fact DNG files can be compressed further using the lossy codec without losing much (if any) image quality. Anyway, I'm starting to get off topic.

Just to make sure I'm following Walter Schulz's instructions properly on my Mac exiftool is located in /Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin. I replaced the exiftool and the contents of the lib directory in the plugin with the ones from Image-ExifTool-9.98. Just for good measure I also installed exiftool in my system so that it is also available in /usr/bin.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 12, 2015, 09:41:56 PM
About file sizes: cr2hdr generates uncompressed DNG. Lightroom will convert it to lossless compressed DNG when manipulating metadata.

And you did much more than suggested making it very difficult to find out where the problem might be.
david az jumped in - I suppose - following former discussions about context menu troubles with plug-in but this is not our problem here.

Please take a look into your plug-in folder cr2hdr.lrplugin/bin/lib/image/exiftool.pm. Find line $version and tell which version is found.

File *-dualiso.dng is not a virtual copy but a real one. LR plug-in will copy original *.DNG to *-dualiso.DNG before cr2hdr jumps in and processes *-dualiso.dng from "RAW" dual ISO to "merged HDR" (= without interlaced lines). This is because cr2hdr has no argument to change output file name and will replace source file with output file (aka overwriting it).
In LR both files (unchanged source and processed file) will be treated as image stack virtually hiding their physical representation. Unstack them and select directory where both files are located.
Create a new dual ISO file, import it as DNG and convert it with plug-in. I suppose you will find a file named *-dualiso.txt inside the directory where LR copied your DNG. Look for last lines. I suppose you will find some error message there. File will be absent if conversion worked without error.

EDIT: Use export option "Export ..." not "Dual ISO converter (cr2hdr)". First option will let you access plug-in's GUI and you can change options/arguments. One of those items is "Mark original as rejected" ...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 13, 2015, 08:13:32 AM
About file sizes: cr2hdr generates uncompressed DNG. Lightroom will convert it to lossless compressed DNG when manipulating metadata.

Ok, I get it but the file size of the cr2hdr generated DNG files are much larger than the original cr2 files which I believe are also uncompressed so there is probably something else going on in order to save all of that dynamic range. In any case, I'm not a developer so let's approach this as a user trying to get the plugin working with the original camera raw files converted into DNG files on import into Lightroom which is something that Adobe seems to be encouraging us to do.

david az jumped in - I suppose - following former discussions about context menu troubles with plug-in but this is not our problem here.

I figured as much though it probably didn't hurt to clear out the old previews and let Lightroom rebuild them.

Please take a look into your plug-in folder cr2hdr.lrplugin/bin/lib/image/exiftool.pm. Find line $version and tell which version is found.

Code: [Select]
$VERSION = '9.98';
Create a new dual ISO file, import it as DNG and convert it with plug-in. I suppose you will find a file named *-dualiso.txt inside the directory where LR copied your DNG. Look for last lines. I suppose you will find some error message there. File will be absent if conversion worked without error.

Yes, you are right. The *-dualiso.TXT file from a DNG "original" shows that the camera was a Canon EOS 5D Mark III which it was not, it was shot with an EOS-M and there is a warning that exiftool couldn't update DNG tag data. Here is a TXT sidecar file that was made from a DNG file:

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 310e39f on 2014-02-27 05:17:41 UTC by 1p:
Fix ISOs in dual ISO

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)

Input file      : /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2082.dng
Camera          : Canon EOS 5D Mark III
Full size       : 5280 x 3528
Active area     : 5208 x 3476
White level     : 13082
Black borders   : 72 left, 52 top
Black level     : 1987
ISO pattern     : dBBd RGGB
Noise levels    : 8.23 15.58 15.67 7.84 (14-bit)
ISO difference  : 3.10 EV (860)
Black delta     : 3.44
Dynamic range   : 10.47 (+) 9.47 => 12.57 EV (in theory)
AMaZE interpolation ...
Amaze took 3.00 s
Edge-directed interpolation...
Semi-overexposed: 16.03%
Deep shadows    : 43.87%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 4.4 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 6.40 (16-bit), ideally 6.30
Dynamic range   : 12.76 EV (cooked)
Black adjust    : -1
Output file     : /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2082.DNG
**WARNING** exiftool couldn't update DNG tag data

And for comparison, here is a *-dualiso.TXT file that was generated from a cr2 file:

Code: [Select]
    1 image files updated
cr2hdr: a post processing tool for Dual ISO images

Last update: 310e39f on 2014-02-27 05:17:41 UTC by 1p:
Fix ISOs in dual ISO

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)

Input file      : /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/IMG_9603.CR2
Camera          : Canon EOS M
Full size       : 5280 x 3528
Active area     : 5208 x 3476
White level     : 13081
Black borders   : 72 left, 52 top
Black level     : 1992
ISO pattern     : dBBd RGGB
Noise levels    : 8.40 25.06 25.52 7.91 (14-bit)
ISO difference  : 4.06 EV (1671)
Black delta     : -0.23
Dynamic range   : 10.45 (+) 8.76 => 12.83 EV (in theory)
AMaZE interpolation ...
Amaze took 3.39 s
Edge-directed interpolation...
Semi-overexposed: 47.48%
Deep shadows    : 19.52%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.4 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 5.28 (16-bit), ideally 5.26
Dynamic range   : 13.04 EV (cooked)
Black adjust    : 3
Output file     : /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/IMG_9603.DNG

EDIT: Use export option "Export ..." not "Dual ISO converter (cr2hdr)". First option will let you access plug-in's GUI and you can change options/arguments. One of those items is "Mark original as rejected" ...

I'm climbing the learning curve. Here's a screenshot of the plug-in's GUI.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F475%2F19033132733_fafae015a7_z.jpg&hash=bb0f73e1646777defd333f08d5f5efea)

And here are the default values:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F274%2F19658537281_d02b50504f_z.jpg&hash=472fbbe7196b5ccea3b61c48b8883c95)

I'm not sure what you are asking me to do but I'm assuming you want me to change "Mark original as rejected" (it is actually "Set the original photo's flag to rejected") so I did that but I'm still getting the same issue with the metadata not copying over to the converted DNG.

Thanks @Walter Schulz for all your help. I really appreciate it. Hope this can be resolved. There must be other users out there that are experiencing this issue.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 13, 2015, 08:38:10 AM
Looks like your using an older build of cr2hdr. Last one is from around 2015. Should also be replaced.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 13, 2015, 09:23:17 AM
Yes, that's outdated. Update with http://www.magiclantern.fm/forum/index.php?topic=11056.msg147298#msg147298
Old cr2hdr is gone and new cr2hdr was formerly known as cr2hdr-20bit.
If you see a cr2hdr-20bit arguments tab after update you might use tip provided by david az to get rid of old version.
Report back, please.

BTW: CR2 out-of-the-cam is always compressed (lossless).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 13, 2015, 08:34:26 PM
It seems strange that I've got the wrong versions of these files in my system. I downloaded the plug-in from the link that is posted on this topic:
https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.zip

I'm guessing that the plug-in ignores the system wide cr2hdr, exiftool, etc. files and instead uses the ones that are packaged inside of cr2hdr.lrplugin. In order to get to them on the Mac through the Finder a user needs to either use the Terminal or Control click and Show Package Contents. (This may be obvious to developers but not to users that might be trying to follow this conversation.)

So cr2hdr that lives in cr2hdr.3.0-BETA3.zip is:
Code: [Select]
Last update: 310e39f on 2014-02-27 05:17:41 UTC by 1p:
Fix ISOs in dual ISO

While the cr2hdr in http://www.magiclantern.fm/forum/index.php?topic=11056.msg147298#msg147298 (kichetof-lr_cr2hdr-42be6b9232cd) is:
Code: [Select]
Last update: 0c08758 on 2015-05-09 19:25:05 UTC by a1ex:
cr2hdr: Makefile commands to create a zip package for Windows

Here are the tests that I ran this morning:
Note that all of the TXT sidecar files from these tests ended with:
Code: [Select]
**WARNING** exiftool couldn't update DNG tag data
I'd like to get this working but don't want to wear out my welcome. I hope that these posts are proving useful for developers. For people using Lightroom on Mac my suggestion would be not to Copy to DNG on import to Lightroom when shooting dual_iso until this issue is resolved.

@Walter Schulz (and everyone else who jumped in) - thanks for your patience on this. Do you have access to a Mac so that you can duplicate the issue? What would you suggest I try next?

I noticed that in MLExportServiceProvider.lua there is a line that might turn on logging for debugging? (Or does this just turn on/of the sidecar TXT file?) :
Code: [Select]
-- var for log
mlLog = LrLogger('MLDualISO')
mlLog:enable("print") -- replace print with logfile to log into a file in ~/Documents on Mac OS, or My Documents on Windows
--mlLog:disable() -- uncomment it to disable log (only on release version)

I don't have much experience with coding and know ziltch about LUA scripting but I'm willing to try. I guess that the proper way to proceed would probably be to create a fork on bitbucket, make pull requests, etc. I have done that before for some minor changes in the ML unified branch but have no idea where to start on this plug-in. In addition, maybe the repository hasn't been updated in a while? The latest versions on the download page (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/) still have the old exiftool version 9.93 and cr2hdr hasn't been updated to the cr2hdr-20bit version.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 13, 2015, 09:05:25 PM
https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0-BETA3.zip

Outdated. Kichetof has to perform some householding duties ...

I'm guessing that the plug-in ignores the system wide cr2hdr, exiftool, etc. files and instead uses the ones that are packaged inside of cr2hdr.lrplugin.

Works as designed. Plug-ins messing up with system files doesn't sound like the best approach.

In order to get to them on the Mac through the Finder a user needs to either use the Terminal or Control click and Show Package Contents. (This may be obvious to developers but not to users that might be trying to follow this conversation.)

"Beta" rings a bell? But you're right. Unneeded hickups here.

Quote
Description of steps taken

As long you are using an old cr2hdr you will have troubles with Exif, I suppose. Use kitchetof's latest downloads, check exiftool.pm and if it is 9.9.3 I suppose it won't work. My exiftool.exe (Windows) is 9.9.5 and I replaced plug-in's bin\lib files with version 9.9.8. Now it works.

Again: Forget kichetof's bitbucket "Download" (bitbucket.org/kichetof/lr_cr2hdr/downloads/) because he doesn't use this repository for development but a local one and he hasn't synced it in ages.

I might be able to lay my hands on OS X but can't promise.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 13, 2015, 11:25:12 PM
Did a fast try on a dual iso dng file to DNG and it seemed to work without errors on lightroom 4. Seemed to copy the metadata. I disabled the classic cr2hdr, only select cr2hdr20bit. Also I think this contains the next latest cr2hdr20bit from a1ex but you can change to the latest. Don,t know what version of exiftool.
Here it is, try it out
https://drive.google.com/file/d/0B4tCJMlOYfirOFBVVHppbllVeFk/view?usp=sharing
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 14, 2015, 01:37:30 AM
@Danne - Thanks for sharing. I tried it, switching over to cr2hdr-20bit and still have the same metadata issue using the latest Lightroom CC. I also checked out exiftool in the plug-in you're using as instructed by Walter Schulz and:
Code: [Select]
$VERSION = '9.93';
@Walter Schulz - Thanks for all the detailed explanation. I do know about "Beta" software. Several years ago I did some testing for Apple on their then new Final Cut Pro. It was both exciting and frustrating and I got to hang out with engineers so I have an appreciation of just how difficult software development is.

I'm not sure if this is an issue that only affects Mac or maybe Lightroom CC. Then again there is the possibility that I'm doing something wrong. It would be great if there is anyone out there running Lightroom CC on a Mac that could try this out and verify the issue. I'll try sending PM's to kichetof and DeafEyeJedi to see if they can check it out.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 14, 2015, 05:16:11 AM
Now replace bin\lib with the one included in exiftool 9.9.8. and retry.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 14, 2015, 06:59:22 AM
Now replace bin\lib with the one included in exiftool 9.9.8. and retry.

I just did that - same results. Then I also replaced the exiftool executable file, again same results. I even tried copying the binary from /usr/bin into the plug-in with the same results. The TXT file always ends with:

Code: [Select]
**WARNING** exiftool couldn't update DNG tag data
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 14, 2015, 07:43:57 AM
Not that good. Warning doesn't tell that much. On Windows I used Process Monitor to trace all actions and found the string containing call to cr2hdr.exe (+ arguments and stuff) transferred to command line interface (= terminal in OS X slang). Copied string and ran it in commandline and there was an error message about exiftool.pm.
Don't know OS X and how to trace there.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 14, 2015, 08:08:12 AM
@Dfort. Could you upload a sample dual iso dng which doesn,t copies the metadata for me to test?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 14, 2015, 08:19:04 AM
@Danne
Gladly--here you go:
https://www.dropbox.com/s/mtcb9isfjgjxbhm/Puerto_Rico_silver_cam-2098.dng?dl=0
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 14, 2015, 10:01:56 AM
Thanks. I, ll try it out tonight or tomorrow. Not by my computer at the moment.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 14, 2015, 06:25:45 PM
[RESOLVED]
Thanks @Walter Schulz I followed the steps you took on Windows. It was a rather long process but I got it figured out. Long story short, the plug-in is looking for exiftool in the PATH -- /usr/bin in this case. I assumed that it was using the exiftool located inside the plug-in itself, shouldn't this be the case?

If you go to the first post of this topic there is this note about installing the plug-in on a Mac:
Code: [Select]
Mac requirements:

Install dcraw and exiftool, you can use this package from a_d_.

The installer apparently puts  version 9.34 of exiftool in /usr/bin.

So now that the story is getting longer, here are the steps I took to figure this out. (Walter Schulz, you can save some time and just skip to the bottom of this post.)

Not that good. Warning doesn't tell that much. On Windows I used Process Monitor to trace all actions and found the string containing call to cr2hdr.exe (+ arguments and stuff) transferred to command line interface (= terminal in OS X slang). Copied string and ran it in commandline and there was an error message about exiftool.pm.
Don't know OS X and how to trace there.

On Mac there is the Console app. Here's the output when running the plug-in on a dual_iso dng:
Code: [Select]
7/14/15 7:13:24.001 AM Adobe Lightroom[9933]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
7/14/15 7:13:25.716 AM Adobe Lightroom[9933]: MLDualISO DEBUG Path: /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2098-dualiso.dng
7/14/15 7:13:25.716 AM Adobe Lightroom[9933]: MLDualISO DEBUG Path DNG: /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2098-dualiso.DNG
7/14/15 7:13:25.716 AM Adobe Lightroom[9933]: MLDualISO DEBUG Path TXT: /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2098-dualiso.TXT
7/14/15 7:13:25.716 AM Adobe Lightroom[9933]: MLDualISO DEBUG first: /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2098-dualiso
7/14/15 7:13:25.717 AM Adobe Lightroom[9933]: MLDualISO DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax
7/14/15 7:13:25.717 AM Adobe Lightroom[9933]: MLDualISO DEBUG command : exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr20bit" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax "/Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2098-dualiso.dng" > "/Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2098-dualiso.TXT"
7/14/15 7:13:32.817 AM lsregister[11305]: LaunchServices: Begin database seeding
7/14/15 7:13:32.817 AM lsregister[11305]: LaunchServices: Completed database seeding
7/14/15 7:13:42.939 AM Adobe Lightroom[9933]: MLDualISO DEBUG success: 1 - nodual: 0 - dual: 0 - format: 0 - fail: 0 - errorMsg: 0

Ok--I can see the string containing call to cr2hdr20bit. It already processed that file so I'll pick another unprocessed dual_iso dng and run it in the Terminal:
Code: [Select]
Rosie-Forts-Computer:~ rosiefort$ exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr20bit" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax "/Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2105.dng" > "/Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2105-dualiso.TXT"
Undefined subroutine Image::ExifTool::IsDirectory called at /usr/bin/lib/Image/ExifTool.pm line 3290
Undefined subroutine Image::ExifTool::Exists called at /usr/bin/lib/Image/ExifTool.pm line 3290

[Process completed]

Ok--running from the command line it looks for ExifTool.pm in /usr/bin/lib/Image/ but I suppose that the plug-in uses the one located inside of the plug-in package. So, what have I got in /usr/bin/lib/Image ?
Code: [Select]
$VERSION = '9.34';This doesn't make sense because I went through the installation instructions when I downloaded Image-ExifTool-9.98.
Code: [Select]
perl Makefile.PL
  make
  make test
  make install
Here's what is happening:
Code: [Select]
Rosie-Forts-Computer:Image-ExifTool-9.98 rosiefort$ sudo make install
Password:
Appending installation info to /opt/local/lib/perl5/5.16.3/darwin-thread-multi-2level/perllocal.pod
Rosie-Forts-Computer:Image-ExifTool-9.98 rosiefort$ which exiftool
/usr/bin/exiftool
It seems that ExifTool.pm 9.98 is installed in /opt/local/lib/perl5/site_perl/5.16.3/Image and 9.34 is installed in /usr/bin/lib/Image. Assuming that the ExifTool installer put it in the right place I deleted the 9.34 version in /usr/bin that I believe was put there when I ran the installer from a_d_'s OSX_cr2hdr as instructed in the installation instructions for this plug-in. However, that caused a "command not found" error so I copied version 9.98 of exiftool and its lib into /usr/bin and it worked from the command line. To my surprise it also worked when used with the plug-in in Lightroom.

So the plug-in is now working with dual_iso DNG files on this Mac but I think that maybe there are a few points that the developers might consider.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 14, 2015, 07:17:35 PM
Fine!
Consider updating to latest plug-in version (which includes updated cr2hdr).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 14, 2015, 08:50:37 PM
Consider updating to latest plug-in version (which includes updated cr2hdr).

First thing I did after figuring this thing out. Everything is working great now.

I was wondering, is the cr2hdr source that is in the bitbucket unified branch the latest 20bit version? It looks like exiftool-bridge.c is where exiftool is being called and it doesn't have an option for a path argument. I suppose that in Windows it look in the current path (inside the plug-in directory) first while on a Mac it will use whatever it finds first the system path (/usr/bin in my case).

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 14, 2015, 10:04:19 PM
Nice work @dfort.
I think mac cr2hdr20bit binary calls for both dcraw and exiftool from /usr/bin/. At least that was my conclusion when I was trying to create a workflow service directing a script to another adress. At least exiftool was problematic to redirect.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 14, 2015, 11:41:26 PM
Ready for the next issues?

I thought I'd do some Lossless DNG Compression so I selected it in the plug-in's GUI and all of the radio button selections disappeared except for the one I selected.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F489%2F19511598300_cf1d437357_z.jpg&hash=e9c8aa1cb7788805d38688023706b0f7)

Closing and relaunching the plug-in GUI restored the radio button selections.

When I compared the file size of the compressed dng it was the same as the uncompressed file. Checking the TXT file I found this:

Code: [Select]
Puerto_Rico_silver_cam-2095-dualiso.DNG
/Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2095-dualiso.DNG: copying EXIF from /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2095-dualiso.dn6
Adobe DNG Converter not found.

Note that in the pop up window after the export is finished there is no error message.

(Nit-picky note: the third time the file name is displayed it ends with a lowercase "dn" and the number six.)

Sorry to use up bandwidth on the forum, this is better handled in bitbucket but since development is being done "off the grid" so to speak I thought I'd bring it up here.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 14, 2015, 11:52:46 PM
Just tried "compress" option which worked but not "compress-lossy".  I have adobe dng converter installed in applications folder. Has to be downloaded externally. I assume you have it installed already? The dn6 I think came with latest cr2hdr20bit. Changes names in process and in the end with .DNG. Also when compressing the file is renamed again since adobe dng converter doesn,t allow overwriting.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 15, 2015, 02:26:28 AM
Learning something new every day.

Found the latest version (9.1) of the Adobe DNG Converter here:
http://www.adobe.com/support/downloads/thankyou.jsp?ftpID=5914&fileID=5941

Silly me, I thought that it was installed along with Photoshop, Lightroom and Adobe Camera Raw.

Now I'm able to make lossless DNG files that are about half the size of the uncompressed DNG's.

Code: [Select]
Output file     : /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2103-dualiso.DNG
/Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2103-dualiso.DNG: copying EXIF from /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2103-dualiso.dn6
Found /Applications/Adobe DNG Converter.app/Contents/MacOS/Adobe DNG Converter
Compressing /Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2103-dualiso.DNG...
"/Applications/Adobe DNG Converter.app/Contents/MacOS/Adobe DNG Converter" -dng1.4  -o "Puerto_Rico_silver_cam-2103-dualiso.DNG" "/Volumes/Silver/Pictures/LightroomMasters/2015/2015-07/2015-07-06/Puerto_Rico_silver_cam-2103-dualiso.DNG.DNG"

From the message in the TXT log file it seems that the final file was named to *.DNG.DNG but that isn't the case. The only difference seems to be that instead of 37.6 MB files they are 17.4 MB (give or take) or about the same size as the "original" Lightroom dng files. That's great news because the HDR files created in Lightroom from a three shot bracket set are weighing in at around 73 MB.

I also got the same issue as Danne with compress-lossy.

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 0c08758 on 2015-05-09 19:25:05 UTC by a1ex:
cr2hdr: Makefile commands to create a zip package for Windows

Unknown option: --stripe-fix--compress-lossy

@kichetof and @Walter Schulz - Just a suggestion--add a note about adding Adobe DNG Converter to the plug-in installation instructions.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 15, 2015, 06:19:20 AM
Wow just digged through the past few pages of fun stuff. Good work @dfort and Thanks to @Walter Schulz & @Danne for their contributions on getting this resolved.

I admit that I have not been using this plugin in LR5 for quite a few months now... Been busy with Video shooting and work has taken my time away from Dual-ISO Photography.

However, I just decided to give it a go with the BETA3 20-bit on my Mac Mini (I downloaded all of the requirements and installed back in Feb 2015) just to be sure and ran through just fine as expected.

Here are some samples of the workflow:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F425%2F19519440728_ae7c09ba2f_n.jpg&hash=951c7718617203b694b854ec34af653b) (https://flic.kr/p/vJSeFw)  (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F280%2F19084904134_5963081873_n.jpg&hash=00fa8fcf656b320ac93305e571a60fba) (https://flic.kr/p/v5t86h)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F526%2F19700326772_d7661414d6_n.jpg&hash=6a38537ccf462baa6829cc06403e0f0a) (https://flic.kr/p/w1RjNq)  (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F451%2F19084906834_10f322e003_n.jpg&hash=0556f2391956881203fa4185925bcbdf) (https://flic.kr/p/v5t8TQ)

So it appears that the Metadata did come through since I can still see them with the converted DNG within PS. (or was the issue only directly for LR?)

Thanks for reviving up this thread alive again!

 8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 15, 2015, 06:43:43 PM
Are you sure? In the Terminal run exiftool on a DNG file before and after running it through cr2hdr and see if the metadata copied over. Also check your version of exiftool.

Code: [Select]
exiftool -ver
If you followed the plug-in install instructions you will have version 9.34 from a_d_'s OSX_cr2hdr package which seems to have an issue with metadata when used on DNG files with the plug-in. Version 9.98 of exiftool fixed that issue for me.

This doesn't affect cr2 dual_iso files.

There is another possibility that I just thought of. The DNG files I was using were using lossless compression and when I was doing these tests I didn't have Adobe DNG Converter installed. In any case we should probably be using exiftool 9.98 instead of an earlier version with this plug-in.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 15, 2015, 06:48:37 PM
The DNG files I was using were using lossless compression and when I was doing these tests I didn't have Adobe DNG Converter installed.

Sorry? cr2hdr without DNG converter will produce uncompressed DNG only
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 15, 2015, 07:12:50 PM
The DNG files I was running cr2hdr on were compressed on import to Lightroom. I was reading compressed DNG's not writing them.

I didn't test it because I would have to uninstall Adobe DNG Converter and regress to exiftool 9.34 to see if that was the problem when I first reported the metadata issue. It seems better to continue moving forward now that things are working. I sent a_d_ a PM via bitbucket to ask if OSX_cr2hdr could be updated with exiftool 9.98.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 15, 2015, 07:35:33 PM
Most likely deafeyejedi got exiftool version from cr2hdr-r installed in usr/bin. Adobe dng converter most likely will not interfere at all with current metadata issues. What would be welcome is to correct the compress-lossy argument. It, s actually useful on still image files and files are greatly reduced in size.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 15, 2015, 08:10:08 PM
@Danne's correct on that. That's the beauty of his 'cr2hdr-r' app which contains all the updated requirements for the most part thus the reason(s) why this plugin worked fine for me in LR5.

I also agree on the fact that we should definitely try and figure out how to resolve the compress-lossy argument since it is indeed very intuitive for these stills to be greatly reduced in size!

@dfprt: I just ran Terminal to verify my exiftool's version -- came up 9.69 and I guess I should update that to the latest on the MBP? (I'll double check the exiftool's version on my MacMini later tonight after work at home) though I admit it could be 9.69 since it's most likely installed from cr2hdr-r.

@Danne: I'll double check your latest beta app but my gut feeling is that it still uses 9.69 -- perhaps it can be replaced with newer version manually within OX S, right?

*UPDATE*

I just updated Exiftool to latest (9.98) and will try to run Dual-ISO files in LR5 with this plugin on MBP and will report back. Thanks!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 15, 2015, 09:11:39 PM
Could be correct. Havn, t updated exiftool in a while.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 15, 2015, 09:23:06 PM
I'm new to dual_iso and was checking out the various tools. Obviously I got hung up on the Lightroom plug-in.

@DeafEyeJedi I just tested exiftool 9.69 and it worked fine with the Lightroom plug-in workflow. In fact I installed 9.69 by removing what I had in /usr/bin and running the cr2hdr-r installer. After the test I put 9.98 back into /usr/bin just because--

@Danne I finally got around to trying out your dualiso_to_DNG Mac services app and wow, so simple and elegant to use. It doesn't even use exiftool and there's no problem losing metadata. I'm also checking into your cr2hdr-r. Maybe this should replace the instructions to use the OSX_cr2hdr package from a_d_ as a simple way to install dcraw and exiftool dependencies for the Lightroom plug-in?

Of course I also agree that the compress-lossy issue would be nice to resolve. Too bad the development for the plug-in is not taking place on the ML bitbucket repository.

Just wondering, does compress-lossy work when using cr2hdr on the command line? The problem may not be in the plug-in.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 15, 2015, 09:34:14 PM
@dfort: Ah, Gotcha that makes sense! Please continue to play with @Danne's incredible app/service workflow since it works really well for most situations and it actually does all the dirty work as well as organizing files into folders for you. Just simply laid back and enjoy a cup of tea while you're at it or sleep overnight with ease!

Well I am glad you are still hung on using Dual-ISO -- it's one of the best features for ML of all time and definitely takes time getting used to but you're getting closer!

Strange that you managed to get this plugin to work again after downgrading/upgrading the exiftool because for me it was rather strange and I knew I shouldn't have tried fixing what's not broken, right? lol

Anyway so on my MBP after updating the exiftool to the latest and tried running LR5 again with the plugin which now is popping up windows saying "Please report to ML forum. An internal error has occurred: Failed to find a place for the imported file" in which I have tried both with original and new folder but neither worked. I'll have to investigate further why it works on Mac Mini but not the MBP.

and on top of that it's even more odd that both of the Beta3 20-bit plugin's are showing different options to choose from in between my MBP and Mac Mini.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F479%2F19537783140_b679034598_n.jpg&hash=924fd89c2fa7883a6f3afdc986e06db7) (https://flic.kr/p/vLuff1)

On the MBP it isn't showing the option to choose "KEEP ORIGINAL DNG AFTER CONVERSION" but it does on the very same plugin in Mac Mini, strange?

p.s. Yes, both are running the latest OS X (10.10.1) in case you guys were curious.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 15, 2015, 09:37:47 PM
Compare plug-in files. There must be differences

And something we have to settle: Go on with Beta3 linked in first post or updated (latest) files?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 15, 2015, 09:44:16 PM
@Walter Schulz:

I can't compare the plug-in files until I get home tonight (I let this one slip under my radar by installing 3.0 instead of 3.2). Meanwhile I'll continue to investigate further on making this to work on MBP.

I personally think we should update to the latest file instead of using the links in the first post (You're referring this to the files from  a_d_, correct?)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 15, 2015, 09:53:16 PM
@dfort.
Compresslossy works fine with cr2hdr20bit binary. It can be tested in my automator workflow. Simply write command straight to one of the files according to instructions in first post. (Off topic)
Wouldn, t advice using my install pack since there is a lot of other stuff but Kichetof could update his first post when he is ready. His lightroom integration is really cool.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 15, 2015, 09:58:54 PM
Agreed with @Danne about not recommending using his install pack because it has a whole bunch of files that are specifically made in order for his app to run smoothly.

Hopefully @Kichetof would either be busy and reading all of this or he is just simply MIA until then since his LR integration plugin is still a useful tool especially for TL.

*UPDATE*

Sorry guys I let this one slip under my radar -- realized I downloaded Beta 3.0 on MBP when it needs to be updated to Beta 3.2 from this post (http://www.magiclantern.fm/forum/index.php?topic=11056.msg146729#msg146729post) #616.

*UPDATE 2*

My apologies but I was eager on getting this resolved by then decided to try Dual-ISO files from both EOS-M and 5D3 which spitted out just fine with 3.2 beta BUT then I tried again with the same 70D files which kept giving me the same error I reported earlier (I thought @kitchetof updated his cr2dhr binary just for the 70D recently?) so I am not sure what the heck is going on in here on my MBP but until then... Will have to wait until I get home tonight after work to test this further. It seems to be the 70D files issue but again I'm not too sure yet.

If anyone out there wants to try a 70D Dual-ISO file to confirm if this is not only happening to me, Thanks!

https://mega.co.nz/#!7t8wVBKJ!Udj5CLNekaISLDcGtmtVznbUVGpMeMydYnmb40p3p38
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: mylesgray on July 15, 2015, 10:12:25 PM
Hi Guys,

Seeing some strange behaviour with LR 3 BETA 3 and BETA 3.2 plugins, after conversion my DualISO files exhibit a single pixel line (seems to be the recovery ISO line) on the very bottom edge of the photo.

See attached CR2 and DNG, also conversion output.

https://www.dropbox.com/sh/ow65u37rqajvukh/AAB84YJM-yfw8pymFNdSosBya?dl=0

Is this a known bug or new?

Myles
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 15, 2015, 11:47:10 PM
@mylesgray - Welcome to the forum. I checked out your files and I've never seen that on my dualiso.DNG's so I processed your cr2 file and it came out clean on my system. (Read on for a possible solution.)

@DeafEyeJedi - The Lightroom plug-in development could use some housekeeping but it looks like kichetof is taking a break. The latest version that Walter Schulz pointed me to is here: http://www.magiclantern.fm/forum/index.php?topic=11056.msg147298#msg147298 It looks like you already grabbed it a while ago but maybe it only got on one of your computers? This version only uses the cr2hdr 20bit version and you should see just one cr2hdr options tab on the plug-in GUI.
If anyone out there wants to try a 70D Dual-ISO file to confirm if this is not only happening to me, Thanks!
I tried it on my system and it worked fine.

@Danne I understand your point about not wanting to have someone install your package in order to get the dependencies for another developer's work. In fact all of the dependencies for the plug-in are inside of the plug-in package but because of the way things are set up on OS-X it uses the exiftool and dcraw that are installed on the system--specifically /usr/bin. At least I found out that when cr2hdr calls exiftool there is no option to specify the path to exiftool (exiftool-bridge.c).




Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 16, 2015, 12:12:46 AM
@mylesgray: Likewise and also confirmed that it spitted out just fine with your file.

@dfort -- Thanks for confirming that the problem is ON ME in particular with this MBP and not the 70D files ( which I figured it would be ) because I have used this plugin with 70D files before on MacMini after he released 3.2 BETA.

I'm still not quite sure what the problem could be but I've tried reinstalling the exiftool and dcraw but it stills doesn't work with 70D files on my end.

All other camera's Dual-ISO files do spit out just fine. Not much for me to do until I get home tonight after work to compare MBP with MacMini.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 16, 2015, 12:13:33 AM
@dfort. Do you have any idea where the compress-lossy argument is called from in the plugin? If that is fixed it would be very nice.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 16, 2015, 12:29:30 AM
@dfort. Do you have any idea where the compress-lossy argument is called from in the plugin? If that is fixed it would be very nice.

Same here. Please let us know asap. Thanks!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 16, 2015, 12:35:00 AM
@DeafEyeJedi @Danne Quick enough for you guys? I got to take a break from my keyboard!

It looks like the default settings and where the options are passed are in MLExportServiceProvider.lua and the file that selects the "--compress-lossy" is in MLProcess.lua.

I ran a compress-lossy test and checked the Console to see what arguments the plug-in was passing:

Code: [Select]
7/15/15 3:25:40.500 PM Adobe Lightroom[511]: MLDualISO DEBUG command : exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix--compress-lossy --wb=graymax "/Volumes/Silver/Pictures/LightroomMasters/tests/IMG_9584-dualiso.dng" > "/Volumes/Silver/Pictures/LightroomMasters/tests/IMG_9584-dualiso.TXT"

It looks to me that the issue is in "--stripe-fix--compress-lossy" note that there is no space between these arguments.

*UPDATE*

Found the problem. In MLProcess.lua change this line:
exportSettings.compress == 1 and " --compress" or ((exportSettings.compress == 2) and "--compress-lossy" or ""),

Add a space at the first quote of --compress-lossy so that it looks like this:

Code: [Select]
exportSettings.compress == 1 and " --compress" or ((exportSettings.compress == 2) and " --compress-lossy" or ""),
Now compress-lossy works.

Big difference in file size, the file I tested went from about 20 MB (lossless compression) to 5.3 MB.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 16, 2015, 01:03:20 AM
Awesome!
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 16, 2015, 01:25:17 AM
20 MB compress file to 5.3 MB compress-lossy file = HOLY S#!t!

Excellent find @dfort and will def try your suggestion asap.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 16, 2015, 09:47:24 AM
Sorry for my bad English

No exif for me with the Lightroom Plugin's

My version Is "unzip, rename kichetof-lr_cr2hdr-42be6b9232cd to cr2hdr.lrplugin"
whit https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.lrtemplate

CANON 70D - Lightroom 6.01
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 16, 2015, 09:54:18 AM
As discussed above:
- OS X: Install Exiftool 9.9.8
- Windows: Replace bin\Exiftool.exe and bin\lib directory in with contents in Exiftool 9.9.8
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 16, 2015, 10:04:47 AM
On Windows 7

I already replace the " bin \ lib directory in 9.9.8 with content in exiftool " but not the exiftool.exe
And I had exif but the photo was becoming overexposed
I will try tonight.
thank you
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 16, 2015, 05:51:54 PM
As far as I can tell this is the "official" home of ExifTool:
http://www.sno.phy.queensu.ca/~phil/exiftool/
Note that there are Mac and Windows downloads with detailed instructions on how to install. The Windows installation is a bit confusing--you need to rename exiftool(-k).exe to exiftool.exe but it doesn't say exactly where you need to move the file so that it is available system wide.

As discussed above:
- OS X: Install Exiftool 9.9.8
- Windows: Replace bin\Exiftool.exe and bin\lib directory in with contents in Exiftool 9.9.8

@Walter Schulz - there is a "bin" directory inside of the plug-in, is that what you are referring to or is this something that is in the root directory of the startup drive?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 16, 2015, 06:12:22 PM
Running plug-in in Windows will use cr2hdr.lrplugin\bin as "working directory". No need to change that.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 17, 2015, 12:40:16 AM
@Walter Schulz - Thanks for clearing that up. Just wondering, on Windows can't you just delete the bin\lib directory and everything should work fine as long as you're running exiftool.exe version 9.98?

I'm probably testing your patience but it seems to me that the bin\lib contents isn't necessary on Windows. What's in there are library files for ExifTool and the Windows executable should include those libraries. A few days ago you mentioned a fix that worked on Windows by replacing the bin\lib directory: http://magiclantern.fm/forum/index.php?topic=11056.msg151047#msg151047

Strange, why would the official ExifTool Windows binary distribution not include the library files if they are necessary?

On Linux and Mac exiftool is a perl script but on Windows it apparently doesn't have any dependencies so that means perl is also included in the binary. Of course this makes for a rather bloated 5.4 MB executable file.

What I'm getting at is that there are several files in the plug-in that aren't being used and perhaps should be eliminated to avoid confusion. On my system I deleted exiftool, dcraw and the lib directory from the plug-in and it still works fine. For the Mac only cr2hdr is needed in cr2hdr.lrplugin/bin.

*Update*

By the way, I forgot to mention that there is no Windows executable in https://fossies.org/linux/misc/Image-ExifTool-9.98.tar.gz/ or http://www.sno.phy.queensu.ca/~phil/exiftool/Image-ExifTool-9.98.tar.gz
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 17, 2015, 12:41:43 PM
Daniel, IMO you truly don't have to be afraid bothering folks around here. I'm speaking for myself - of course - but you're helping a lot driving this project forward. Thorough testing, bug reports with detailed descriptions, reasonable suggestions (and not that much mixing up facts and conclusions) -> valuable input. Keep 'em coming ...

Back on topic: You nailed it!
Fun thing is:
- If bin\lib is present it will be used by Exiftool.exe. And Exiftool's version doesn't matter at all. It now depends on Exiftool.pm's version.
- If lib directory is absent: Exiftool will work without error and Exif will be transferred just fine to output file.
So just delete/rename "lib" and your good to go with exiftool v9.9.5.

Tested with Windows 8.1. No Perl library installed but using plug-in files and directories only. I'm wondering what will happen if library is installed in search path (roughly equal to placing files into bin in OS X/Unices).

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 17, 2015, 07:45:51 PM
Great, now how do we get the developer's attention so that these updates get incorporated into the plug-in?

@WalterSchulz - Is that the proper way to use @name for you? I assume it doesn't work with the space. In any case, do you have the radio button on the GUI issue that I described on your Windows system?

Selected an option that uses radio buttons in the plug-in's GUI and all of the radio button selections disappeared except for the one selected.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F489%2F19511598300_cf1d437357_z.jpg&hash=e9c8aa1cb7788805d38688023706b0f7)

Closing and relaunching the plug-in GUI restored the radio button selections.

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 17, 2015, 09:09:03 PM
Great, now how do we get the developer's attention so that these updates get incorporated into the plug-in?

Piece of cake, sort of: Drop a beer keg with note attached to his front door somewhere in/nearby Lausanne, Swiss.

@WalterSchulz - Is that the proper way to use @name for you?
Default in web/internet forums is informal.

Selected an option that uses radio buttons in the plug-in's GUI and all of the radio button selections disappeared except for the one selected.
Not a problem here.
2 systems tested
- Windows 8.1, LR CC, Intel HD Graphics 5300
- Windows 7, LR CC, NVIDIA GeForce GTX 750 Ti

I suppose this is where Windows and OS X platforms may react in different ways. Found something about troubleshooting GPU errors in LR but in doubt it applies here: https://helpx.adobe.com/lightroom/kb/lightroom-gpu-faq.html
You may try to disable GPU support.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 17, 2015, 09:23:27 PM
-DELETE-
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 17, 2015, 11:42:40 PM
I disabled GPU acceleration (NVIDIA GeForce GT 750N OpenGL Engine) but still have the same issue.

Beer? Here's a few I've got around the house. Maybe a keg of Arrogant Bastard is appropriate?

Shot on a Canon EOS-M with Dual ISO processed (ISO 100/800) in Lightroom with the cr2hdr plug-in.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F261%2F19594840220_a53c153676_z.jpg&hash=30bdf888be1bc0109a8dfc2861ef9ba6)

Amazing to capture all the detail in the darkest to lightest areas. The bottles were indoors and the background is a bright sunny day in Redondo Beach, California.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 17, 2015, 11:56:17 PM
No, you got the wrong impression about kichetof. He doesn't deserve Fucking Hell (https://en.wikipedia.org/wiki/Fucking_Hell) either.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 18, 2015, 12:25:41 AM
Ha ha, good one!

@kichetof -- Yo Hoo! Got a beer for you!

Anyone spotted him? Last seen on June 06, 2015, 04:15:35 PM
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 18, 2015, 09:25:42 AM
Kichetof is the best.

@dfort
A suggestion.
Assemble the newly updated plugin package removing unnessecary files and also include the new argument string which fixed the " compress-lossy" error and just send Kichetof a pm with the new package.

Another (I think doable) suggestion for Kichetof to check would be that the plugin itself would install dcraw and exiftool on first run from within lightroom if not already installed. Then the files could be included in the plugin pack and only used if necessary. Of course I,m not a luascripter but I can,t see why it wouldn,t work. Hm, might be root privilige issues in /us/bin/ when I think of it. Well. Updates needed somehow.


Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 18, 2015, 10:56:41 AM
Just an idea for OS X plug-in: Would it be possible for plugin to open terminal, define local PATH=$PATH:<path to cr2hdr, dcraw, exiftool> and call cr2hdr with arguments after?

And for development we can fork kichetof's stuff.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 19, 2015, 03:05:19 AM
There are lots of ways to improve the user experience for Mac--make an installer that puts all the dependencies in the right place, define a local path by having the lua script call a system command, modify cr2hdr to accept a path argument when calling exiftool and dcraw, etc. The tricky part is not breaking the plug-in for Windows systems.

All of this is way beyond my coding abilities.

I did a little detective work on the Internet and think I may have found kichetof on Flickr, Linkedin and Facebook. Hopefully I'll be successful at luring him back to this project. Either that or someone is going to think I'm some sort of a creepy Internet stalker trying to lure people with an offer to buy them a beer.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 21, 2015, 08:03:49 PM
Bad :(

CR2 Export to JPEG
http://dl.free.fr/tw4ztVsDw

Export with original plugin but no exif
http://dl.free.fr/tjbu7Gpp2

Export with change exiftool and/or lib ( exif OK but no Good )
http://dl.free.fr/thO53IFRk
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 21, 2015, 08:16:04 PM
CR2 Export to JPEG
http://dl.free.fr/tw4ztVsDw

? What are you trying to show? That exporting Dual-ISO.CR2 to JPG gives garbage output?
This "workflow" will not work, nobody ever made a statement it should. Quite the opposite: Dual-ISO.CR2 has to be processed by cr2hdr or equivalent tools to merge interlaced lines.

Export with original plugin but no exif
http://dl.free.fr/tjbu7Gpp2

Yes, that's just discussed in posts above. Nothing new here.

Export with change exiftool and/or lib ( exif OK but no Good )
http://dl.free.fr/thO53IFRk

You may upload your Dual-ISO.CR2 so others may try to show better results.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 22, 2015, 02:18:21 AM
Bad :(
Yeah, Bad. I'm not getting anything from those links other than a French website with a bunch of advertisement. Were the files removed?

A few days ago I processed some raw dual iso files from users that were having problems but you really need to provide the raw files. We also need more information, like Windows or Mac? Have you updated to the latest version of the plug-in? (Rather convoluted at the moment but doable.)

I'm assuming that one thing you did was to export a dual iso raw file to jpeg without running it through cr2hdr. That's not how it works. This is how it works:

http://acoutts.com/a1ex/dual_iso.pdf

The Lightroom plug-in just makes it easier to do for people that are more familiar with Photoshop/Lightroom than the command line.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 22, 2015, 12:07:50 PM
Hi,

I know used the plugin, which works very well with LR5.5.

With LR6,
when I use the version "kichetof lr_cr2hdr-to-42be6b9232cd cr2hdr.lrplugin" with the modified CH2HDR.template, I get an image well exposed but no EXIF.
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F380%2F19884361696_4b0bc91c68_c.jpg&hash=5e568b470c19fced4b7061abbe051d0c) (https://flic.kr/p/wi7xYm)dualno (https://flic.kr/p/wi7xYm) by Stephane CAIRE (https://www.flickr.com/photos/msaphotos/), sur Flickr

If I apply the Walter advice by replacing the / LIB / or replacing the exiftool.exe, I find EXIF, but the photo is overexposed.
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm4.staticflickr.com%2F3771%2F19722530428_1e0e6e63c7_c.jpg&hash=83951618413bd474db18347aacaf825a) (https://flic.kr/p/w3P8b5)dualexif (https://flic.kr/p/w3P8b5) by Stephane CAIRE (https://www.flickr.com/photos/msaphotos/), sur Flickr

I specified that no adjustment is applied to compare the two files
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 22, 2015, 12:20:22 PM
Again: Without original file we're unable to help.
Without original file (untreated CR2) we cannot reproduce your findings.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 22, 2015, 06:44:38 PM
@snakec:

Seriously just upload the original CR2 file already otherwise you're just basically wasting our time.

We obviously don't mind helping out but you simply just won't let us unless you can provide us original samples.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 22, 2015, 10:07:04 PM
@snakec - I think I understand your issue. You have the plug-in installed in Lightroom 6 and that is working fine and you also have it installed in Lightroom 5.5 and there it is not working properly.

We need some information from you in order to help.

Are both versions of LR running on the same or different computers?

What operating system are you using, Mac or Windows?

For now I'm assuming that you are on Windows because you mentioned exiftool.exe -- that is for Windows only. Remove the lib that is inside the plug-in's bin directory! That is what was causing the problems in the Windows installation.

If you are on Mac, remove everything from the bin directory except for cr2hdr. On the Mac exiftool (along with its associated lib directory) and dcraw should be installed in /usr/bin.

Hope this helps.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 23, 2015, 02:41:40 PM
Hi

Put simply,
When I used the plugin with LR 5.5, it worked perfectly
Since the switch to LR6, my pictures have become overexposed,
Since the new version of the plugin released after May 12,
The plugin provides well exposed photos, without EXIF.
I tried the advice of Walter, but if my pictures retrouvre their EXIF she again become overexposed.

I am on windows 7 pro, Canon 70D, Lightroom 6.01

Best Regards

ps: Walter, can share your "ch2hdr.lrplugins" to test it?

Photo example of dual iso treated with the plugin, it's good but no exif
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fscontent-cdg2-1.xx.fbcdn.net%2Fhphotos-xtp1%2Fv%2Ft1.0-9%2Fs720x720%2F11703323_797447633704595_1703019804290960729_n.jpg%3Foh%3Df1aef04c5c056c9204e53816eb9bb6f5%26amp%3Boe%3D56531969&hash=d823c449a74dfa4bb729cdc707ebbeda)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fscontent-cdg2-1.xx.fbcdn.net%2Fhphotos-xtp1%2Fv%2Ft1.0-9%2Fq81%2Fs720x720%2F11738050_797447350371290_691531189947787595_n.jpg%3Foh%3D84b0dad246be5030c5eca249f4eed575%26amp%3Boe%3D5646BABD&hash=60578caa1fe6373747cd12fcb8f470e8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 23, 2015, 02:46:05 PM
@snakec:

Seriously just upload the original CR2 file already otherwise you're just basically wasting our time.

We obviously don't mind helping out but you simply just won't let us unless you can provide us original samples.
I'm not returned home since I post a cr2 tonight
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 23, 2015, 03:31:52 PM
@snakec - I think I understand your issue. You have the plug-in installed in Lightroom 6 and that is working fine and you also have it installed in Lightroom 5.5 and there it is not working properly.

Ok, so it looks like I didn't understand your issue--and I'm quoting myself  :(

I'm not on Windows so I don't have the plug-in configured for your system but have you removed the cr2hdr.lrplugin\bin\lib directory? You may also want to try the latest version of ExifTool (http://www.sno.phy.queensu.ca/~phil/exiftool/). (They have updated it to version 9.99 recently and I haven't checked it out yet.)

Apparently there are two fixes that work for Windows, replacing the lib directory in the plug-in with an updated one or simply removing the lib directory. I'd go for the simplest solution.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 23, 2015, 03:55:04 PM
Just a warning for Mac users--I just tried out ExifTool 9.99 and the installer will remove the previous version in /usr/bin and put the new version in /usr/local/bin. That is probably a better place for it but it breaks the plug-in. I made a symbolic link to it in /usr/bin and it did work (moving the files should also work) so it looks like maybe something is hard coded to /usr/bin/exiftool instead of searching the $path?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 23, 2015, 05:07:56 PM
Ok, so it looks like I didn't understand your issue--and I'm quoting myself  :(

The error he described:
Processed file has no exif but good exposure with plug-in out-of-the box.
Processed file has exif but overexposed if using workaround.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 23, 2015, 06:53:54 PM
There is also the part about the same plug-in working fine in LR 5.5 but not in LR 6. --or did he change LR version and plug-in version at the same time? That would be changing two variables.

In any case I'm on a Mac and Lightroom CC 2015.1 so I should stay out of Windows LR 6 issues.

Regarding the Mac ExifTool issue I just discovered--it would be nice if the plug-in uses the exiftool and dcraw that kichetof put in cr2hdr.lrplugin/bin but it uses the system wide versions instead. I checked the cr2hdr source code in the unified branch but don't see anything that would make /usr/bin/exiftool work and not /usr/local/bin/exiftool, they are both in the $path. Is the cr2hdr in the plug-in a different version?

BTW--I still haven't heard from kichetof though I did find someone by the same name in Switzerland.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 23, 2015, 07:24:41 PM
Hi,

I know used the plugin, which works very well with LR5.5.

With LR6,
when I use the version "kichetof lr_cr2hdr-to-42be6b9232cd cr2hdr.lrplugin" with the modified CH2HDR.template, I get an image well exposed but no EXIF.
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F380%2F19884361696_4b0bc91c68_c.jpg&hash=5e568b470c19fced4b7061abbe051d0c) (https://flic.kr/p/wi7xYm)dualno (https://flic.kr/p/wi7xYm) by Stephane CAIRE (https://www.flickr.com/photos/msaphotos/), sur Flickr

If I apply the Walter advice by replacing the / LIB / or replacing the exiftool.exe, I find EXIF, but the photo is overexposed.
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm4.staticflickr.com%2F3771%2F19722530428_1e0e6e63c7_c.jpg&hash=83951618413bd474db18347aacaf825a) (https://flic.kr/p/w3P8b5)dualexif (https://flic.kr/p/w3P8b5) by Stephane CAIRE (https://www.flickr.com/photos/msaphotos/), sur Flickr

I specified that no adjustment is applied to compare the two files

CANON 70D , WINDOWS 7, LIGHTROOM 6.01
Plugin :
http://www.magiclantern.fm/forum/index.php?topic=11056.msg147298#msg147298
Template :
http://www.magiclantern.fm/forum/index.php?topic=11056.msg147348#msg147348

CR2 :
https://mega.co.nz/#!fsRUUI5K!Kfs9OtWGe8GaOCjNGKnO7HeOcc_EnvbnTVrIKbfjYEE
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 23, 2015, 08:26:18 PM
Thanks for the files. I'm able to reproduce your error in LR CC on Windows 8.1. Have to play around a bit now.

EDIT: File made with 7D just works fine with both configurations.
Big question now is which application is messing up with 70D files. LR or cr2hdr?

Guys, please test in OS X and report back.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on July 23, 2015, 09:59:49 PM
Sounds like it's related to the cr2hdr binary which may need to be replaced with latest in order to work with 70D files?

I'll check and confirm this as soon as I get on my MBP.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 23, 2015, 10:05:38 PM
I try with different version of the one that worked so cr2hdr with the 70d.
same result
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on July 23, 2015, 10:25:22 PM
It's an Adobe issue. ACR simply refuses to load any DNG file that has CameraModel=Canon EOS 70D.

http://www.magiclantern.fm/forum/index.php?topic=14309.msg150201#msg150201

I would suggest seeing what happens when running a vanilla 70D CR2 through Adobe DNG converter.

EDIT: going through Adobe DNG converter from a sample 70D CR2 I found on the internet seems to work. The thing to do would be to start stripping out metadata to figure out what particular missing/added metadata is causing problems when CameraModel=Canon EOS 70D

Code: [Select]
exiftool -v IMG_0072.dng
  ExifToolVersion = 9.35
  FileName = IMG_0072.dng
  Directory = ~/Downloads
  FileSize = 21560380
  FileModifyDate = 1437683334
  FileAccessDate = 1437683407
  FileInodeChangeDate = 1437683334
  FilePermissions = 33188
  FileType = DNG
  MIMEType = image/x-adobe-dng
  ExifByteOrder = II
  + [IFD0 directory with 60 entries]
  | 0)  SubfileType = 1
  | 1)  ImageWidth = 256
  | 2)  ImageHeight = 171
  | 3)  BitsPerSample = 8 8 8
  | 4)  Compression = 1
  | 5)  PhotometricInterpretation = 2
  | 6)  Make = Canon
  | 7)  Model = Canon EOS 70D
  | 8)  StripOffsets = 200286
  | 9)  Orientation = 1
  | 10) SamplesPerPixel = 3
  | 11) RowsPerStrip = 171
  | 12) StripByteCounts = 131328
  | 13) PlanarConfiguration = 1
  | 14) Software = Adobe DNG Converter 8.7.1 (Macintosh)
  | 15) ModifyDate = 2015:07:23 16:28:54
  | 16) SubIFD (SubDirectory) -->
  | + [SubIFD directory with 26 entries]
  | | 0)  SubfileType = 0
  | | 1)  ImageWidth = 5568
  | | 2)  ImageHeight = 3708
  | | 3)  BitsPerSample = 16
  | | 4)  Compression = 7
  | | 5)  PhotometricInterpretation = 32803
  | | 6)  SamplesPerPixel = 1
  | | 7)  PlanarConfiguration = 1
  | | 8)  TileWidth = 256
  | | 9)  TileLength = 256
  | | 10) TileOffsets = 331614 385744 442308 503434 553696 625244 692526 760018 827668 [snip]
  | | 11) TileByteCounts = 54130 56563 61125 50261 71547 67282 67491 67650 68118 68246 [snip]
  | | 12) CFARepeatPatternDim = 2 2
  | | 13) CFAPattern2 = 0 1 1 2
  | | 14) CFAPlaneColor = 0 1 2
  | | 15) CFALayout = 1
  | | 16) BlackLevelRepeatDim = 2 2
  | | 17) BlackLevel = 2049 2049 2049 2049 (524544/256 524544/256 524544/256 524544/256)
  | | 18) WhiteLevel = 15000
  | | 19) DefaultScale = 1 1 (1/1 1/1)
  | | 20) DefaultCropOrigin = 12 12 (12/1 12/1)
  | | 21) DefaultCropSize = 5472 3648 (5472/1 3648/1)
  | | 22) BayerGreenSplit = 250
  | | 23) AntiAliasStrength = 1 (100/100)
  | | 24) BestQualityScale = 1 (1/1)
  | | 25) ActiveArea = 38 72 3708 5568
  | 17) ApplicationNotes (SubDirectory) -->
  | + [XMP directory, 6142 bytes]
  | | XMPToolkit = Adobe XMP Core 5.6-c011 79.156380, 2014/05/21-23:38:37       
  | | ModifyDate = 2015-07-23T16:28:54-04:00
  | | CreateDate = 2013-08-30T16:43:26.25
  | | CreatorTool = Adobe DNG Converter 8.7.1 (Macintosh)
  | | MetadataDate = 2015-07-23T16:28:54-04:00
  | | SerialNumber = 032021006204
  | | LensInfo = 24/1 70/1 0/0 0/0
  | | Lens = 24-70mm
  | | LensID = 137
  | | [adding XMP-aux:LensSerialNumber]
  | | LensSerialNumber = 0000000000
  | | ImageNumber = 0
  | | ApproximateFocusDistance = 698/100
  | | FlashCompensation = 0/1
  | | Firmware = 1.1.1
  | | DateCreated = 2013-08-30T16:43:26.25
  | | DocumentID = xmp.did:39c6db57-7e20-41eb-bd3b-51e9b4de6c92
  | | OriginalDocumentID = C8CDD5B13FF11FF7929E941DE75DD3CC
  | | InstanceID = xmp.iid:39c6db57-7e20-41eb-bd3b-51e9b4de6c92
  | | Format = image/dng
  | | HistoryAction = derived
  | | HistoryParameters = converted from image/x-canon-cr2 to image/dng, saved to new l[snip]
  | | HistoryAction = saved
  | | HistoryInstanceID = xmp.iid:39c6db57-7e20-41eb-bd3b-51e9b4de6c92
  | | HistoryWhen = 2015-07-23T16:28:54-04:00
  | | HistorySoftwareAgent = Adobe DNG Converter 8.7.1 (Macintosh)
  | | HistoryChanged = /
  | | DerivedFromDocumentID = C8CDD5B13FF11FF7929E941DE75DD3CC
  | | DerivedFromOriginalDocumentID = C8CDD5B13FF11FF7929E941DE75DD3CC
  | 18) ExifOffset (SubDirectory) -->
  | + [ExifIFD directory with 30 entries]
  | | 0)  ExposureTime = 0.003125 (1/320)
  | | 1)  FNumber = 4 (4/1)
  | | 2)  ExposureProgram = 1
  | | 3)  ISO = 100
  | | 4)  SensitivityType = 2
  | | 5)  RecommendedExposureIndex = 100
  | | 6)  ExifVersion = 0230
  | | 7)  DateTimeOriginal = 2013:08:30 16:43:26
  | | 8)  CreateDate = 2013:08:30 16:43:26
  | | 9)  ShutterSpeedValue = 8.321928 (8321928/1000000)
  | | 10) ApertureValue = 4 (4/1)
  | | 11) ExposureCompensation = 0 (0/1)
  | | 12) MaxApertureValue = 3 (3/1)
  | | 13) MeteringMode = 5
  | | 14) Flash = 16
  | | 15) FocalLength = 24 (24/1)
  | | 16) SubSecTimeOriginal = 25
  | | 17) SubSecTimeDigitized = 25
  | | 18) ColorSpace = 1
  | | 19) FocalPlaneXResolution = 2452.118652 (80351024/32768)
  | | 20) FocalPlaneYResolution = 2452.118652 (80351024/32768)
  | | 21) FocalPlaneResolutionUnit = 3
  | | 22) CustomRendered = 0
  | | 23) ExposureMode = 1
  | | 24) WhiteBalance = 0
  | | 25) SceneCaptureType = 0
  | | 26) SerialNumber = 032021006204
  | | 27) LensInfo = 24 70 undef undef (24/1 70/1 0/0 0/0)
  | | 28) LensModel = 24-70mm
  | | 29) LensSerialNumber = 0000000000
  | 19) ImageNumber = 0
  | 20) DNGVersion = 1 4 0 0
  | 21) DNGBackwardVersion = 1 1 0 0
  | 22) UniqueCameraModel = Canon EOS 70D
  | 23) ColorMatrix1 = 0.7546 -0.1435 -0.0929 -0.3846 1.1488 0.2692 -0.0332 0.1209 0.63[snip]
  | 24) ColorMatrix2 = 0.7034 -0.0804 -0.1014 -0.442 1.2564 0.2058 -0.0851 0.1994 0.575[snip]
  | 25) CameraCalibration1 = 0.944 0 0 0 1 0 0 0 0.9905 (9440/10000 0/10000 0/10000 0/1[snip]
  | 26) CameraCalibration2 = 0.944 0 0 0 1 0 0 0 0.9905 (9440/10000 0/10000 0/10000 0/1[snip]
  | 27) AnalogBalance = 1 1 1 (1000000/1000000 1000000/1000000 1000000/1000000)
  | 28) AsShotNeutral = 0.431703 1 0.625917 (431703/1000000 1000000/1000000 625917/1000000)
  | 29) BaselineExposure = 0.25 (25/100)
  | 30) BaselineNoise = 0.8 (80/100)
  | 31) BaselineSharpness = 1.25 (125/100)
  | 32) LinearResponseLimit = 1 (100/100)
  | 33) CameraSerialNumber = 032021006204
  | 34) DNGLensInfo = 24 70 undef undef (24/1 70/1 0/0 0/0)
  | 35) ShadowScale = 1 (1/1)
  | 36) DNGAdobeData (SubDirectory) -->
  | + [DNGAdobeData directory, 68810 bytes]
  | | MakN = II..+..1.....P....X..."`............. ..........%...........&....5...... *[snip]
  | | + [AdobeMakN directory, 68796 bytes]
  | | | + [MakerNotes directory with 43 entries]
  | | | | 0)  CanonCameraSettings (SubDirectory) -->
  | | | | + [BinaryData directory, 98 bytes]
  | | | | | MacroMode = 2
  | | | | | SelfTimer = 0
  | | | | | Quality = 4
  | | | | | CanonFlashMode = 0
  | | | | | ContinuousDrive = 5
  | | | | | FocusMode = 0
  | | | | | RecordMode = 7
  | | | | | CanonImageSize = 0
  | | | | | EasyMode = 1
  | | | | | DigitalZoom = 0
  | | | | | Contrast = 0
  | | | | | Saturation = 0
  | | | | | Sharpness = 32767
  | | | | | CameraISO = 32767
  | | | | | MeteringMode = 3
  | | | | | FocusRange = 2
  | | | | | AFPoint = 0
  | | | | | CanonExposureMode = 4
  | | | | | LensType = 137
  | | | | | MaxFocalLength = 70
  | | | | | MinFocalLength = 24
  | | | | | FocalUnits = 1
  | | | | | MaxAperture = 96
  | | | | | MinAperture = 288
  | | | | | FlashActivity = 0
  | | | | | FlashBits = 0
  | | | | | FocusContinuous = -1
  | | | | | AESetting = -1
  | | | | | ImageStabilization = -1
  | | | | | DisplayAperture = 0
  | | | | | ZoomSourceWidth = 0
  | | | | | ZoomTargetWidth = 0
  | | | | | SpotMeteringMode = -1
  | | | | | PhotoEffect = -1
  | | | | | ManualFlashOutput = 0
  | | | | | ColorTone = 0
  | | | | | SRAWQuality = 0
  | | | | 1)  CanonFocalLength (SubDirectory) -->
  | | | | + [BinaryData directory, 8 bytes]
  | | | | | FocalType = 0
  | | | | | FocalLength = 24
  | | | | 2)  CanonFlashInfo = 0 0 0 0
  | | | | 3)  CanonShotInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 68 bytes]
  | | | | | AutoISO = 0
  | | | | | BaseISO = 160
  | | | | | MeasuredEV = 272
  | | | | | TargetAperture = 128
  | | | | | TargetExposureTime = 268
  | | | | | ExposureCompensation = 0
  | | | | | WhiteBalance = 0
  | | | | | SlowShutter = 3
  | | | | | SequenceNumber = 0
  | | | | | OpticalZoomCode = 8
  | | | | | CameraTemperature = 153
  | | | | | FlashGuideNumber = 0
  | | | | | AFPointsInFocus = 0
  | | | | | FlashExposureComp = 0
  | | | | | AutoExposureBracketing = 0
  | | | | | AEBBracketValue = 0
  | | | | | ControlMode = 1
  | | | | | FocusDistanceUpper = 0
  | | | | | FNumber = 128
  | | | | | ExposureTime = 268
  | | | | | MeasuredEV2 = 159
  | | | | | BulbDuration = 0
  | | | | | CameraType = 248
  | | | | | AutoRotate = -1
  | | | | | NDFilter = -1
  | | | | | SelfTimer2 = -1
  | | | | | FlashOutput = 0
  | | | | 4)  CanonImageType = Canon EOS 70D
  | | | | 5)  CanonFirmwareVersion = Firmware Version 1.1.1
  | | | | 6)  OwnerName =
  | | | | 7)  CanonCameraInfoUnknown (SubDirectory) -->
  | | | | + [BinaryData directory, 1536 bytes]
  | | | | 8)  CanonModelID = 2147484453
  | | | | 9)  ThumbnailImageValidArea = 0 159 7 112
  | | | | 10) Canon_0x0019 = 1
  | | | | 11) CanonAFInfo2 (SubDirectory) -->
  | | | | + [SerialData directory, 278 bytes]
  | | | | | 0)  AFInfoSize = 278
  | | | | | 1)  AFAreaMode = 2
  | | | | | 2)  NumAFPoints = 31
  | | | | | 3)  ValidAFPoints = 19
  | | | | | 4)  CanonImageWidth = 5472
  | | | | | 5)  CanonImageHeight = 3648
  | | | | | 6)  AFImageWidth = 5472
  | | | | | 7)  AFImageHeight = 3648
  | | | | | 8)  AFAreaWidths = 229 229 229 229 229 229 229 229 229 229 229 229 229 229 [snip]
  | | | | | 9)  AFAreaHeights = 277 277 277 277 277 277 277 277 277 277 277 277 277 277[snip]
  | | | | | 10) AFAreaXPositions = -1395 -897 -897 -897 -399 -399 -399 0 0 0 0 0 399 39[snip]
  | | | | | 11) AFAreaYPositions = 0 401 0 -401 401 0 -401 755 401 0 -401 -755 401 0 -4[snip]
  | | | | | 12) AFPointsInFocus = 512 0
  | | | | | 13) AFPointsSelected = 512 0
  | | | | 12) TimeInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 16 bytes]
  | | | | | TimeZone = -300
  | | | | | TimeZoneCity = 27
  | | | | | DaylightSavings = 0
  | | | | 13) CanonFileInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 64 bytes]
  | | | | | BracketMode = 0
  | | | | | BracketValue = 0
  | | | | | BracketShotNumber = 0
  | | | | | RawJpgQuality = 0
  | | | | | RawJpgSize = 0
  | | | | | LongExposureNoiseReduction2 = -1
  | | | | | WBBracketMode = 0
  | | | | | WBBracketValueAB = 0
  | | | | | WBBracketValueGM = 0
  | | | | | FilterEffect = -1
  | | | | | ToningEffect = -1
  | | | | | LiveViewShooting = 0
  | | | | | FlashExposureLock = 0
  | | | | 14) LensModel = 24-70mm
  | | | | 15) InternalSerialNumber = FA0151001
  | | | | 16) DustRemovalData =
  | | | | 17) CropInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 8 bytes]
  | | | | | CropLeftMargin = 0
  | | | | | CropRightMargin = 0
  | | | | | CropTopMargin = 0
  | | | | | CropBottomMargin = 0
  | | | | 18) CustomFunctions2 (SubDirectory) -->
  | | | | + [CanonCustom2 directory with 3 entries]
  | | | | + [CanonCustom2 group 1 directory with 6 entries]
  | | | | | 0)  ExposureLevelIncrements = 0
  | | | | | 1)  ISOSpeedIncrements = 0
  | | | | | 2)  AEBAutoCancel = 0
  | | | | | 3)  AEBSequence = 0
  | | | | | 4)  AEBShotCount = 5 2
  | | | | | 5)  SafetyShift = 0
  | | | | + [CanonCustom2 group 3 directory with 13 entries]
  | | | | | 0)  AIServoTrackingSensitivity = -1
  | | | | | 1)  AccelerationTracking = 0
  | | | | | 2)  AIServoFirstImagePriority = 2
  | | | | | 3)  AIServoSecondImagePriority = 2
  | | | | | 4)  AFAssistBeam = 1
  | | | | | 5)  LensDriveNoAF = 0
  | | | | | 6)  SelectAFAreaSelectMode = 0 7
  | | | | | 7)  CanonCustom_Functions2_0x051b = 0
  | | | | | 8)  OrientationLinkedAFPoint = 0
  | | | | | 9)  ManualAFPointSelectPattern = 0
  | | | | | 10) AFPointDisplayDuringFocus = 0
  | | | | | 11) SuperimposedDisplay = 0
  | | | | | 12) AFMicroadjustment = 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
  | | | | + [CanonCustom2 group 4 directory with 4 entries]
  | | | | | 0)  DialDirectionTvAv = 0
  | | | | | 1)  MultiFunctionLock = 0 2
  | | | | | 2)  ViewfinderWarnings = 3
  | | | | | 3)  CustomControls = 0 0 0 2 0 0 0 3 0 0 0 0 0 0 0 0 0 1 0
  | | | | 19) AspectInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 20 bytes]
  | | | | | AspectRatio = 0
  | | | | | CroppedImageWidth = 5472
  | | | | | CroppedImageHeight = 3648
  | | | | | CroppedImageLeft = 0
  | | | | | CroppedImageTop = 0
  | | | | 20) ProcessingInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 28 bytes]
  | | | | | ToneCurve = 0
  | | | | | Sharpness = 3
  | | | | | SharpnessFrequency = 0
  | | | | | SensorRedLevel = 0
  | | | | | SensorBlueLevel = 0
  | | | | | WhiteBalanceRed = 0
  | | | | | WhiteBalanceBlue = 0
  | | | | | WhiteBalance = -1
  | | | | | ColorTemperature = 5800
  | | | | | PictureStyle = 135
  | | | | | DigitalGain = 0
  | | | | | WBShiftAB = 0
  | | | | | WBShiftGM = 0
  | | | | 21) MeasuredColor (SubDirectory) -->
  | | | | + [BinaryData directory, 12 bytes]
  | | | | | MeasuredRGGB = 340 1024 1024 746
  | | | | 22) ColorSpace = 1
  | | | | 23) VRDOffset = 0
  | | | | 24) SensorInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 34 bytes]
  | | | | | SensorWidth = 5568
  | | | | | SensorHeight = 3708
  | | | | | SensorLeftBorder = 84
  | | | | | SensorTopBorder = 50
  | | | | | SensorRightBorder = 5555
  | | | | | SensorBottomBorder = 3697
  | | | | | BlackMaskLeftBorder = 0
  | | | | | BlackMaskTopBorder = 0
  | | | | | BlackMaskRightBorder = 0
  | | | | | BlackMaskBottomBorder = 0
  | | | | 25) ColorData7 (SubDirectory) -->
  | | | | + [BinaryData directory, 2626 bytes]
  | | | | | ColorDataVersion = 10
  | | | | | WB_RGGBLevelsAsShot = 2372 1024 1024 1636
  | | | | | ColorTempAsShot = 5807
  | | | | | WB_RGGBLevelsAuto = 2372 1024 1024 1636
  | | | | | ColorTempAuto = 5807
  | | | | | WB_RGGBLevelsMeasured = 2372 1024 1024 1636
  | | | | | ColorTempMeasured = 5807
  | | | | | WB_RGGBLevelsDaylight = 2144 1024 1024 1680
  | | | | | ColorTempDaylight = 5200
  | | | | | WB_RGGBLevelsShade = 2491 1024 1024 1448
  | | | | | ColorTempShade = 7000
  | | | | | WB_RGGBLevelsCloudy = 2310 1024 1024 1556
  | | | | | ColorTempCloudy = 6000
  | | | | | WB_RGGBLevelsTungsten = 1509 1024 1024 2439
  | | | | | ColorTempTungsten = 3200
  | | | | | WB_RGGBLevelsFluorescent = 1862 1024 1024 2315
  | | | | | ColorTempFluorescent = 3733
  | | | | | WB_RGGBLevelsKelvin = 2275 1024 1024 1584
  | | | | | ColorTempKelvin = 5807
  | | | | | WB_RGGBLevelsFlash = 2372 1024 1024 1553
  | | | | | ColorTempFlash = 6172
  | | | | | RawMeasuredRGGB = 2540437506 4141154311 19988488 3343450117
  | | | | 26) CRWParam = ...0""""""".................h...r.8....!.  . Pp.d@....dZ.A.A.u[snip]
  | | | | 27) Flavor = .A. .?_......?a......?_......@b......?_......Be.................[snip]
  | | | | 28) BlackLevel = 135 135 135
  | | | | 29) Canon_0x4009 = 0 0 0
  | | | | 30) CustomPictureStyleFileName =
  | | | | 31) Canon_0x4011 =
  | | | | 32) Canon_0x4012 =
  | | | | 33) AFMicroAdj (SubDirectory) -->
  | | | | + [BinaryData directory, 44 bytes]
  | | | | | AFMicroAdjMode = 0
  | | | | | AFMicroAdjValue = 0
  | | | | 34) VignettingCorr (SubDirectory) -->
  | | | | + [BinaryData directory, 456 bytes]
  | | | | | PeripheralLighting = 0
  | | | | | ChromaticAberrationCorr = 0
  | | | | | ChromaticAberrationCorr = 0
  | | | | | PeripheralLightingValue = 0
  | | | | | OriginalImageWidth = 5472
  | | | | | OriginalImageHeight = 3648
  | | | | 35) VignettingCorr2 (SubDirectory) -->
  | | | | + [BinaryData directory, 28 bytes]
  | | | | | PeripheralLightingSetting = 0
  | | | | | ChromaticAberrationSetting = 0
  | | | | 36) LightingOpt (SubDirectory) -->
  | | | | + [BinaryData directory, 28 bytes]
  | | | | | AutoLightingOptimizer = 3
  | | | | 37) LensInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 30 bytes]
  | | | | | LensSerialNumber =
  | | | | 38) AmbienceInfo (SubDirectory) -->
  | | | | + [BinaryData directory, 28 bytes]
  | | | | | AmbienceSelection = 0
  | | | | 39) Canon_0x4021 = 20 0 0 0 1
  | | | | 40) FilterInfo (SubDirectory) -->
  | | | | + [Creative Filter directory with 7 entries]
  | | | | + [Filter 1 directory with 1 entries, 20 bytes]
  | | | | | GrainyBWFilter = -1
  | | | | + [Filter 2 directory with 1 entries, 20 bytes]
  | | | | | SoftFocusFilter = -1
  | | | | + [Filter 3 directory with 1 entries, 20 bytes]
  | | | | | ToyCameraFilter = -1
  | | | | + [Filter 4 directory with 4 entries, 56 bytes]
  | | | | | MiniatureFilter = -1
  | | | | | MiniatureFilterOrientation = 0
  | | | | | MiniatureFilterPosition = 0
  | | | | | Canon_FilterInfo_0x0404 = 0
  | | | | + [Filter 5 directory with 1 entries, 20 bytes]
  | | | | | Canon_FilterInfo_0x0501 = -1
  | | | | + [Filter 6 directory with 1 entries, 20 bytes]
  | | | | | Canon_FilterInfo_0x0601 = -1
  | | | | + [Filter 7 directory with 1 entries, 20 bytes]
  | | | | | Canon_FilterInfo_0x0701 = -1
  | | | | 41) Canon_0x4025 = 36 0 0 0 0 0 0 0 0
  | | | | 42) Canon_0x4027 = 24 524546 2969567282 134217728 13684944 0
  | 37) CalibrationIlluminant1 = 17
  | 38) CalibrationIlluminant2 = 21
  | 39) RawDataUniqueID = .).oe...4,.%`L.
  | 40) OriginalRawFileName = IMG_0072.CR2
  | 41) CameraCalibrationSig = com.adobe
  | 42) ProfileCalibrationSig = com.adobe
  | 43) ProfileName = Adobe Standard
  | 44) ProfileHueSatMapDims = 90 30 1
  | 45) ProfileHueSatMapData1 = 2 1 1 1.29631185531616 1.0373512506485 1.00313758850098[snip]
  | 46) ProfileHueSatMapData2 = 2 1 1 1.27510297298431 1.00438475608826 0.9957437515258[snip]
  | 47) ProfileEmbedPolicy = 0
  | 48) ProfileCopyright = Copyright 2012 Adobe Systems, Inc.
  | 49) ForwardMatrix1 = 0.7763 0.0065 0.1815 0.2364 0.8351 -0.0715 -0.0059 -0.4228 1.2[snip]
  | 50) ForwardMatrix2 = 0.7464 0.1044 0.1135 0.2648 0.9173 -0.182 0.0113 -0.2154 1.029[snip]
  | 51) PreviewApplicationName = Adobe DNG Converter
  | 52) PreviewApplicationVersion = 8.7.1
  | 53) PreviewSettingsDigest = ..=..........;s.
  | 54) PreviewColorSpace = 2
  | 55) PreviewDateTime = 2015-07-23T16:28:54-04:00
  | 56) ProfileLookTableDims = 36 8 16
  | 57) ProfileLookTableData = 0 1 1 0 0.87861567735672 1 0 0.885046482086182 1 0 0.892[snip]
  | 58) NoiseProfile = 4.97062638284886e-05 4.68483521743603e-07
  | 59) NewRawImageDigest = .U.i.p.A#.....M,
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 24, 2015, 01:16:35 AM
Guys, please test in OS X and report back.

Tested and reproduced the same error. This is very strange because the dual iso cr2 that @DeafEyeJedi posted (https://mega.co.nz/#!7t8wVBKJ!Udj5CLNekaISLDcGtmtVznbUVGpMeMydYnmb40p3p38) works fine.

I tried the two methods, having Lightroom copy the cr2 into the library and creating a dng on import. The cr2 converted properly but the dng conversion was corrupted in both sample files. LR error message: "The file appears to be unsupported or damaged."
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on July 26, 2015, 10:52:20 AM
No solutions :/
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 26, 2015, 11:35:30 AM
Macusers. I put in the 10th may mac cr2hdr20bit binary in the plugin folder and 70D dual iso files works fine. I say you find the 10th may windows binary and you should be fine?
Here is the binary for mac. You might have to give the binary sudo priviliges
https://drive.google.com/file/d/0B4tCJMlOYfirSVBPTEduVElaREU/view?usp=sharing
/D
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on July 26, 2015, 01:05:17 PM
10th May? The last build available here (https://builds.magiclantern.fm/jenkins/view/Other%20tasks/job/cr2hdr-20bit/) is from 9th.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on July 26, 2015, 01:35:48 PM
Probably the same but I believe N/A compiled the mac binary 10th may or was is Kichetof? Can,t remember. I don,t see why the exe won,t work though. Could it be acr related? I ran the plugin on my macbook pro in lightroom 5.

*Actually it was Kichetof that compiled the latest mac binary. (10th may)
http://www.magiclantern.fm/forum/index.php?topic=7139.msg147286#msg147286
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on July 29, 2015, 07:57:21 AM
Just saw this in another topic. May be worth a try.
http://www.magiclantern.fm/forum/index.php?topic=14309.msg151861#msg151861
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on August 03, 2015, 08:53:50 AM
Good news everyone--I tracked down kichetof  :D

He should be back here soon.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on August 03, 2015, 09:11:13 AM
Definitely good news, Dan!

Also thanks for your kind PM and will write back as soon as I get back home from being on the road for work.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: guoyida on August 16, 2015, 12:15:29 AM
Update:
I got it fixed.
I replaced files(exif, lib folder) inside cr2hdr.lrplugin which relate to exiftool



Hi, I tried to use this plug in to convert my image. It's really easy to use. However, every time I converted my image, when I check the exif info after conversion, the converted file has a 1.0 sec at f1.0 exposure, and lose other exif info (lense, focus length, GPS, etc) as well. The model showed Canikon.

I tried to reinstall exiftool 9.99 from their homepage. It didn't solve my problem.
I am using LR 6.1.1 on Yosemite 10.10.5

I just read some recent post. I confirmed that I have exiftools in my /usr/bin folder. That could be the older version of it. Does it matter?
 
What could be the problem here?

Please help!

John
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on August 16, 2015, 12:23:16 AM
As discussed above: Delete lib folder or replace lib folder contents with Exiftools lib v9.9.9.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: guoyida on August 16, 2015, 01:25:07 AM
Thank you so much!
Got it sorted!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on August 20, 2015, 12:27:54 PM
Always not solution for Windows?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on August 21, 2015, 05:25:14 AM
Always not solution for Windows?

It is working in Windows. Re-read the posts. Make sure you got the latest version and delete or update the lib folder.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on August 21, 2015, 02:56:26 PM
Snakec's 70D problem is discussed above and latest download doesn't fix it.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on August 21, 2015, 04:24:57 PM
Right, not a Windows only issue because we also tested it on Mac's with the same results. dmilligan has merged cr2hdr 20-bit with his revised DNG branch. If there is going to be a fix for the 70D issue it will probably come from the new branch first:

https://bitbucket.org/dmilligan/magic-lantern/branch/ml_dng-cr2hdr20bit

http://www.magiclantern.fm/forum/index.php?topic=7139.msg153172#msg153172
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on August 21, 2015, 05:45:14 PM
Works with mac binary and 70D. See reply #762 :).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on August 21, 2015, 06:15:35 PM
Have you tried to convert snakec's problem file? Overexposed a lot on my site.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on August 21, 2015, 06:51:11 PM
Yea, the file is overexposed so I think this is normal, but metadata copied in lightroom 5 as with other dual iso files(5D mark 3). Also tested dmilligan branch cr2hdr20bit compiled from dfort with a 70D file and that worked fine. Tested with cr2hdr-r since I don,t have my lightroom installed on my work computer.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on August 21, 2015, 07:01:05 PM
Yea, the file is overexposed so I think this is normal, but metadata copied in lightroom 5 as with other files. Also tested dmilligan branch cr2hdr20bit compiled from dfort with a 70D file and that worked fine. Tested with cr2hdr-r since I don,t have my lightroom installed on my work computer.

Well, you didn't need LR on your computer. Just running cr2hdr is all you need to find out if snakec's case is worth investigating.
As described above:
With original cr2hdr + lib delivered by kichetof his (and others) conversion shows just fine exposure but EXIF is messed up.
With cr2hdr + lib 9.99 or cr2hdr without lib EXIF is fine but exposure is messed up.

Link to CR2: https://mega.co.nz/#!fsRUUI5K!Kfs9OtWGe8GaOCjNGKnO7HeOcc_EnvbnTVrIKbfjYEE
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on August 21, 2015, 07:27:11 PM
Overexposed over here with LR cc on Mac and latest cr2hdr 20-bit from dmilligan. The metadata looks fine.

Wasn't it determined that this is an Adobe Camera Raw issue?

http://magiclantern.fm/forum/index.php?topic=11056.msg151675#msg151675

Looks like snakec took down his sample images but I believe I got his same results.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on August 21, 2015, 07:42:11 PM
Just tested with Rawtherapee and you are right. Converted DNG in RT shows exposure just fine, LR messes up badly.
Waiting for Adobe to fix this ... okay, I have to laugh, too ... Who is willing to dive into metadata?

EDIT: Let me rephrase that "RT shows exposure just fine": It is *not* overexposed but I don't think it should be called well exposed.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on August 21, 2015, 07:56:42 PM
Ran the latest mac binary with cr2hdr-r and converts fine. But, when converting with adobe dng converter for size reduction it heavily overexposes. Too bad I can,t test with lightroom 5 right now.

cr2hdr20bit run in cr2hdr-r(looks fine) Probably not an issue with camera raw then?
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs11.postimg.org%2Fewp2gunfj%2FScreen_Shot_2015_08_21_at_19_57_28.png&hash=e2f8511872cd69a49a1adf6680b5ddda) (http://postimg.org/image/ewp2gunfj/)

cr2hdr20bit run in cr2hdr-r and then with adobe dng converter lossless compression(overexposed)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs11.postimg.org%2Fjty1o800v%2FScreen_Shot_2015_08_21_at_19_59_00.png&hash=386758a9d23a5403ce2744d995534cb9) (http://postimg.org/image/jty1o800v/)
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on August 21, 2015, 08:17:11 PM
Looks fine over here. Used LR5 with the latest 20-bit cr2hdr binary and confirmed it is overexposed but here's the most what you can get out of atm...

Original after convert:                                             Definitely OE if you read the right tall lines in Histogram here:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5828%2F20739281746_2fe91aa403_n.jpg&hash=64dc4b7b2e1a1c492dec801ddec92338) (https://flic.kr/p/xAEeVd) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5758%2F20578805499_95425908dc.jpg&hash=579fae5d75e1c6e852c5c5969c4222c7) (https://flic.kr/p/xmtKVn)

This is the best I can do with your OE shot in converted Dual-ISO:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F693%2F20577564790_647cef1568_n.jpg&hash=1eb8a96ca7ac5be11a4295120628f870) (https://flic.kr/p/xmnp6Q)

Just for fun, with Cinelog-C applied even though it's not intent for Dual-ISO:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5658%2F20577558138_806bf291f2_n.jpg&hash=a3e4ac9001d8cd39861bff0837f97992) (https://flic.kr/p/xmnn89)

Adjusted the exposure down to about 1 1/3 of a Stop:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F776%2F20578807429_553cf697b9_n.jpg&hash=515d6dacdc4e0487fc898bdff0375121) (https://flic.kr/p/xmtLuD)

Here with Cinelog-C REC709 Wide DR v2 in AE:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F676%2F20739283976_e7d62839c8_n.jpg&hash=b974348f0aa424ae84b1b4ae3786a3a5) (https://flic.kr/p/xAEfzE)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on August 21, 2015, 08:24:04 PM
Seems to work then in lightroom 5 Deafeyejedi. Might be lightroom CC related.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on August 21, 2015, 08:44:26 PM
As well as your app...  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on August 21, 2015, 09:57:27 PM
What puzzles me is that other 70D dual iso files converted fine even with adobe dng converter lossless setting in cr2hdr-r but not this file. Do you have any dual iso 70D files lying around Deafeye?
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on August 21, 2015, 11:24:45 PM
Sure, here are few additional ones in your Mega Folder...

https://mega.nz/#F!r0FzUApa!-KHcQHXE7NLXWBaYrQ10-w
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on August 22, 2015, 07:15:01 AM
Thanks.
So the same problem occurs with your sample files Deafeyejedi. Dual iso conversion of CR2 files works with cr2hdr20bit but not with lossless compression with adobe dng converter(cr2hdr-r). 
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on August 22, 2015, 07:25:19 AM
Regarding 70D Dual ISO CR2 -- does it matter from which Alpha build is it coming from?

Perhaps 111.A vs 111.B or something else?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on August 22, 2015, 07:37:21 AM
Probably not. Stay off adobe dng converter and 70D files I say. I have lossless conversion automated(if adobe dng converter installed in cr2hdr-r so this will be a problem with 70D files. See if I can change the routines for 70D files.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: snakec on September 06, 2015, 09:48:08 PM
Le probleme vient vraiment de lr cc
Avec un dng crée par Barracuda Gui, je n'ai pas le meme resultat en l'important dans les 2 versions de LR

The problem really comes from lr cc
With dng created by Barracuda Gui, I do not have the same result by importing it in the 2 versions of LR

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fsnakec.free.fr%2Fimages%2Ftest.PNG&hash=788416d85361583eef913504c090f842)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on September 07, 2015, 03:13:23 AM
Slipped under my radar: LR 6 SDK is out!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: jakepetre on September 27, 2015, 11:51:50 AM
Any update? Trying to find a way to process these dual ISO cr2's on my mac with LR 5. Help!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on September 27, 2015, 01:06:11 PM
And your problem is?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on September 28, 2015, 01:42:29 PM
Hey guys, I love this plugin and it has always been super efficient and amazingly useful and I use Dual ISO all the time! Only issue is; OSX 10.11 El Capitan has this new 'rootless' feature which disqualifies any access to /usr/bin which is where dcraw and exiftool are stored and installed to. So since updating to 10.11, choosing to export to Dual ISO converter shows the 'Dependancies Error: This plugin (cr2hdr) need dcraw and exiftool. Please install it before run this plugin'. So it won't work, anyone have a workaround or something that will let me continue to use it?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on September 28, 2015, 04:45:26 PM
Hey guys, I love this plugin and it has always been super efficient and amazingly useful and I use Dual ISO all the time! Only issue is; OSX 10.11 El Capitan has this new 'rootless' feature which disqualifies any access to /usr/bin which is where dcraw and exiftool are stored and installed to. So since updating to 10.11, choosing to export to Dual ISO converter shows the 'Dependancies Error: This plugin (cr2hdr) need dcraw and exiftool. Please install it before run this plugin'. So it won't work, anyone have a workaround or something that will let me continue to use it?

Uh oh--can't say I saw this coming but mentioned this a couple months ago:

« Reply #741 on: July 19, 2015, 03:05:19 AM »
Quote from: dfort
There are lots of ways to improve the user experience for Mac--make an installer that puts all the dependencies in the right place, define a local path by having the lua script call a system command, modify cr2hdr to accept a path argument when calling exiftool and dcraw, etc. The tricky part is not breaking the plug-in for Windows systems.

All of this is way beyond my coding abilities.

The issue is that if you download the plugin you'll find exiftool and dcraw in the plugin's bin/lib directory but OS-X looks into the system path for these programs. Obviously it is time to revisit this issue.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on September 29, 2015, 06:46:16 AM
Uh oh--can't say I saw this coming but mentioned this a couple months ago:

« Reply #741 on: July 19, 2015, 03:05:19 AM »
The issue is that if you download the plugin you'll find exiftool and dcraw in the plugin's bin/lib directory but OS-X looks into the system path for these programs. Obviously it is time to revisit this issue.

So it's Lightroom that looks to /usr/bin/ for the dcraw and exiftool? I can probably create a redirect script for it. I'm overseas at the moment but I'll do my best to see what I can come up with, even if it's a temporary thing for now, I'll share whatever I can make, if I can make something.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on September 29, 2015, 07:08:29 AM
No. Inside plug-in scripts cr2hdr is called and it will look for both executables via OS X because cr2hdr can't do (yet?).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on September 29, 2015, 03:36:44 PM
So it's Lightroom that looks to /usr/bin/ for the dcraw and exiftool? I can probably create a redirect script for it. I'm overseas at the moment but I'll do my best to see what I can come up with, even if it's a temporary thing for now, I'll share whatever I can make, if I can make something.

It looks like El Capitan, a.k.a. 10.11, still allows installation in /usr/local/bin. Could you give that a try?

No. Inside plug-in scripts cr2hdr is called and it will look for both executables via OS X because cr2hdr can't do (yet?).

There should be a way to have cr2hdr use the dcraw and exiftool that is inside of the LR plugin. This is only an issue with OS-X. I just started looking into dmilligan's ml_dng-cr2hdr20bit branch to see if that is possible.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on September 29, 2015, 05:20:53 PM
It looks like El Capitan, a.k.a. 10.11, still allows installation in /usr/local/bin. Could you give that a try?
I'll see if I can make an alias that forces it. I mean, I can just boot to recovery mode and make 10.11 stop being a pain, but I mean, that's low level file structure changes and 99% of the users of this plugin won't want to do that, I'm sure, and it's pretty complex. So I will see if I can workaround it.

No. Inside plug-in scripts cr2hdr is called and it will look for both executables via OS X because cr2hdr can't do (yet?).
I'll see if I can edit cr2hdr to not look to OSX/not look to /usr/bin for the exiftool and dcraw. Probably impossible but I'll see what I can do.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: camagna on September 29, 2015, 06:03:08 PM
I really hope that some of you can solve the issue because I'm on 10.11 and I need to process a lot of files from an assignment. I'm really stuck now.  :(
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on September 29, 2015, 06:12:35 PM
You could try install the binary pack from app cr2hdr-r since it places both exiftool and dcraw in usr/bin through a script.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on September 30, 2015, 01:42:49 AM
I really hope that some of you can solve the issue because I'm on 10.11 and I need to process a lot of files from an assignment. I'm really stuck now.  :(
I'll do my best to do a temporary work around but if I can't, you could upload the files to Dropbox and I could just do it on my Windows computer for you.

You could try install the binary pack from app cr2hdr-r since it places both exiftool and dcraw in usr/bin through a script.

That's the whole issue; I have tried that many times, it says that it has 'installed' but if you go to usr/bin the files aren't there due to 10.11 not allowing that folder to be modified. Even through Terminal (command line) to just copy them there, it doesn't allow that. To use the non-Lightroom processing app on Mac always fails to work as well.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on September 30, 2015, 03:18:16 AM
I'll see if I can edit cr2hdr to not look to OSX/not look to /usr/bin for the exiftool and dcraw. Probably impossible but I'll see what I can do.
cr2hdr simply calls 'exiftool' and 'dcraw'. This means that OSX simply uses the PATH environment variable to resolve their locations. They do not have to be in /usr/bin, they can be anywhere that is on the PATH. /usr/local/bin is on the PATH, and that folder is not restricted by 10.11's new rootless "feature" (this is what dfort suggested doing). Additionally, you can simply put them anywhere you want and add that directory to the PATH (environment variables are specific to the local user, you don't even have to be root to change them, because they are *your* environment variables). If you want to have them in the plugin folder so they don't have to be "installed" somewhere, simply have the Lr plugin modify the PATH to include the plugin's bin directory.

I think something like this should work:
Code: [Select]
LrTasks.execute('export PATH="${PATH}:'..LrPathUtils.child(_PLUGIN.path, "bin")..'"')

You can also simply using something like homebrew (http://brew.sh) to install these:
Code: [Select]
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
brew install exiftool
brew install dcraw

BTW, there's some good information about SIP and how it affects /usr/local/ on hombrew's github, here: https://github.com/Homebrew/homebrew/blob/master/share/doc/homebrew/El_Capitan_and_Homebrew.md


@Danne, you should probably update your cr2hdr-r installers to use /usr/local/bin/ for compatibility with 10.11
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on September 30, 2015, 03:45:29 AM
Thanks for info. I, ll check in to that usr/local/bin instead.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on September 30, 2015, 06:00:22 AM
I updated cr2hdr-r with the /usr/local/bin folder. I tried many scenarios, seemed to work but please check and report if testing. Binary pack will all move to /usr/local/bin now.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on September 30, 2015, 07:32:49 AM
I think something like this should work:
Code: [Select]
LrTasks.execute('export PATH="${PATH}:'..LrPathUtils.child(_PLUGIN.path, "bin")..'"')

Cool, I was searching all over the place for this. I was thinking of putting it either in this function:

MLProcess.lua
Code: [Select]
-- Check for Mac dependencies
function MLProcess.checkDependencies()
    return "exec which dcraw exiftool"
end

or just before calling that function:
Code: [Select]
    if MAC_ENV then
        local cmd = MLProcess.checkDependencies()
        isDependOk = LrTasks.execute(cmd)
        if isDependOk ~= 0 then
            LrDialogs.message(LOC "$$$/ML/Dependencies/ErrorTitle=~ Dependencies error ~", LOC "$$$/ML/Dpendencies/Error=This plugin (cr2hdr) need dcraw and exiftool.^n^nPlease install it before run this plugin")
            do return end
        end
    end

So it will find the dcraw and exiftool that is installed in the plugin's bin directory on the Mac.

It looks like Windows looks in the plugin bin directory before searching the environmental variable path. That would be the preferred behavior on Mac too.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on September 30, 2015, 01:00:59 PM
It looks like Windows looks in the plugin bin directory before searching the environmental variable path. That would be the preferred behavior on Mac too.

The default behavior of Windows is that the current directory is automatically included (first) when searching the PATH.

So on Windows you can cd to a directory containing an exe and call it simply using it's name (e.g. myexe). On mac (and other *nix OSs) you can't do this, if you want to execute something that's in the current directory you must specify it's path, the easiest way is with "./" so for example: ./myexe


There is one assumption my solution makes and that is that the state of environment variables are maintained from one call to LrTasks.execute() to the next. If this isn't the case (I'm not really sure if it is or not, you'll just have to try it) then you may have to make it into one single command to set the PATH and call cr2hdr.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on September 30, 2015, 05:57:25 PM
There is one assumption my solution makes and that is that the state of environment variables are maintained from one call to LrTasks.execute() to the next. If this isn't the case (I'm not really sure if it is or not, you'll just have to try it) then you may have to make it into one single command to set the PATH and call cr2hdr.

One thing that I tried as a test before I saw your post was to remove dcraw and exiftool from their installed locations add the plugin's bin directory to ~/.profile
Code: [Select]
## LR Plugin Test
export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin:$PATH"

It worked from the terminal:

Code: [Select]
$ which dcraw
/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/dcraw

but as I'm posting this the plugin reports "~Dependencies error~" and now I can't restore things to their former working condition -- can't make sense of this.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on September 30, 2015, 07:40:58 PM
You might want to take out the dependency check altogether (if this works, you theoretically won't need it anyway)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on September 30, 2015, 11:59:47 PM
Ok--this hasn't been easy but I'm starting to get the hang of it.

Removed the function to check for dependencies and modified the section that calls that function and displays the error message to this:

Code: [Select]
    if MAC_ENV then
      LrTasks.execute('export PATH="${PATH}:'..LrPathUtils.child(_PLUGIN.path, "bin")..'"')
    end

This doesn't work as desired yet. If dcraw and exiftool are installed on the system it will still work but only because it finds them in the path but not the ones in the plugin's bin directory. Removing dcraw and exiftool from /usr/bin or wherever will break the plugin (of course no error message). However, the file (or database?) is modified so that the image should be deleted and reimported for the next test--that is something that took me a while to figure out. Note that without dcraw it errors out but if only exiftool is missing it will complete the conversion without an error message but also without the metadata on the converted file. This may be obvious, just reporting what I observed.

So it is not finding dcraw and exiftool in the plugin's bin directory yet. In addition, shouldn't the "_PLUGIN.path" be searched before the system path? If there is a different version of dcraw and/or exiftool installed in the system it might create unexpected results.

Like this?

Code: [Select]
    if MAC_ENV then
      LrTasks.execute('export PATH="..LrPathUtils.child(_PLUGIN.path, ‘bin’)..”:${PATH}')
    end

Thought that isn't working yet either.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 01, 2015, 01:12:44 AM
Wrote a shell script that is promising.

path.command
Code: [Select]
#!/bin/sh
export PATH=./bin:$PATH

Code: [Select]
Rosies-Air:cr2hdr.lrplugin Fort$ which dcraw
Rosies-Air:cr2hdr.lrplugin Fort$ source path.command
Rosies-Air:cr2hdr.lrplugin Fort$ which dcraw
./bin/dcraw

But I can't seem to find a way to run this from the plugin:
Code: [Select]
    if MAC_ENV then
--      LrTasks.execute('export PATH="..LrPathUtils.child(_PLUGIN.path, ‘bin’)..”:${PATH}')
      LrTasks.execute('source path.command')
    end
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on October 01, 2015, 02:25:07 AM
I would use full paths for everything and not make the assumption that cwd is the plugin path (I have no idea if this is the case or not, it might be). You have _PLUGIN.path available, so just prepend it to all your paths. Also not sure why you are putting it in a shell script, doesn't seem necessary, it's a one liner anyway.

My concern is that environment variables you set are not persisted from one call to LrTasks.execute() to the next (again, I have no idea if this is the case), which would mean you need to set the path and call cr2hdr all at once.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 01, 2015, 03:24:16 AM
dmilligan -- You're post came in while I was writing and testing this out. I was testing this on a shell script simply because I know it better than Lightroom's version of lua. Of course you are right that it should all be done in lua. In any case, this is what I found out--

Made some discoveries but still not working.

The plugin looks for all executable files in the bin directory so I moved the shell script in there. I also changed it so instead of creating a relative directory it will define an absolute path:

bin/path.command
Code: [Select]
#!/bin/sh
export PATH=$PWD:$PATH

Code: [Select]
Rosies-Air:bin Fort$ echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
Rosies-Air:bin Fort$ which dcraw
Rosies-Air:bin Fort$ source path.command
Rosies-Air:bin Fort$ echo $PATH
/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
Rosies-Air:bin Fort$ which dcraw
/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/dcraw

So now the plugin launches and runs but it still doesn't process the file so maybe the new path isn't available to the plugin?

I also did some experimenting placing dcraw in various path locations and it seems that it is only available when it is placed in one of the factory default path locations:

Code: [Select]
/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
This might have been a part of a security update when Apple pushed out 10.10.5.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on October 01, 2015, 03:50:50 AM
Have you tried what I suggested: doing the path setter and cr2hdr in one single call?

e.g.
Code: [Select]
LrTasks.execute('export PATH=<blah blah> && cr2hdr <args>')
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 01, 2015, 06:35:35 AM
I see, so if the path settings don't persist and cr2hdr, dcraw and exiftool need to have absolute paths to launch properly--it looks like I'm working on the wrong section of the lua script. I'm getting the feeling that there was a recent change to the way applications use the path variable because the macports installation in /opt/local/bin stopped working with the LR plugin even though it was still available through the terminal.

This is a moving target. While I was working on this Adobe updated Lightroom and Apple released El Capitan, OS-X 10.11, today. My system is updating now so we'll see what surprises that brings.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 01, 2015, 07:32:44 AM
dmilligan -- made a pull request on your branch of cr2hdr20bit. As long as everyone else is updating--using the latest versions of cr2hdr, dcraw and exiftool. It all works as long as dcraw and exiftool are in /usr/bin but still need to get them working inside the plugin directory structure.

[EDIT - Never mind, the system finished updating so I switched to a plugin before I started hacking at it and I'm back to where I started with the dependencies error even with the tools installed in /usr/local/bin. Oh, and /usr/bin is now off limits.]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 01, 2015, 09:14:10 AM
Oops looks like there's yet another update. This time with cr2hdr.

https://bitbucket.org/hudson/magic-lantern/commits/1779727a4b6b0aa2c89629de8b592620deed87f7

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on October 01, 2015, 10:16:12 AM
So, we haven't gotten anywhere then?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 01, 2015, 03:13:28 PM
So, we haven't gotten anywhere then?

You said that you have a Windows system? The same plugin you have installed on your Mac should work on Windows. It is just OS-X, specifically 10.10.5 and 10.11 that seem to be a problem.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on October 02, 2015, 02:59:07 AM
I do since i have dual booted my Mac, but it's still a pain as I'm only using the standalone program because I'm currently in Bali and haven't had a chance to download Lightroom to the Windows boot, so I was just checking if we had made any progress on the 10.11 issue. I have been able to redirect Lightroom with some trick aliases but it only worked until I quit Lightroom.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 02, 2015, 03:34:48 AM
I spent the last couple of days trying to figure this out. Ideally the plugin will work without needing to have dcraw and exiftool installed on the system because they are already inside of the plugin. I've got a couple of Macs, both updated to 10.11 and even with dcraw and exiftools in /usr/local/bin the plugin doesn't work.

Code: [Select]
Rosies-Air:bin Fort$ which dcraw exiftool
/usr/local/bin/dcraw
/usr/local/bin/exiftool

Although dmilligan's suggestions look correct according to the Lightroom SDK 6.0 documentation, I couldn't get it to work. Looking into kichetof's code it seems he went to great lengths to get LrTasks.execute commands to a single variable name. I ended up building up the command to set the path in several small steps and kept checking the code with a LrDialogs.message but even though everything looks good, including the quotation marks needed because there might be a space in the path, it still doesn't work.

Code: [Select]
    if MAC_ENV then

        local exportPath = 'export PATH="'
        local toolsPath = LrPathUtils.child(_PLUGIN.path, 'bin"')
        local searchPath = exportPath..toolsPath
--        LrDialogs.message(searchPath)
        LrTasks.execute(searchPath)

The searchPath variable ended up like this on my system:
Code: [Select]
export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin"
Don't know where to go from here.

[EDIT: Doh! I thought it wasn't necessary to append the system path but I just checked it out and and of course all of the system tools are in /usr/bin. Looks like I've got more work to do.]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on October 02, 2015, 03:57:14 AM
I fixed it on 10.11.... so so so so so easy....
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 02, 2015, 04:04:46 AM
Would you share please?

BTW--adding the system path at the end works great in the terminal but doesn't work at all in the plugin. Maybe I've got other issues. (Yeah, laugh.)

Just for the record:

Code: [Select]
    if MAC_ENV then

        local exportPath = 'export PATH="'
        local toolsPath = LrPathUtils.child(_PLUGIN.path, 'bin"')
        local systemPath = ':$PATH'
        local searchPath = exportPath..toolsPath..systemPath
--        LrDialogs.message(searchPath)
        LrTasks.execute(searchPath)

created this searchPath variable:
Code: [Select]
export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":$PATH
which finds the tools installed in the plugin first then goes to the system for anything else--at least that's the way it works in the terminal. Plugin is still broken.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on October 02, 2015, 04:21:52 AM
It's temporary but it works:

1. Restart the computer, while booting hold down Command-R to boot into recovery mode.
2. Once booted, navigate to the "Utilities > Terminal" in the top menu bar.
3. Enter csrutil disable in the terminal window and hit the return key.
4. Restart the machine and System Integrity Protection will now be disabled.
5. Run install from cr2hdr package to install the files.
6. (optional) To reenable System Integrity Protection follow the steps above, except use the csrutil enable command for step 3.

It doesn't change the plugin, but it does allow us to use it as per normal again, and takes a matter of minutes to do.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 02, 2015, 04:38:54 AM
I got something even quicker.

Open the terminal and add the path to the plugin's bin directory ahead of the system path.

Code: [Select]
export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":$PATH

Then simply start Lightroom from the terminal. Well maybe not so obvious:

Code: [Select]
/Applications/Adobe\ Lightroom/Adobe\ Lightroom.app/Contents/MacOS/Adobe\ Lightroom
The terminal has to be left open or LR will shutdown. You can also geek out at the messages LR outputs.

Sorry, I would have told you sooner but I just thought of this. In any case, these are just workarounds, the plugin should still be fixed.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 02, 2015, 09:30:53 AM
Until a real fix is found I uploaded a version of the cr2hdr.lrplugin that has the latest cr2hdr, dcraw and exiftool installed internally. This should be fine with Windows and Mac--pre El Capitan. If the Mac version can't find dcraw and exiftool it will display a dialog box with instructions on how to set the path with the terminal and how to launch LR from the terminal so the plugin works.

Here's the download link to all things cr2hdr that I compiled on October 1. Note that they should be replaced once new "official" versions are ready.

[EDIT: Official version is ready: https://bitbucket.org/kichetof/lr_cr2hdr/downloads ]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on October 02, 2015, 10:28:45 AM
Or my method is a permanent fix. But it means low level Mac editing. It's not ideal but it saves launching Terminal every time.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on October 02, 2015, 11:16:54 AM
@Wadehome. Did you run the install for usr/bin or usr/local/bin?

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: wadehome on October 02, 2015, 05:24:22 PM
@Danne I just ran the normal install which puts them in usr/bin, but you need to make sure you disable system integrity first.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 02, 2015, 05:45:35 PM
@wadehome -- The reason I'm trying to get the dcraw and exiftool that is already inside the plugin working is because:
In the meantime it is very easy to write a simple shell script that can launch Lightroom with the proper path for the plugin. Open TextEdit and copy and paste from the dialog box (using the version I uploaded last night). Just make sure to save it as a plain text file and add a ".command" file extension. For example on my system it looks like this:

LR.command
Code: [Select]
export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":$PATH
/Applications/Adobe\ Lightroom/Adobe\ Lightroom.app/Contents/MacOS/Adobe\ Lightroom

In order to get it to launch by double-clicking you need to go to the terminal and enter this:
Code: [Select]
chmod +x LR.command
Note that you don't have to cd to the file location to do this. Simply type chmod +x then drag and drop the file into the terminal window to get the path to your file.

Like I said this is just a workaround until someone comes up with a way to get the lua script inside the plugin to find the path to dcraw and exiftool that are located inside the plugin. Or maybe cr2hdr needs to be modified so it can accept a path argument?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on October 03, 2015, 03:00:58 AM
So I tested it out, and it is as I suspected, environment variables are not persisted to the next call to LrTasks.execute().
Test Code:
Code: [Select]
  LrTasks.execute("echo ======================")
  LrTasks.execute("export PATH=/my/test/path:${PATH} && echo ${PATH}")
  LrTasks.execute("echo ======================")
  LrTasks.execute("echo ${PATH}")
Output:
Code: [Select]
======================
/my/test/path:/opt/local/bin:/opt/local/sbin:/opt/local/bin:/opt/local/sbin:/Library/Frameworks/Python.framework/Versions/2.7/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/git/bin:/usr/local/astrometry/bin:/usr/local/opt/coreutils/libexec/gnubin
======================
/opt/local/bin:/opt/local/sbin:/opt/local/bin:/opt/local/sbin:/Library/Frameworks/Python.framework/Versions/2.7/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/git/bin:/usr/local/astrometry/bin:/usr/local/opt/coreutils/libexec/gnubin

But this is no problem, all you have to do is prepend the path export to all the calls to cr2hdr, which should be very simple (and get rid of the dependency check like you already have).
For example, simply replace all the lines:
Code: [Select]
result = LrTasks.execute(command)

with this:
Code: [Select]
if MAC_ENV then
    command = 'export PATH='..LrPathUtils.child(_PLUGIN.path, 'bin')..':${PATH} && '..command
end
result = LrTasks.execute(command)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 03, 2015, 04:11:00 AM
I was just about to report on a suggestion I got on the Adobe Lightroom SDK (https://forums.adobe.com/thread/1969031) forum. Their top guy there, johnrellis, confirmed that LrTasks.execute() calls don't persist. What he suggested is to make a launcher script for cr2hdr. Basically it does the same as what you are suggesting, set the path just before launching cr2hdr.

cr2hdr.sh
Code: [Select]
export PATH=`dirname -- "$0"`:$PATH
cr2hdr $@

I like your approach better. I've got to take a break now--it is Friday night here and I'm getting pulled away from the keyboard.

[EDIT: By the way I did do exactly what you suggested, there were only 2 "result = LrTasks.execute(command)" in the script but it didn't work. Looks like it is going to take a little longer to fix this.]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 03, 2015, 04:59:21 AM
One more try and it worked!

The path had spaces so it needed to be in quotes. Notice the quotes after the ="' and 'bin"'

Code: [Select]
if MAC_ENV then
    command = 'export PATH="'..LrPathUtils.child(_PLUGIN.path, 'bin"')..':${PATH} && '..command
end
result = LrTasks.execute(command)

Big thanks to dmilligan!

[EDIT: Official version is ready: https://bitbucket.org/kichetof/lr_cr2hdr/downloads ]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 04, 2015, 03:27:06 AM
There's still more to do.

The Mac GUI issue I reported back in July (http://magiclantern.fm/forum/index.php?topic=11056.msg151316#msg151316) should be solved and if you choose make a compressed DNG without having the Adobe DNG Converter installed it will give you an uncompressed dualiso.dng but no warning that it could not compress the DNG. The only indication that something went wrong is if you have the log file option enabled there's a little note at the end of the file, "Adobe DNG Converter not found."

The "proper" way to deal with this is through kichetof's bitbucket repository (https://bitbucket.org/kichetof/lr_cr2hdr) but he hasn't been active for a while. Anyone near Geneva, Switzerland who could bribe him with some beer?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 04, 2015, 04:45:42 PM
Taking a closer look at the GUI, wb=exif is being cutoff. This shows up on two Macs that I have tried. In addition, the window cannot be resized to show it properly.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F489%2F19511598300_cf1d437357_z.jpg&hash=e9c8aa1cb7788805d38688023706b0f7)

I made a fix of this in case anyone else is having this problem. In addition I forked kichetof's repository (https://bitbucket.org/kichetof/lr_cr2hdr) and will start doing the changes there so my test builds will be located at:

[EDIT: Official version is ready: https://bitbucket.org/kichetof/lr_cr2hdr/downloads ]

Please test out the WIP build and post feedback.

Hope this doesn't cause too much confusion. As far as I know kichetof is the only one who can make changes to the plugin's official bitbucket repository. While we're waiting for him to come back to this project you can check out his photos on Flickr (https://www.flickr.com/photos/kichetof).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on October 04, 2015, 05:13:21 PM
Nice to see this plugin maintained Dfort.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on October 05, 2015, 01:09:40 AM
Indeed it is nice to see this plugin maintained.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F592%2F21939373822_48b50cd12c_n.jpg&hash=4df078251555dccb1c517d361c3ffb88) (https://flic.kr/p/zqH2tU)

Great work & Thanks, Daniel!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 05, 2015, 07:43:59 PM
Need some feedback from Windows users.

Are the radio buttons disappearing when you select a radio button. Look at the screenshot of the Mac UI (http://magiclantern.fm/forum/index.php?topic=11056.msg151316#msg151316) to see what I mean.

I've been in contact with Adobe about this. Looking for a workaround.

https://forums.adobe.com/message/8030703#8030703
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 05, 2015, 07:47:39 PM
No, they don't disappear. Kichetof had the same problem and it was discussed here before.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on October 05, 2015, 07:51:49 PM
perhaps you should just use dropdowns instead of radio buttons, that will make it a lot more compact anyway
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 05, 2015, 08:21:54 PM
Yes it was discussed before but things are changing and just wondering if that has changed too.

I grouped the radio buttons and it is working but it doesn't look too good:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F710%2F21955435441_e329933ed9_z.jpg&hash=f37b7c45b4836ca66291abe6d421e9e6)

Got a few suggestions including the dropdown (popup_menu?) and using os_Factory so it looks like there's a few things to try out.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 05, 2015, 08:31:53 PM
Just retested it with yesterdays build. All radio buttons are persistent.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 06, 2015, 01:41:39 AM
Posting another work in progress - cr2hdr.lrplugin_2015-10-05_WIP.zip (http://cr2hdr.lrplugin_2015-10-05_WIP.zip) This is for Mac users who are bothered by the disappearing radio buttons.

An hour ago I had enough fun for the day and posted a less than ideal version but I gave it one last try and it worked. So it looks exactly like kichetof designed it but the radio buttons don't disappear on the Mac. I could use some feedback from Windows users to make sure nothing is broken on that side.

I'll post the build here as soon as I clean up the code:

[EDIT: Official version is ready: https://bitbucket.org/kichetof/lr_cr2hdr/downloads ]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 06, 2015, 06:17:31 AM
First link not working, second link only showing "download repository" with older build -> Unable to test newest build.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 06, 2015, 07:10:36 AM
Hi Walter Schulz, you're too quick for me. It took me longer than I anticipated but it is there now. Replaced in both repositories. Also made a pull request. Hope I didn't break anything.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 06, 2015, 12:25:37 PM
Had to wait for LR update. Slow line here.
Windows GUI looks good so far. Will test conversions later. And welcome back, kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 06, 2015, 06:36:35 PM
If you are interested in these things:

https://bitbucket.org/kichetof/lr_cr2hdr/pull-requests/12/cr2hdr_unify_merge/diff

See why it took a while to get this pull request ready.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nikfreak on October 09, 2015, 06:16:09 PM
Anyone able to test a 100D dualiso cr2 ?? Just to see what happens  ;D
https://drive.google.com/file/d/0B9Mu66yg5QzRakxpUDdLblU3Mzg/view?usp=sharing
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on October 09, 2015, 06:58:10 PM
Worked prefectly both with lightroom plugin and cr2hdr-r @Nikfreak :).

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs14.postimg.org%2Fsn6uvln59%2FScreen_Shot_2015_10_09_at_18_56_17.jpg&hash=9f75699422085348d32bcc23510a76a1) (http://postimg.org/image/sn6uvln59/)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 09, 2015, 07:06:22 PM
Looks good to me too.

Straight conversion:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F623%2F21868364428_45ce62160c_z.jpg&hash=e0acd6de16bf3691fabd3792d9090070)



Processed:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5764%2F21435119153_a0a9f3b8b5_z.jpg&hash=88d5424246a4f365d43ec98283ffd2e7)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: nikfreak on October 09, 2015, 07:08:03 PM
Great! Thanx @Danne & @dfort.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on October 10, 2015, 12:08:49 AM
Beautiful!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on October 20, 2015, 03:47:59 PM
Hi all  8)

sorry for my absence and for my low activity for Magic Lantern and my plugin  :-[

Hopefully, you're always here !

Big thanks to @dfort for his great pull request, that kick my ass to move to you!!

What's new ?

I hope it will be the last update for this 3.0-BETA X :)

Download latest version cr2hdr.3.0BETA3.3 here (https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.3.0BETA3.3.lrplugin.zip)

I'll do my best to be more reactive on the forum, but if not, don't hesitate to send me a mail to my gmail address :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 20, 2015, 04:21:21 PM
Thanks  kichetof -- you made this even better.  :D
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on October 20, 2015, 04:33:48 PM
Welcome once again Kichetof and great efforts dfort, dmilligan. A great plugin got even better.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on October 20, 2015, 05:01:56 PM
Perfectly well said. A great plugin just gotten better. Excellent timing, @kichetof! [emoji106]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: shissc1079 on October 21, 2015, 12:39:13 PM
VERY GOOD!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on October 21, 2015, 04:47:31 PM
New features in progress for LR6/CC users : syncing develop params :)
I always forget to recheck lens profile and calibration profile !

The changes here (https://bitbucket.org/kichetof/lr_cr2hdr/commits/0229983f74e9f804e73c3158c618fcfbf6899e2f)
You can replace the file and test it (no GUI option to enable/disable <- todo) and need some improvement (see my post on Adobe forums).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on October 23, 2015, 09:57:22 AM
LR6/CC syncing develop params OK :)

I'll add this feature on the new version when you will agree to leave beta :)

commit c705594 (https://bitbucket.org/kichetof/lr_cr2hdr/commits/c70559491cb4e8ba2b65ce59863e35056e5b9f93)


@Walter Schulz do you have some issue with presets loaded ?

I think we have an Adobe Lightroom 6 problem here, kichetof.
- Downloaded SDK for LR5 (no LR6 SDK there, yet)
- Copied extracted FTP Upload plug-in directory to local disk
- Used Plug-in Manager to install plug-in
- Several times restarting LR.
-> Not showing up in "Presets". Same behauviour as your plug-in.
- Created an item "FTP Upload" in "User Presets" and this one is showing up.

That's right, no presets folder for this plugin, only selected under export menu list and you could create a user preset to keep settings
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on October 23, 2015, 10:30:08 AM
Alright you have finally convinced me to upgrade...

Not sure if I'll be happy paying "rent" to Adobe after years of supporting them back in their disc days.

Hopefully the trade off with their extras and mobile app will be worthwhile especially the Photography bundle package which includes their latest Photoshop as well.

Thanks for the heads up & You're def a tease, kichetof! [emoji4]

p.s. Their customer service better be more efficient than how it used to be back in early to mid 2000's now that they're all getting "paid" by the month... Fun times, ugh! lol
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 23, 2015, 10:54:25 AM
Beware: Don't upgrade to 6.2.x/CC 2015.2.x if you don't want to have new - and disimproved - import dialog.
You may want to use 6.1.1 instead.
Adobe's apology for buggy 6.2 and new import dialog (http://blogs.adobe.com/lightroomjournal/2015/10/lightroom-6-2-release-update-and-apology.html)
Adobe's own downgrade instruction (http://blogs.adobe.com/lightroomjournal/2015/10/lightroom-62-import-update.html)

@kichetof: Will try to reply soon.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on October 23, 2015, 04:37:18 PM
Quote
I think we have an Adobe Lightroom 6 problem here, kichetof.
- Downloaded SDK for LR5 (no LR6 SDK there, yet)

Guess that was an old quote from Walter Schulz

http://wwwimages.adobe.com/content/dam/Adobe/en/devnet/photoshoplightroom/pdfs/lr6/lightroom-sdk-guide.pdf
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on October 23, 2015, 05:08:18 PM
Yes I know. We have a bug with the plugin for loading the preset under the export window. And I found this post about an another plugin that doesn't have a preset folder, so it's a classic way to doesn't have anything on the left panel (but not for my plugin).

Does someone encounter this bug with latest beta without hyphen on the folder name?
If not, I think we only need to add some translations on DE (PT & SV welcome) to leave beta  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 23, 2015, 07:08:19 PM
@kichetof: Hyphen it is! At least in Windows.
Path name without: Context menu entry is there.
Path name with: Nope, invisible here, only in "Export ..." -> drop-down box

Tested with an older build (about April) and newest.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on October 23, 2015, 07:17:32 PM
Beware: Don't upgrade to 6.2.x/CC 2015.2.x if you don't want to have new - and disimproved - import dialog.
You may want to use 6.1.1 instead.

That's right. I remember reading that on their Forums recently. Thanks for the friendly reminder.

Does someone encounter this bug with latest beta without hyphen on the folder name?
If not, I think we only need to add some translations on DE (PT & SV welcome) to leave beta  8)

This only applies to Window users, correct?

I'm still debating with myself whether or not I should upgrade from LR 5.7 to LR 6.1 due to their monthly plan.  :o
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 23, 2015, 07:23:14 PM
I'm still debating with myself whether or not I should upgrade from LR 5.7 to LR 6.1 due to their monthly plan.  :o

? You can buy "old-fashioned" LR licences. You don't have to subscribe.
http://laurashoe.com/2015/04/21/which-should-i-buy-lightroom-cc-2015-or-lightroom-6/
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on October 23, 2015, 08:02:15 PM
Ah that's good to know and unfortunately it seems that Adobe's still doing a decent job of luring me into their "Photography Plan" which not only includes latest PS and the mobile app for LR which seems pleasing.

I've tried their trail versions last year and it was all kind of buggy 'n shit.

But I supposed they have ironed all these out by now... Thanks for heads up, Walter!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on October 23, 2015, 09:06:37 PM
@Walter Schulz yeeeeeees  8)  8)
We can leave beta status! No?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 23, 2015, 09:27:22 PM
Let me take a look on DE strings over the weekend. Do you have checked for obsolete string definitions in TranslatedStrings_xx.txt? We lost some in transaction after 20bit merge, I suppose.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on October 23, 2015, 09:42:02 PM
I'll check translated file to remove old definition if needed!
Could you translate 2 new definitions on the branch sync_develop_params too? Big thanks for that!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Troylee on October 23, 2015, 10:00:31 PM
Hello to all,

I'm a new user of ML and that's really great thing for my old 5dm2. Thank you very much for this second chance for my camera.
Just tried the Dual ISO and LR plugin v3.0 beta3. Everything looks good but one thing - is it ok if after conversion with cr2hder  I've got more green color and more dark? It's easy to correct in LR or PS but is it ok or not?

Thank you in advance for the help.

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2F3.bp.blogspot.com%2F-wWXqhI6iRy0%2FViqRQz5xXJI%2FAAAAAAAAGuc%2FtXf8YTrkaSw%2Fs1600%2Fdual_iso_test.jpg&hash=7dfc24346263ffda132bc5ba879ce190)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on October 25, 2015, 05:21:13 PM
@Troylee: Sure that's normal, try playing with sliders to achieve certain looks.

@all:

After finally going through upgrading to the latest LR6 (I still kept LR5) as well as managed to downgrade back to 6.1.1 (Thanks Walter for the tips) and ran the latest plugin cr2hdr.3.0BETA3.3 with ease!

Pre
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F572%2F22452961902_d4dc059f2c_n.jpg&hash=194eed1228816e5ea95c6df0fb12587f) (https://flic.kr/p/Ad6ijN)

Post
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F572%2F21845191693_5729887d32_n.jpg&hash=1dd88adc044758bc6d396e27e804309e) (https://flic.kr/p/zhojq6)

Merged Info
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5667%2F22452560152_d17279ff97_n.jpg&hash=ee2e1413be6a6c91c3f4c8dc33ea798b) (https://flic.kr/p/Ad4eU5)

Excellent work once again, @kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on October 25, 2015, 09:02:22 PM
@kichetof: Edited TranslatedStrings_de.txt.
I think proofreading TranslatedStrings_en.txt by native speaker would be fine. ;-) "Importation" does sound odd ...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on October 28, 2015, 12:36:10 PM
Thanks @Walter for DE translation :)

Regarding EN, if someone want to edit something, feel free to make a pull request :)

could you try to replace MLProcess.lua with this one (https://bitbucket.org/kichetof/lr_cr2hdr/raw/926d3c7028cf25403e30d6271c40465a65309197/MLProcess.lua) ?
You'll have the sync develop parameters and normally fix a bug with background operation.

When you try this file, select a collection to be syncing with Lr Mobile and active the sync, after that, convert one file with the plugin and keep the summary dialog active.
connect to Lr Mobile (web browser, iPad, iPhone) and look if your collection photo's continue to be syncing, I hope!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 09, 2015, 04:54:01 PM
No news, good news ! 3.1 ??  8) 8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 09, 2015, 04:57:22 PM
Must confess I haven't tested LR mobile ...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 09, 2015, 05:26:32 PM
You can test it with Lr Mobile or other background tasks.
I had a blocking task (syncing mobile) when summary was open but I don't know if it appear with other task ..
Normally this bug is fixed, I hope so!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on November 11, 2015, 02:43:02 AM
Wish I could help out but now I'm busy on a job and don't have my gear with me to test out the new features. Guess I could take a look at the menus and see if any English grammar mestakes be made more better.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DavidSamish on November 11, 2015, 07:37:18 PM
I've been using the cr2hdr-r_9.9_lut_lab to process my dual iso photos with some success, but I was looking forward to using the Lightroom plugin to simplify the process.

I finally got it to work, but the exposure on the processed file is way too high; the highlights are blown out and I can't adjust them back.

Here is a before and after sample. I'm using Lightroom CS6 on a Mac with El Capitan. These are shot with a Canon 70D with ML 70D.111A.

I don't know how to add attachment to this forum, so here is a dropbox link to the files: https://www.dropbox.com/sh/na83wgkdeq05rso/AAAi9k4bS0_GdAWBw4dV4Y7aa?dl=0

What am I doing wrong?

I've updated to the LR Plugin Beta 3.3 and get a error #256 when I try to export. LR 6.3CS Mac El Capitan
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DavidSamish on November 11, 2015, 07:41:18 PM
Oops. I had the wrong url, but I edited it.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 11, 2015, 07:48:09 PM
There are known problems with eos 70D and dual iso conversion. I had problems using adobe dng converter with the 70D.
By the way, you could update to the latest cr2hdr-r_12.3. It gives the in camera white balance to the converted DNG files. I get the multipliers with dcraw. Don,t know if this could be implemented in the lightroom plugin as well.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 12, 2015, 07:47:36 AM
That's a good feature! I'll try it on both windows and Mac to check if it's possible with Lr :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 12, 2015, 08:23:03 AM
Cool. Here is the way I use the multipliers.
http://www.magiclantern.fm/forum/index.php?topic=16024.msg155569#msg155569

-i -v gives some useful info from dcraw.
Code: [Select]
dcraw -i -v  DUAL3755.CR2
Gives below
Code: [Select]
Camera multipliers: 2032.000000 1024.000000 2009.000000 1024.000000
Then writing som bash to divide and insert the result with exiftool to AsShoNeutralValues. I,d like to pint out that the
Code: [Select]
--wb=exif doesn,t really work al the time so dcraw multipliers are more robust to obtain correct wb values.

Code snippet below is the way cr2hdr-r is working to get the numbers and dividing them etc. It also creates a lists which it uses after conversions to add the correct values after conversions.


Code: [Select]
ls *.CR2 *.DNG > /tmp/magic_l_prores/d_iso_list

while grep -q 'CR2' /tmp/magic_l_prores/d_iso_list
do
   
grep 'CR2' /tmp/magic_l_prores/d_iso_list | awk 'FNR == 1 {print}' > /tmp/magic_l_prores/d_iso_CR2
CR2=$(cat /tmp/magic_l_prores/d_iso_CR2)
rm /tmp/magic_l_prores/d_iso_CR2

~/Library/Services/folder_ProRes444_lut.workflow/Contents/dcraw -i -v $CR2 | awk '/Camera multipliers/ { print $3; exit }' > /tmp/magic_l_prores/CR2_01
CR2_01=$(cat /tmp/magic_l_prores/CR2_01)

echo 1024.000000/$CR2_01 | bc -l | awk 'FNR == 1 {print}' > /tmp/magic_l_prores/CR2_01
CR2_01=$(cat /tmp/magic_l_prores/CR2_01)
rm /tmp/magic_l_prores/CR2_01

~/Library/Services/folder_ProRes444_lut.workflow/Contents/dcraw -i -v $CR2 | awk '/Camera multipliers/ { print $5; exit }' > /tmp/magic_l_prores/CR2_02
CR2_02=$(cat /tmp/magic_l_prores/CR2_02)

echo 1024.000000/$CR2_02 | bc -l | awk 'FNR == 1 {print}' > /tmp/magic_l_prores/CR2_02
CR2_02=$(cat /tmp/magic_l_prores/CR2_02)
rm /tmp/magic_l_prores/CR2_02

echo "-AsShotNeutral=$CR2_01 1 $CR2_02" > /tmp/magic_l_prores/CR2_R
CR2_R=$(cat /tmp/magic_l_prores/CR2_R)

grep 'DNG' /tmp/magic_l_prores/d_iso_list | awk 'FNR == 1 {print}' > /tmp/magic_l_prores/d_iso_DNG
DNG=$(cat /tmp/magic_l_prores/d_iso_DNG)
rm /tmp/magic_l_prores/d_iso_DNG

~/Library/Services/folder_ProRes444_lut.workflow/Contents/exiftool $CR2_R $DNG -overwrite_original

echo "$(tail -n +3 /tmp/magic_l_prores/d_iso_list)" > /tmp/magic_l_prores/d_iso_list
list=$(cat /tmp/magic_l_prores/d_iso_list)

mkdir -p CR2_ORIGINALS

mv $CR2 CR2_ORIGINALS

done
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 12, 2015, 12:23:14 PM
@Danne thanks for your snippet!

I'm trying to obtain same result on Windows...
If someone with more skill on Windows CMD is able to obtain the value, bingo!

Code: [Select]
for /f "tokens=3-6" %a in ('dcraw.exe -i -v "E:\Tof\Photos\Photographies\2015\2015_10_18 Lausanne automne\_MG_9488.CR2" ^| findstr /C:"Camera multipliers"') do set n1=%a && set n2=%b && set n3=%c && set n4=%d
set /a res=%n1:.000000=%/%n2:.000000=%
echo %res% <-- 1 ... NO FLOAT!!!


value used
(set n1=1802.000000  && set n2=1024.000000   && set n3=1765.000000   && set n4=1024.000000)
n1/n2 = 1.759765625
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 12, 2015, 12:30:46 PM
"Set /a" can't handle float.
Powershell will do. Or normalize.

Code: [Select]
C:\Windows\system32>powershell 1802/1024
1,759765625

EDITEDIT:
Code: [Select]
for /F "tokens=3-6" %a in ('dcraw -i -v *.cr2 ^|findstr /C:"Camera multipliers"') do for /F %m in ('powershell %a/%b') do set res=%m
set res=%res:,=.%
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 12, 2015, 01:25:50 PM
Thanks Walter!

The final target is

Code: [Select]
exiftool "-AsShotNeutral=XXX 1 YYY" DUAL3755.DNG
XXX and YYY come from dcraw, but we need to parse value from dcraw before running exiftool on the same command :)
I'll try your command!

dcraw parse output:

Code: [Select]
for /F "tokens=3-6" %a in ('dcraw.exe -i -v "E:\Tof\Photos\Photographies\2015\2015_10_18 Lausanne automne\_MG_9488.CR2" ^| findstr /C:"Camera multipliers"') do (for /F %m in ('powershell %a/%b') do set res1=%m & for /F %u in ('powershell %c/%d') do set res2=%u)
echo %res1:,=.%
echo %res2:,=.%
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 12, 2015, 01:50:12 PM
Dang! You are fast!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 12, 2015, 01:53:01 PM
final code
Code: [Select]
for /F "tokens=3-6" %a in ('dcraw.exe -i -v "E:\Tof\Photos\Photographies\2015\2015_10_18 Lausanne automne\_MG_9488.CR2" ^| findstr /C:"Camera multipliers"') do (for /F %m in ('powershell %a/%b') do set res1=%m & for /F %n in ('powershell %c/%d') do set res2=%n) & exiftool.exe "-AsShotNeutral=%res1:,=.% 1 %res2:,=.%" "E:\Tof\Photos\Photographies\2015\2015_10_18 Lausanne automne\_MG_9488.CR2"

Next step --> Mac
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 12, 2015, 02:17:45 PM
Really glad to see that this is getting implemented to your fine plugin Kichetof.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 12, 2015, 02:41:59 PM
first try on Mac
Code: [Select]
./exiftool "-AsShotNeutral=$(./dcraw -i -v DUAL4726.CR2 | awk '/Camera multipliers/ { print $3/$4}') 1 $(./dcraw -i -v DUAL4726.CR2 | awk '/Camera multipliers/ { print $5/$6}')" DUAL4726.CR2

Someone see a best solution ?

@Danne thanks to you for the tip!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on November 12, 2015, 06:05:31 PM
Why not just parse the output from dcraw in Lua and then call exiftool? Then you shouldn't need different complicated shell scripts for Mac/Win. You might not even need exiftool, but be able to apply the WB with Lr API.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 12, 2015, 08:41:52 PM
That's right @dmilligan!
But from LrTask.execute only return code is catches and if return code is ok I'll not have the dcraw output.

Do you know if io.popen is present on Lr? No access until tomorrow <-- normally yes: Lua 5.1

I'm looking how to transform dcraw multipliers to temp/tint to apply them on Lr, do you know how to convert?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 12, 2015, 09:25:06 PM
Isn,t the division results giving you the the temp/tint values via AsShotNeutral values? Or are there other values you looking for?

Code: [Select]
dcraw -i -v DUAL3755.CR2

Camera multipliers: 2032.000000 1024.000000 2009.000000 1024.000000

1024.000000/2032.000000=0.50393701

1024.000000/2009.000000=0.50970632

Code: [Select]
exiftool "-AsShotNeutral=0.50393701 1 0.50970632" DUAL3755.DNG
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on November 12, 2015, 09:49:29 PM
Yes, you can use popen
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: CKING018 on November 12, 2015, 10:19:01 PM
Hey guys

I need some help. I am pretty sure I have downloaded everything including the cr2hdr, as well as dcraw and exiftool (which I think I did because if I type "dcraw" or "exiftool" in to the Terminal it outputs the app? But when I try to export a picture to cr2hdr it gives me this. Any suggestions?
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fphotos-1.dropbox.com%2Ft%2F2%2FAADwcUjode9enlLFtonCirUKxI2uSOe_vTLD-CBfpqxZ8g%2F12%2F128164459%2Fpng%2F32x32%2F3%2F1447380000%2F0%2F2%2FScreen%2520Shot%25202015-11-12%2520at%25203.13.37%2520PM%25201.png%2FELW812IYqRwgASgB%2FNOQMFOe4oNft8AaQeAoXJ4otmCK68-YYorcdokKyokI%3Fsize_mode%3D5%26amp%3Bsize%3D32x32&hash=59f1905421fa19c6f972198bd0ce0775)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 12, 2015, 10:38:11 PM
Tried this version?
http://www.magiclantern.fm/forum/index.php?topic=11056.msg155765;topicseen#msg155765
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: CKING018 on November 12, 2015, 11:03:03 PM
I actually saw that right after I posted and now it is working for me. I did notice though that on my Canon 7D, when I turn the video mode to RAW (either the normal or MLV) and go to Dual Iso it says it is on with the green dot but it is not lit. Does the 7D support dual iso in video or no?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 13, 2015, 12:08:04 AM
No Dual-ISO support in video mode for 7D, 50D, 5D2.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 13, 2015, 07:21:27 AM
@Danne I'm looking for a mathematical transformation from multipliers divided to temp (°K) / tint (green to violet), or maybe its wrong and don't use the right way!

@dmilligan thanks I'll test that!

@CKING018 which version of plugin? The latest like Danne give you? Which version of Mac OS X?

Hmmmm ... that doesn't work ...

Code: [Select]
local LrDialogs = import 'LrDialogs'
local LrLogger = import 'LrLogger'
local LrPathUtils = import 'LrPathUtils'
local LrTasks = import 'LrTasks'

local log = LrLogger( 'popenLr' )
log:enable( "print" )

local cmd = string.format('"%s" -i -v "%s"', LrPathUtils.child(_PLUGIN.path, 'dcraw.exe'), LrPathUtils.child(_PLUGIN.path, '_MG_9542.CR2'))
log:debug(cmd) -- "C:\Users\tof\Scripts\popen\popen.lrplugin\dcraw.exe" -i -v "C:\Users\tof\Scripts\popen\popen.lrplugin\_MG_9542.CR2"
local stdout = io.popen(cmd) -- cmd open and close quickly
local output = stdout:read('*all') -- nothing
for line in stdout:lines() do -- nothing printed, so no data in stdout
    log:debug(line)
end

Another way is to capture output to a temp file, but it's less beautiful !
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on November 13, 2015, 01:26:54 PM
Perhaps popen doesn't work on Windows. I don't have a win pc, but I know it works on Mac. Also, your code snippet the way it is written shouldn't work, b/c you read the whole input, discard that and then try to read it again line by line. You should simply print the output variable. You also may need to specify the mode parameter for popen.

RGB to Temp/Tint is an incredibly complex calculation involving matrix transformations. I have implemented it in MLVFS source, but I still don't really understand the math.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 13, 2015, 04:34:49 PM
Code: [Select]
local cmd = string.format('""%s" -i -v "%s""', LrPathUtils.child(_PLUGIN.path, 'dcraw.exe'), LrPathUtils.child(_PLUGIN.path, '_MG_9542.CR2'))
-- note the double double quote
log:debug(cmd)

for l in io.popen(cmd, 'r'):lines() do
    log:debugf("%s", l)
end

Yes that works!

Okay I'll apply exiftool -AsShotNeutral to simplify the process :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 15, 2015, 02:12:12 PM
Hi,

i have testet version 3.0 beta 3.3 with dual iso pics from my 70D and the plugin works randomly.

here two pics, the first doesn't work and second works:

https://www.dropbox.com/sh/8obd08vnf59y7kn/AABqSzGQAbyf0cFixvloDXm1a?dl=0

regards

starbase64
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 15, 2015, 03:36:22 PM
What does "doesn't work" mean?
- Dual-ISO is not treated as Dual-ISO or any other error resulting in cr2hdr missing to generate DNG?
- Converted DNG exposure is just wrong (overexposed)?

Can confirm second one.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 15, 2015, 03:41:31 PM
the replied message is simple, it is not a dual iso image
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 15, 2015, 03:45:59 PM
Conversion is working here. Had a hickup once with a strange error message about path properties but not reproducable.
You are using latest cr2hdr (compiled by dfort)?
https://bitbucket.org/daniel_fort/magic-lantern/downloads
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 15, 2015, 03:52:46 PM
i use the LR Plugin 3.0 beta 3.3
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 15, 2015, 03:54:14 PM
Download dfort's binaries and replace cr2hdr.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 15, 2015, 03:59:20 PM
cr2hdr-Windows_2015-11-14.zip works
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 16, 2015, 03:40:56 PM
Bin updated, thanks @dfort
First support of WB=dcraw from camera multipliers :)
Move all files into lrplugin container to avoid hyphen bug and other little tweaks (see commits)

Version 3.1 on the road!  8) 8)

Could you confirm that GUI doesn't go out of view ? (on both Mac and Windows, for me everything is ok (27" for Mac and 2x24" on Win), luckily 8))

(No download link, download repo; Used command line operation for the moment, need to considere the gain from parsing command output in lua)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 17, 2015, 05:40:38 PM
And Adobe *can* speed up fixing things ...
LR 6.3/CC 2015.3 is there and old import dialog is back
http://blogs.adobe.com/lightroomjournal/2015/11/lightroom-cc-2015-3-6-3-now-available.html

Patch installer seems to work for LR 6.1.x/CC 2015.1.x but CC app still wants to install October update (aka: 6.2/CC 2015.2). Those jumping from LR CC 2015.1 to 2015.3 may want to install LR CC 2015.2 first. We will see an updated CC app soon, I suppose.
Camera RAW version is 9.3
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 17, 2015, 05:53:09 PM
Great news!! Normally the plugin should works with this version!
I can't try it before tomorrow morning!

If someone could confirm that everything works  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 17, 2015, 06:07:40 PM
I'm afraid I cannot confirm this, now.
Plug-In is there and can be used but I have exactly the same error starbase64 was reporting. One of his sample files works fine and is converted and for the other one cr2hdr is telling me that it is no Dual-ISO file.

Update: Deleted his samples and reimported both and everything works fine now.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 17, 2015, 10:38:41 PM
Glad to read this! I'll try tomorrow to confirm that everything works well!

[EDIT] everything is ok !
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 18, 2015, 10:52:05 AM
@Walter Schulz

can you upload v3.1 for me? can't build with command line.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 18, 2015, 11:15:35 AM
@starbase64 no v3.1 for the moment. But you only need to replace cr2hdr from bin folder with @dfort compiled
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 18, 2015, 11:21:33 AM
@kichetof

ok, thanks
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: NickZee on November 19, 2015, 08:08:17 AM
Hello @kichetof,

I recently started using the plugin and think it is great!  I received these errors and I believe turning off Same Levels fixed it.

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs13.postimg.org%2Frh3xsimmb%2FLR_Error.jpg&hash=fc933bb20100a124a3ba9815b9bbab5b) (http://postimg.org/image/rh3xsimmb/)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs13.postimg.org%2F6y91ng8oz%2FLR_Error2.jpg&hash=9d0996381725766e75e98629d3ebb7ff) (http://postimg.org/image/6y91ng8oz/)


I'm blending 5600 files right now.  They are from 20 Dual ISO RAW videos. 

Do you have a donation link?  If I find the plugin in my workflow, I would like to contribute to its further development.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 19, 2015, 11:29:46 AM
Hello @NickZee

Ouch effectively same-levels will create an error like that with a lot of pictures.

When you run the plugin with same-levels, it will run like that:

Code: [Select]
C:\Users\tof\Scripts\cr2hdr.lrdevplugin\bin\cr2hdr.exe  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --same-levels 'C:\Users\tof\photos\1.DNG' 'C:\Users\tof\photos\2.DNG' 'C:\Users\tof\photos\3.DNG' 'C:\Users\tof\photos\4.DNG' 'C:\Users\tof\photos\5.DNG' 'C:\Users\tof\photos\6.DNG' 'C:\Users\tof\photos\7.DNG' 'C:\Users\tof\photos\8.DNG' 'C:\Users\tof\photos\9.DNG' 'C:\Users\tof\photos\10.DNG' 'C:\Users\tof\photos\11.DNG' 'C:\Users\tof\photos\12.DNG' 'C:\Users\tof\photos\13.DNG' 'C:\Users\tof\photos\14.DNG' 'C:\Users\tof\photos\15.DNG' 'C:\Users\tof\photos\16.DNG' 'C:\Users\tof\photos\17.DNG' 'C:\Users\tof\photos\18.DNG' 'C:\Users\tof\photos\19.DNG' 'C:\Users\tof\photos\20.DNG' 'C:\Users\tof\photos\21.DNG' 'C:\Users\tof\photos\22.DNG' 'C:\Users\tof\photos\23.DNG' 'C:\Users\tof\photos\24.DNG' 'C:\Users\tof\photos\25.DNG' 'C:\Users\tof\photos\26.DNG' 'C:\Users\tof\photos\27.DNG' 'C:\Users\tof\photos\28.DNG' 'C:\Users\tof\photos\29.DNG' 'C:\Users\tof\photos\30.DNG' 'C:\Users\tof\photos\31.DNG' 'C:\Users\tof\photos\32.DNG' 'C:\Users\tof\photos\33.DNG' 'C:\Users\tof\photos\34.DNG' 'C:\Users\tof\photos\35.DNG' 'C:\Users\tof\photos\36.DNG' 'C:\Users\tof\photos\37.DNG' 'C:\Users\tof\photos\38.DNG' 'C:\Users\tof\photos\39.DNG' 'C:\Users\tof\photos\40.DNG' 'C:\Users\tof\photos\41.DNG' 'C:\Users\tof\photos\42.DNG' 'C:\Users\tof\photos\43.DNG' 'C:\Users\tof\photos\44.DNG' 'C:\Users\tof\photos\45.DNG' 'C:\Users\tof\photos\46.DNG' 'C:\Users\tof\photos\47.DNG' 'C:\Users\tof\photos\48.DNG' 'C:\Users\tof\photos\49.DNG' 'C:\Users\tof\photos\50.DNG' 'C:\Users\tof\photos\51.DNG' 'C:\Users\tof\photos\52.DNG' 'C:\Users\tof\photos\53.DNG' 'C:\Users\tof\photos\54.DNG' 'C:\Users\tof\photos\55.DNG' 'C:\Users\tof\photos\56.DNG' 'C:\Users\tof\photos\57.DNG' 'C:\Users\tof\photos\58.DNG' 'C:\Users\tof\photos\59.DNG' 'C:\Users\tof\photos\60.DNG' 'C:\Users\tof\photos\61.DNG' 'C:\Users\tof\photos\62.DNG' 'C:\Users\tof\photos\63.DNG' 'C:\Users\tof\photos\64.DNG' 'C:\Users\tof\photos\65.DNG' 'C:\Users\tof\photos\66.DNG' 'C:\Users\tof\photos\67.DNG' 'C:\Users\tof\photos\68.DNG' 'C:\Users\tof\photos\69.DNG' 'C:\Users\tof\photos\70.DNG' 'C:\Users\tof\photos\71.DNG' 'C:\Users\tof\photos\72.DNG' 'C:\Users\tof\photos\73.DNG' 'C:\Users\tof\photos\74.DNG' 'C:\Users\tof\photos\75.DNG' 'C:\Users\tof\photos\76.DNG' 'C:\Users\tof\photos\77.DNG' 'C:\Users\tof\photos\78.DNG' 'C:\Users\tof\photos\79.DNG' 'C:\Users\tof\photos\80.DNG' 'C:\Users\tof\photos\81.DNG' 'C:\Users\tof\photos\82.DNG' 'C:\Users\tof\photos\83.DNG' 'C:\Users\tof\photos\84.DNG' 'C:\Users\tof\photos\85.DNG' 'C:\Users\tof\photos\86.DNG' 'C:\Users\tof\photos\87.DNG' 'C:\Users\tof\photos\88.DNG' 'C:\Users\tof\photos\89.DNG' 'C:\Users\tof\photos\90.DNG' 'C:\Users\tof\photos\91.DNG' 'C:\Users\tof\photos\92.DNG' 'C:\Users\tof\photos\93.DNG' 'C:\Users\tof\photos\94.DNG' 'C:\Users\tof\photos\95.DNG' 'C:\Users\tof\photos\96.DNG' 'C:\Users\tof\photos\97.DNG' 'C:\Users\tof\photos\98.DNG' 'C:\Users\tof\photos\99.DNG' 'C:\Users\tof\photos\100.DNG' 'C:\Users\tof\photos\101.DNG' 'C:\Users\tof\photos\102.DNG' 'C:\Users\tof\photos\103.DNG' 'C:\Users\tof\photos\104.DNG' 'C:\Users\tof\photos\105.DNG' 'C:\Users\tof\photos\106.DNG' ... ... ...

So, the command is too long ...
I'll thinking to find an another way to converse a lot of pictures (maybe to converse entire folder, but converse all pictures without exception)

If you want to donate, contribute to Magic Lantern :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 19, 2015, 03:06:45 PM
How about exiftool adding the white level from the first dng to all the selected pics after conversion? Don,t know how lightroom/lua registers the pics chosen but there must be some kind of listing?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 19, 2015, 03:52:11 PM
That a solution, but I need to calculate the white level...

cr2hdr same-levels source
Code: [Select]
if (same_levels && num_files > 1)
    {
        /* Equalize white-black for all shots.
         *
         * Assuming all the pictures were shot at the same exposure settings,
         * this step will make sure they are all rendered identically (without flicker).
         *
         * However, for this to work, all the files must be passed in the same command line.
         *
         * We will use something close to maximum range among all files (with outlier filter).
         *
         * This should work even if the black level is not the same in all shots.
         */
       
        printf("\nEqualizing levels...\n");
       
        int* ranges = malloc(num_files * sizeof(ranges[0]));
        for (int i = 0; i < num_files; i++)
        {
            ranges[i] = whites[i] - blacks[i];
        }
        int new_range = kth_smallest_int(ranges, num_files, num_files * 8 / 9 - 1);

        for (int i = 0; i < num_files; i++)
        {
            char* input_file = argv[file_indices[i]];

            /* fixme: duplicate code */
            char out_filename[1000];
            snprintf(out_filename, sizeof(out_filename), "%s", input_file);
            int len = strlen(out_filename);
            out_filename[len-3] = 'D';
            out_filename[len-2] = 'N';
            out_filename[len-1] = 'G';

            int new_white = blacks[i] + new_range;
            printf("%-16s: %d ... %d\n", out_filename, blacks[i], new_white);
            set_white_level(out_filename, new_white);
        }
       
        free(ranges);
    }

If Dual ISO same-levels picture are on the same folder, easy to run the command cr2hdr --same-levels path\*.DNG/CR2, but if some picture aren't Dual ISO ?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on November 19, 2015, 03:58:46 PM
@starbase64 no v3.1 for the moment. But you only need to replace cr2hdr from bin folder with @dfort compiled

Yesterday I updated the cr2hdr (along with the included exiftool and dcraw) in my download area, there was a problem with the previous version I compiled. The test version is preferred, it has some fixes by a1ex that haven't been merged into the unified branch yet.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 19, 2015, 03:59:41 PM
Or snatch it the old style way ;)

exiftool First.DNG | awk '/White Level/ { print $4; }' > /tmp/magic_l_prores/wl_01 
wl_01=$(cat /tmp/magic_l_prores/wl_01)
 rm /tmp/magic_l_prores/wl_01


Quote
If Dual ISO same-levels picture are on the same folder, easy to run the command cr2hdr --same-levels path\*.DNG/CR2, but if some picture aren't Dual ISO ?

Same level is only needed for movie DNG sequences not for standalone CR2 files?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on November 19, 2015, 04:05:02 PM
@kichetof if you are looking into cr2hdr make sure you are using the new cr2hdr branch that a1ex has been working on. You might also take a look at an issue that is causing a segmentation fault. dmilligan has narrowed down the problem.

http://magiclantern.fm/forum/index.php?topic=16166.msg157501;topicseen#msg157501
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 19, 2015, 04:15:22 PM
@Danne you can run --same-levels on CR2 but it does not make sense
Thanks for the command!

@dfort yes I follow the topic, I'll update bin with new one!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 19, 2015, 04:27:22 PM
Yes, exactly, CR2 can be ruled out. But I guess same levels has to be on folder basis and only for movie seqeunces so the first DNG from each folder would be the white level number for that specific folder of DNG files? That,s what I do with exiftool and cr2hdr-r to avoid flicker anyway.

Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 19, 2015, 04:57:13 PM
One other thing. If using the adobe dng converter you will get non linear results in white level once again so those won,t work together. There actually a linear settint in adobe dng converter but not implemented in cr2hdr.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 19, 2015, 04:58:22 PM
@Same-Levels Users

How do you use this function on Lightroom?
What do you think about that:

On Lightroom, if you check same-levels, the entire folder will be passing through cr2hdr --same-levels [other args] path/*.DNG[.CR2 for time lapse sequence] ?


Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 19, 2015, 05:24:46 PM
Optional: Yes.
Mandatory: I'm against it!
And please test what cr2hdr is doing with a folder filled quite good with high-res Dual-ISO files.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 19, 2015, 05:33:36 PM
Good idea @Walter!!
I can add a double option for --same-levels

1. Nothing changes (limited by the length of the command --> the number of pictures)
2. Convert the entire path

What do you think?

I'll try to convert a folder with dual ISO from my 5DIII
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on November 19, 2015, 06:37:36 PM
I'm loving this progress so far guys!

Excellent contribution party going on and I like the new concept @kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 19, 2015, 08:36:55 PM
Some bugs with path : "/Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.CR2"

Code: [Select]
19.11.15 21:13:38.381 Adobe Lightroom[907]: MLDualISO DEBUG cmd export PATH="/Users/tof/Documents/MagicLantern/lr_cr2hdr/cr2hdr.lrplugin/bin":${PATH} && exec "/Users/tof/Documents/MagicLantern/lr_cr2hdr/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.CR2" "/Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.DNG" > "/Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/same-levels-path.log"

output
Code: [Select]
/Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.CR2: No such file or directory
File not found: /Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.CR2
File not found: /Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.DNG
/Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.DNG: No such file or directory
File not found: /Users/tof/Pictures/Photographies/Magic Lantern/Dual ISO/same-levels-path/*.DNG

Code uploaded, I'll continue tomorrow
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Audionut on November 20, 2015, 05:50:20 AM
I tend to input a days worth of shooting into one folder.  This will typically be mixed content (regular CR2, dual iso, dual iso panorama).

So I just select the dual iso images I need processed with --same-levels and export those as a group.  So basically, the same opinion as Walter.

Optional: Yes.
Mandatory: I'm against it!

I defiantly wouldn't want all dual iso images processed with --same-levels, since that is not what that command is for.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on November 20, 2015, 07:12:53 AM
Well said, @Audionut!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 20, 2015, 07:22:22 AM
@Audionut yes like me!

My target is: facility the life of a lot of people

I'm starting to add an optional same-levels-path to apply on the entire folder, but "classic" way still here!!  8)

If you want to see (only see the GUI, converter doesn't works now), download the same-levels-path repo!

For the moment is a rough code, but I'll rewrite the entire process for getting image (I'm writing another plugin to play with collections and have more experience now!)

[EDIT]

Some bugs on Mac & Win to run the command with *.CR2... need some times to investigate
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 22, 2015, 11:01:42 PM
dual iso is awesome...

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F565%2F22926073010_9f578cb116_c.jpg&hash=cf0b729eef86b3d55ccb85d51443f1c3) (https://flic.kr/p/AVU7LS)
DualISO_&amp;_Enfuse (https://flic.kr/p/AVU7LS) by Maik Reifschneider (https://www.flickr.com/photos/maik_reifschneider/), auf Flickr
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 22, 2015, 11:08:04 PM
Interesting concept @starbase64. Curious. What are the benefits shooting dual iso in this situation? Are you maximizing each picture regaining highlights and shadows from each converted dual iso file prior to stacking in enfuse or do you enfuse them straight after conversion?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 22, 2015, 11:16:02 PM
enfused the converted dual iso images
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on November 23, 2015, 06:14:46 AM
Yes, but you've already got a bracketed set so why dual iso?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on November 23, 2015, 09:00:57 AM
i mean the result is much "cleaner"
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Audionut on November 23, 2015, 02:24:46 PM
If you compare to a bracketed set of regular exposures that covers the same dynamic range, it won't be.  The top three stops of the darkest image are half resolution, and the bottom couple of stops of the brightest image are not as clean as a regular ISO 800 image.  Dual iso is great in it's intended purpose, but it just doesn't make sense here.  Dual iso is intended to increase the dynamic range from a single exposure, where you otherwise cannot bracket.

Most cameras are shot noise limited for at least the top two stops of an exposure.  That is to say, the noise produced by the camera plays no role on image quality, until at least two stops from saturation (overexposure).

When you bracket at one stop intervals, you are bracketing for shot noise only.  The noise that the camera produces plays absolutely no role on image quality, until about three stops below the saturation (overexposure) point of the brightest image.  So with the darkest six images in your bracketed set, dual iso did nothing useful, but still produced all of its cons (half resolution highlights/shadows, etc).

The only time dual iso provided a useful outcome was in the brightest image.  Here, you gain the benefit of dual iso (increased dynamic range) in the shadow areas of this image.  But since you've taken seven images in this bracketed set anyway (at one stop apart), you probably should have just continued to exposure bracket till 1024 seconds, started increasing ISO, or some combination, since this would have maintained a higher level of quality in the shadows.

Dual iso is awesome.  :)

@kichetof thanks.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 25, 2015, 08:02:58 PM
@Same-Levels Users Testers

Normally everything should works on both Mac & Windows (not tested now on this).

Download the branch (https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip) and load the plugin in Lr.

Let me know if everything is fine for you. The code isn't perfect for the moment, need some time to rewrite some routines 8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on November 26, 2015, 12:33:42 AM
Hi kichetof

I've got some dual_iso dng's that crashed cr2hdr while using the LR plugin. You should look into the latest update:

http://magiclantern.fm/forum/index.php?topic=7139.msg157773;topicseen#msg157773

https://bitbucket.org/hudson/magic-lantern/commits/branch/cr2hdr
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 26, 2015, 07:14:32 AM
@dfort yes I follow your topic and the fixes by a1ex! Glad to see that!

Bin's will be updated when -same-levels will be done :)

@Walter (you've always good ideas!) & all
how I denominate the 3 options for --same-levels


Download the branch to see the GUI with new text
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 26, 2015, 12:20:59 PM
Just downloaded it. Bright ideas in short supply today.

But I'm quite sure your string cleanup cleared more than asked for. ;-) Some german text string disappeared.
q.e.d.

EDIT: Not happy with recent and proposed user interface for this argument. It's just a different thing. Other arguments do something with a single file and this one - sticking out like a sore thumb - leveling selected files or everything in a folder and it just hides in plain sight.

Mumbling ... self-resetting buttons ... warning if used for single file export ... warning if set during export ... will come back with proposal. Any input welcome.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 26, 2015, 01:45:58 PM
Yes I forget to mention that you need to restore default settings for cr2hdr, otherwise, it doesn't work (that will be fixed in final version)

Imagine that:

One picture selected:

Two or more pictures selected:

All pictures in folder selected:


For the moment is only for testing, GUI not finish

cr2hdr help strings was never translated :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 26, 2015, 02:15:02 PM
Does the new same-level select the whole directory regardless if you select one or all files?
Then maybe

- same level (only selected files)

- same level (selected files including the whole directory)

Havn, t had the time to test this yet. Good work Kichetof!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 26, 2015, 02:37:08 PM
You're right, new way process all files in directory, that you select one or more pictures.

That's really more simple to enable both same-levels options if selected picture is more than one...  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Audionut on November 26, 2015, 02:46:00 PM
With all pictures in folder selected, what is the difference between classic and entire path?  They would appear to do the same thing.

I haven't downloaded the GUI yet, but it would seem much better to simply provide an option of processing all files in the folder, even with no files selected.  And all CR2HDR options also, not just --same-levels.

When some files in a folder are selcted, then you have the option of processing just the selected files, or, all files in the folder.

Edit: wait it's late and I'm forgetting how lightroom works.  I'll download GUI before commentating further.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 26, 2015, 02:54:08 PM
With all pictures in folder selected, what is the difference between classic and entire path?  They would appear to do the same thing.

There *should* be no difference. String used for "classic" will contain all file names (thus causing problems if maximum command line string lenght is reached, 2047 or 8191). "Entire path" should run wildcards AFAIK.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on November 26, 2015, 03:46:14 PM
The wildcard same level works on DNG files as well as CR2? A common scenario would be bringing in a bunch of movie sequence dual iso dng folders.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on November 26, 2015, 03:52:07 PM
*Should* work but haven't tested it yet. Looks like MLProcess.lua lines 592+ are handling DNG.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 26, 2015, 04:00:58 PM
@Danne yes it do!
Code: [Select]
sameLevelsPathAll = string.format("\"%s/\"*.CR2 \"%s/\"*.DNG", sameLevelsPath, sameLevelsPath)
GUI update (https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip) :)

Select one, more, all from same folder or from 2 distinct folders, normally everything should works well!

Updated default settings for same-levels when you update the plugin :)
text changing to : no-same-levels; same-levels; same-levels on entire path

@All
This new option do the same as before, but convert entire path with wildcard instead of selected pictures (command too long with a lot of selected); with your args :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on November 26, 2015, 07:55:26 PM
Happy Thanksgiving everyone and Thanks once again to @kichetof for yet another surprise during the Holidays -- at least it keeps us all warm with the anxiety issues that comes along with ML. lol

Anyway, I just downloaded the latest GUI Beta and tried running your plugin with the Dual-ISO test files shot in MLV on SL1 (100D) via both non crop mode and crop mode.

Upon selecting the arguments and running the plugin will crash the application and would need to restart LR6 every time.

Is this normal?

Even for total of 111 files in combined?

Will investigate further and see if MLVFS could be the culprit because I was using the Virtual Files from running MLVFS...

*Edit*

Will do another test run with actual files in root of MBP. Stand by! 

*Edit#2*

Seems rendering fine atm w Flicker Handing selected to 'same-level' while using the DNG's on system's root (however I cant seem to figure out why the 'same level on entire path' is greyed out unable to highlighted it myself).

Now I am curious to play with the highlight/shadow slider ... what exactly does soft-film do and if I were to slide it up to +10 -- what would it do or at least supposed to do? Or better yet is there a 'sweet-spot' for it?

Here's what I also notice what could be a glitch or at least it seems to be hidden gem outside on the lower right within the GUI under 'White Balance' and I am unable to reach out to it if you look at the attachment below...
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5655%2F22961970519_6ec67b6a58_n.jpg&hash=5c8a6faad4b654d7a76745ea2901676a) (https://flic.kr/p/AZ56Rr)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 26, 2015, 09:00:12 PM
@DeafEyeJedi thanks for all :)
To have the same-levels on entire path enable, you need to select all pictures on the same folder. Let me know if it works!

I'll disable sharing width between WB and same-levels to make GUI into the view (on both Mac & win Lr that I've, my export screen is bigger...)

Crash appear every time you run plugin on MLVFS storage? I need to test that! Maybe isn't writable?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on November 26, 2015, 09:16:44 PM
I did select all the photos in both folders and yes if running virtual DNG's within MLVFS it will cause to crash but if running within root of system then it all seems OK.

Still need to investigate furthermore.

Thanks, @kichetof!

*Edit*

Okay now apparently I was running the older plugin by mistake I have two plugin folders (one within Application folder and another in the Content Folder) so after replacing with the latest version and ran again now I am getting this...
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F571%2F23222450712_cc4291aa39_n.jpg&hash=2df829ee0a36d0c2ddb3a69f71893b0b) (https://flic.kr/p/Bo68xf)

It could be due to SL1 files so I'll need to run another test files from other cameras to confirm this.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 26, 2015, 09:46:22 PM
If you select photos from multiple folders, you'll not have option enable. Only from one folder, select all.

I think that a I forget something... I'll investigate tomorrow. Your file is DNG?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 27, 2015, 08:46:41 AM
Same bug on MLVFS mounted point.

How to reproduce:

Mount MLV files with MLVFS
Add to catalog the mounted folder into Lr
Select some images and run Dual ISO plugin with same-levels enable
Lr crash

I need to investigate where is the bug ... I'll lookup when I've more time  8)
(I'm not a filmmaker, so I doesn't use MLVFS, but I'll find a workaround)

------------------------------------------------

Permission on MLV mounted point are personalized (maybe Lr doesn't have access)
New bug with Lr: edit a file into MLV folder and save metadata into the file: ERROR
Code: [Select]
free space is less than 1Gb
So, maybe when can't use MLVFS with Lr properly
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 30, 2015, 06:59:55 PM
Ok guys! Same-levels "classic" and with entire path are in the place!

Download the branch "same-levels-path (https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip) to test it (bin not updated for the moment; MLVFS "bug" not solved and maybe never and only prevent this)

Let me know if everything works well with these same-levels options 8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dmilligan on November 30, 2015, 07:29:31 PM
DNGs in an MLVFS mount have to be read only (because they are being created on the fly by MLVFS). Any other file types (except .wav) you can read, create, and write in the mount, because it simply passes through to the "MLD" directory.

I have used Lr successfully with MLVFS (though not the dual ISO plugin). I believe there is a setting in Lr where you can prevent it from writing metadata/develop settings into to DNGs, you can use sidecars (.xmp) or have the metadata stored in the Lr catalog itself (I successfully used this plugin of mine with MLVFS: https://github.com/davidmilligan/LrDeflick).

If you want to convert dual ISO from an MLVFS mount, you will have to convert them to somewhere outside the MLVFS mount. (BTW: MLVFS already has dual ISO processing built in, so I don't see much need for this capability, or any reason for you to bother about implementing it, unless you just want to).
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on November 30, 2015, 10:05:57 PM
@dmilligan Thanks for your great informations! It's what I thought, read only and only for specific file.

Personally, I doesn't use MLV files so I don't need it. And your great tool already have this option, so I'll find the best way to prevent user in MLVFS content.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Arun on December 11, 2015, 04:23:08 PM
Hi,

I am new here and have been trying to get cr2hdr working on my Mac (OS X El Capitan). I've been able to get the .app to work by locating it in a subfolder of /usr/local/bin together with dcraw (which I compiled using the Xcode c compiler) and exiftool. My problem is, although I clearly have dcraw and exiftool installed, the Lightroom plugin cannot find them while the command line app can. There must be something obvious I am missing in setting the path or where the plugin is located. Would appreciate any help experienced folks here can provide. The command line app is clearly enough to keep me going, so the plugin is a matter of convenience and efficiency.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 11, 2015, 05:08:46 PM
You are probably using an old version of the plugin. The latest uses dcraw and exiftool that are bundled inside of the plugin. This change was necessary because El Capitan blocks apps from using binaries located in /usr/local/bin though they continue to work fine from the command line.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Arun on December 11, 2015, 06:51:24 PM
@dfort, thanks for the tip; I downloaded the version at the beginning of this thread. The latest version is 3.0 beta 3.3, correct?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on December 11, 2015, 07:01:25 PM
Yep.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 11, 2015, 07:29:25 PM
@Arun

I see you have some compiling (and maybe coding?) skills so you might want to check into kichetof's latest:

https://bitbucket.org/kichetof/lr_cr2hdr/

kichetof is doing some great stuff on it lately.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 11, 2015, 08:03:16 PM
For the latest stuff, download this version (https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip)

I need some feedback to release the version :) please review this version and we will have a Christmas gift :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: starbase64 on December 11, 2015, 08:20:35 PM
@kichetof

i'm use this without problems, all fine here.
Title: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on December 12, 2015, 12:30:54 AM
Thanks @kichetof for Beta4 and here are the test reports:

I noticed the W/B Line has the last option outside of the window template almost unreachable (check 3rd attachment).

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F747%2F23684781655_623af6f51e_n.jpg&hash=8306aeb8d79aa09cb3521bc44cf8cebb) (https://flic.kr/p/C5WGqp) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F629%2F23576234222_af51fb2721_n.jpg&hash=c912abcdffaf55b48208cb71905019b8) (https://flic.kr/p/BVmn3W)
 (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5633%2F23316833479_129dd69c7c_n.jpg&hash=a4274584cc42c46389129fc8a4d662b0) (https://flic.kr/p/BwqSfk) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5671%2F23057794593_a4166f21d2_n.jpg&hash=b3a3a520897f4ff0bb83e3284a51be77) (https://flic.kr/p/B8xe1D)

I also will report back later after testing some more on Time-lapse Dual-ISO CR2's with your new Flicker Handling feature.

Thanks for the early Christmas Gift and yet more to come!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 12, 2015, 02:19:37 AM
Looks like the new wb=dcraw option is the one going off the screen. The White Balance options should be split into two lines. Should be an easy fix.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 12, 2015, 10:05:28 AM
Thanks for the feedback! I'll fix the white balance out of screen ;)

Please try same-levels on some files and on the entire path, after that, new release :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 12, 2015, 04:58:24 PM
Sent you a fix for the wb options via a pull request. That way you can concentrate on the hard parts

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F747%2F23590693372_12ff2b7281.jpg&hash=6f5e0774ff34517193912500b2fdefc1)

Please try same-levels on some files and on the entire path, after that, new release :)

First I'll need to create some dng's with the flickery issue.

The README.md included in the zip file doesn't include any information about the same-levels feature. The tool tips are quite detailed but there may be some confusion because "same-levels" and "same-levels on entire path" have the same description. I take it that the first only affects selected images and the second processes all the images that are in the directory even if just one image is selected? If so a GUI issue might be that the name of the export window is "Export One File" if only one image is selected. Then again if all of the images need to be selected then maybe I'm not understanding the difference between "same-levels" and "same-levels on entire path".

no-same-levels
Don't Adjust output white levels to keep the same overall exposure

same-levels
Adjust output white levels to keep the same overall exposure
for all frames passed in a single command line
(useful to avoid flicker - for video or panoramas)

same-levels on entire path
Adjust output white levels to keep the same overall exposure
for all frames passed in a single command line
(useful to avoid flicker - for video or panoramas)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 12, 2015, 05:59:45 PM
Sent you a fix for the wb options via a pull request. That way you can concentrate on the hard parts

Thanks Daniel and already merged! :)

The README.md included in the zip file doesn't include any information about the same-levels feature. The tool tips are quite detailed but there may be some confusion because "same-levels" and "same-levels on entire path" have the same description. I take it that the first only affects selected images and the second processes all the images that are in the directory even if just one image is selected? If so a GUI issue might be that the name of the export window is "Export One File" if only one image is selected. Then again if all of the images need to be selected then maybe I'm not understanding the difference between "same-levels" and "same-levels on entire path".

That's normal, I need to explain this on the readme but waiting for feedback.
Concretely, no change for final result: all pictures are converted with --same-levels

But, the real changes is the command line to execute cr2hdr:

Practically, select:

The last option is only useful for big sequences only took with Dual ISO, like movie or timelapse or giga pano.

I'll not update tooltip text because nothing changes with cr2hdr exec, only the way to pass picture to it. But I'll explain it on the readme.

So, if your folder contain pictures took classically and Dual ISO, don't use same-levels on entire path but only same-levels on specific selected files.
I hope that my explanations are understandable, if not maybe after a good beer, it will be more readable 8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 12, 2015, 11:01:16 PM
  • one with all specific paths --> limited to a maximum of chars --> maybe can't convert all pictures
  • second send all pictures with a wild card --> command line smaller --> no restriction

I suppose the test would be to break "same-levels" then see if the same process breaks "same-levels on entire path"? I shot some test footage and it is chomping away on 2,025 dual iso dng files using the "same-levels" option without any complaints. At what point would you expect it to break? Does it depend on system memory?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 12, 2015, 11:15:57 PM
Thanks for the test!
Windows command prompt breaks at 8192 chars and Mac I don't know (bug especially confirmed on Windows).

So same-levels option should works on entire path but, to catch the bug, I added this option to parse the path with wild card instead of all paths.

This option is useful when you have 100% Dual ISO into the folder, if not use classic approach.

I just need some feedback from you to confirm that option works like a charm (works great on Mac and Windows for me)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 13, 2015, 12:55:27 AM
Ah ha! Got these error messages with the "same-levels" option:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5808%2F23624500821_e484d425ed.jpg&hash=4887ab4e04e5422d292059e26ad8b41f)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F735%2F23680973836_697326e118.jpg&hash=c57aa9b97f611db2a4516ff99aabce90)

Don't know how many characters the command prompt was but it got through processing all 2,025 files but the *dualiso.DNG files didn't import into Lightroom. Running "Library>Sychronize Folder..." brings in the processed dual iso files into Lightroom and they appear fine.

Running another test using a similar shot with the "same-levels on entire path" option to see if that brings up an error. BTW--I'm rebooting between tests.

[EDIT:]
Well the second test didn't go very far before the same errors came up. This time the error messages appeared before any files got processed. In fact on my second attempt it looks like some temp files were left over:

Code: [Select]
M12-1210_frame_000000-dualiso.dng
M12-1210_frame_000000-dualiso-2.dng
M12-1210_frame_000000-dualiso-3.dng

[EDIT 2:]

Oh yeah, the contents of the .TXT file. The previous run created on .TXT file for the whole batch and there were no errors reported. Maybe there's something wrong with these files? I made a copies of everything so I'll attempt to re-run the same files that sort of worked the first time.

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 8b9190b on 2015-11-14 16:44:35 UTC by a1ex:
cr2hdr: identify camera model from string (should fix issue #2403 ...

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)
--same-levels   : Adjust output white levels to keep the same overall exposure
                  for all frames passed in a single command line
                  (useful to avoid flicker - for video or panoramas)

Input file      : /Users/Fort/Desktop/100CANON/M12-1210/*.CR2
**WARNING** Could not identify the camera from EXIF. Assuming 5D Mark III.
Camera          : Canon EOS 5D Mark III
dcraw could not open this file

Input file      : /Users/Fort/Desktop/100CANON/M12-1210/*.DNG
**WARNING** Could not identify the camera from EXIF. Assuming 5D Mark III.
Camera          : Canon EOS 5D Mark III
dcraw could not open this file

[EDIT 3:]

Nope--tried it on the same files that worked before and it is consistent, "same-levels on entire path" will always bring up the error before the first file finishes processing while "same-levels" will process the files. I'll just let it run to see if the same errors come up after all the files are processed--it takes several hours to get through all those files on the little MacBook Air I'm using for these tests.

[EDIT 4:]

Might as well keep editing this post while the Europeans are sleeping--Yet another run finished and the results are repeatable over here. "same-levels" will process the files but end with the error messages and the processed files will not be automatically added to the LR catalog. "same-levels on entire path" will throw the same error message before the first file finishes processing.

Next test, just for the heck of it--run a batch with the "no-same-levels" option. Maybe this doesn't have to do with the option but about processing so many files at once?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 13, 2015, 10:56:17 AM
So cool @dfort 8) thanks for all!

Could you clean up the folder with -dualiso.dng and -dualiso-x.dng and run it again with Console open filtered by MLDualISO and paste result here to confirm some things.

Many thanks for all!

[EDIT]

I added some comments to help to find where error come from! Update your plugin with https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip but try on a little batch (10-20 pictures because a lot of log)

Some times when I implemented the new same-levels way I had some errors because folder wasn't cleaned before running (file converted (exist on folder) but not into Lr catalog).

Don't forget to have Console.app filtered open before running plugin
I hope that's only a ghost file error
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 13, 2015, 04:55:57 PM
Will do but first I'd like to report on the test that I started last night--running a batch of 2,687 dual iso dng frames, 1280x720, 1.6 MB each frame.

I started the process with the "no-same-levels" yesterday at 9:18 PM and when I got up this morning to check on the progress it was still churning away without any problems though it was only on frame 470 at 6:37 AM.

Here's the system I'm using:

Code: [Select]
OS-X 10.11.1
Model Name: MacBook Air
Model Identifier: MacBookAir6,1
Processor Name: Intel Core i5
Processor Speed: 1.4 GHz
Number of Processors: 1
Total Number of Cores: 2
L2 Cache (per Core): 256 KB
L3 Cache: 3 MB
Memory: 4 GB

I've also got another system with a faster processor and more memory but not all users have the latest and most powerful systems so this MacBook Air seems like a good test bed.

Ok--here's the latest test. With the new build, 10 frames selected, "same-levels" option. Note that the "same-levels on entire path" was not available when selecting only a few frames. Also, the export progress window didn't come up this time but dng files were processed, the error warnings came up and the processed dng files were not imported into the catalog.

Console output:

Code: [Select]
12/13/15 7:22:25.854 AM Adobe Lightroom[13828]: MLDualISO DEBUG path /Users/Fort/Desktop/3rd_run/M12-1213
12/13/15 7:22:56.790 AM Adobe Lightroom[13828]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
12/13/15 7:22:57.188 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.dng
12/13/15 7:22:57.188 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.DNG
12/13/15 7:22:57.188 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.TXT
12/13/15 7:22:57.188 AM Adobe Lightroom[13828]: MLDualISO DEBUG first: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso
12/13/15 7:22:57.205 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.dng
12/13/15 7:22:57.205 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.DNG
12/13/15 7:22:57.205 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.TXT
12/13/15 7:22:57.232 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.dng
12/13/15 7:22:57.232 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.DNG
12/13/15 7:22:57.232 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.TXT
12/13/15 7:22:57.247 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.dng
12/13/15 7:22:57.247 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.DNG
12/13/15 7:22:57.247 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.TXT
12/13/15 7:22:57.267 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.dng
12/13/15 7:22:57.267 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.DNG
12/13/15 7:22:57.268 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.TXT
12/13/15 7:22:57.283 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.dng
12/13/15 7:22:57.283 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.DNG
12/13/15 7:22:57.283 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.TXT
12/13/15 7:22:57.303 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.dng
12/13/15 7:22:57.303 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.DNG
12/13/15 7:22:57.303 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.TXT
12/13/15 7:22:57.319 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.dng
12/13/15 7:22:57.319 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.DNG
12/13/15 7:22:57.319 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.TXT
12/13/15 7:22:57.343 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.dng
12/13/15 7:22:57.343 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.DNG
12/13/15 7:22:57.344 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.TXT
12/13/15 7:22:57.362 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.dng
12/13/15 7:22:57.362 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.DNG
12/13/15 7:22:57.362 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.TXT
12/13/15 7:22:57.365 AM Adobe Lightroom[13828]: MLDualISO DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels
12/13/15 7:22:57.365 AM Adobe Lightroom[13828]: MLDualISO DEBUG command : export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":${PATH} && exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.dng" "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.dng" > "/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso-M12-1213_frame_000009.TXT"
12/13/15 7:23:16.566 AM Adobe Lightroom[13828]: MLDualISO DEBUG command status OK
12/13/15 7:23:16.572 AM Adobe Lightroom[13828]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000.dng
12/13/15 7:23:16.572 AM Adobe Lightroom[13828]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000.DNG
12/13/15 7:23:16.576 AM Adobe Lightroom[13828]: MLDualISO DEBUG newOriginalFilePath: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso-2.dng
12/13/15 7:23:16.582 AM Adobe Lightroom[13828]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso-2.dng
12/13/15 7:23:16.583 AM Adobe Lightroom[13828]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso-2.dng

[continued on next post because of the per post characters limit]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 13, 2015, 04:58:04 PM
[continued...]

Contents of M12-1213_frame_000000-dualiso-M12-1213_frame_000009.TXT

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 8b9190b on 2015-11-14 16:44:35 UTC by a1ex:
cr2hdr: identify camera model from string (should fix issue #2403 ...

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)
--same-levels   : Adjust output white levels to keep the same overall exposure
                  for all frames passed in a single command line
                  (useful to avoid flicker - for video or panoramas)

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : dBBd RGGB
White levels    : 10534 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 5.22 EV (3737)
Black delta     : 71.94
Dynamic range   : 10.05 (+) 10.65 => 15.87 EV (in theory)
AMaZE interpolation ...
Amaze took 0.17 s
Edge-directed interpolation...
Semi-overexposed: 98.89%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.05 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (gray max)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : dBBd RGGB
White levels    : 10476 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 4.45 EV (2180)
Black delta     : -75.09
Dynamic range   : 10.04 (+) 10.65 => 15.09 EV (in theory)
AMaZE interpolation ...
Amaze took 0.11 s
Edge-directed interpolation...
Semi-overexposed: 99.14%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.04 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : dBBd RGGB
White levels    : 10483 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 5.67 EV (5077)
Black delta     : 120.37
Dynamic range   : 10.04 (+) 10.65 => 16.31 EV (in theory)
AMaZE interpolation ...
Amaze took 0.11 s
Edge-directed interpolation...
Semi-overexposed: 99.02%
Deep shadows    : 0.04%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.04 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : BBdd RGGB
White levels    : 10765 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 4.43 EV (2150)
Black delta     : -80.11
Dynamic range   : 10.09 (+) 10.65 => 15.07 EV (in theory)
AMaZE interpolation ...
Amaze took 0.11 s
Edge-directed interpolation...
Semi-overexposed: 98.65%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.09 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : BBdd RGGB
White levels    : 10753 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 4.49 EV (2247)
Black delta     : -69.41
Dynamic range   : 10.09 (+) 10.65 => 15.14 EV (in theory)
AMaZE interpolation ...
Amaze took 0.10 s
Edge-directed interpolation...
Semi-overexposed: 98.80%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.09 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : BddB RGGB
White levels    : 10408 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 4.53 EV (2313)
Black delta     : -47.60
Dynamic range   : 10.03 (+) 10.65 => 15.18 EV (in theory)
AMaZE interpolation ...
Amaze took 0.12 s
Edge-directed interpolation...
Semi-overexposed: 99.21%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.03 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : BddB RGGB
White levels    : 10555 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 4.71 EV (2610)
Black delta     : -13.16
Dynamic range   : 10.05 (+) 10.65 => 15.35 EV (in theory)
AMaZE interpolation ...
Amaze took 0.10 s
Edge-directed interpolation...
Semi-overexposed: 99.07%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.05 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : ddBB RGGB
White levels    : 10488 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 4.54 EV (2330)
Black delta     : -44.87
Dynamic range   : 10.04 (+) 10.65 => 15.19 EV (in theory)
AMaZE interpolation ...
Amaze took 0.10 s
Edge-directed interpolation...
Semi-overexposed: 99.00%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.04 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : ddBB RGGB
White levels    : 10572 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 3.88 EV (1472)
Black delta     : -225.30
Dynamic range   : 10.06 (+) 10.65 => 14.53 EV (in theory)
AMaZE interpolation ...
Amaze took 0.11 s
Edge-directed interpolation...
Semi-overexposed: 98.66%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.2 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.06 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.dn6

Input file      : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.dng
Camera          : Canon EOS M
Full size       : 1280 x 720
Active area     : 1280 x 720
Black borders   : N/A
ISO pattern     : dBBd RGGB
White levels    : 10767 14882
Noise levels    : 8.00 8.00 8.00 8.00 (14-bit)
ISO difference  : 4.36 EV (2051)
Black delta     : -91.73
Dynamic range   : 10.09 (+) 10.65 => 15.01 EV (in theory)
AMaZE interpolation ...
Amaze took 0.11 s
Edge-directed interpolation...
Semi-overexposed: 98.51%
Deep shadows    : 0.00%
Horizontal stripe fix...
Full-res reconstruction...
ISO overlap     : 3.0 EV (approx)
Half-res blending...
Chroma smoothing...
Building alias map...
Filtering alias map...
Smoothing alias map...
Final blending...
Noise level     : 8.00 (20-bit), ideally 8.00
Dynamic range   : 16.09 EV (cooked)
AsShotNeutral   : 0.42 1 0.58, 5358K/g=0.79 (custom)
Output file     : /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.DNG
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.DNG: copying EXIF from /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.dn6

Equalizing levels...
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000001-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000002-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000003-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000004-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000005-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000006-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000007-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000008-dualiso.DNG: 8192 ... 43012
/Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000009-dualiso.DNG: 8192 ... 43012

This time it looks like there was a partially processed "M12-1213_frame_000000-dualiso-2.dng" that had the same timestamp as the original. I ran a second test with the same results, the first frame always ended up with a "*dualiso-2.dng" that had the same timestamp as the original dng.

I also thought it would be interesting to run a test with the "same-levels on entire path" option so I put 10 files in a separate directory and got these results in the console:

Code: [Select]
12/13/15 7:45:24.956 AM Adobe Lightroom[13828]: MLDualISO DEBUG path /Users/Fort/Desktop/3rd_run/M12-1210_subset
12/13/15 7:45:31.415 AM Adobe Lightroom[13828]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
12/13/15 7:45:31.868 AM Adobe Lightroom[13828]: MLDualISO DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels
12/13/15 7:45:31.868 AM Adobe Lightroom[13828]: MLDualISO DEBUG command : export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":${PATH} && exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/Fort/Desktop/3rd_run/M12-1210_subset/"*.CR2 "/Users/Fort/Desktop/3rd_run/M12-1210_subset/"*.DNG > "/Users/Fort/Desktop/3rd_run/M12-1210_subset/M12-1210_subset.TXT"
12/13/15 7:45:32.285 AM Adobe Lightroom[13828]: MLDualISO DEBUG command status OK
12/13/15 7:45:32.288 AM Adobe Lightroom[13828]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1210_subset/M12-1210_frame_000000.dng
12/13/15 7:45:32.288 AM Adobe Lightroom[13828]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1210_subset/M12-1210_frame_000000.DNG
12/13/15 7:45:32.545 AM Adobe Lightroom[13828]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1210_subset/M12-1210_frame_000000-dualiso.dng
12/13/15 7:45:32.545 AM Adobe Lightroom[13828]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1210_subset/M12-1210_frame_000000-dualiso.dng

[continued next post...]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 13, 2015, 05:07:40 PM
[continued...]

Contents of "M12-1210_subset.TXT" from the "same-levels on entire path" option.

Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 8b9190b on 2015-11-14 16:44:35 UTC by a1ex:
cr2hdr: identify camera model from string (should fix issue #2403 ...

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--no-bad-pix    : disable bad pixel fixing (try it if you shoot stars)
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)
--same-levels   : Adjust output white levels to keep the same overall exposure
                  for all frames passed in a single command line
                  (useful to avoid flicker - for video or panoramas)

Input file      : /Users/Fort/Desktop/3rd_run/M12-1210_subset/*.CR2
**WARNING** Could not identify the camera from EXIF. Assuming 5D Mark III.
Camera          : Canon EOS 5D Mark III
dcraw could not open this file

Input file      : /Users/Fort/Desktop/3rd_run/M12-1210_subset/*.DNG
**WARNING** Could not identify the camera from EXIF. Assuming 5D Mark III.
Camera          : Canon EOS 5D Mark III
dcraw could not open this file

End of test -- whew!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on December 13, 2015, 06:27:50 PM
Lovely work done as always, @dfort!  :P

Now I just downloaded the beta from today (Thanks @kitchetof) and seems to be that I am running into the same hiccups as @dfort reported earlier.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F691%2F23699206786_efb07c1119_n.jpg&hash=25e94e33b1f851a9143581cbcab2cf4b) (https://flic.kr/p/C7dCvy) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F607%2F23725279255_44daac352e_n.jpg&hash=50683b7e78a868f0406c3c24d8b53ecb) (https://flic.kr/p/C9wfWT)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5623%2F23357343659_eec88db7f1_n.jpg&hash=27728da42e6aca3c3c8a5631b09ce57e) (https://flic.kr/p/BA1uvH)(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5720%2F23642750301_a75c7eed65_n.jpg&hash=9116a5c3b19280596ff57c4f572b8fdc) (https://flic.kr/p/C2egXT)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5801%2F23725279245_656c33f120_n.jpg&hash=a82cd9b4ca0a3b318a229ecdc5b8127a) (https://flic.kr/p/C9wfWH)

Couldn't even open the converted DNG in PS either.

 (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F755%2F23616789552_8a7caa9874_n.jpg&hash=5a6a64c081a715d8f220ba4c58d304ef) (https://flic.kr/p/BYWdJL)

Maybe this is all because I haven't had my "coffee" yet this morning although I don't drink it. Much. If ever!

Perhaps should I go back to the previous beta4?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 13, 2015, 06:45:13 PM
Thanks @dfort and @ DeafEyeJedi !

What I see on the console log, is certainly a filename bug into the plugin.

Before export (MLProcess.lua:506)
Code: [Select]
12/13/15 7:22:57.188 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.dng
12/13/15 7:22:57.188 AM Adobe Lightroom[13828]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000-dualiso.DNG

After conversion (MLProcess.lua:596)
Code: [Select]
12/13/15 7:23:16.572 AM Adobe Lightroom[13828]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000.dng
12/13/15 7:23:16.572 AM Adobe Lightroom[13828]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1213/M12-1213_frame_000000.DNG

As you can see, path before update isn't the same that after.
I need to check why this bug appear.

Do you use DNG file ? (I only check with CR2)

----------------------------------------------------------------------

Okay.. I think that I know why it appear and need to reproduce the bug to solve it (MLProcess.lua:494 and MLProcess.lua:598 same test... need it ? I'll try to solve it quickly!)


[EDIT] Could you try to copy some DNG files, and run export with the plugin and uncheck "keep DNG file after conversion" and let me know!

[EDIT] I see clearer now! same-levels pass iterator to copy file if you choose to keep DNG after conversion, but same-levels on entire path doesn't go into iterator to copy them.
I do that because before, I didn't disable on entire folder if all picture wasn't selected, but now, I can enable it!

Let's go to play! :)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 13, 2015, 07:01:46 PM
Do you use DNG file ? (I only check with CR2)

Yes and looking at the messages for the "same-levels on entire path" option it looks like you're only checking for *.DNG (uppercase) and the dng files I'm using were shot as MLV and converted to dng using mlv_dump which creates files with a *.dng (lowercase) file extension.

[EDIT] Could you try to copy some DNG files, and run export with the plugin and uncheck "keep DNG file after conversion" and let me know!

That is how I have been running them--using the default settings except for the "same-levels" option.

[EDIT] Oops--see you want me to run it the other way. Will do and report back.

Couldn't even open the converted DNG in PS either.

Strange, the ones here open fine. Isn't your PS opening ACR first? Have you tried importing the converted files into Lightroom?

Instead of a coffee may I suggest a type of beer called a coffee porter? Coffee is a stimulant. Beer is a depressant. But put them together, and you get MAGIC!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 13, 2015, 07:08:08 PM
Okay.. I see the problem, now I need to solve it and I hope it's done with my fix
https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip

Hope 8) Let me know!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 13, 2015, 07:14:01 PM
[EDIT] Could you try to copy some DNG files, and run export with the plugin and uncheck "keep DNG file after conversion" and let me know!

That worked for the set-levels option. Didn't try it with the "entire path" option.

Console output:
Code: [Select]
12/13/15 10:06:13.111 AM Adobe Lightroom[14134]: MLDualISO DEBUG path /Users/Fort/Desktop/3rd_run/M12-1208
12/13/15 10:06:39.712 AM Adobe Lightroom[14134]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
12/13/15 10:06:40.077 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000.dng
12/13/15 10:06:40.077 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000.DNG
12/13/15 10:06:40.077 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000.TXT
12/13/15 10:06:40.077 AM Adobe Lightroom[14134]: MLDualISO DEBUG first: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000
12/13/15 10:06:40.084 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001.dng
12/13/15 10:06:40.084 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001.DNG
12/13/15 10:06:40.084 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001.TXT
12/13/15 10:06:40.089 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002.dng
12/13/15 10:06:40.089 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002.DNG
12/13/15 10:06:40.089 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002.TXT
12/13/15 10:06:40.094 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003.dng
12/13/15 10:06:40.094 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003.DNG
12/13/15 10:06:40.094 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003.TXT
12/13/15 10:06:40.099 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004.dng
12/13/15 10:06:40.099 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004.DNG
12/13/15 10:06:40.099 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004.TXT
12/13/15 10:06:40.104 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005.dng
12/13/15 10:06:40.104 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005.DNG
12/13/15 10:06:40.104 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005.TXT
12/13/15 10:06:40.111 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006.dng
12/13/15 10:06:40.111 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006.DNG
12/13/15 10:06:40.111 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006.TXT
12/13/15 10:06:40.115 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007.dng
12/13/15 10:06:40.115 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007.DNG
12/13/15 10:06:40.115 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007.TXT
12/13/15 10:06:40.120 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008.dng
12/13/15 10:06:40.120 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008.DNG
12/13/15 10:06:40.120 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008.TXT
12/13/15 10:06:40.125 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009.dng
12/13/15 10:06:40.125 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009.DNG
12/13/15 10:06:40.125 AM Adobe Lightroom[14134]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009.TXT
12/13/15 10:06:40.126 AM Adobe Lightroom[14134]: MLDualISO DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels
12/13/15 10:06:40.127 AM Adobe Lightroom[14134]: MLDualISO DEBUG command : export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":${PATH} && exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008.dng" "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009.dng" > "/Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000-M12-1208_frame_000009.TXT"
12/13/15 10:06:42.007 AM Adobe Lightroom[14134]: MLDualISO DEBUG command status OK
12/13/15 10:06:42.008 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000.dng
12/13/15 10:06:42.008 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000.DNG
12/13/15 10:06:42.009 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000.dng
12/13/15 10:06:42.012 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000000-dualiso.DNG
12/13/15 10:06:42.827 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001.dng
12/13/15 10:06:42.827 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001.DNG
12/13/15 10:06:42.843 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001.dng
12/13/15 10:06:42.846 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000001-dualiso.DNG
12/13/15 10:06:43.285 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002.dng
12/13/15 10:06:43.285 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002.DNG
12/13/15 10:06:43.286 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002.dng
12/13/15 10:06:43.288 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000002-dualiso.DNG
12/13/15 10:06:43.682 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003.dng
12/13/15 10:06:43.682 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003.DNG
12/13/15 10:06:43.683 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003.dng
12/13/15 10:06:43.685 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000003-dualiso.DNG
12/13/15 10:06:44.159 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004.dng
12/13/15 10:06:44.159 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004.DNG
12/13/15 10:06:44.160 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004.dng
12/13/15 10:06:44.164 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000004-dualiso.DNG
12/13/15 10:06:44.684 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005.dng
12/13/15 10:06:44.684 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005.DNG
12/13/15 10:06:44.685 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005.dng
12/13/15 10:06:44.688 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000005-dualiso.DNG
12/13/15 10:06:45.402 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006.dng
12/13/15 10:06:45.402 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006.DNG
12/13/15 10:06:45.416 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006.dng
12/13/15 10:06:45.436 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000006-dualiso.DNG
12/13/15 10:06:45.980 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007.dng
12/13/15 10:06:45.981 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007.DNG
12/13/15 10:06:45.982 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007.dng
12/13/15 10:06:45.984 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000007-dualiso.DNG
12/13/15 10:06:46.391 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008.dng
12/13/15 10:06:46.391 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008.DNG
12/13/15 10:06:46.391 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008.dng
12/13/15 10:06:46.394 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000008-dualiso.DNG
12/13/15 10:06:46.802 AM Adobe Lightroom[14134]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009.dng
12/13/15 10:06:46.802 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009.DNG
12/13/15 10:06:46.803 AM Adobe Lightroom[14134]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009.dng
12/13/15 10:06:46.805 AM Adobe Lightroom[14134]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/3rd_run/M12-1208/M12-1208_frame_000009-dualiso.DNG
12/13/15 10:06:47.296 AM Adobe Lightroom[14134]: MLDualISO DEBUG success: 10 - nodual: 0 - dual: 0 - format: 0 - fail: 0 - errorMsg: 0

I didn't include the messages from the .TXT file because there were no errors on it and it would have made this post too large.

[EDIT] This was using the previous build. I see you made a fix as I was writing this post.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 13, 2015, 08:15:22 PM
Using the new build--Selecting 10 frames and using the set-levels options and keeping the original still doesn't work--same error messages pop up. Not keeping the original dng does continue to work.

Console output:

Code: [Select]
12/13/15 11:13:11.241 AM Adobe Lightroom[14259]: MLDualISO DEBUG path /Users/Fort/Desktop/4th_run/M12-1210
12/13/15 11:13:22.063 AM Adobe Lightroom[14259]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
12/13/15 11:13:23.331 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso.dng
12/13/15 11:13:23.331 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso.DNG
12/13/15 11:13:23.331 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso.TXT
12/13/15 11:13:23.331 AM Adobe Lightroom[14259]: MLDualISO DEBUG first: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso
12/13/15 11:13:23.362 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000066-dualiso.dng
12/13/15 11:13:23.362 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000066-dualiso.DNG
12/13/15 11:13:23.362 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000066-dualiso.TXT
12/13/15 11:13:23.377 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000067-dualiso.dng
12/13/15 11:13:23.377 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000067-dualiso.DNG
12/13/15 11:13:23.377 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000067-dualiso.TXT
12/13/15 11:13:23.393 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000068-dualiso.dng
12/13/15 11:13:23.393 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000068-dualiso.DNG
12/13/15 11:13:23.393 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000068-dualiso.TXT
12/13/15 11:13:23.418 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000069-dualiso.dng
12/13/15 11:13:23.418 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000069-dualiso.DNG
12/13/15 11:13:23.418 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000069-dualiso.TXT
12/13/15 11:13:23.446 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000070-dualiso.dng
12/13/15 11:13:23.446 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000070-dualiso.DNG
12/13/15 11:13:23.446 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000070-dualiso.TXT
12/13/15 11:13:23.472 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000071-dualiso.dng
12/13/15 11:13:23.472 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000071-dualiso.DNG
12/13/15 11:13:23.472 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000071-dualiso.TXT
12/13/15 11:13:23.501 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000072-dualiso.dng
12/13/15 11:13:23.502 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000072-dualiso.DNG
12/13/15 11:13:23.502 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000072-dualiso.TXT
12/13/15 11:13:23.535 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000073-dualiso.dng
12/13/15 11:13:23.535 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000073-dualiso.DNG
12/13/15 11:13:23.535 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000073-dualiso.TXT
12/13/15 11:13:23.553 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000074-dualiso.dng
12/13/15 11:13:23.553 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000074-dualiso.DNG
12/13/15 11:13:23.553 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000074-dualiso.TXT
12/13/15 11:13:23.556 AM Adobe Lightroom[14259]: MLDualISO DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels
12/13/15 11:13:23.556 AM Adobe Lightroom[14259]: MLDualISO DEBUG command : export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":${PATH} && exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000066-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000067-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000068-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000069-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000070-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000071-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000072-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000073-dualiso.dng" "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000074-dualiso.dng" > "/Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso-M12-1210_frame_000074.TXT"
12/13/15 11:13:50.169 AM Adobe Lightroom[14259]: MLDualISO DEBUG command status OK
12/13/15 11:13:50.171 AM Adobe Lightroom[14259]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065.dng
12/13/15 11:13:50.171 AM Adobe Lightroom[14259]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065.DNG
12/13/15 11:13:50.175 AM Adobe Lightroom[14259]: MLDualISO DEBUG newOriginalFilePath: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso-2.dng
12/13/15 11:13:50.175 AM Adobe Lightroom[14259]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/4th_run/M12-1210/M12-1210_frame_000065-dualiso-2.dng

New errors seem to be happening with the "entire path" option. Now there is a *dualiso* file for each dng but they are all the same size and have the same timestamp as the original. In addition no .TXT file is created. Here is the console output:

Code: [Select]
12/13/15 11:09:28.055 AM Adobe Lightroom[14259]: MLDualISO DEBUG path /Users/Fort/Desktop/4th_run/M12-1210_subset
12/13/15 11:09:40.312 AM Adobe Lightroom[14259]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
12/13/15 11:09:40.757 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000000-dualiso.dng
12/13/15 11:09:40.757 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000000-dualiso.DNG
12/13/15 11:09:40.757 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000000-dualiso.TXT
12/13/15 11:09:40.758 AM Adobe Lightroom[14259]: MLDualISO DEBUG first: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000000-dualiso
12/13/15 11:09:40.769 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000001-dualiso.dng
12/13/15 11:09:40.769 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000001-dualiso.DNG
12/13/15 11:09:40.769 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000001-dualiso.TXT
12/13/15 11:09:40.783 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000002-dualiso.dng
12/13/15 11:09:40.784 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000002-dualiso.DNG
12/13/15 11:09:40.784 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000002-dualiso.TXT
12/13/15 11:09:40.798 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000003-dualiso.dng
12/13/15 11:09:40.798 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000003-dualiso.DNG
12/13/15 11:09:40.798 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000003-dualiso.TXT
12/13/15 11:09:40.813 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000004-dualiso.dng
12/13/15 11:09:40.813 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000004-dualiso.DNG
12/13/15 11:09:40.814 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000004-dualiso.TXT
12/13/15 11:09:40.867 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000005-dualiso.dng
12/13/15 11:09:40.867 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000005-dualiso.DNG
12/13/15 11:09:40.867 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000005-dualiso.TXT
12/13/15 11:09:40.886 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000006-dualiso.dng
12/13/15 11:09:40.886 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000006-dualiso.DNG
12/13/15 11:09:40.886 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000006-dualiso.TXT
12/13/15 11:09:40.900 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000007-dualiso.dng
12/13/15 11:09:40.900 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000007-dualiso.DNG
12/13/15 11:09:40.901 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000007-dualiso.TXT
12/13/15 11:09:40.915 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000008-dualiso.dng
12/13/15 11:09:40.915 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000008-dualiso.DNG
12/13/15 11:09:40.915 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000008-dualiso.TXT
12/13/15 11:09:40.934 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000009-dualiso.dng
12/13/15 11:09:40.934 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000009-dualiso.DNG
12/13/15 11:09:40.934 AM Adobe Lightroom[14259]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/4th_run/M12-1210_subset/M12-1210_frame_000009-dualiso.TXT
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 13, 2015, 10:19:52 PM
Thanks for all informations!
Bug identified and now I need to test it with some DNG to fix it! I'll try to fix it tomorrow 8)

@All don't use last same-levels on entire path link! Please wait for a fix!

@dfort and other testers, please could you try this version https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip this should fix --same-levels option but maybe not on entire folder
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 14, 2015, 03:44:07 AM
Tried that latest build and I'm still getting the same errors as before.

Strange thing is if "keep original dng" is not checked it will work but the LR library will show a copy of the shot without any cr2hdr processing and with the delete flag enabled. This isn't right.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5743%2F23735283375_73b2f21921.jpg&hash=ad9392a9faac527cc80aef6b845305f6)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 14, 2015, 07:14:42 AM
Thanks for trying! I'll try to solve it today!

Keep DNG files after conversion, is ambiguous. This option is useful only when you process DNG files with same input and output file. It's more like a copy before process to keep original file.

It's not a bug (Lr or cr2hdr), that the way how cr2hdr works:

Code: [Select]
cr2hdr img1.cr2
--> output file: img1.DNG
Code: [Select]
cr2hdr img1.dng
--> output file: img1.DNG

And for dual file with flag reject, I think that I know the problem: importing file to Lr... But it's the same!

I need to improve DNG workflow (I don't use it a lot, that's the reason)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 14, 2015, 03:58:00 PM
Normally fixed!

https://bitbucket.org/kichetof/lr_cr2hdr/get/same-levels-path.zip

(I can't try it now, I don't have DNG on the hand, but I believe in me... 8))
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 14, 2015, 08:17:42 PM
I can't try it now either because I'm at work without my test system and DNG files.

I thought that you needed tests to see how many files it will process before breaking because the command line gets too long. (Wildcard expansion?) That's why I shot a few mlv's and converted them into DNG's--it is an easy way of creating massive amounts of dual_iso shots. From what I've been able to gather the "--same-levels" option is useful for panorama shots so maybe I should have started with a bunch of dual iso CR2 or FRSP DNG files instead?

In any case, it looks like the bugs we're chasing don't have to do with processing a boat load of files.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 14, 2015, 09:02:29 PM
No problem, I can't test before tomorrow but this time, I hope it's fixed!

You can try update with less files (10-30 is nice). Personally I don't want to know how many files you could process with "classic" same-levels instead of wild card. If you shot a lot of Dual ISO files, use same-levels on entire folder otherwise use same-levels.

It means that you need to change your workflow (movie, timelapse or gigapano on the same folder) and other pictures on an another folder.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: BestLittleStudio on December 15, 2015, 06:18:25 AM
OK I have read every single page on this thread, all 40 of them.

And no matter what I still end up with zero results.

Version 3 Beta 3. 70D, ISO 100-800, underexposing, I run the conversion via LR and I see zero results, the resulting DNG is still a mess of lines just like the original.

What step am I missing or what am I doing wrong?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 15, 2015, 06:58:12 AM
Quick test--Saving dng's
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F724%2F23133816343_34991e211d.jpg&hash=ca2c2128ea59d6843ce2e30a5df89376)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F718%2F23133816303_b8ddc453d1.jpg&hash=85b80ebf0f16dda7df75dd2a3b4c8650)

Not saving dng's
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm1.staticflickr.com%2F660%2F23734503606_4708b808c7.jpg&hash=fc75adbaed280edec24867c9648ca4dc)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm6.staticflickr.com%2F5749%2F23734503596_48d656dcaa.jpg&hash=87a3f846d4c65dc52d700598491a1055)

Neither method created any significant errors on the txt file. Here's the Console output:

Code: [Select]
12/14/15 9:29:55.562 PM Adobe Lightroom[15136]: MLDualISO DEBUG path /Users/Fort/Desktop/6th_run/M12-1210
12/14/15 9:30:05.307 PM Adobe Lightroom[15136]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
12/14/15 9:30:05.675 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010-dualiso.dng
12/14/15 9:30:05.675 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010-dualiso.DNG
12/14/15 9:30:05.675 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010-dualiso.TXT
12/14/15 9:30:05.675 PM Adobe Lightroom[15136]: MLDualISO DEBUG first: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010-dualiso
12/14/15 9:30:05.688 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000011-dualiso.dng
12/14/15 9:30:05.688 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000011-dualiso.DNG
12/14/15 9:30:05.689 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000011-dualiso.TXT
12/14/15 9:30:05.714 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000012-dualiso.dng
12/14/15 9:30:05.714 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000012-dualiso.DNG
12/14/15 9:30:05.714 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000012-dualiso.TXT
12/14/15 9:30:05.728 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000013-dualiso.dng
12/14/15 9:30:05.728 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000013-dualiso.DNG
12/14/15 9:30:05.728 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000013-dualiso.TXT
12/14/15 9:30:05.741 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000014-dualiso.dng
12/14/15 9:30:05.741 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000014-dualiso.DNG
12/14/15 9:30:05.741 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000014-dualiso.TXT
12/14/15 9:30:05.759 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000015-dualiso.dng
12/14/15 9:30:05.760 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000015-dualiso.DNG
12/14/15 9:30:05.760 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000015-dualiso.TXT
12/14/15 9:30:05.775 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000016-dualiso.dng
12/14/15 9:30:05.775 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000016-dualiso.DNG
12/14/15 9:30:05.775 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000016-dualiso.TXT
12/14/15 9:30:05.800 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000017-dualiso.dng
12/14/15 9:30:05.800 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000017-dualiso.DNG
12/14/15 9:30:05.800 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000017-dualiso.TXT
12/14/15 9:30:05.813 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000018-dualiso.dng
12/14/15 9:30:05.814 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000018-dualiso.DNG
12/14/15 9:30:05.814 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000018-dualiso.TXT
12/14/15 9:30:05.834 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000019-dualiso.dng
12/14/15 9:30:05.834 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000019-dualiso.DNG
12/14/15 9:30:05.834 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000019-dualiso.TXT
12/14/15 9:30:05.838 PM Adobe Lightroom[15136]: MLDualISO DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels
12/14/15 9:30:05.838 PM Adobe Lightroom[15136]: MLDualISO DEBUG command : export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":${PATH} && exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000011-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000012-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000013-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000014-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000015-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000016-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000017-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000018-dualiso.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000019-dualiso.dng" > "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010-dualiso-M12-1210_frame_000019.TXT"
12/14/15 9:30:26.871 PM Adobe Lightroom[15136]: MLDualISO DEBUG command status OK
12/14/15 9:30:26.872 PM Adobe Lightroom[15136]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010.dng
12/14/15 9:30:26.873 PM Adobe Lightroom[15136]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000010.DNG
12/14/15 9:31:36.398 PM Adobe Lightroom[15136]: MLDualISO DEBUG path /Users/Fort/Desktop/6th_run/M12-1210
12/14/15 9:31:44.945 PM Adobe Lightroom[15136]: MLDualISO DEBUG I'm called before exportServiceProvider.processRenderedPhotos
12/14/15 9:31:45.581 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030.dng
12/14/15 9:31:45.581 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030.DNG
12/14/15 9:31:45.581 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030.TXT
12/14/15 9:31:45.581 PM Adobe Lightroom[15136]: MLDualISO DEBUG first: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030
12/14/15 9:31:45.595 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000031.dng
12/14/15 9:31:45.595 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000031.DNG
12/14/15 9:31:45.595 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000031.TXT
12/14/15 9:31:45.602 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000032.dng
12/14/15 9:31:45.603 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000032.DNG
12/14/15 9:31:45.603 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000032.TXT
12/14/15 9:31:45.609 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000033.dng
12/14/15 9:31:45.609 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000033.DNG
12/14/15 9:31:45.609 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000033.TXT
12/14/15 9:31:45.616 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000034.dng
12/14/15 9:31:45.616 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000034.DNG
12/14/15 9:31:45.616 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000034.TXT
12/14/15 9:31:45.626 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000035.dng
12/14/15 9:31:45.626 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000035.DNG
12/14/15 9:31:45.626 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000035.TXT
12/14/15 9:31:45.635 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000036.dng
12/14/15 9:31:45.635 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000036.DNG
12/14/15 9:31:45.636 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000036.TXT
12/14/15 9:31:45.648 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000037.dng
12/14/15 9:31:45.649 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000037.DNG
12/14/15 9:31:45.649 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000037.TXT
12/14/15 9:31:45.674 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000038.dng
12/14/15 9:31:45.674 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000038.DNG
12/14/15 9:31:45.674 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000038.TXT
12/14/15 9:31:45.686 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000039.dng
12/14/15 9:31:45.686 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path DNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000039.DNG
12/14/15 9:31:45.686 PM Adobe Lightroom[15136]: MLDualISO DEBUG Path TXT: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000039.TXT
12/14/15 9:31:45.692 PM Adobe Lightroom[15136]: MLDualISO DEBUG arguments :  --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels
12/14/15 9:31:45.693 PM Adobe Lightroom[15136]: MLDualISO DEBUG command : export PATH="/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin":${PATH} && exec "/Library/Application Support/Adobe/Lightroom/Modules/cr2hdr.lrplugin/bin/cr2hdr" --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000031.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000032.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000033.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000034.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000035.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000036.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000037.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000038.dng" "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000039.dng" > "/Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030-M12-1210_frame_000039.TXT"
12/14/15 9:32:06.860 PM Adobe Lightroom[15136]: MLDualISO DEBUG command status OK
12/14/15 9:32:06.861 PM Adobe Lightroom[15136]: MLDualISO DEBUG originalFilePath: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030.dng
12/14/15 9:32:06.861 PM Adobe Lightroom[15136]: MLDualISO DEBUG finalPathDNG: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030.DNG
12/14/15 9:32:06.862 PM Adobe Lightroom[15136]: MLDualISO DEBUG import Dual ISO file: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030.dng
12/14/15 9:32:06.865 PM Adobe Lightroom[15136]: MLDualISO DEBUG finalPath: /Users/Fort/Desktop/6th_run/M12-1210/M12-1210_frame_000030-dualiso.DNG

@BestLittleStudio
The "developed" dual iso DNG should import into the library--if you are still selected on "last import" in Lightroom you probably won't see it. As you can tell from these last several posts we're doing testing on a new feature and part of the problem is that the new DNG isn't importing into Lightroom after processing. Look into the directory on your hard drive where the original DNG lives and see if there is one named *dualsio* in there. If you are still having problems post one of your one of your dual iso camera originals to some publicly available download site so we can take a crack at it.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 15, 2015, 07:23:14 AM
Thanks @dfort! I recorded a short Dual ISO movie and converted it to DNG. I'll try to catch error and optimize DNG workflow. It will be more simple with DNG file in the hands! With more hours of sleeping, maybe it will be more... Efficient  :o

@BestLittleStudio sorry to heard that! What kind of type is your original file? (CR2, DNG)
If it's DNG, be patient, I'm trying to fix the bug :) if it's CR2, don't use beta version or download previous "version"
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 15, 2015, 10:08:00 AM
Bug confirmed with DNG, with or without --same-levels ... try with only one file DNG... no success. I'm working to resolve it quickly
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 15, 2015, 04:14:17 PM
Bug with DNG partially fixed!
simple Dual ISO or same-levels works well. I've always a bug with same-levels on entire path, a bug with the command ... thanks Windows...

@Power Windows Users
Could you help me to fix command line bug ?
That's my command, who doesn't works (got it by debugging):
Quote
"start /D "C:\Users\tof\Scripts\lr_cr2hdr\cr2hdr.lrplugin\bin" /B /WAIT /BELOWNORMAL cr2hdr.exe --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "E:\Photographies LCAP\Photographies\ML\same-levels\"*-dualiso.CR2 "E:\Photographies LCAP\Photographies\ML\same-levels\"*-dualiso.DNG > "E:\Photographies LCAP\Photographies\ML\same-levels\same-levels.TXT""

When I run this on a cmd started @C:\Users\tof\Scripts\lr_cr2hdr\cr2hdr.lrplugin\bin
(note the \\ at the end of paths; same as Lua script)
Quote
> C:\Users\tof\Scripts\lr_cr2hdr\cr2hdr.lrplugin\bin>cr2hdr.exe --amaze-edge --cs2x2 --no-bad-pix --fullres --alias-map --stripe-fix --wb=graymax --same-levels "E:\Photographies LCAP\Photographies\ML\same-levels\\"*-dualiso.CR2 "E:\Photographies LCAP\Photographies\ML\same-levels\\"*-dualiso.DNG > "E:\Photographies LCAP\Photographies\ML\same-levels\same-levels.TXT"
E:\Photographies LCAP\Photographies\ML\same-levels\*-dualiso.CR2: Invalid argument
No matching files
E:\Photographies LCAP\Photographies\ML\same-levels\*-dualiso.DNG: Invalid argument
No matching files

https://bitbucket.org/kichetof/lr_cr2hdr/commits/d293631639b30cae3a1da862253771e287280ba6#Lcr2hdr.lrplugin/MLProcess.luaT590

When Windows command will be fixed, "normally" everyhting should works well!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on December 15, 2015, 04:19:17 PM
There is room for improvement:

Code: [Select]
Old:
"E:\Photographies LCAP\Photographies\ML\same-levels\"*-dualiso.CR2 "E:\Photographies LCAP\Photographies\ML\same-levels\"*-dualiso.DNG
Better:
"E:\Photographies LCAP\Photographies\ML\same-levels\*-dualiso.CR2" "E:\Photographies LCAP\Photographies\ML\same-levels\*-dualiso.DNG"

Old command will break if original/source filename contains blanks.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 15, 2015, 04:29:55 PM
Thanks Walter, but I already try this and it seems that wildcard doesn't works...
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on December 15, 2015, 04:45:23 PM
Are you sure "Cr2hdr --same-levels" supports wildcards in Windows?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 15, 2015, 05:06:19 PM
That's a good question !

Code: [Select]
C:\Users\tof\Scripts\lr_cr2hdr\cr2hdr.lrplugin\bin>cr2hdr.exe --same-levels "E:\Photographies LCAP\Photographies\ML\same-levels\*-dualiso.dng" > "E:\Photographies LCAP\Photographies\ML\same-levels\test.txt"
E:\Photographies LCAP\Photographies\ML\same-levels\*-dualiso.dng: Invalid argument

test.txt
Code: [Select]
cr2hdr: a post processing tool for Dual ISO images

Last update: 8b9190b on 2015-11-14 16:44:35 UTC by a1ex:
cr2hdr: identify camera model from string (should fix issue #2403 ...

Active options:
--amaze-edge    : use a temporary demosaic step (AMaZE) followed by edge-directed interpolation (default)
--cs2x2         : apply 2x2 chroma smoothing in noisy and aliased areas (default)
--wb=graymax    : set AsShotNeutral by maximizing the number of gray pixels (default)
--same-levels   : Adjust output white levels to keep the same overall exposure
                  for all frames passed in a single command line
                  (useful to avoid flicker - for video or panoramas)

Input file      : E:\Photographies LCAP\Photographies\ML\same-levels\*-dualiso.dng
Camera          : Canon EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mar
Matrix not found: EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mar
No table found for camera model: EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mark IIICanon EOS 5D Mar
dcraw could not open this file

so ... you're right! sh*""%t!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on December 15, 2015, 05:14:04 PM
Love how Walter's usually right. He'd be one heck of a Detective! [emoji4]
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 15, 2015, 05:32:27 PM
So... I need to find a way to pass a wildcard to cr2hdr --same-levels on Windows... Always windows!

With some beers, perhaps a genius idea will come!
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Danne on December 15, 2015, 07:50:30 PM
I was thinking. Could you create a list of the files selected? Find command would work, ls command would not. Will break script after around 5000 files selected. From the list you could grab and diminish the list with a while loop until all files have gotten the same white level. This way same levels would work as it was supposed to from the beginning. I use this list while looping in MLP. Could write the code here when I, m at the computer.
Happy beering :D
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: Walter Schulz on December 15, 2015, 07:58:34 PM
@a1ex: Would it be a big deal to implement wildcards for --same-level into cr2hdr for windows? Or something like "--same-level <dir>"?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: BestLittleStudio on December 15, 2015, 08:03:26 PM
Man, you guys run fast around here.

dfort, kichetof,

I did find the file location and located it in lightroom, the file did not auto import but I just went back to the full collection and it was there with the dualiso name. Unfortunately there is no difference between the two images.

I originally used the non beta, I saw no change, so tried the beta and saw the same issue, no change.

If I download the files from the camera to a sort folder and import from there then they are CR2 files. However, if I import directly from the camera then they come in as DNG files.

The CR2 files do not convert with the beta, and the DNG files, though they do convert, show no changes.

I have uploaded the original CR2 and DNG Files, along with the converted DNG files. All setting are at defaults.
You can find them here.

https://dl.dropboxusercontent.com/u/10158027/MagicLantern/IMG_3483-dualiso.TXT
https://dl.dropboxusercontent.com/u/10158027/MagicLantern/IMG_3483-dualiso.DNG
https://dl.dropboxusercontent.com/u/10158027/MagicLantern/IMG_3483.dng
https://dl.dropboxusercontent.com/u/10158027/MagicLantern/IMG_3480-dualiso.TXT
https://dl.dropboxusercontent.com/u/10158027/MagicLantern/IMG_3480-dualiso.DNG
https://dl.dropboxusercontent.com/u/10158027/MagicLantern/IMG_3480.dng
https://dl.dropboxusercontent.com/u/10158027/MagicLantern/151215-IMG_3483-70D.CR2
https://dl.dropboxusercontent.com/u/10158027/MagicLantern/151215-IMG_3480-70D.CR2

I included both an overexposed and an underexposed image.
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 15, 2015, 11:06:55 PM
I tried the files BestLittleStudio posted with cr2hdr on the command line and got the same errors he's reporting. I think it is an issue with 70D files. I've never seen that error before.

Code: [Select]
No camera model found with id 0x325
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: DeafEyeJedi on December 15, 2015, 11:19:46 PM
So does this mean I should try to do some similar test with 70D files to confirm this as well?
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: kichetof on December 15, 2015, 11:28:22 PM
@Danne yes I can export a list of file, easy! But if we found a command line to simplify the process, I'll be happy!
Especially that's work on Mac... Windows always the same story! I've an idea, thanks beer, loop inside file with cmd for like for dcraw white balance! Maybe after a little night it will be more clearer!

@Walter I think that cr2hdr is capable to accept wildcard but it's the way that I launch the command that fail to works because on Mac it works well!

@dfort thanks to find the bug! Glad to heard that's not the plugin! Pfiou  8)
Title: Re: Lightroom plugin cr2hdr v3.0 BETA3 (WIP)
Post by: dfort on December 15, 2015, 11:48:47 PM
So does this mean I should try to do some similar test with 70D files to confirm this as well?

That would be great--and please post the bug report with a sample file on bitbucket. I would do it but since I don't own a 70D and already have too many projects going on....
Title: Re: Lightroom pl