Pretty easy job this one.
For small changes to code anyway :P
From the main repo, create a fork.
https://bitbucket.org/hudson/magic-lantern/overview
(https://s14.postimg.cc/pij5sn9kx/fork.png)
Give it a name and fork it.
(https://s14.postimg.cc/igptk6vcx/fork1.png)
Voila, your own repository.
(https://s14.postimg.cc/dbom2kif5/repositry.jpg)
From there you can browse the source code and edit it.
(https://s14.postimg.cc/wx8hl0vgh/edit.png)
When you've finished editing the source, it's time to commit it.
(https://s14.postimg.cc/lic0gej41/commit.png)
You should give it a name that suits the changes you have made.
(https://s14.postimg.cc/icreq70ht/commit1.png)
Once the changes have been committed to your own repo, it's time to create a pull request for merge into the main repo.
(https://s14.postimg.cc/i6ib0ugqp/pullrequest.png)
Note: You can edit more files at this stage before creating the pull request.
You can change the title, add a description, and then create the pull request.
(https://s14.postimg.cc/shunti8g1/pullrequest1.png)
Note: You can edit more files (or the same file) at this stage and update the pull request. Just hit the pull request button again and follow the procedure above. A new pull request will not be created, the original pull request will be updated.
And it ends up in the main repo as a pull request :)
(https://s14.postimg.cc/agbivpef5/pullrequest2.jpg)
Where hopefully it gets merged into the main source tree.
(https://s14.postimg.cc/sfas6o4sh/merged.jpg)
Help: I'm stupid and stuck at 'create a fork'.
How do I do this: I've never done this before.
I'm trying to make a pull request to change some code in focus.c
Cheers
Garry
Pictures aren't loading in Safari, Firefox or Chromium, I'm in UK. Anyone else not seeing them?
Exactly the tutorial I wanted though :) Theres a small change I want to add(don't know if its useful but been using it myself)
Edit: oh just noticed this is quite old ::) I guess its the DropBox thing.
Image links fixed.
@Audionut
Many thanks for taking the time to do this.
For those like me, i.e. not programmers and infrequent submitters, having this tutorial is a key resource, i.e. To remind us what to do.
BTW, having just made a pull request for correcting the DoFs in focus.c, I noticed a silly mistake in the submitted pull request. Can I correct this, or do I need to make another pull request and reference ignoring the original pull request.
Finally, I truly would welcome a tutorial like this, that showed me how to compile on a Win from my fork. I've tried following the existing tutorial, but keep getting errors.
Once again, many thanks.
Oops: just read this :)
QuoteNote: You can edit more files (or the same file) at this stage and update the pull request. Just hit the pull request button again and follow the procedure above. A new pull request will not be created, the original pull request will be updated.
Quote from: garry23 on May 26, 2017, 07:03:29 AM
Finally, I truly would welcome a tutorial like this, that showed me how to compile on a Win from my fork. I've tried following the existing tutorial, but keep getting errors.
Sorry for the late reply.
Which tutorial?
@Audionut
Time has moved on, but I think I was hoping for a 'dummies guide' for making a pull request from my fork.
I'm still not yet compiling and editing as I should, i.e. I end up doing things incorrectly.
Others have spotted my mistakes, so, for now, I've stopped trying: so I stick with Lua for now.
As I say, time has moved on.
Cheers
Garry
Quote from: Audionut on August 28, 2013, 09:26:10 AM
Pretty easy job this one.
For small changes to code anyway :P
From the main repo, create a fork.
https://bitbucket.org/hudson/magic-lantern/overview
(https://s14.postimg.cc/pij5sn9kx/fork.png)
If someone recently wants to create a fork according to this tutoral, will scratch his head already on the first step and keep shouting "WTF?!" (Where's the fork?!)...
It's been moved to a submenu on the left, under a plus sign.
(https://i.postimg.cc/pVYrspdS/bitbucket-fork-wtf.png)
(https://i.postimg.cc/kgD5Msyr/bitbucket-fork-wtf2.png)
Quote from: ArcziPL on March 10, 2019, 10:22:25 PM
If someone recently wants to create a fork according to this tutoral, will scratch his head already on the first step and keep shouting "WTF?!" (Where's the fork?!)...
:D
I had that feeling too...