Author Topic: Submitting a pull request all via web browser  (Read 4929 times)

Audionut

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3383
  • I have a 1Dx, I'm awesome.
Submitting a pull request all via web browser
« on: August 28, 2013, 09:26:10 AM »
Pretty easy job this one. 

For small changes to code anyway :P

From the main repo, create a fork.

https://bitbucket.org/hudson/magic-lantern/overview



Give it a name and fork it.


Voila, your own repository.


From there you can browse the source code and edit it.


When you've finished editing the source, it's time to commit it.


You should give it a name that suits the changes you have made.


Once the changes have been committed to your own repo, it's time to create a pull request for merge into the main repo.


Note:  You can edit more files at this stage before creating the pull request.

You can change the title, add a description, and then create the pull request.


Note:  You can edit more files (or the same file) at this stage and update the pull request.  Just hit the pull request button again and follow the procedure above.  A new pull request will not be created, the original pull request will be updated.

And it ends up in the main repo as a pull request :)


Where hopefully it gets merged into the main source tree.

garry23

  • Hero Member
  • *****
  • Posts: 1259
Re: Submitting a pull request all via web browser
« Reply #1 on: May 22, 2017, 07:49:37 PM »
Help: I'm stupid and stuck at 'create a fork'.

How do I do this: I've never done this before.

I'm trying to make a pull request to change some code in focus.c

Cheers

Garry

Ilia3101

  • Member
  • ***
  • Posts: 168
Re: Submitting a pull request all via web browser
« Reply #2 on: May 22, 2017, 08:58:30 PM »
Pictures aren't loading in Safari, Firefox or Chromium, I'm in UK. Anyone else not seeing them?

Exactly the tutorial I wanted though :) Theres a small change I want to add(don't know if its useful but been using it myself)

Edit: oh just noticed this is quite old ::) I guess its the DropBox thing.
5D2

Audionut

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3383
  • I have a 1Dx, I'm awesome.
Re: Submitting a pull request all via web browser
« Reply #3 on: May 26, 2017, 03:32:30 AM »
Image links fixed.

garry23

  • Hero Member
  • *****
  • Posts: 1259
Re: Submitting a pull request all via web browser
« Reply #4 on: May 26, 2017, 07:03:29 AM »
@Audionut

Many thanks for taking the time to do this.

For those like me, i.e. not programmers and infrequent submitters, having this tutorial is a key resource, i.e. To remind us what to do.

BTW, having just made a pull request for correcting the DoFs in focus.c, I noticed a silly mistake in the submitted pull request. Can I correct this, or do I need to make another pull request and reference ignoring the original pull request.

Finally, I truly would welcome a tutorial like this, that showed me how to compile on a Win from my fork. I've tried following the existing tutorial, but keep getting errors.

Once again, many thanks.

garry23

  • Hero Member
  • *****
  • Posts: 1259
Re: Submitting a pull request all via web browser
« Reply #5 on: May 26, 2017, 07:12:52 AM »
Oops: just read this  :)

Quote
Note:  You can edit more files (or the same file) at this stage and update the pull request.  Just hit the pull request button again and follow the procedure above.  A new pull request will not be created, the original pull request will be updated.

Audionut

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3383
  • I have a 1Dx, I'm awesome.
Re: Submitting a pull request all via web browser
« Reply #6 on: June 30, 2017, 08:13:24 AM »
Finally, I truly would welcome a tutorial like this, that showed me how to compile on a Win from my fork. I've tried following the existing tutorial, but keep getting errors.

Sorry for the late reply.

Which tutorial?

garry23

  • Hero Member
  • *****
  • Posts: 1259
Re: Submitting a pull request all via web browser
« Reply #7 on: June 30, 2017, 09:47:47 AM »
@Audionut

Time has moved on, but I think I was hoping for a 'dummies guide' for making a pull request from my fork.

I'm still not yet compiling and editing as I should, i.e. I end up doing things incorrectly.

Others have spotted my mistakes, so, for now, I've stopped trying: so I stick with Lua for now.

As I say, time has moved on.

Cheers

Garry