Author Topic: Assign lens focal length and name for non cpu lenses  (Read 23842 times)

dfort

  • Hero Member
  • *****
  • Posts: 1795
Re: Assign lens focal length and name for non cpu lenses
« Reply #225 on: September 02, 2017, 03:16:02 AM »
A while back we discussed the possibility of adding an optional block that could take more than 32 characters, actually 31 characters terminated by a null (0).

Note the truncated name (...ZF.2)

Code: [Select]
Block: LENS
  Offset: 0x00000164
    Size: 96
    Time: 0.806000 ms
     Name:        'Zeiss Makro-Planar T* 2/100 ZF.'
     Serial:      ''
     Focal Len:   100 mm
     Focus Dist:  0 mm
     Aperture:    f/2.00
     IS Mode:     0
     AF Mode:     3
     Lens ID:     0x00000000
     Flags:       0x00000000

Any progress on that yet?
EOSM.202 EOSM.203 EOSM2.103 700D.115 5D3.*

Lars Steenhoff

  • Member
  • ***
  • Posts: 242
Re: Assign lens focal length and name for non cpu lenses
« Reply #226 on: September 10, 2017, 11:24:22 PM »
What's the best way to make a build that combines the crop_rec_4k experiment with the manual lens info branch?

Import the manual lens into the crop_rec_4k branch?

and can this perhaps be done already for the main crop_rec_4k branch.  So that the new experimental build also include the option to set the lens info.

I don't want to make a pull request yet because I don't know what implication this has for the crop_rec_4k branch.
I would like to see a newer build for people to experiment with so we get more feedback on its use.

I can make one but I don't know how to upload it to the experiments page.

dfort

  • Hero Member
  • *****
  • Posts: 1795
Re: Assign lens focal length and name for non cpu lenses
« Reply #227 on: September 11, 2017, 01:54:59 AM »
What's the best way to make a build that combines the crop_rec_4k experiment with the manual lens info branch?

Merge

I did that a while ago and it seems to work fine. Seeing your message I thought I'd update it. There were some conflicts that I'm pretty sure I resolved properly. The branch is here:

https://bitbucket.org/daniel_fort/magic-lantern/branch/crop_rec_4k_manual_lens_info

It would be nice to add manual_lens_info to crop_rec_4k sort of like how raw_video_10bit_12bit was merged into crop_rec_4k. Only a few cameras are working with crop_rec_4k so those other branches are not going away any time soon.

As far as posting to the experiments page, I believe only a developer can do that. Of course if you can compile ML you can post your own test builds. Hint.
EOSM.202 EOSM.203 EOSM2.103 700D.115 5D3.*

Lars Steenhoff

  • Member
  • ***
  • Posts: 242
Re: Assign lens focal length and name for non cpu lenses
« Reply #228 on: September 11, 2017, 12:55:49 PM »
Thanks
Yea I tested your build too, I still can't get it to auto run on startup on the canon 5d mk3 1.2.3
I guess you have the same?

And for the mlv play module to load mlv_rec has to be disabled.
But I think thats a known issue.

JohanJ

  • New to the forum
  • *
  • Posts: 47
Re: Assign lens focal length and name for non cpu lenses
« Reply #229 on: September 11, 2017, 01:55:13 PM »
In case you did not notice yet. @a1ex placed a pull request to merge lens_info into lua_fix which is probably the easiest and fastest way to get this function into nightly and also different experimental branches. Might be  good to comment this PR.
60D.111 / 100D.101 / M2.103

Lars Steenhoff

  • Member
  • ***
  • Posts: 242
Re: Assign lens focal length and name for non cpu lenses
« Reply #230 on: September 11, 2017, 02:47:35 PM »
@JohanJ. Good tip, thanks

Lars Steenhoff

  • Member
  • ***
  • Posts: 242
Re: Assign lens focal length and name for non cpu lenses
« Reply #231 on: September 14, 2017, 12:19:22 PM »
I added a few more Nikon lenses.

Code: [Select]
--  Nikon lenses
    { name = "Nikon AF Fisheye-NIKKOR 16mm f/2.8D",          focal_length =  16, manual_aperture = 2.8 },
    { name = "Nikon AF NIKKOR 20mm f/2.8D",          focal_length =  20, manual_aperture = 2.8 },
    { name = "Nikon AF NIKKOR 28mm f/1.4D",          focal_length =  28, manual_aperture = 1.4 },
    { name = "Nikon AF NIKKOR 35mm f/2D",            focal_length =  35, manual_aperture = 2   },
    { name = "Nikon AF NIKKOR 50mm f/1.4D",          focal_length =  50, manual_aperture = 1.4 },
    { name = "Nikon AFS-NIKKOR 50mm f/1.8G",         focal_length =  50, manual_aperture = 1.8 },
    { name = "Nikon AF Micro-NIKKOR 60mm f/2.8D",    focal_length =  60, manual_aperture = 2.8 },
    { name = "Nikon AF NIKKOR 85mm f/1.4D IF",       focal_length =  85, manual_aperture = 1.4 },
    { name = "Nikon AF DC-NIKKOR 105mm f/2D",        focal_length = 105, manual_aperture = 2   },
    { name = "Nikon AF DC-NIKKOR 135mm f/2D",        focal_length = 135, manual_aperture = 2   },
    { name = "Nikon AF NIKKOR 28-105 f3.5-4.5D",     focal_length =  28, manual_aperture = 3.5 },

--  Nikon Manual focus lenses
    { name = "Nikon Zoom Ais ED 50-300",             focal_length = 300, manual_aperture = 4.5 },
    { name = "Nikon Ais NIKKOR 24mm f/2.8",          focal_length =  24, manual_aperture = 2.8 },
    { name = "Nikon Ais NIKKOR 35mm f/1.4",          focal_length =  35, manual_aperture = 1.4 },
    { name = "Nikon Ais NIKKOR 55mm f/1.2",          focal_length =  55, manual_aperture = 1.2 },
    { name = "Nikon Ais NIKKOR 105mm f/1.8",         focal_length = 105, manual_aperture = 1.8 },
    { name = "Nikon Ais NIKKOR 500mm f/8",           focal_length = 500, manual_aperture = 8   },
    { name = "Kiron Macro 100mm f/2.8",              focal_length = 105, manual_aperture = 2.8 },

--  Anamorphic Lenses
    { name = "Iscorama Anamorphic 50 f/2.8mm ",      focal_length =  50, manual_aperture = 2.8 },

I know the list is not complete but there are so many manual lenses
http://www.photosynthesis.co.nz/nikon/lenses.html

Full manual lenses from Nikon won't be recognised in ACR because adobe does not have profile for them.
There is a way to make profiles with the adobe profile creator.
http://supportdownloads.adobe.com/detail.jsp?ftpID=5493.

Here an article on the editor
http://blogs.adobe.com/jkost/2013/09/create-your-own-lens-profiles.html

The best way to auto recognise them is what fort described here.
@Lars_Steenhoff

Had a breakthrough today. To get your Nikon AF NIKKOR 35mm f2D lens working with the lua script simply copy the profile from the ACR installation. I'm not sure what the Windows location is but on the Mac it is in:

Code: [Select]
/Library/Application Support/Adobe/CameraRaw/LensProfiles/1.0/Nikon/NIKON D3X (Nikon AF NIKKOR 35mm f2D) - RAW.lcp
and put the copy in your user area, again on the Mac it is in:

Code: [Select]
/Users/<you>/Library/Application Support/Adobe/CameraRaw/LensProfiles/1.0/
Then edit the stCamera:Lens from this:

Code: [Select]
<stCamera:Lens>35.0 mm f/2.0</stCamera:Lens>
To this:

Code: [Select]
<stCamera:Lens>Nikon AF NIKKOR 35mm f2D</stCamera:Lens>
Do a copy/replace because there are multiple instances of that tag.

Finally put that lens name in your lua script and that's it.

For more details, here's my latest post on the Adobe Camera Raw forum:

https://forums.adobe.com/message/9200782#9200782