Magic Lantern Forum

Using Magic Lantern => Post-processing Workflow => Topic started by: a1ex on December 18, 2013, 06:09:34 PM

Title: UFRaw-mod - a tweaked version of UFRaw
Post by: a1ex on December 18, 2013, 06:09:34 PM
I decided to throw all my UFRaw patches in a repository, so you guys can try them until they will be - hopefully - integrated in the official version (http://ufraw.sourceforge.net/).

Source code on Bitbucket (https://bitbucket.org/a1ex/ufraw-mod) (with changelog and issue tracker)
Windows binaries (https://bitbucket.org/a1ex/ufraw-mod/downloads) (ufraw.exe and ufraw-batch.exe, plus a bunch of DLLs)

Tip: if you are on Mac/Linux and don't feel like typing "./configure && make && make install", you can run my executable under Wine.

The patches:
- custom soft-film curve (http://www.magiclantern.fm/forum/index.php?topic=5197.msg91513#msg91513) with nicer highlight rolloff
- overexposure fixes (http://www.magiclantern.fm/forum/index.php?topic=5197) (hopefully solves these issues (http://ninedegreesbelow.com/bug-reports/ufraw-highlights.html))
- white balance on skintones (http://www.magiclantern.fm/forum/index.php?topic=9469) (work in progress, hardcoded for 5D3 for now)
- experimental support for 32-bit floating point DNG files created by CeroNoice (http://www.magiclantern.fm/forum/index.php?topic=9581) (exposure slider extended until +20 EV; be careful, it can be slow)

Note that I don't use the Windows version myself (I use a Linux binary compiled from the same source, but the versions of the underlying libraries may differ). I've opened it under Wine, dragged some sliders, saved a jpeg, but that was it. If it behaves weird, please report it to my issue tracker on Bitbucket (https://bitbucket.org/a1ex/ufraw-mod/issues?status=new&status=open). Of course, if your issue is also present in stock ufraw, report it there (https://sourceforge.net/p/ufraw/bugs/).

Here I'd like to see feedback on the above modifications, difficult test cases where they either helped or made things worse, comparisons with stock UFRaw, stuff like that.

Some pictures and screenshots:
(http://a1ex.magiclantern.fm/bleeding-edge/ufraw-mod/ufraw-mod.png) (http://a1ex.magiclantern.fm/bleeding-edge/ufraw-mod/ufraw-mod-hdr.jpg) (http://a1ex.magiclantern.fm/bleeding-edge/skinwb/skinwb.jpg)

(http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-orig-film-3.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-orig-film-3.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-orig-film-2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-orig-film-2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-orig-film-0.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-orig-film-0.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-orig-film%2B2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-orig-film%2B2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-orig-film%2B4.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-orig-film%2B4.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-orig-film%2B6.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-orig-film%2B6.jpg)
(http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-final-film-3.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-final-film-3.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-final-film-2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-final-film-2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-final-film-0.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-final-film-0.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-final-film%2B2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-final-film%2B2.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-final-film%2B4.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-final-film%2B4.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/small/ettr-final-film%2B6.jpg) (http://a1ex.magiclantern.fm/hdr/ufraw%20bug/big/ettr-final-film%2B6.jpg)

Happy pixel peeping!
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: Greg on December 18, 2013, 06:22:25 PM
Work on windows:

(http://s13.postimg.org/4ubijej1j/win.jpg)
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: pilgrim on December 21, 2013, 12:33:52 AM
Work very well on Windows 7 - 64bit.
The button for skin tone is really very useful. If the colour of the wall or the tree not correct is not disturbing, but the wrong colour skin is really disturbing. I know that all of you know that, just underlining  ;)

In real life, not in studio, is not always easy and practical with the chip card, and the good moment sometime to short.
Thanks a lots Alex for the better and easier result. 
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: Audionut on December 22, 2013, 12:24:14 PM
edit:  I guess dual ISO to blame?

http://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/_UAL3947.DNG

(http://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/ufraw.PNG)
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: a1ex on December 22, 2013, 01:55:05 PM
Solved. This shot is quite tricky, can you post the final rendering?
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: Audionut on December 22, 2013, 04:05:33 PM
No idea on a final rendering, I wouldn't normally take a shot like that.  I'd rather shot into the light and gel a flash.  I noticed the light and was curious what your skin WB would do  :)

Without a flash, shooting further away from the light is much more preferable imo.
(http://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/_UAL3933.jpg)

https://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/_UAL3933.DNG
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: Audionut on December 22, 2013, 04:39:41 PM
Pale skin tones are throwing it off.

http://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/_46A3994.CR2

(http://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/Skin.PNG)


His right arm was more accurate but still about 1.3K to warm imo.

This looks more neutral to me.
(http://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/Neutral.JPG)
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: Audionut on December 22, 2013, 06:01:47 PM
Pink highlights with the soft film curve.  Ugly highlights with the linear curve.

http://dl.dropboxusercontent.com/u/34113196/ML/UFRAW/D46A7025.CR2

Shot includes colorchecker.  Second row from the bottom of the card contains patches for progressively warmer skin tones from right to left as looking at it.
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: a1ex on December 22, 2013, 06:11:41 PM
White level is bad, try converting the CR2 to DNG with Adobe DNG first.
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: a1ex on February 02, 2014, 08:37:32 PM
Been playing with the soft-film curve used here, and just came up with this graph:

(http://a1ex.magiclantern.fm/bleeding-edge/soft-film-curves.png)

(I'm experimenting with burning this curve into DNG files - it would compress highlights in order to squeeze more shadow detail into a 16-bit integer container; could be useful for dual ISO and CeroNoice as a trick to maintain compatibility with 16-bit raw processors)
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: Marsu42 on February 02, 2014, 08:44:40 PM
Quote from: a1ex on February 02, 2014, 08:37:32 PM
I'm experimenting with burning this curve into DNG files - it would compress highlights in order to squeeze more shadow detail into a 16-bit integer container

Good idea in general because the first thing I'm usually doing after importing even vanilla shots is to set some highlight recovery in Lightroom, usually the highlights are too extended, at least for what I shoot. For dual_iso shoots, this would be even more valuable, I usually would like to set highlights to -200 but -100 is the max value :-\
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: ADJ on April 18, 2014, 11:21:09 PM
Quote from: pilgrim on December 21, 2013, 12:33:52 AM
Works very well on Windows 7 - 64bit.
I was trying to use Alex's patches tonight but cannot get them working. Maybe I'm doing something wrong. There are two sets of files which I could download at https://bitbucket.org/a1ex/ufraw-mod/downloads
I assume I should just download the most recent zip, extract the files, and overwrite the Ufraw versions. This is not working for me. I have some ETTR timelapes and I have some pixels going pink/magenta in the overexposed areas. The files are working fine with UFRAW except for the magenta areas. I tried the other zip but that's not doing much either. I did reboot after overwriting the files.

Is there something obvious I'm doing wrong?

RenatoPhoto maybe you'd like to update 1. for windows users from the UFRAW WORKFLOW section

"...I used the windows for dummies version from here:
http://sourceforge.net/projects/ufraw/files/ufraw/ufraw-0.19.2/ufraw-0.19.2-2-setup.exe/download"

to mention Alex's updates?
I'm using Windows7 x64 Home Premium SP1, i3 CPU, 8GB RAM. The camera is a 50D on a fairly recent nightly.
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: a1ex on April 22, 2014, 08:54:57 AM
Do you have some sample raw files where I can look?
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: ADJ on April 24, 2014, 08:47:46 PM
Thanks A1ex for offering to take a look. I uploaded some files to https://www.dropbox.com/sh/myapniqklu5fm8k/cizAKnZQDm (https://www.dropbox.com/sh/myapniqklu5fm8k/cizAKnZQDm)

File 7294 is probably the one to look at. I was just using the intervalometer for the first time and so had a go at a sunrise. I can improve the bad photography but the pink highlights are beyond me.
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: a1ex on April 24, 2014, 08:52:10 PM
When you get pink highlights, it's usually the white level wrong (ufraw and dcraw use some hardcoded values which are not always good).

Workaround: convert the CR2 to DNG with Adobe DNG converter. That one has some more chances to get it right, and if not, you can tweak it with exiftool.

If it doesn't help, upload the CR2 for that file.

Also note that ufraw's highlight recovery is not exactly the best, but grayscale detail is recovered pretty well if the white level is correct.
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: djronbxs on December 17, 2021, 12:19:34 PM
The windows binaries link is not working.
Title: Re: UFRaw-mod - a tweaked version of UFRaw
Post by: Walter Schulz on December 17, 2021, 12:46:45 PM
https://web.archive.org/web/20200622000811/https://bitbucket.org/a1ex/ufraw-mod/downloads/