Magic Lantern Forum

Developing Magic Lantern => Modules Development => Topic started by: a1ex on October 28, 2013, 12:07:15 PM

Title: MLV PLAY (mlv_play.mo)
Post by: a1ex on October 28, 2013, 12:07:15 PM
Quote from: g3gg0 on October 26, 2013, 11:22:14 PM
i added mlv_play.mo to the pre-built binaries.
if you install file_man.mo, you can browse your card's file system and open .mlv and .raw files for playback

Added color playback support. If it's too slow, press SET to switch back to grayscale.

Do we need a separate thread for mlv_play.mo?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on October 28, 2013, 03:04:00 PM
cool :)
i would say yes, becuase this thread is already too overloaded.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: RenatoPhoto on October 29, 2013, 03:31:21 PM
Oh yea!!  Color on RAW and MLV payback.  Amazing stuff guys!  Congratulations and thank you for the continued improvements.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on October 29, 2013, 03:41:23 PM
Well, somebody needs to suggest a better conversion matrix from raw to yuv (mine is from rgb to yuv, which is not quite correct).
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 10, 2013, 02:01:11 AM
i made a lot of changes to mlv_play:

* when using mlv_rec and RAW recording is enabled, pressing PLAY will automatically start mlv_play
* you now can cycle through all videos using your scroll wheel (on top)
* alternatively you can open the OSD with Q and select < or > to jump to previous or next file
* when pressing INFO, the top bar will toggle

you can download the latest version of mlv_play along with mlv_rec in the mlv_rec thread (http://www.magiclantern.fm/forum/index.php?topic=7122.msg59525#msg59525).
just scroll down to "pre-built" binaries in the main post and download the package.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on November 10, 2013, 02:36:58 AM
Heh, now it needs a delete button the way it works with play...
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Andy600 on November 10, 2013, 02:59:25 AM
Nice one g3gg0!  :D
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on November 10, 2013, 09:20:23 AM
real nice!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 10, 2013, 11:53:12 AM
good that you like it :)
trying to incorporate the requests stevefal already made and deleting is one of them.
isnt hard to do - just the confirmation dialog is some work.

atm i am playing with color matrices alex has asked for once.
currently the decoder uses raw RGGB, applies some kind of gamma curve and converts it straight to YUV.

a) i am missing white point conversion as RAW is based on 5000K and RGB/YUV on 6500K
b) i am missing the camera specific color matrix

the first one, white point correction is simple. (well, as soon you get the basics and some code to automate that)
but the latter one is kind of problem yet - i always end up with distorted YCbCr data having huge color shifts.
i am sure i missed a *2 somewhere ;)

not sure if it is worth the hassle, as the current implementation from alex performs quite well and looks good.
but still i want to understand how it should be and then we still can decide to use the non-perfect but fast solution.
however, maybe its just a coefficient change to the color matrix RAW->RGB
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on November 10, 2013, 07:17:11 PM
It looks good in the player.. more or less the color matrix + cam model deal is a problem for raw2dng, etc... hopefully the fix from andy kills bad frame issues on 7D/50D and we'll have meta data finally. If it works I'll move the new status icon into my copy.

I get 86MB/s instant rates which is better than raw_rec but bad frames and LV slowdown every time the meta data is written (I think)... I recall 5DII this was the issue as well :) Then the last problem with MLV is batch tools...
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Andy600 on November 10, 2013, 07:47:24 PM
Yep. I'm getting up to 86MB/s with mlv_rec on the 50D and no bad frames now. My 50D is shooting reliably upto it's full 2000x1080 px res for more frames than I even need for a shot!! \o/

@g3gg0 - I saw you had the stubs to fix the 60D camera model property. Do you have the ones for the 50D by any chance?  ::)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on November 10, 2013, 08:17:23 PM
Yea, working on 7D... speed drops from the fix but 1728x1152 is usually continuous. Only 1 bad frame, frame 1, who cares
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Andy600 on November 10, 2013, 08:25:54 PM
Quote from: 1% on November 10, 2013, 08:17:23 PM
Yea, working on 7D... speed drops from the fix but 1728x1152 is usually continuous. Only 1 bad frame, frame 1, who cares

Bingo!  ;D
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 10, 2013, 09:22:07 PM
mlv_rec: http://www.magiclantern.fm/forum/index.php?topic=7122.msg87887#msg87887
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on November 10, 2013, 09:26:57 PM
Yea, a tool like rawanizer that gives you a few preview frames... maybe allows different conversion formats. Although mlv_dump you can add compression I think to finally make some smaller file sizes. If only the source was available :)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on November 10, 2013, 09:32:22 PM
Something like rawmagic for mac ;)
Simply a wish  8)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on November 10, 2013, 09:53:39 PM
Hey here is another thought... would frame skipping help in playback?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 10, 2013, 09:55:58 PM
Quote from: 1% on November 10, 2013, 09:26:57 PM
Yea, a tool like rawanizer that gives you a few preview frames... maybe allows different conversion formats. Although mlv_dump you can add compression I think to finally make some smaller file sizes. If only the source was available :)

did you see http://www.magiclantern.fm/forum/index.php?topic=8447.0 ?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on November 10, 2013, 10:26:36 PM
Its nice to preview that way but not when you have a folder of 20 files named MLV_blahblah.mlv

Basically someone needs to make a GUI that lets you add a bunch of MLV files with preview frames + maybe open with MLV play and then converts them in one press to DNG or proxy video with options, esp folder options. Just missing the convenience.. I am going to give MLV a go now that it appears reliable/speedy. Andy said videos look better too when ACR has meta data + cam name.

Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 11, 2013, 04:40:41 PM
Quote from: g3gg0 on November 10, 2013, 02:01:11 AM
i made a lot of changes to mlv_play:

* when using mlv_rec and RAW recording is enabled, pressing PLAY will automatically start mlv_play
* you now can cycle through all videos using your scroll wheel (on top)
* alternatively you can open the OSD with Q and select < or > to jump to previous or next file
* when pressing INFO, the top bar will toggle

you can download the latest version of mlv_play along with mlv_rec in the mlv_rec thread (http://www.magiclantern.fm/forum/index.php?topic=7122.msg59525#msg59525).
just scroll down to "pre-built" binaries in the main post and download the package.
Any HDMI playback support? that is most important thing on  set! Now the whole idea of using ML with a crew is useless unles there is HDMI feed to directors monitor, focus puller and DIT monitors.please please can you address this ussue!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 11, 2013, 05:59:48 PM
Quote from: MonteNero on November 11, 2013, 04:40:41 PM
Any HDMI playback support? that is most important thing on  set! Now the whole idea of using ML with a crew is useless unles there is HDMI feed to directors monitor

did you try it?
the whole effort of the ML crew (in total literally 0,5 full time devlopers) is useless if there is no testing from those who have the setup ;)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on November 11, 2013, 08:18:08 PM
Quote from: g3gg0 on November 11, 2013, 05:59:48 PM
did you try it?
the whole effort of the ML crew (in total literally 0,5 full time devlopers) is useless if there is no testing from those who have the setup ;)

I can confirm that playback always immediately freezes the camera (Error 80) when using an HDMI monitor. 

I have just tested the latest build of MLV and found a few issues issues during my brief tests.

On 5D Mark III (using a SmallHD DP-4 monitor)
- playback via HDMI crashes
- some pink/corrupt frames (I still need to confirm which framerates this occurs most often).
- crop mode does not work via HDMI when Memory Hack is enabled. It doesn't crash, it just stops right away.
- 16:9 black framing bars at top and bottom disappear when recording starts.  These are the built in canon ones.

I will perform more extensive tests tonight and report back to you everything I found.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 11, 2013, 09:05:24 PM
thanks for testing
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on November 12, 2013, 03:55:17 AM
Quote from: g3gg0 on November 11, 2013, 09:05:24 PM
thanks for testing

I just tested mlv_rec for a couple hours.  I noticed the following on my 5D Mark III and using my SmallHD DP-4 HDMI monitor...

- Playback via HDMI crashes
- Crop mode does not work via HDMI when Memory Hack is enabled. It doesn't crash, it just stops right away.  I always need Memory Hack enabled to achieve a usable number of frames for 29.970 or higher framerates.
- Corrupt/Pink frames occur when fps are set to 29.970.  I typically get 1 to 2 bad frames on at least half the clips I shot (I shot at least 50 clips).  I use 29.970 for at least half my work.
- The good news is that when Canon fps is set to 60p mode, I get no bad frames.  I tested both 48fps and 60fps.  I guess the last update you released really helped with that.
- 16:9 black framing bars at top and bottom disappear when recording starts.  These are the built in canon ones.
- If you set Global Draw to OFF (within raw settings), when you stop recording, global draw stays OFF (even though it show GD is on in ml menu).  I needed to reboot camera to restore GD.
- Card spanning doesn't seem to offer much improvement though in past versions I had tested, it had given a much better better improvement in frames that could be recorded.
-The new mlv_play features which link playback to the Canon play button is much appreciated and works well when used without an HDMI monitor attached.  Since I have personally committed to using ML raw for many of my profession projects, I cannot stress enough the importance of workable HDMI functionality for professional work.  Up to now, I have been using workarounds for issues like playback crashing the camera, by unplugging the monitor to play back footage.  It really makes it hard to work this way when on a project.  I have thus far resisted switching to the MLV format because performance isn't as good and rec_raw (though improving). 

Wish list
- More performance when shooting 29.970.
- Recording indicator settings to match raw_rec would be great (small recording icon without distracting status verbage).
- A beep when recording begins would be useful

I'm happy to help test MLV on the 5D3 as much as necessary if it helps MLV become a bit more conducive to production work.  Thank you for all your efforts g3gg0.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on November 12, 2013, 09:41:16 AM
QuoteI needed to reboot camera to restore GD.

Instead of rebooting, try hitting play. For me it gets stuck off like .02% of the time. 5DIII might be different, EOSM was.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 12, 2013, 10:03:06 AM
Thanks for feedback!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: kgv5 on November 12, 2013, 10:25:42 AM
Quote from: MA Visuals on November 12, 2013, 03:55:17 AM

- Card spanning doesn't seem to offer much improvement though in past versions I had tested, it had given a much better better improvement in frames that could be recorded.

- A beep when recording begins would be useful


I have the same thoughts.
Card spanning which is one of my favourites features and for now the main reason of switching from raw is not so brilliant as it was at the beginning of mlv development. Back than write speed was reaching 110-116 MB and 2,5k 2,35:1 was continous but unfortunatelly there was no tools for processing. Now we have the tools but speed decreased and it is stopping suddenly not reaching expected frames even close.
I believe that this will be polished in some time, for 5d3 file spanning is a breakthrough feature.
With current build 2,5k 2,35:1 23,976fps gives about 25-35 seconds.
Beep on start is useful, we get used to this with raw_rec and now something is missing.
Thanks
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 12, 2013, 12:25:34 PM
Quote from: g3gg0 on November 11, 2013, 05:59:48 PM
did you try it?
the whole effort of the ML crew (in total literally 0,5 full time devlopers) is useless if there is no testing from those who have the setup ;)
The effort of ML's 0.5 full time developer kicks canon's ass though! The playback was the first thing I tested, and it crashes the cam.  If you solve and post it in nightly builds I will be first to try the HDMI playback support!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 14, 2013, 05:46:06 PM
Hi, g3ggo! Any news on HDMI?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 14, 2013, 06:36:44 PM
the problem is there:

https://bitbucket.org/hudson/magic-lantern/src/570c301158185f8dd29372ae7260d88bfda49c1c/src/raw.c?at=unified#cl-1527
https://bitbucket.org/hudson/magic-lantern/src/570c301158185f8dd29372ae7260d88bfda49c1c/src/raw.c?at=unified#cl-741

at least *some* problem is there, that causes incorrect memory accesses.
unfortunately these things are quite complex.  at least i dont get it :)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 14, 2013, 11:03:22 PM
fixed the HDMI issues hopefully.
can you redownload, update your autoexec.bin and retry?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on November 15, 2013, 12:27:18 AM
Tried the hdmi on a small monitor. Worked very well. Havn,t used the hdmi before with raw or .mlv. Worked well with playback aswell with the file manager both .mlv and raw. filmed for a minute or so but it worked fine.
Had a frozen monitor image two times after fiddlin in menus. THis was NOT during filming. When getting out of liveview and back again the picture came alive again. Had a hard time reproducing the issue though.
My main concern now with .mlv is that I can,t get 25 fps 1080p continuous  all the time like with raw. Maybe when card is getting warm :)
GReat work g3gg0
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on November 15, 2013, 12:37:25 AM
Will test tonight on my SmallHD monitor and report back to you.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: gary2013 on November 15, 2013, 01:52:14 AM
Quote from: a1ex on October 28, 2013, 12:07:15 PM
Added color playback support. If it's too slow, press SET to switch back to grayscale.

Do we need a separate thread for mlv_play.mo?
I get an error message when I try to view an MLV file thru the File Manager on my M cam using Nov 13 version. It says "Failed to get a free buffer." I have to pull battery since it freezes thre cam.

Gary
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 15, 2013, 03:34:37 AM
I will extensively  test the HDMI this days and get back with a report. Can' wait to try  ;D
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 15, 2013, 09:26:54 AM
Quote from: gary2013 on November 15, 2013, 01:52:14 AM
I get an error message when I try to view an MLV file thru the File Manager on my M cam using Nov 13 version. It says "Failed to get a free buffer." I have to pull battery since it freezes thre cam.

didnt try lately.
can you try the current version?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: gary2013 on November 15, 2013, 11:14:57 AM
Quote from: g3gg0 on November 15, 2013, 09:26:54 AM
didnt try lately.
can you try the current version?
i have the current version ML. is that what you mean? if not, where is the current version you want me to try.

Gary
I found this=
https://docs.google.com/spreadsheet/ccc?key=0AgQ2MOkAZTFHdHJraTVTOEpmNEIwTVlKd0dHVi1ULUE#gid=0

but i don't know how to use all of that. I was expecting a simple mo file to add to my ML modules folder. I always get the daily builds for the M off of http://tl.bot-fly.com/
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 15, 2013, 11:31:08 AM
Quote from: gary2013 on November 15, 2013, 11:14:57 AM
i have the current version ML. is that what you mean? if not, where is the current version you want me to try.

just download the mlv_rec package and use the modules from there
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 16, 2013, 07:46:12 AM
Hi, g3ggo! Here are some results I've got.
1) HDMI playback doesn't crash the camera, but it doesn't display the recorded raw file either. Here is what I get when playback the file with HDMI
(http://i42.tinypic.com/21ezw8w.jpg)
There is some strange playback behind the grey bar.
2) Pressing "info" or "loupe" buttons crash the camera while recording raw with HDMI and without.
I used latest ML build 2013-11-16 5d mark III
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 16, 2013, 08:51:40 AM
which camera?
when you rotate the wheel (on top) does the video file change?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: gary2013 on November 16, 2013, 08:56:40 AM
Quote from: g3gg0 on November 15, 2013, 11:31:08 AM
just download the mlv_rec package and use the modules from there
that is what I have been doing. I always get the no free buffer message. i go to ML File manager, navigate to the MLV file i just shot and then select view. It shows building index and then saving index and goes blank and the error message pops up about not getting a free buffer. The M hangs and i have to pull the battery and reboot.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 16, 2013, 09:34:09 AM
Quote from: g3gg0 on November 16, 2013, 08:51:40 AM
which camera?
when you rotate the wheel (on top) does the video file change?
5d mark iii. Yes, the video file changes if I scroll the top wheel and the grey bar dissappears but there are strange flickering on the top and bottom of the display, if you take a look at the image I posted above you will see pixels and lines on the top and the bottom of the image. Moreover greyscale playback slows down if viewed with HDMI.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 16, 2013, 09:58:47 AM
(http://i41.tinypic.com/1yaf7q.jpg)

Here is the new image.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on November 16, 2013, 09:59:20 AM
Strange. I got everything to play just fine on my 5d mark 3 through hdmi. Playback in color. I downloaded the pre-built version from here, http://www.magiclantern.fm/forum/index.php?topic=7122.0
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 16, 2013, 10:06:46 AM
maybe it depends on the exact resolution.
hdmi playback is slower for reason. the resolution is higher.

Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 16, 2013, 06:57:17 PM
Quote from: Danne on November 16, 2013, 09:59:20 AM
Strange. I got everything to play just fine on my 5d mark 3 through hdmi. Playback in color. I downloaded the pre-built version from here, http://www.magiclantern.fm/forum/index.php?topic=7122.0
Most likely your monitor is cropping the video! I've just tested the HDMI playback on a cheap small field monitor, the monitor has an options of 480p and 1080i. When I watch it in 480p mode the playback is cropped and I don't get the weird pixel flicker on the top and the bottom of the frame. But if I playback with full HD mode it scales it whole video to fit in the screen, and I see the artifacts. So far I tested the HDMI playback on the field monitors Lilliput an TV logic. Moreover I run couple of tests on a broadcast reference monitor set, finally I tested it on my home TV Samsung Smart, every full HD device give this weird flicker. The exception is the Lilliput monitor that crops  the video in a 480p mode. Also I've noticed that the playback with HDMI is a tiny bit slower that in camera playback. So this is it so far. Hope that will be useful for further development.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on November 16, 2013, 07:16:08 PM
Ok, yes, I get the pixel thingy also but I get the color view at least :)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 16, 2013, 07:44:32 PM
its just some remaining pixel trash on top and bottom bars?
i can imagine where this comes from.

just a appearance-thingy, no functional problem, right?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on November 16, 2013, 08:18:26 PM
exactly, works perfectly fine here.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on November 17, 2013, 01:05:15 AM
I'm not sure if this is helpful, but here's a short iphone video demonstrating the HDMI playback issue others have observed (5D Mark III, SmallHD DP-4)...

On first playback, the no image message blocks the display.  If you switch to another clip using the top dial, it clears up the "No Image" issue but the image remains cut off on the left side and offset.

Also, the playback speed drops dramatically compared to in-camera playback.  You can get a sense of the playback speed in the video example.


Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 17, 2013, 02:17:16 AM
Quote from: g3gg0 on November 16, 2013, 10:06:46 AM
hdmi playback is slower for reason. the resolution is higher.

this ;)

thanks for the vid
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on November 17, 2013, 05:05:54 AM
Makes sense. Sometimes obvious escapes me.  ;D
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 17, 2013, 11:29:01 PM
added delete feature.
either press TRASH or go choose "Del" .
you have to confirm by pressing SET again.

still buggy - seems to have trouble with deleting .idx and .M00, etc chunks.
just the main file seems to get deleted.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 18, 2013, 04:44:02 PM
Great!
Is it possible to get real time color playback?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 18, 2013, 06:09:55 PM
you mean the playback should be faster?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 19, 2013, 06:02:13 AM
Hi, g3ggo!
I mean now the playback is arround 2-3 fps in color mode. I wonder if it is possible to make the playback at a correct speed of 24/25/30 fps?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on November 19, 2013, 07:10:28 AM
Now with the play button being assigned to playback mlv files, was the function to select/deselect individual files in the file browser reassigned to another key?  If not, can it be?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 19, 2013, 10:37:39 AM
Quote from: MA Visuals on November 19, 2013, 07:10:28 AM
Now with the play button being assigned to playback mlv files, was the function to select/deselect individual files in the file browser reassigned to another key?  If not, can it be?

ah okay seems i should check for ML menus being inactive before launching playback.
thanks.

Quote from: MonteNero on November 19, 2013, 06:02:13 AM
Hi, g3ggo!
I mean now the playback is arround 2-3 fps in color mode. I wonder if it is possible to make the playback at a correct speed of 24/25/30 fps?

can you do me favor? just make a guess why the playback is that slow. ;)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 19, 2013, 11:45:11 AM
Quote from: g3gg0 on November 19, 2013, 10:37:39 AM
can you do me favor? just make a guess why the playback is that slow. ;)
Are you trying to say it is too much for the camera to process the raw files?  ::)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on November 25, 2013, 05:33:22 PM
Hi,g3ggo!
I took time to run some HDMI tests on the latest build.
So this what I found:
1. No more strange "no image" overlay in playback.
2. There is the shift of the whole image to the left side of the screen on the playback.
3.There are still white noise and lines on the top and the bottom of the screen when playback. Very distracting btw.
4. On some field monitors custom res like 1600x900 give strange overlays in liveview (recording mode).
5. And most important thing... I had several crashes after I tried to exit the HDMI playback. I would say that it is less stable comparing to previous builds.
6.Detaching HDMI cable can freeze the camera.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on November 25, 2013, 05:55:00 PM
Quote from: MonteNero on November 25, 2013, 05:33:22 PM
Hi,g3ggo!
I took time to run some HDMI tests on the latest build.

thanks!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on December 01, 2013, 06:06:52 PM
Hi, guys!
I see there were some more changes in MLV Play module. Hopefully I will test it during the week.
I still have some hopes regarding the real time color playback  ;D Is it possible?????? Come on that would be another miracle you guys do.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on December 04, 2013, 06:51:02 PM
Hi!
I was digging the playback, and I've noticed that the playback is faster at 24 fps... So I thought what if frame skipping functionality could be done for 25 fps. I suggest to  playback only 20  actual frames per second plus 5 that are duplicates(holds) of every 4th frame. This way camera has to read only 20 frames out of 25 frames.
This technic is used in some 2d animation, when there are 12 actual drawings and every drawing is repeated twice to achieve 24 fps.
What do you think guys?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on December 04, 2013, 07:06:56 PM
By the way I tested HDMI, it has got really bad...
1) 5d III crashes every time I want to exit the playback. I have to pull out the battery.
2) There is overlay "no image" bar again that overlays the playback.
3) The weird lines on the top and bottom of the frame are now colored and have some strange flickering with strange  pink blinks.
4) There is the offset toward the left side of the screen of overall playback window.
I did not try to offload the video I've shot while I was testing HDMI, so can't tell if there are any buggy frames.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on December 04, 2013, 10:25:55 PM
please: block the play button hook when LV isn't open? the delete option is working great and other than that everything is kosher
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on December 04, 2013, 11:02:19 PM
right. remember that annoying me too.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Andy600 on December 04, 2013, 11:11:53 PM
Would be good to play the last recorded file when hitting play without having to scroll through all shots or go into the file manager to get to the latest one. I sometimes shoot some stills for reference when shooting video but can't view them without first disabling mlv_play. Can it co-exist with Canon photo previews?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on December 04, 2013, 11:18:20 PM
Quote from: MonteNero on December 04, 2013, 07:06:56 PM
By the way I tested HDMI, it has got really bad...
1) 5d III crashes every time I want to exit the playback. I have to pull out the battery.
2) There is overlay "no image" bar again that overlays the playback.
3) The weird lines on the top and bottom of the frame are now colored and have some strange flickering with strange  pink blinks.
4) There is the offset toward the left side of the screen of overall playback window.

I am experiencing the same exact issues for all the points you listed.  Using 5d3 as well. The crashing while exiting playback being the most problematic of course.  Regarding the image being offset, this makes it difficult to judge if I nailed composition.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on December 05, 2013, 01:03:50 AM
added playback of last recorded file and some progress bar when creating an index.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on December 05, 2013, 01:16:46 AM
Quote from: g3gg0 on December 05, 2013, 01:03:50 AM
added playback of last recorded file and some progress bar when creating an index.

This is very helpful.  Another suggestion would be to allow navigating past the last recording and continuing to the first recording.  And the same behavior if navigating in the opposite direction.  On a 64gb card I often end up with 40+ short video clips and this would make it much easier to navigate through lots of footage.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Andy600 on December 05, 2013, 01:23:01 AM
g3gg0 you're a star!  8)

Thanks
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on December 05, 2013, 02:36:41 AM
Quote from: g3gg0 on December 05, 2013, 01:03:50 AM
added playback of last recorded file and some progress bar when creating an index.

Just tried this with raw_rec using the latest nightly (commit 9d367a5) which included these new changes to mlv_play and raw_rec.  Pressing the Canon play button no longer lauches mlv_play.  I just get the "No Image" message.

Also, can you upload an updated pre-built mlv_rec file?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on December 05, 2013, 03:32:07 PM
so with the latest raw_rec it doesnt work? ok will check tonight.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: 1% on December 05, 2013, 04:13:46 PM
Working here still.. maybe raw_rec in main is missing original change to make mlv_play on play work?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on December 09, 2013, 11:15:20 PM
can you test the next nightly build, if it works with .raw as expected?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on December 10, 2013, 02:48:11 AM
Quote from: g3gg0 on December 09, 2013, 11:15:20 PM
can you test the next nightly build, if it works with .raw as expected?

Yes... playback of last recorded file now works well with .raw

It still often crashes often exiting playback mode when using an HDMI monitor.  I have been trying to recreate this, but so far, it seems to occur randomly.  When it happens, it always requires taking out the battery.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on January 05, 2014, 09:08:33 AM
Happy New Year everyone! I wish everyone new interesting film/video projects and stable builds from ML team  this year ;)
During the Holidays I had time to play with new builds. The problems that I have been reporting several times are still there :( The HDMI playback crashes every single time when I exit from the playback. It crashes when I try to switch to another video file. The weird overlays are still there too.
And sadly my suggestions about frame rate playback improvement was left without any attention.
It is the beginning  of 2014 and there are plenty projects that are coming this year, and I really want to give a try to 5d ML on a professional shoot, but without stable HDMI playback my 5D is just a toy for shooting trees, dogs,cats and some family members. Come on guys, give a little bit of attention to the most needed thing in production! I really really hope that you will fix HDMI playback once and forever.
Cheers!!!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on January 05, 2014, 12:15:23 PM
We cannot simply increase frame rate. Decoding already uses 100% CPU time.

the hdmi bug is confirmed, but its hard to debug it. I just have one hdmi monitor, that's the,one on my PC.
need a small screen, some like you use.

recording has higher precedence, so I focused on making recording more usable.
playback will follow later on.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on January 07, 2014, 11:50:12 PM
Quote from: g3gg0 on January 05, 2014, 12:15:23 PM
the hdmi bug is confirmed, but its hard to debug it. I just have one hdmi monitor, that's the,one on my PC.
need a small screen, some like you use.

I just tried connecting my 5D3 to 2 different TVs which have HDMI out (both a Plasma and LCD).  The same exact 2 issues occur on both TVs as well (crashing on exiting playback & offset image).  Doos your TV have an HDMI port?  Hopefully, you would be able to recreate it that way without needing a specialized HDMI monitor for cameras.  Just trying to offer suggestions that might yield a solution to this issue.

I recall that the first version of MLVPlay you put out that supported HDMI playback did not crash, only later versions introduced the crashing upon exiting playback.  I'm not sure exactly in what build when it started however.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on January 08, 2014, 01:28:30 AM
well, the tv is in a different room which makes it hard to do some tests.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on January 08, 2014, 02:12:31 AM
Quote from: g3gg0 on January 08, 2014, 01:28:30 AM
well, the tv is in a different room which makes it hard to do some tests.

I wish I had an extra HDMI monitor to send you... I definitely would  :(  I appreciate all your efforts though.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on January 09, 2014, 04:13:54 AM
Quote from: g3gg0 on January 05, 2014, 12:15:23 PM
We cannot simply increase frame rate. Decoding already uses 100% CPU time.
playback will follow later on.
That perfectly makes sense!
What if you frame skip? I mean, playback every second frame and hold it twice long on the screen for 24/25 fps??? That will male playback faster, because this way you read only 12 frames per second. And if this can sustain real time speed it would be GREAT!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on February 10, 2014, 02:13:08 PM
Did some cleanup and fixed a crash on 5D3.

Funny how nobody noticed what happens if you press delete a few times...
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on February 10, 2014, 05:10:38 PM
wow, thought that painting outside is already safe :)
ok thanks then!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on February 14, 2014, 03:18:49 PM
Small bug: if there are no videos recorded, pressing PLAY does nothing (remains in LiveView). It should at least print something.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on February 18, 2014, 02:08:41 PM
Hi, Alex! It is been a while since I tryed new builds. I'will test playback this week!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: optik on February 20, 2014, 02:57:19 AM
It's been about a week since I checked the nighties, has mlv_ play.mo been removed? Or I must be missing where it has been implemented in the menu
I just need to find way to play them back in camera (MLV)  ???
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Audionut on February 20, 2014, 04:52:27 AM
I thought I must have messed up my repo, but it's broken in the nightlies too.

Building module mlv_play...
REBUILDING
[ README   ]   module_strings.h
[ CC       ]   mlv_play.o
make[4]: *** No rule to make target `video.bmp.rsc', needed by `mlv_play.mo'.  Stop.

********************************************************
WARNING: module mlv_play failed to build, deleting
Title: Re: MLV PLAY (mlv_play.mo)
Post by: optik on February 20, 2014, 06:10:41 AM
I added the module from 2014Feb18.5D311 to the newest nightly and everything seems to be working just fine.
Don't know if that's the safest thing to do since the back end rebuild, ??? I have no idea.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on February 20, 2014, 09:39:01 AM
see https://bitbucket.org/hudson/magic-lantern/commits/dec1075df2d56a8b582e7ad519f9c60be4a1eaf7#general-comments

my commit https://bitbucket.org/hudson/magic-lantern/commits/827ab66f is necessary for building the modules.
are you sure the ML core is up to date?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Audionut on February 20, 2014, 09:55:53 AM
I double checked my VM and it was fine.

That quoted build output above is direct from the nightly builds output.

http://builds.magiclantern.fm/#/
Select a build and check the output.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on February 20, 2014, 10:31:48 AM
Quote from: Audionut on February 20, 2014, 09:55:53 AM
I double checked my VM and it was fine.

that means, you can build mlv_play locally?
ok then its probably the build server
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on February 20, 2014, 11:41:50 AM
Solved, rebuilding nightlies.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on February 20, 2014, 11:53:56 AM
thanks
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on February 20, 2014, 12:14:59 PM
please make sure you use a recent build of autoexec.bin with the new mlv_play.mo.
it uses a new interface available since a few days ago.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: arrinkiiii on February 20, 2014, 05:37:09 PM

If not yet exist maybe is because can't have that functions but here the question...

It's not possible wend you press the play button for see the videos you have thumbnails of the videos instead of one  playing file?  ...and from there choosing what file you want to see?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: optik on February 20, 2014, 09:22:48 PM
Thanks
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Audionut on February 27, 2014, 06:15:06 PM
When trying to play back resolution 3584 x 1320 on 5D3, it causes the LCD screen to enter QR mode, with standard Canon no image screen.  Red card light to remain on, and requiring battery pull.

Here (https://dl.dropboxusercontent.com/u/34113196/ML/M28-0257.MLV) is a file that causes the crash if needed.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: anandkamal on April 30, 2014, 06:05:36 PM
hi am using march 2014 update for 5d3. I shot in .mlv and while in playback, i could not completely watch the preview. For ex: if the total frames is 731, the playback stops at 200 or 300 and while pressing play button again, it goes further till 600 frames and when left to repeat the playback, it plays till the end of 731 frames and does not start from the 1st frame but starts from 160th frame... any mistake that i am committing? or will it be like this ? thanks
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on April 30, 2014, 08:25:13 PM
please dont use modules that are older than a month.
get the latest nightly builds from there (http://builds.magiclantern.fm/#/)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: anandkamal on May 01, 2014, 10:13:05 AM
hi updated the latest build and the playback is now approximately 10 frames/second, low saturation look. I think its better now. I wish this is how it will be or am I to turn on something to get real time playback? Also, how should I play files from file manager? thanks
Title: Re: MLV PLAY (mlv_play.mo)
Post by: ted ramasola on May 01, 2014, 11:13:52 AM
When you have navigated to the file you want to play using file manager, what options do you see?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: anandkamal on May 01, 2014, 03:58:39 PM
in 5d3, under Debug, i see File Manager > A:/ > DCIM > 100EOS5D > there is file (xxx.mlv) and mlv_rec.tmp. When i hit play, a green dot selects the file and when i press SET, there is a list of options under FILE MANAGER: copy, move, delete, clear selection, select *.mlv............ yeah and without the green dot selection, i get "view" after pressing SET. This playback is similar to what i get when i hit the play button directly after shooting the file. Approx. 10 frames per second.. am i right? thanks
Title: Re: MLV PLAY (mlv_play.mo)
Post by: ted ramasola on May 01, 2014, 04:17:58 PM
yes. use the "view" to playback. I'm not sure if its the same with 5d3 but on 5d2, when playback is starting, I can press the trash bin button to show more options for playback. fast or color, exit, and delete etc.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: anandkamal on May 01, 2014, 08:50:51 PM
5d3 has no such options like fast and color..
Title: Re: MLV PLAY (mlv_play.mo)
Post by: tonybeccar on May 01, 2014, 09:23:52 PM
Will it be possible someday realtime playback? (In some watchable quality)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on May 04, 2014, 08:32:15 AM
with the latest commit (https://bitbucket.org/hudson/magic-lantern/commits/e5939c727eb4fb759df433244bb4e675503a98ba), i added a feature to play back with real speed BY DROPPING FRAMES (if cpu is too slow)
or by waiting (if video resolution is small).

should work on 600D, 7D and 5D3, others will follow.

can you test it a bit?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: tonybeccar on May 04, 2014, 11:21:10 AM
Quote from: g3gg0 on May 04, 2014, 08:32:15 AM
with the latest commit (https://bitbucket.org/hudson/magic-lantern/commits/e5939c727eb4fb759df433244bb4e675503a98ba), i added a feature to play back with real speed BY DROPPING FRAMES (if cpu is too slow)
or by waiting (if video resolution is small).

should work on 600D, 7D and 5D3, others will follow.

can you test it a bit?

OMG, will try it as soon as it is on TL!!! AMAZING! :D

EDIT: Still isnt on the official nightlies also, will wait for it and test it on my 7D! Thanks!!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: tonybeccar on May 06, 2014, 10:41:42 AM
Quote from: g3gg0 on May 04, 2014, 08:32:15 AM
can you test it a bit?

I am testing right now. I gotta say it's a great improvement! It looks a lot faster even though it drops frames on the 7D.

Couple of things:

- Couldnt tell the difference between "all" and "exact"
- If the preview is Fast, the playback goes WAY faster and exceeds the set framerate (that's very good! :D)
- One problem that bugged me forever with mlv_play is that it starts playing and it doesnt reproduce the frames in order. For example first it plays from frame 0 to 300. Then it jumps back to frame 50 and continues to 600. Then it comes back to 300 and goes to 500. And so on... values are referencial of course. I understand that the camera records frames out of order, that's why the .idx is there for. This is on the 7D, I never said anything cause I thought it was normal, is it? Because, with the improvements that you just made, and playing frames in order, it's a gamechanger, really.
- Sound, you mentioned you were working on a new soundsystem? Well that would be amazing.
- As noted, on the 7D I dont have realtime playback on full color, but it's usable.
- Another thing, the color playback. I noticed it has something like a "rolling shutter". The frames do not seem to refresh fully but they go refreshing line by line and it's slow. And that causes rolling shutter in the playback, it's a bit distracting.
- If I have only one clip on the card, the << button does not bring me to its beggining.
- On HDMI, the playback GUI is completely messed up!

I hope I could be of some use but I'm sure you know most of this things. Gonna test it out more now.
Let me know if you need anything please!

Thank you!

EDIT:
All and Exact is doing what's supposed to be doing now. :S
And I just tested with lower resolutions and I'm getting realtime playback on Fast. :)
With full res in Fast i think it's realtime or almost realtime.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on May 06, 2014, 07:24:33 PM
Quote from: tonybeccar on May 06, 2014, 10:41:42 AM
I am testing right now. I gotta say it's a great improvement! It looks a lot faster even though it drops frames on the 7D.

Couple of things:

- Couldnt tell the difference between "all" and "exact"
- If the preview is Fast, the playback goes WAY faster and exceeds the set framerate (that's very good! :D)
- One problem that bugged me forever with mlv_play is that it starts playing and it doesnt reproduce the frames in order. For example first it plays from frame 0 to 300. Then it jumps back to frame 50 and continues to 600. Then it comes back to 300 and goes to 500. And so on... values are referencial of course. I understand that the camera records frames out of order, that's why the .idx is there for. This is on the 7D, I never said anything cause I thought it was normal, is it? Because, with the improvements that you just made, and playing frames in order, it's a gamechanger, really.
- Sound, you mentioned you were working on a new soundsystem? Well that would be amazing.
- As noted, on the 7D I dont have realtime playback on full color, but it's usable.
- Another thing, the color playback. I noticed it has something like a "rolling shutter". The frames do not seem to refresh fully but they go refreshing line by line and it's slow. And that causes rolling shutter in the playback, it's a bit distracting.
- If I have only one clip on the card, the << button does not bring me to its beggining.
- On HDMI, the playback GUI is completely messed up!

I hope I could be of some use but I'm sure you know most of this things. Gonna test it out more now.
Let me know if you need anything please!

Thank you!

EDIT:
All and Exact is doing what's supposed to be doing now. :S
And I just tested with lower resolutions and I'm getting realtime playback on Fast. :)
With full res in Fast i think it's realtime or almost realtime.
All the way back to january I was suggesting to make the drop frame playback, finally it is here! Bravo g3ggo!
The HDMI playback is the most important feature for a serious production and it is the most buggy and unstable ML feature so far.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: tonybeccar on May 06, 2014, 10:39:05 PM
Quote from: MonteNero on May 06, 2014, 07:24:33 PM
All the way back to january I was suggesting to make the drop frame playback, finally it is here! Bravo g3ggo!
The HDMI playback is the most important feature for a serious production and it is the most buggy and unstable ML feature so far.

Yes I agree. Some weeks ago I posted all the listing of the interface bugs. You are right, if you are on a real production, you are using 1, 2 or even 3 monitors at once, and it is paramount that the functionality is ok.

I don't know if to make a feature request or something, because it should be a high priority! I also do not know the reason behind this, because maybe if the interface is rewritten a bit the screen "copy" could be natively ok in the monitor.... aanyway. I'm really happy about the drop frame playback.. and it is much faster too!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: poromaa on May 07, 2014, 01:54:01 PM
The mlv_play module is gone in the nightlies for the 5D2? is this intentional?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on May 07, 2014, 02:12:59 PM
The latest mlv_play updates require some stubs for 5D2 and most other cameras. Until somebody sits down and finds them, the nightly build system will say this module will not load on your camera, so it will not bundle it in the zip.

https://bitbucket.org/hudson/magic-lantern/commits/03bb4ef73a77a5bf4b4dbb05c8b473f789439bb2
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on May 07, 2014, 05:00:30 PM
Quote from: tonybeccar on May 06, 2014, 10:39:05 PM
I don't know if to make a feature request or something, because it should be a high priority!
You are damn right!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on May 07, 2014, 05:25:10 PM
You may have better chances if you find somebody with coding skills who actually uses HDMI monitors. I don't have any use for them, so for me it has a low priority.

I'll do take a look at some point, but I prefer to focus on stuff that I actually use.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on May 07, 2014, 05:37:56 PM
same here, my current "implementation tasks":
- sound system: try to unify audio IC access for canon-configuration-finetuning, recording and playback
- mlv video: changes that improve experience (e.g. playback with sound)

concept work:
- understanding and checking generating color matrices
- understanding raw/yuv/jpeg paths (aim: playback raw in realtime by feeding EDMACs like in LV)

plus there are a lot of things that i started but not finished, like module unloading and some visual improvement.

but if someone sends me a small HDMI monitor, i can try to understand that RAW/YUV/BMP/HDMI positioning construct.
maybe i can fix your issues. although playback through EDMAC would make this task unnecessary
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on May 07, 2014, 05:53:10 PM
Quote from: g3gg0 on May 07, 2014, 05:37:56 PM
- understanding raw/yuv/jpeg paths (aim: playback raw in realtime by feeding EDMACs like in LV)

This one would be a huge breakthrough. I'm also researching it, with the aim of full-resolution silent pictures and maybe MJPEG encoding, but without much success so far (just confirming g3gg0's findings from http://magiclantern.wikia.com/wiki/Register_Map ).
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on May 08, 2014, 05:43:05 PM
G3gg0,
You can plug any HDMI monitor be it tv or lcd display for pc.
Where do you live btw? I might help you with that.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on May 08, 2014, 05:45:05 PM
Quote from: tonybeccar on May 06, 2014, 10:39:05 PM
Yes I agree. Some weeks ago I posted all the listing of the interface bugs. You are right, if you are on a real production, you are using 1, 2 or even 3 monitors at once, and it is paramount that the functionality is ok.

I don't know if to make a feature request or something, because it should be a high priority! I also do not know the reason behind this, because maybe if the interface is rewritten a bit the screen "copy" could be natively ok in the monitor.... aanyway. I'm really happy about the drop frame playback.. and it is much faster too!
Hey Tony, did you test new builds? I dont have my 5d at the mo.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on May 12, 2014, 10:48:15 AM
Quote from: g3gg0 on May 07, 2014, 05:37:56 PM
same here, my current "implementation tasks":
- sound system: try to unify audio IC access for canon-configuration-finetuning, recording and playback
- mlv video: changes that improve experience (e.g. playback with sound)

concept work:
- understanding and checking generating color matrices
- understanding raw/yuv/jpeg paths (aim: playback raw in realtime by feeding EDMACs like in LV)

plus there are a lot of things that i started but not finished, like module unloading and some visual improvement.

but if someone sends me a small HDMI monitor, i can try to understand that RAW/YUV/BMP/HDMI positioning construct.
maybe i can fix your issues. although playback through EDMAC would make this task unnecessary
G3ggo!
Where are you from? may be I can help you with the monitor.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on May 12, 2014, 12:12:45 PM
Quote from: MonteNero on May 08, 2014, 05:43:05 PM
G3gg0,
You can plug any HDMI monitor be it tv or lcd display for pc.
Where do you live btw? I might help you with that.
i have a monitor, but its rather stressful to unplug from PC, plug into camera, test, plug back a few hundred times to nail down how the HDMI coordinates and buffers map correctly.
i am from germany.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MonteNero on May 14, 2014, 08:01:45 PM
I can send you my field monitor for as long time as it necessary to make HDMI work perfectly.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Defkaunta on June 02, 2014, 11:38:37 AM
I am terribly sorry for being so amazingly stupid but where the heck can i get the mlv_play module to download and put into my ml folder? I tried searching but no candy for me! I have a 60D and want to play back raw files on my camera.  Does this only work with the mlv raw files or does it also play back the standard raw files? Thanks!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on June 27, 2014, 11:49:30 PM
mlv_play has a critical issue that may cause data loss.

I wasn't able to reproduce it yet, but - until next week when I'll be able to take a closer look - please try the quick fix from the link below and let me know if it works:

https://bitbucket.org/hudson/magic-lantern/issue/2022/mlv_play-destroy-data

(the link includes a video about how to reproduce the bug)

The code for the quick fix is this one: https://bitbucket.org/hudson/magic-lantern/commits/fa60068292f3

I'll include it in future nightly builds until a better fix is available. Worst case, it will have no effect.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on June 28, 2014, 11:20:12 AM
also pushed a fix for the ugly delete task. might support in nailing down the problem.
or not.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: dpjpandone on July 15, 2014, 04:59:08 PM
g3gg0,

I still experience some strangeness on 7D with mlv play, sometimes the camera will beep and then I can't look at any clips other than the one I am currently viewing, and I cannot delete the file I am stuck on. The only way to restore normal operation is to delete that file from the card in computer. Once the offending file is gone, MLV play works again. I'm still trying to nail down the steps that lead up to this....

it definitely happens more often when I'm using hdmi monitor in 1080i, vs. 480p mode. Performance is better in general with 480p HDMI.


Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on July 15, 2014, 05:04:03 PM
Do you still experience the issue after today's fixes?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on July 16, 2014, 04:00:28 AM
Just downloaded today's nightly.  I can no longer delete clips via mlv_play when using raw_rec.  I tried initiating deletion from the trash can button as well as from the mlv_play popup.   No errors or indications that the deletions are not actually happening.  I did try various common frame rates with and without hdmi monitor plugged in.  I can delete from the file manager however or from mlv_play while using mlv_rec.   So the problem seems to only be when using raw_rec.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on July 16, 2014, 08:16:02 AM
It never worked, from what I can tell. Will fix.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: kontrakatze on July 16, 2014, 08:24:20 AM
I found another issue regarding mlv_play in conjunction with the follow focus option.
If mlv_play is loaded, recording started, the starting point for the follow focus saved and the second  focus point set, pressing the play button to play the focus sequence in the first time leads to no reaction, a second press on the button crashes my camera. After taking out the battery ml starts again with all settings reset. I repeated this several times on my 5d mark III 1.2.3
It appears as if mlv_play tries to play back a file while recording.

Regards,
kontrakatze
Title: Re: MLV PLAY (mlv_play.mo)
Post by: kontrakatze on July 16, 2014, 08:54:10 AM
Sorry, just read that this problem is solved...

Regards,
Kontrakatze
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on July 16, 2014, 09:42:04 PM
Quote from: a1ex on July 16, 2014, 08:16:02 AM
It never worked, from what I can tell. Will fix.

I never noticed since I was using mlv_rec for a while but just recently switched back to raw_rec for 30fps shooting due to the better performance of raw_rec.   I know that overlays are being collected/analyzed for a potential solution to the HDMI issue, but mlv_play also has another display issue that seems unrelated to the the overlay alignment issue.  When playing back a clip while using an HDMI monitor, initially it always displays "No Image".  The only way to view the last clip is to first navigate to the previous clip using the top dial, and then back again to the last clip (this clears the message).  You can see it here... http://www.magiclantern.fm/forum/index.php?topic=9062.msg88894#msg88894 (http://www.magiclantern.fm/forum/index.php?topic=9062.msg88894#msg88894).   At that time,  I was only reporting the overlay issue but now I realize that the "No Image" issue seems to be independent of the misaligned overlay issue.   One thing that happens a lot is when you have recorded your first clip and want to review it, you can't because there is no other clip to navigate to to clear the message.  So you then need to record a 2nd clip just to have something to switch to.  Not the end of the world but just wanted to mention it to separate it from the other overlay issues.

By the way, as a few other forum members have pointed out, switching on Force HDMI-VGA does indeed help with alignment of the main video display in playback mode.  But ml overlays are made worse so it's a bit of a tradeoff.  In case it helps anyone who is using the 5D3 and SmallHD DP-4 monitor (it may be applicable to the DP6 as well), what I do is create 2 custom scale presets on my DP4... 1 for recording and 1 for playback.  With Force HDMI-VGA selected in ML, none of the built-in DP4 monitor presets work well, so you will need to go into custom scale settings and tweak to get full screen video.   I have opted to tweak the scale settings to view playback completely full screen, but this will push the ML overlays completely off screen.  The main video display takes precedence for me.  Hope that helps some of you.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on July 17, 2014, 12:55:34 AM
Downloaded the new nightly and can confirm that the delete from mlv_play works when using in raw_rec.  Thank you!
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on July 17, 2014, 01:08:57 AM
Also, Exact/All toggle of mlv_play doesn't yet work with raw_rec.  Currently, it is displays only All frames.  I toggle that feature all the time to be able to check the speed of my camera movement in realtime vs checking the quality of the shot.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: dpjpandone on July 19, 2014, 04:07:24 AM
Much more stable so far, I will put it through it's paces this weekend.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on July 31, 2014, 05:35:05 AM
Quote from: MA Visuals on July 17, 2014, 01:08:57 AM
Also, Exact/All toggle of mlv_play doesn't yet work with raw_rec.  Currently, it is displays only All frames.  I toggle that feature all the time to be able to check the speed of my camera movement in realtime vs checking the quality of the shot.

This was fixed in the recent nightly.  Works great.  Also, overall stability of mlv_play is much improved.  Thank you.

Not that it bothers me, but I was just curious about the need for color/fast toggle.  Seems like this was originally put in place to deal with the slower playback of raw files.  But with Exact/All toggle working so well (and in color), I can't see why anyone would ever need the color/fast option now.   Removing it would simplify the menu a bit and free up space in case it's needed down the road.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: dpjpandone on August 09, 2014, 01:57:09 AM
I disagree with the above. Greyscale shows more fluid motion (does not skip frames like "exact" does) if you are reviewing a long take with lots of fast moving objects moving through the frame it is very useful. Please do not remove this feature.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: MA Visuals on August 10, 2014, 05:10:54 AM
It's not really an issue leaving it in place... especially if people find it useful.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: motionSOUL on August 25, 2014, 05:23:07 PM
Thanks for all the hard work. The MLV Player addition is great for ML workflow!
Would it be possible  to add a loop function? I find difficult to play a particular clip again and again to check if all is OK.
You have to go to the one before, then go back to play it again. If several clips are almost the same, you are lost in no time.
The loop function could be automatically set to loop at the end of one clip or perhaps a loop button to restart the clip each time you press it?

If there is a simple way to do that please tell me I've missed something?

Regards,

S.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Jakobmen on August 25, 2014, 05:39:44 PM
Quote from: dpjpandone on August 09, 2014, 01:57:09 AM
I disagree with the above. Greyscale shows more fluid motion (does not skip frames like "exact" does) if you are reviewing a long take with lots of fast moving objects moving through the frame it is very useful. Please do not remove this feature.

agree
Title: Re: MLV PLAY (mlv_play.mo)
Post by: ayshih on August 30, 2014, 02:02:33 AM
Quote from: motionSOUL on August 25, 2014, 05:23:07 PM
The loop function could be automatically set to loop at the end of one clip or perhaps a loop button to restart the clip each time you press it?
I've wanted this too!  I've just implemented this functionality – replay a video by selecting "|>" after it finishes – on my mlv_play pull request (https://bitbucket.org/hudson/magic-lantern/pull-request/580/even-more-mlv_play-improvements/diff), which is up for review.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: ayshih on September 01, 2014, 05:16:10 AM
This module just got a bunch of improvements, and they're in tonight's nightly builds.  See the text of the now-merged pull request (https://bitbucket.org/hudson/magic-lantern/pull-request/580/even-more-mlv_play-improvements/diff) for details.  Enjoy!

For fans of "exact" playback, there's a performance boost when playing back long MLV videos.  However, to achieve this boost, the index files (*.IDX) that are generated by mlv_play now have additional information embedded in them.  The consequence is that IDX files created prior to tonight's update will actually inhibit "exact" playback from working properly because the module isn't told which frames are okay to drop.  The remedy: simply delete any existing IDX files and let the module re-create them.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: kontrakatze on February 27, 2016, 03:08:41 PM
Quite old this discussion, but anyway. I hope I'm in the right place:

On 5d Mark III 1.1.3 latest nightly:

Today I received my new cf card and did an unattended test, I recorded for 10min at 1920*1080@25p with audio (but mic was off) to check the stability of the card. Recording went completely normal, files are ok, playback via MlRawViewer completely normal.

Playback on camera with mlv_play failed while indexing. 10 out of 13 files seem to get indexed, than an error occured repeatedly: Index error
mlv_play can be exited normally, there is no index file on the cf.
I can't say if it stops always on the same file, but always with the same error message.
It says 10 out of 10, but there are 13.
I already reported a bug on bitbucket, but thought it might be of interest here, too.
(http://s20.postimg.org/hazb4qo4t/IMG_0657.jpg)
Regards,
kontrakatze
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Walter Schulz on February 27, 2016, 03:27:33 PM
Try this workaround:
Use ExFAT file system and enable -> Movie tab -> RAW video (MLV) -> Files > 4 GiB (exFAT)

g3gg0 will address this bug for sure. I think it has been around for about 12 months. Before that date MLV recording in non-ExFAT mode was restricted to 10 chunks (around 40 GB).
Title: Re: MLV PLAY (mlv_play.mo)
Post by: kontrakatze on February 27, 2016, 03:54:23 PM
What happens if after changing format to exFAT I format the cf in camera, will it be changed to FAT32 again?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Walter Schulz on February 27, 2016, 04:00:51 PM
Unfortunately 5D3 will convert your card's file system to FAT32. Confirmed for card's up to 128 GB. Not tested with bigger ones.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: kontrakatze on February 27, 2016, 04:07:34 PM
Too bad, but on sd-cards format stays exFAT (just tested for 128gb sd). Interesting, but still not helpful.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: a1ex on February 27, 2016, 04:30:11 PM
Looks like mlv_play tries to open all the chunks at the same time, but DryOS can't handle that many files opened at the same time. I guess it was implemented that way to handle file spanning (that means, one frame from one chunk, next frame from some other chunk), and it was easiest to code that way.

The simplest fix would be to have a single file handle, and open each chunk when needed.

For spanning files, in the worst case scenario, this would do open/seek/close operations for every single frame, which might be slow. In this case, allowing one file handle per drive (two open files at a time) should work just fine.

I wasn't aware of the issue (doesn't seem to have been reported before (https://bitbucket.org/hudson/magic-lantern/issues?status=new&status=open&q=mlv_play)), and probably g3gg0 wasn't either.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on February 27, 2016, 11:48:14 PM
right, was not aware of that this might happen. just knew about the 10-handle-limit.
never really tried to play back that huge files.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on December 19, 2016, 02:50:46 PM
Quote from: Danne on December 19, 2016, 01:59:55 PM
Any thoughts on mlv_play buttons? They seem vanished into oblivion once raw_twk starts running?

if you zoom in, buttons should disappear.
did you mean that?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on December 19, 2016, 03:12:59 PM
Risking double posts now but I continue this issue here.

On eos m play, pause, delete, scroll buttons are visible either when pressing set and also a while from start of playing mlv files in cam.
Problem with raw_twk enabled is that all buttons are gone making deleting impossible. Previewing is possible but no possibilities to go to the next video pause it etc won,t work. This seems to be a problem only on the eos m and only when using the raw_twk module. All buttons are visible if raw_twk is disabled and regular mlv_play is running.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on December 19, 2016, 08:46:55 PM
interesting bug. i dont understand it.
if raw_twk is enabled, no GUI code behaves different.
t.b.h the whole code doesn't care about raw_twk at all.

so this might be an issue with the number of threads we are starting.
raw_twk starts threads, mlv_play does etc. and the EOS M is (iirc) at its limit.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on December 19, 2016, 09:04:45 PM
That certainly would explain why it,s working on seemingly all other cams. How would it work if done in mlv_play.mo code directly(working with 10/12bit)?

On the eos m with raw_twk enabled
(https://s30.postimg.org/qkdcfdmld/20161219_205835.jpg)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on June 18, 2017, 01:34:26 AM
fixed the black screen issue when playing back several files.
now scrolling through files should work without trouble.

https://bitbucket.org/hudson/magic-lantern/commits/3f90c436d85aff183af93b9bf6a30224811e5fa2
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on June 18, 2017, 06:57:19 AM
Thanks g3gg0.
Just compiled from crop_rec_4k.
Working
- 10bit/12bit/14bit plays back nicely
- Scrolling back and forth always opens up the expected file
- black screen issue fixed!
- nice to have info on what bits we´re previewing

not working
- lossles compressed 14bit files causes camera freeze and black screen. Restart needed.
once I got one frame showing freezed but tested two more times after restart and  screen went black and freeze. No crash logs to be found.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on June 18, 2017, 09:25:28 AM
thanks.
on which model you tried it?

oh and disable raw_twk for now.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on June 18, 2017, 09:29:46 AM
Yes, I will.
Sorry, 5D mark III. 1.1.3.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on June 18, 2017, 09:50:34 AM
same as me, so i expect it to work if you disable raw_twk.
there seem to be some incompatibilities.
maybe some locking or so.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on June 18, 2017, 10:23:11 AM
Yes, you're absolutely right. Lossless works when raw_twk is disabled. Thanks for pointing that out.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: domasa on June 28, 2017, 12:16:07 AM
Thx for add lossless playback support inside camera.

Do you know some alternative for Windows?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on June 28, 2017, 05:39:34 AM
Previewing footage in windows can be done in MlRawViewer. Either through MLVFS, check link
http://www.magiclantern.fm/forum/index.php?topic=19300.msg185808#msg185808
Or you can decompress your MLV files with mlv_dump and preview the uncompressed MLV files directly in MLRawViewer.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on July 02, 2017, 02:04:41 AM
Quote from: Danne on June 18, 2017, 10:23:11 AM
Yes, you're absolutely right. Lossless works when raw_twk is disabled. Thanks for pointing that out.

fixed in latest crop_rec_4k branch.

when we have pure raw frames, raw_twk will still repack them to 16bpp and then render them.
for lossless with raw_twk, mlv_play will use the lossless routines to already pack them to 16bpp and then pass to raw_twk which renders on screen.
for lossless without raw_twk, mlv_play will use lossless routines to create 14bpp data as before and pass them to the core raw backend.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on July 02, 2017, 06:33:20 PM
Tested briefly today. Seems to swing nicely with all bitdepths and compression mode. Nice, nice. Some porting for this and mlv_rec as well would be nice :).
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on July 02, 2017, 07:26:59 PM
cool, happy to hear that :)
if you want to support, feel free :D

which models do you use?

edit:
mlv_rec will get replaced by mlv_lite step by step.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on July 02, 2017, 08:44:08 PM
I use 5D mark III and eosm.
Sure, support, how?
Mlv_lite taking over :)
Title: Re: MLV PLAY (mlv_play.mo)
Post by: g3gg0 on July 02, 2017, 09:22:32 PM
mlv_lite is a cleaner rewrite of mlv_rec with all knowledge of it with additional new findings.
so yeah, it will take over and be the raw recording module.
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Surin Dmitriy on July 03, 2017, 01:37:51 AM
Quote from: g3gg0 on July 02, 2017, 09:22:32 PM
mlv_lite is a cleaner rewrite of mlv_rec with all knowledge of it with additional new findings.
so yeah, it will take over and be the raw recording module.

Does mlv_lite support sound?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: andy kh on July 03, 2017, 11:47:57 AM
Quote from: g3gg0 on July 02, 2017, 09:22:32 PM
mlv_lite is a cleaner rewrite of mlv_rec with all knowledge of it with additional new findings.
so yeah, it will take over and be the raw recording module.

won't be a problem if it's going to support audio recording
Title: Re: MLV PLAY (mlv_play.mo)
Post by: andy kh on July 03, 2017, 11:51:37 AM
Quote from: Surin Dmitriy on July 03, 2017, 01:37:51 AM
Does mlv_lite support sound?


No
Title: Re: MLV PLAY (mlv_play.mo)
Post by: theBilalFakhouri on July 10, 2019, 03:01:12 PM
Can we play the sound beside MLV file in camera?
What should we do ? Where to start ?
Title: Re: MLV PLAY (mlv_play.mo)
Post by: Danne on July 10, 2019, 03:14:15 PM
Check in mlv_play code. g3gg0  has some unused code regarding audio in there. Good start.